* [PATCH] Do not append to BBCLASSEXTEND
@ 2017-03-08 14:17 liu.ming50
2017-03-08 22:02 ` Leonardo Sandoval
0 siblings, 1 reply; 3+ messages in thread
From: liu.ming50 @ 2017-03-08 14:17 UTC (permalink / raw)
To: openembedded-core; +Cc: Ming Liu
From: Ming Liu <peter.x.liu@external.atlascopco.com>
Replace some "+=/=+" with "=" when setting BBCLASSEXTEND, they are
redundant and inconsistent with the same setting in other recipes.
Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
---
meta/recipes-devtools/build-compare/build-compare_git.bb | 2 +-
meta/recipes-extended/libsolv/libsolv_0.6.24.bb | 2 +-
meta/recipes-extended/lzip/lzip_1.18.bb | 2 +-
meta/recipes-extended/wget/wget.inc | 2 +-
meta/recipes-support/ca-certificates/ca-certificates_20161130.bb | 2 +-
meta/recipes-support/lz4/lz4.bb | 2 +-
meta/recipes-support/lzop/lzop_1.03.bb | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb b/meta/recipes-devtools/build-compare/build-compare_git.bb
index e432143..eb12e40 100644
--- a/meta/recipes-devtools/build-compare/build-compare_git.bb
+++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
@@ -22,7 +22,7 @@ PV = "git+${SRCPV}"
S = "${WORKDIR}/git"
-BBCLASSEXTEND += "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
do_install() {
install -d ${D}/${bindir}
diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.24.bb b/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
index 6de38b5..73db5ed 100644
--- a/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
+++ b/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
@@ -27,4 +27,4 @@ FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
FILES_${PN}-tools = "${bindir}/*"
FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
-BBCLASSEXTEND =+ "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-extended/lzip/lzip_1.18.bb b/meta/recipes-extended/lzip/lzip_1.18.bb
index 30c7dd5..c1dc8ce 100644
--- a/meta/recipes-extended/lzip/lzip_1.18.bb
+++ b/meta/recipes-extended/lzip/lzip_1.18.bb
@@ -38,4 +38,4 @@ do_install () {
fi
}
-BBCLASSEXTEND += "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
index 9eb051f..1299edb 100644
--- a/meta/recipes-extended/wget/wget.inc
+++ b/meta/recipes-extended/wget/wget.inc
@@ -16,7 +16,7 @@ ALTERNATIVE_PRIORITY = "100"
RRECOMMENDS_${PN} += "ca-certificates"
-BBCLASSEXTEND += "nativesdk"
+BBCLASSEXTEND = "nativesdk"
PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
PACKAGECONFIG[libuuid] = "--with-libuuid, --without-libuuid,util-linux"
diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb b/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
index e47bad1..42088b9 100644
--- a/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
+++ b/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
@@ -80,4 +80,4 @@ do_install_append_class-native () {
RDEPENDS_${PN} += "openssl"
-BBCLASSEXTEND += "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-support/lz4/lz4.bb b/meta/recipes-support/lz4/lz4.bb
index 18e56d0..03c5a7a 100644
--- a/meta/recipes-support/lz4/lz4.bb
+++ b/meta/recipes-support/lz4/lz4.bb
@@ -18,4 +18,4 @@ do_install() {
oe_runmake install
}
-BBCLASSEXTEND += "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-support/lzop/lzop_1.03.bb b/meta/recipes-support/lzop/lzop_1.03.bb
index 649e724..6f09002 100644
--- a/meta/recipes-support/lzop/lzop_1.03.bb
+++ b/meta/recipes-support/lzop/lzop_1.03.bb
@@ -26,4 +26,4 @@ do_configure_prepend () {
install -Dm 0644 ${WORKDIR}/acinclude.m4 ${S}/acinclude.m4
}
-BBCLASSEXTEND += "native nativesdk"
+BBCLASSEXTEND = "native nativesdk"
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Do not append to BBCLASSEXTEND
2017-03-08 14:17 [PATCH] Do not append to BBCLASSEXTEND liu.ming50
@ 2017-03-08 22:02 ` Leonardo Sandoval
2017-03-08 23:08 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Leonardo Sandoval @ 2017-03-08 22:02 UTC (permalink / raw)
To: liu.ming50; +Cc: Ming Liu, openembedded-core
Hi
you need to send a v2 revision, following the shortlog format
* Patch Do not append to BBCLASSEXTEND
Issue Shortlog does not follow expected format [test_shortlog_format]
Suggested fix Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"
On Wed, 2017-03-08 at 15:17 +0100, liu.ming50@gmail.com wrote:
> From: Ming Liu <peter.x.liu@external.atlascopco.com>
>
> Replace some "+=/=+" with "=" when setting BBCLASSEXTEND, they are
> redundant and inconsistent with the same setting in other recipes.
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
> ---
> meta/recipes-devtools/build-compare/build-compare_git.bb | 2 +-
> meta/recipes-extended/libsolv/libsolv_0.6.24.bb | 2 +-
> meta/recipes-extended/lzip/lzip_1.18.bb | 2 +-
> meta/recipes-extended/wget/wget.inc | 2 +-
> meta/recipes-support/ca-certificates/ca-certificates_20161130.bb | 2 +-
> meta/recipes-support/lz4/lz4.bb | 2 +-
> meta/recipes-support/lzop/lzop_1.03.bb | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/meta/recipes-devtools/build-compare/build-compare_git.bb b/meta/recipes-devtools/build-compare/build-compare_git.bb
> index e432143..eb12e40 100644
> --- a/meta/recipes-devtools/build-compare/build-compare_git.bb
> +++ b/meta/recipes-devtools/build-compare/build-compare_git.bb
> @@ -22,7 +22,7 @@ PV = "git+${SRCPV}"
>
> S = "${WORKDIR}/git"
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
>
> do_install() {
> install -d ${D}/${bindir}
> diff --git a/meta/recipes-extended/libsolv/libsolv_0.6.24.bb b/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
> index 6de38b5..73db5ed 100644
> --- a/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
> +++ b/meta/recipes-extended/libsolv/libsolv_0.6.24.bb
> @@ -27,4 +27,4 @@ FILES_${PN}-dev += "${datadir}/cmake/Modules/FindLibSolv.cmake"
> FILES_${PN}-tools = "${bindir}/*"
> FILES_${PN}ext = "${libdir}/${PN}ext.so.*"
>
> -BBCLASSEXTEND =+ "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-extended/lzip/lzip_1.18.bb b/meta/recipes-extended/lzip/lzip_1.18.bb
> index 30c7dd5..c1dc8ce 100644
> --- a/meta/recipes-extended/lzip/lzip_1.18.bb
> +++ b/meta/recipes-extended/lzip/lzip_1.18.bb
> @@ -38,4 +38,4 @@ do_install () {
> fi
> }
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
> index 9eb051f..1299edb 100644
> --- a/meta/recipes-extended/wget/wget.inc
> +++ b/meta/recipes-extended/wget/wget.inc
> @@ -16,7 +16,7 @@ ALTERNATIVE_PRIORITY = "100"
>
> RRECOMMENDS_${PN} += "ca-certificates"
>
> -BBCLASSEXTEND += "nativesdk"
> +BBCLASSEXTEND = "nativesdk"
>
> PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ipv6', d)}"
> PACKAGECONFIG[libuuid] = "--with-libuuid, --without-libuuid,util-linux"
> diff --git a/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb b/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
> index e47bad1..42088b9 100644
> --- a/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
> +++ b/meta/recipes-support/ca-certificates/ca-certificates_20161130.bb
> @@ -80,4 +80,4 @@ do_install_append_class-native () {
>
> RDEPENDS_${PN} += "openssl"
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-support/lz4/lz4.bb b/meta/recipes-support/lz4/lz4.bb
> index 18e56d0..03c5a7a 100644
> --- a/meta/recipes-support/lz4/lz4.bb
> +++ b/meta/recipes-support/lz4/lz4.bb
> @@ -18,4 +18,4 @@ do_install() {
> oe_runmake install
> }
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-support/lzop/lzop_1.03.bb b/meta/recipes-support/lzop/lzop_1.03.bb
> index 649e724..6f09002 100644
> --- a/meta/recipes-support/lzop/lzop_1.03.bb
> +++ b/meta/recipes-support/lzop/lzop_1.03.bb
> @@ -26,4 +26,4 @@ do_configure_prepend () {
> install -Dm 0644 ${WORKDIR}/acinclude.m4 ${S}/acinclude.m4
> }
>
> -BBCLASSEXTEND += "native nativesdk"
> +BBCLASSEXTEND = "native nativesdk"
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Do not append to BBCLASSEXTEND
2017-03-08 22:02 ` Leonardo Sandoval
@ 2017-03-08 23:08 ` Richard Purdie
0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2017-03-08 23:08 UTC (permalink / raw)
To: Leonardo Sandoval, liu.ming50; +Cc: Ming Liu, openembedded-core
On Wed, 2017-03-08 at 16:02 -0600, Leonardo Sandoval wrote:
> Hi
>
> you need to send a v2 revision, following the shortlog format
>
> * Patch Do not append to BBCLASSEXTEND
> Issue Shortlog does not follow expected format
> [test_shortlog_format]
> Suggested fix Commit shortlog (first line of commit message)
> should follow the format "<target>: <summary>"
Ross actually added one when he added the patch to mut but please
remember to do this in future.
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-08 23:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-08 14:17 [PATCH] Do not append to BBCLASSEXTEND liu.ming50
2017-03-08 22:02 ` Leonardo Sandoval
2017-03-08 23:08 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.