From: Yisheng Xie <ysxie@foxmail.com> To: akpm@linux-foundation.org, hannes@cmpxchg.org, mgorman@suse.de, vbabka@suse.cz, mhocko@suse.com, riel@redhat.com, shakeelb@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, xieyisheng1@huawei.com, guohanjun@huawei.com, qiuxishi@huawei.com Subject: [PATCH v3 RFC] mm/vmscan: more restrictive condition for retry of shrink_zones Date: Sun, 12 Mar 2017 19:06:10 +0800 [thread overview] Message-ID: <1489316770-25362-1-git-send-email-ysxie@foxmail.com> (raw) From: Yisheng Xie <xieyisheng1@huawei.com> When we enter do_try_to_free_pages, the may_thrash is always clear, and it will retry shrink zones to tap cgroup's reserves memory by setting may_thrash when the former shrink_zones reclaim nothing. However, when memcg is disabled or on legacy hierarchy, it should not do this useless retry at all, for we do not have any cgroup's reserves memory to tap, and we have already done hard work but made no progress. To avoid this time costly and useless retrying, add a stub function mem_cgroup_thrashed() and return true when memcg is disabled or on legacy hierarchy. Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> Suggested-by: Shakeel Butt <shakeelb@google.com> --- v3: - rename function may_thrash() to mem_cgroup_thrashed() to avoid confusing. v2: - more restrictive condition for retry of shrink_zones (restricting cgroup_disabled=memory boot option and cgroup legacy hierarchy) - Shakeel - add a stub function may_thrash() to avoid compile error or warning. - rename subject from "donot retry shrink zones when memcg is disable" to "more restrictive condition for retry in do_try_to_free_pages" Any comment is more than welcome! Thanks Yisheng Xie mm/vmscan.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index bc8031e..a76475af 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -184,6 +184,19 @@ static bool sane_reclaim(struct scan_control *sc) #endif return false; } + +static bool mem_cgroup_thrashed(struct scan_control *sc) +{ + /* + * When memcg is disabled or on legacy hierarchy, there is no cgroup + * reserves memory to tap. So fake it as thrashed. + */ + if (!cgroup_subsys_enabled(memory_cgrp_subsys) || + !cgroup_subsys_on_dfl(memory_cgrp_subsys)) + return true; + + return sc->may_thrash; +} #else static bool global_reclaim(struct scan_control *sc) { @@ -194,6 +207,11 @@ static bool sane_reclaim(struct scan_control *sc) { return true; } + +static bool mem_cgroup_thrashed(struct scan_control *sc) +{ + return true; +} #endif /* @@ -2808,7 +2826,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, return 1; /* Untapped cgroup reserves? Don't OOM, retry. */ - if (!sc->may_thrash) { + if (!mem_cgroup_thrashed(sc)) { sc->priority = initial_priority; sc->may_thrash = 1; goto retry; -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Yisheng Xie <ysxie@foxmail.com> To: akpm@linux-foundation.org, hannes@cmpxchg.org, mgorman@suse.de, vbabka@suse.cz, mhocko@suse.com, riel@redhat.com, shakeelb@google.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, xieyisheng1@huawei.com, guohanjun@huawei.com, qiuxishi@huawei.com Subject: [PATCH v3 RFC] mm/vmscan: more restrictive condition for retry of shrink_zones Date: Sun, 12 Mar 2017 19:06:10 +0800 [thread overview] Message-ID: <1489316770-25362-1-git-send-email-ysxie@foxmail.com> (raw) From: Yisheng Xie <xieyisheng1@huawei.com> When we enter do_try_to_free_pages, the may_thrash is always clear, and it will retry shrink zones to tap cgroup's reserves memory by setting may_thrash when the former shrink_zones reclaim nothing. However, when memcg is disabled or on legacy hierarchy, it should not do this useless retry at all, for we do not have any cgroup's reserves memory to tap, and we have already done hard work but made no progress. To avoid this time costly and useless retrying, add a stub function mem_cgroup_thrashed() and return true when memcg is disabled or on legacy hierarchy. Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com> Suggested-by: Shakeel Butt <shakeelb@google.com> --- v3: - rename function may_thrash() to mem_cgroup_thrashed() to avoid confusing. v2: - more restrictive condition for retry of shrink_zones (restricting cgroup_disabled=memory boot option and cgroup legacy hierarchy) - Shakeel - add a stub function may_thrash() to avoid compile error or warning. - rename subject from "donot retry shrink zones when memcg is disable" to "more restrictive condition for retry in do_try_to_free_pages" Any comment is more than welcome! Thanks Yisheng Xie mm/vmscan.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index bc8031e..a76475af 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -184,6 +184,19 @@ static bool sane_reclaim(struct scan_control *sc) #endif return false; } + +static bool mem_cgroup_thrashed(struct scan_control *sc) +{ + /* + * When memcg is disabled or on legacy hierarchy, there is no cgroup + * reserves memory to tap. So fake it as thrashed. + */ + if (!cgroup_subsys_enabled(memory_cgrp_subsys) || + !cgroup_subsys_on_dfl(memory_cgrp_subsys)) + return true; + + return sc->may_thrash; +} #else static bool global_reclaim(struct scan_control *sc) { @@ -194,6 +207,11 @@ static bool sane_reclaim(struct scan_control *sc) { return true; } + +static bool mem_cgroup_thrashed(struct scan_control *sc) +{ + return true; +} #endif /* @@ -2808,7 +2826,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, return 1; /* Untapped cgroup reserves? Don't OOM, retry. */ - if (!sc->may_thrash) { + if (!mem_cgroup_thrashed(sc)) { sc->priority = initial_priority; sc->may_thrash = 1; goto retry; -- 1.9.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-03-12 11:15 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-12 11:06 Yisheng Xie [this message] 2017-03-12 11:06 ` [PATCH v3 RFC] mm/vmscan: more restrictive condition for retry of shrink_zones Yisheng Xie 2017-03-12 20:20 ` Shakeel Butt 2017-03-12 20:20 ` Shakeel Butt 2017-03-13 8:33 ` Michal Hocko 2017-03-13 8:33 ` Michal Hocko 2017-03-13 12:00 ` Yisheng Xie 2017-03-13 12:00 ` Yisheng Xie 2017-03-13 15:17 ` Shakeel Butt 2017-03-13 15:17 ` Shakeel Butt 2017-03-13 15:48 ` Michal Hocko 2017-03-13 15:48 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1489316770-25362-1-git-send-email-ysxie@foxmail.com \ --to=ysxie@foxmail.com \ --cc=akpm@linux-foundation.org \ --cc=guohanjun@huawei.com \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mgorman@suse.de \ --cc=mhocko@suse.com \ --cc=qiuxishi@huawei.com \ --cc=riel@redhat.com \ --cc=shakeelb@google.com \ --cc=vbabka@suse.cz \ --cc=xieyisheng1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.