* [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-12 20:13 ` Jérémy Lefaure
0 siblings, 0 replies; 9+ messages in thread
From: Jérémy Lefaure @ 2017-03-12 20:13 UTC (permalink / raw)
To: linux-arm-kernel
The driver uses kzalloc and kfree functions. So it should include
linux/slab.h. This header file is implicitly included by v4l2-common.h
if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
included. In this case, the driver does not compile:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ?mtk_jpeg_open?:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
declaration of function ?kzalloc?
[-Werror=implicit-function-declaration]
ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
^~~~~~~
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
assignment makes pointer from integer without a cast [-Wint-conversion]
ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
^
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
declaration of function ?kfree? [-Werror=implicit-function-declaration]
kfree(ctx);
^~~~~
This patch adds the missing include to fix this issue.
Signed-off-by: J?r?my Lefaure <jeremy.lefaure@lse.epita.fr>
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index b10183f7942b..f9bd58ce7d32 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -22,6 +22,7 @@
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
+#include <linux/slab.h>
#include <linux/spinlock.h>
#include <media/v4l2-event.h>
#include <media/v4l2-mem2mem.h>
--
2.12.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-12 20:13 ` Jérémy Lefaure
0 siblings, 0 replies; 9+ messages in thread
From: Jérémy Lefaure @ 2017-03-12 20:13 UTC (permalink / raw)
To: Rick Chang, Bin Liu, Mauro Carvalho Chehab, Matthias Brugger
Cc: Jérémy Lefaure, linux-mediatek, linux-arm-kernel, linux-media
The driver uses kzalloc and kfree functions. So it should include
linux/slab.h. This header file is implicitly included by v4l2-common.h
if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
included. In this case, the driver does not compile:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_open’:
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
declaration of function ‘kzalloc’
[-Werror=implicit-function-declaration]
ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
^~~~~~~
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
assignment makes pointer from integer without a cast [-Wint-conversion]
ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
^
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
kfree(ctx);
^~~~~
This patch adds the missing include to fix this issue.
Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
index b10183f7942b..f9bd58ce7d32 100644
--- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
+++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
@@ -22,6 +22,7 @@
#include <linux/of_platform.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
+#include <linux/slab.h>
#include <linux/spinlock.h>
#include <media/v4l2-event.h>
#include <media/v4l2-mem2mem.h>
--
2.12.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
2017-03-12 20:13 ` Jérémy Lefaure
(?)
@ 2017-03-13 3:04 ` Rick Chang
-1 siblings, 0 replies; 9+ messages in thread
From: Rick Chang @ 2017-03-13 3:04 UTC (permalink / raw)
To: Jérémy Lefaure
Cc: Bin Liu, Mauro Carvalho Chehab, Matthias Brugger, linux-media,
linux-arm-kernel, linux-mediatek
On Sun, 2017-03-12 at 16:13 -0400, Jérémy Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_open’:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ‘kzalloc’
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rick Chang <rick.chang@mediatek.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-13 3:04 ` Rick Chang
0 siblings, 0 replies; 9+ messages in thread
From: Rick Chang @ 2017-03-13 3:04 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, 2017-03-12 at 16:13 -0400, J?r?my Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ?mtk_jpeg_open?:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ?kzalloc?
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ?kfree? [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
>
> Signed-off-by: J?r?my Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rick Chang <rick.chang@mediatek.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-13 3:04 ` Rick Chang
0 siblings, 0 replies; 9+ messages in thread
From: Rick Chang @ 2017-03-13 3:04 UTC (permalink / raw)
To: Jérémy Lefaure
Cc: Bin Liu, Mauro Carvalho Chehab, Matthias Brugger, linux-media,
linux-arm-kernel, linux-mediatek
On Sun, 2017-03-12 at 16:13 -0400, Jérémy Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_open’:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ‘kzalloc’
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: Rick Chang <rick.chang@mediatek.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-13 10:17 ` Hans Verkuil
0 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2017-03-13 10:17 UTC (permalink / raw)
To: Jérémy Lefaure, Rick Chang, Bin Liu,
Mauro Carvalho Chehab, Matthias Brugger
Cc: linux-media, linux-arm-kernel, linux-mediatek
On 03/12/2017 09:13 PM, Jérémy Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_open’:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ‘kzalloc’
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
Thanks for the patch, but someone else made the same fix already and it is
queued up for 4.12.
Regards,
Hans
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index b10183f7942b..f9bd58ce7d32 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -22,6 +22,7 @@
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/slab.h>
> #include <linux/spinlock.h>
> #include <media/v4l2-event.h>
> #include <media/v4l2-mem2mem.h>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-13 10:17 ` Hans Verkuil
0 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2017-03-13 10:17 UTC (permalink / raw)
To: linux-arm-kernel
On 03/12/2017 09:13 PM, J?r?my Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ?mtk_jpeg_open?:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ?kzalloc?
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ?kfree? [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
Thanks for the patch, but someone else made the same fix already and it is
queued up for 4.12.
Regards,
Hans
>
> Signed-off-by: J?r?my Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index b10183f7942b..f9bd58ce7d32 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -22,6 +22,7 @@
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/slab.h>
> #include <linux/spinlock.h>
> #include <media/v4l2-event.h>
> #include <media/v4l2-mem2mem.h>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] [media] vcodev: mediatek: add missing include in JPEG decoder driver
@ 2017-03-13 10:17 ` Hans Verkuil
0 siblings, 0 replies; 9+ messages in thread
From: Hans Verkuil @ 2017-03-13 10:17 UTC (permalink / raw)
To: Jérémy Lefaure, Rick Chang, Bin Liu,
Mauro Carvalho Chehab, Matthias Brugger
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-media-u79uwXL29TY76Z2rM5mHXA
On 03/12/2017 09:13 PM, Jérémy Lefaure wrote:
> The driver uses kzalloc and kfree functions. So it should include
> linux/slab.h. This header file is implicitly included by v4l2-common.h
> if CONFIG_SPI is enabled. But when it is disabled, slab.h is not
> included. In this case, the driver does not compile:
>
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c: In function ‘mtk_jpeg_open’:
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:8: error: implicit
> declaration of function ‘kzalloc’
> [-Werror=implicit-function-declaration]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^~~~~~~
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1017:6: warning:
> assignment makes pointer from integer without a cast [-Wint-conversion]
> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
> ^
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c:1047:2: error: implicit
> declaration of function ‘kfree’ [-Werror=implicit-function-declaration]
> kfree(ctx);
> ^~~~~
>
> This patch adds the missing include to fix this issue.
Thanks for the patch, but someone else made the same fix already and it is
queued up for 4.12.
Regards,
Hans
>
> Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
> ---
> drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> index b10183f7942b..f9bd58ce7d32 100644
> --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c
> @@ -22,6 +22,7 @@
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/slab.h>
> #include <linux/spinlock.h>
> #include <media/v4l2-event.h>
> #include <media/v4l2-mem2mem.h>
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 9+ messages in thread