* [PATCH] md:fix a trivial typo in comments
@ 2017-03-13 5:53 Zhilong Liu
2017-03-13 9:10 ` Jack Wang
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Zhilong Liu @ 2017-03-13 5:53 UTC (permalink / raw)
To: shli; +Cc: linux-raid, Zhilong Liu
fix a trivial typo in freeze_array() of raid1.c
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
drivers/md/raid1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 7b0f647..2ec0617 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
static void freeze_array(struct r1conf *conf, int extra)
{
/* stop syncio and normal IO and wait for everything to
- * go quite.
+ * go quit.
* We wait until nr_pending match nr_queued+extra
* This is called in the context of one normal IO request
* that has failed. Thus any sync request that might be pending
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
@ 2017-03-13 9:10 ` Jack Wang
2017-03-13 9:23 ` Guoqing Jiang
2017-03-13 14:27 ` John Stoffel
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Jack Wang @ 2017-03-13 9:10 UTC (permalink / raw)
To: Zhilong Liu; +Cc: shli, linux-raid
2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
> fix a trivial typo in freeze_array() of raid1.c
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 7b0f647..2ec0617 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
> static void freeze_array(struct r1conf *conf, int extra)
> {
> /* stop syncio and normal IO and wait for everything to
> - * go quite.
> + * go quit.
> * We wait until nr_pending match nr_queued+extra
> * This is called in the context of one normal IO request
> * that has failed. Thus any sync request that might be pending
> --
s/quite/quietly ?
Cheers,
Jack
> 2.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 9:10 ` Jack Wang
@ 2017-03-13 9:23 ` Guoqing Jiang
2017-03-13 9:26 ` zhilong
0 siblings, 1 reply; 9+ messages in thread
From: Guoqing Jiang @ 2017-03-13 9:23 UTC (permalink / raw)
To: Jack Wang, Zhilong Liu; +Cc: shli, linux-raid
On 03/13/2017 05:10 PM, Jack Wang wrote:
> 2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
>> fix a trivial typo in freeze_array() of raid1.c
>>
>> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>> ---
>> drivers/md/raid1.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
>> index 7b0f647..2ec0617 100644
>> --- a/drivers/md/raid1.c
>> +++ b/drivers/md/raid1.c
>> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
>> static void freeze_array(struct r1conf *conf, int extra)
>> {
>> /* stop syncio and normal IO and wait for everything to
>> - * go quite.
>> + * go quit.
>> * We wait until nr_pending match nr_queued+extra
>> * This is called in the context of one normal IO request
>> * that has failed. Thus any sync request that might be pending
>> --
> s/quite/quietly ?
I guess it should be "quiet" if referring from freeze_array in raid10.c.
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 9:23 ` Guoqing Jiang
@ 2017-03-13 9:26 ` zhilong
0 siblings, 0 replies; 9+ messages in thread
From: zhilong @ 2017-03-13 9:26 UTC (permalink / raw)
To: Guoqing Jiang, Jack Wang; +Cc: shli, linux-raid
On 03/13/2017 05:23 PM, Guoqing Jiang wrote:
>
>
> On 03/13/2017 05:10 PM, Jack Wang wrote:
>> 2017-03-13 6:53 GMT+01:00 Zhilong Liu <zlliu@suse.com>:
>>> fix a trivial typo in freeze_array() of raid1.c
>>>
>>> Signed-off-by: Zhilong Liu <zlliu@suse.com>
>>> ---
>>> drivers/md/raid1.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
>>> index 7b0f647..2ec0617 100644
>>> --- a/drivers/md/raid1.c
>>> +++ b/drivers/md/raid1.c
>>> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf,
>>> sector_t start_next_window,
>>> static void freeze_array(struct r1conf *conf, int extra)
>>> {
>>> /* stop syncio and normal IO and wait for everything to
>>> - * go quite.
>>> + * go quit.
>>> * We wait until nr_pending match nr_queued+extra
>>> * This is called in the context of one normal IO request
>>> * that has failed. Thus any sync request that might be
>>> pending
>>> --
>> s/quite/quietly ?
>
> I guess it should be "quiet" if referring from freeze_array in raid10.c.
many thanks for your review and correction. and here keep 'quiet' same
as raid10.c?
Thanks,
-Zhilong
>
> Thanks,
> Guoqing
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-13 9:10 ` Jack Wang
@ 2017-03-13 14:27 ` John Stoffel
2017-03-13 14:59 ` Coly Li
2017-03-14 7:52 ` [PATCH v1] " Zhilong Liu
3 siblings, 0 replies; 9+ messages in thread
From: John Stoffel @ 2017-03-13 14:27 UTC (permalink / raw)
To: Zhilong Liu; +Cc: shli, linux-raid
>>>>> "Zhilong" == Zhilong Liu <zlliu@suse.com> writes:
Zhilong> fix a trivial typo in freeze_array() of raid1.c
Zhilong> Signed-off-by: Zhilong Liu <zlliu@suse.com>
Zhilong> ---
Zhilong> drivers/md/raid1.c | 2 +-
Zhilong> 1 file changed, 1 insertion(+), 1 deletion(-)
Zhilong> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
Zhilong> index 7b0f647..2ec0617 100644
Zhilong> --- a/drivers/md/raid1.c
Zhilong> +++ b/drivers/md/raid1.c
Zhilong> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
Zhilong> static void freeze_array(struct r1conf *conf, int extra)
Zhilong> {
Zhilong> /* stop syncio and normal IO and wait for everything to
Zhilong> - * go quite.
Zhilong> + * go quit.
Zhilong> * We wait until nr_pending match nr_queued+extra
Zhilong> * This is called in the context of one normal IO request
Zhilong> * that has failed. Thus any sync request that might be pending
Zhilong> --
Zhilong> 2.6.6
Don't you mean "quiet" instead?
John
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-13 9:10 ` Jack Wang
2017-03-13 14:27 ` John Stoffel
@ 2017-03-13 14:59 ` Coly Li
2017-03-14 7:52 ` [PATCH v1] " Zhilong Liu
3 siblings, 0 replies; 9+ messages in thread
From: Coly Li @ 2017-03-13 14:59 UTC (permalink / raw)
To: Zhilong Liu, shli; +Cc: linux-raid
On 2017/3/13 下午1:53, Zhilong Liu wrote:
> fix a trivial typo in freeze_array() of raid1.c
>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 7b0f647..2ec0617 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -958,7 +958,7 @@ static void allow_barrier(struct r1conf *conf, sector_t start_next_window,
> static void freeze_array(struct r1conf *conf, int extra)
> {
> /* stop syncio and normal IO and wait for everything to
> - * go quite.
It should be "quiet", this is a typo, thanks for catching it :-)
Coly
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1] md:fix a trivial typo in comments
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
` (2 preceding siblings ...)
2017-03-13 14:59 ` Coly Li
@ 2017-03-14 7:52 ` Zhilong Liu
2017-03-14 8:23 ` Coly Li
2017-03-14 18:09 ` Shaohua Li
3 siblings, 2 replies; 9+ messages in thread
From: Zhilong Liu @ 2017-03-14 7:52 UTC (permalink / raw)
To: shli
Cc: linux-raid, Zhilong Liu, Jack Wang, Guoqing Jiang, John Stoffel, Coly Li
raid1.c: fix a trivial typo in comments of freeze_array().
Cc: Jack Wang <jack.wang.usish@gmail.com>
Cc: Guoqing Jiang <gqjiang@suse.com>
Cc: John Stoffel <john@stoffel.org>
Cc: Coly Li <colyli@suse.de>
Signed-off-by: Zhilong Liu <zlliu@suse.com>
---
drivers/md/raid1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index fbc2d78..92ca6de 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -1027,7 +1027,7 @@ static int get_unqueued_pending(struct r1conf *conf)
static void freeze_array(struct r1conf *conf, int extra)
{
/* Stop sync I/O and normal I/O and wait for everything to
- * go quite.
+ * go quiet.
* This is called in two situations:
* 1) management command handlers (reshape, remove disk, quiesce).
* 2) one normal I/O request failed.
--
2.6.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1] md:fix a trivial typo in comments
2017-03-14 7:52 ` [PATCH v1] " Zhilong Liu
@ 2017-03-14 8:23 ` Coly Li
2017-03-14 18:09 ` Shaohua Li
1 sibling, 0 replies; 9+ messages in thread
From: Coly Li @ 2017-03-14 8:23 UTC (permalink / raw)
To: Zhilong Liu, shli; +Cc: linux-raid, Jack Wang, Guoqing Jiang, John Stoffel
On 2017/3/14 下午3:52, Zhilong Liu wrote:
> raid1.c: fix a trivial typo in comments of freeze_array().
>
> Cc: Jack Wang <jack.wang.usish@gmail.com>
> Cc: Guoqing Jiang <gqjiang@suse.com>
> Cc: John Stoffel <john@stoffel.org>
> Cc: Coly Li <colyli@suse.de>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
Acked-by: Coly Li <colyli@suse.de>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index fbc2d78..92ca6de 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1027,7 +1027,7 @@ static int get_unqueued_pending(struct r1conf *conf)
> static void freeze_array(struct r1conf *conf, int extra)
> {
> /* Stop sync I/O and normal I/O and wait for everything to
> - * go quite.
> + * go quiet.
> * This is called in two situations:
> * 1) management command handlers (reshape, remove disk, quiesce).
> * 2) one normal I/O request failed.
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] md:fix a trivial typo in comments
2017-03-14 7:52 ` [PATCH v1] " Zhilong Liu
2017-03-14 8:23 ` Coly Li
@ 2017-03-14 18:09 ` Shaohua Li
1 sibling, 0 replies; 9+ messages in thread
From: Shaohua Li @ 2017-03-14 18:09 UTC (permalink / raw)
To: Zhilong Liu
Cc: shli, linux-raid, Jack Wang, Guoqing Jiang, John Stoffel, Coly Li
On Tue, Mar 14, 2017 at 03:52:26PM +0800, Zhilong Liu wrote:
> raid1.c: fix a trivial typo in comments of freeze_array().
>
> Cc: Jack Wang <jack.wang.usish@gmail.com>
> Cc: Guoqing Jiang <gqjiang@suse.com>
> Cc: John Stoffel <john@stoffel.org>
> Cc: Coly Li <colyli@suse.de>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
applied, thanks
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index fbc2d78..92ca6de 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1027,7 +1027,7 @@ static int get_unqueued_pending(struct r1conf *conf)
> static void freeze_array(struct r1conf *conf, int extra)
> {
> /* Stop sync I/O and normal I/O and wait for everything to
> - * go quite.
> + * go quiet.
> * This is called in two situations:
> * 1) management command handlers (reshape, remove disk, quiesce).
> * 2) one normal I/O request failed.
> --
> 2.6.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-03-14 18:09 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-13 5:53 [PATCH] md:fix a trivial typo in comments Zhilong Liu
2017-03-13 9:10 ` Jack Wang
2017-03-13 9:23 ` Guoqing Jiang
2017-03-13 9:26 ` zhilong
2017-03-13 14:27 ` John Stoffel
2017-03-13 14:59 ` Coly Li
2017-03-14 7:52 ` [PATCH v1] " Zhilong Liu
2017-03-14 8:23 ` Coly Li
2017-03-14 18:09 ` Shaohua Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.