Patch "USB: serial: omninet: fix reference leaks at open" has been added to the 4.10-stable tree

Patch "USB: serial: omninet: fix reference leaks at open" has been added to the 4.10-stable tree

[gregkh]

This is a note to let you know that I've just added the patch titled

    USB: serial: omninet: fix reference leaks at open

to the 4.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-serial-omninet-fix-reference-leaks-at-open.patch
and it can be found in the queue-4.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 30572418b445d85fcfe6c8fe84c947d2606767d8 Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 6 Mar 2017 17:36:38 +0100
Subject: USB: serial: omninet: fix reference leaks at open

From: Johan Hovold <johan@kernel.org>

commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream.

This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.

Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/serial/omninet.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -142,12 +142,6 @@ static int omninet_port_remove(struct us
 
 static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port)
 {
-	struct usb_serial	*serial = port->serial;
-	struct usb_serial_port	*wport;
-
-	wport = serial->port[1];
-	tty_port_tty_set(&wport->port, tty);
-
 	return usb_serial_generic_open(tty, port);
 }
 


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.10/usb-serial-digi_acceleport-fix-oob-event-processing.patch
queue-4.10/usb-serial-omninet-fix-reference-leaks-at-open.patch
queue-4.10/usb-serial-digi_acceleport-fix-oob-data-sanity-check.patch
queue-4.10/usb-iowarrior-fix-null-deref-in-write.patch
queue-4.10/usb-iowarrior-fix-null-deref-at-probe.patch
queue-4.10/usb-serial-io_ti-fix-null-deref-in-interrupt-callback.patch
queue-4.10/usb-serial-io_ti-fix-information-leak-in-completion-handler.patch
queue-4.10/usb-serial-safe_serial-fix-information-leak-in-completion-handler.patch