* [PATCH 1/2] drm/amdgpu/vi: remove duplicate CG flags
@ 2017-03-16 2:06 Alex Deucher
[not found] ` <1489630010-4650-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2017-03-16 2:06 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
GFX_MGLS was added twice.
Noticed-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index fca85f8..28385b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -1044,7 +1044,6 @@ static int vi_common_early_init(void *handle)
AMD_CG_SUPPORT_GFX_RLC_LS |
AMD_CG_SUPPORT_GFX_CP_LS |
AMD_CG_SUPPORT_GFX_CGTS |
- AMD_CG_SUPPORT_GFX_MGLS |
AMD_CG_SUPPORT_GFX_CGTS_LS |
AMD_CG_SUPPORT_GFX_CGCG |
AMD_CG_SUPPORT_GFX_CGLS |
@@ -1073,7 +1072,6 @@ static int vi_common_early_init(void *handle)
AMD_CG_SUPPORT_GFX_RLC_LS |
AMD_CG_SUPPORT_GFX_CP_LS |
AMD_CG_SUPPORT_GFX_CGTS |
- AMD_CG_SUPPORT_GFX_MGLS |
AMD_CG_SUPPORT_GFX_CGTS_LS |
AMD_CG_SUPPORT_GFX_CGCG |
AMD_CG_SUPPORT_GFX_CGLS |
--
2.5.5
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] drm/amdgpu/vi: add missing error handling when setting uvd dclk
[not found] ` <1489630010-4650-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2017-03-16 2:06 ` Alex Deucher
[not found] ` <1489630010-4650-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-16 9:14 ` [PATCH 1/2] drm/amdgpu/vi: remove duplicate CG flags Christian König
1 sibling, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2017-03-16 2:06 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Noticed-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/vi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index 28385b8..eff123b 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -795,6 +795,8 @@ static int vi_set_uvd_clocks(struct amdgpu_device *adev, u32 vclk, u32 dclk)
return r;
r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
+ if (r)
+ return r;
return 0;
}
--
2.5.5
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] drm/amdgpu/vi: add missing error handling when setting uvd dclk
[not found] ` <1489630010-4650-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2017-03-16 3:40 ` Emil Velikov
0 siblings, 0 replies; 4+ messages in thread
From: Emil Velikov @ 2017-03-16 3:40 UTC (permalink / raw)
To: Alex Deucher; +Cc: Alex Deucher, amd-gfx mailing list
Hi Alex,
On 16 March 2017 at 02:06, Alex Deucher <alexdeucher@gmail.com> wrote:
> Noticed-by: David Binderman <dcb314@hotmail.com>
In case it matters - Reported-by or Suggested-by are the more common tags.
Quick search in kernel history [since 2007] shows less than ~60
instances of the above with ~20 from yourself.
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/vi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
> index 28385b8..eff123b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> @@ -795,6 +795,8 @@ static int vi_set_uvd_clocks(struct amdgpu_device *adev, u32 vclk, u32 dclk)
> return r;
>
> r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
> + if (r)
> + return r;
>
> return 0;
One can drop the intermediate "r" here
return vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
Either way both patches are correct. so FWIW
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
-Emil
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] drm/amdgpu/vi: remove duplicate CG flags
[not found] ` <1489630010-4650-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-16 2:06 ` [PATCH 2/2] drm/amdgpu/vi: add missing error handling when setting uvd dclk Alex Deucher
@ 2017-03-16 9:14 ` Christian König
1 sibling, 0 replies; 4+ messages in thread
From: Christian König @ 2017-03-16 9:14 UTC (permalink / raw)
To: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Am 16.03.2017 um 03:06 schrieb Alex Deucher:
> GFX_MGLS was added twice.
>
> Noticed-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com> for both.
> ---
> drivers/gpu/drm/amd/amdgpu/vi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
> index fca85f8..28385b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> @@ -1044,7 +1044,6 @@ static int vi_common_early_init(void *handle)
> AMD_CG_SUPPORT_GFX_RLC_LS |
> AMD_CG_SUPPORT_GFX_CP_LS |
> AMD_CG_SUPPORT_GFX_CGTS |
> - AMD_CG_SUPPORT_GFX_MGLS |
> AMD_CG_SUPPORT_GFX_CGTS_LS |
> AMD_CG_SUPPORT_GFX_CGCG |
> AMD_CG_SUPPORT_GFX_CGLS |
> @@ -1073,7 +1072,6 @@ static int vi_common_early_init(void *handle)
> AMD_CG_SUPPORT_GFX_RLC_LS |
> AMD_CG_SUPPORT_GFX_CP_LS |
> AMD_CG_SUPPORT_GFX_CGTS |
> - AMD_CG_SUPPORT_GFX_MGLS |
> AMD_CG_SUPPORT_GFX_CGTS_LS |
> AMD_CG_SUPPORT_GFX_CGCG |
> AMD_CG_SUPPORT_GFX_CGLS |
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-16 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-16 2:06 [PATCH 1/2] drm/amdgpu/vi: remove duplicate CG flags Alex Deucher
[not found] ` <1489630010-4650-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-16 2:06 ` [PATCH 2/2] drm/amdgpu/vi: add missing error handling when setting uvd dclk Alex Deucher
[not found] ` <1489630010-4650-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2017-03-16 3:40 ` Emil Velikov
2017-03-16 9:14 ` [PATCH 1/2] drm/amdgpu/vi: remove duplicate CG flags Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.