* [PATCH 0/4] [libdrm] support PRT and replace interface @ 2017-03-16 3:56 Junwei Zhang [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Junwei Zhang @ 2017-03-16 3:56 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Junwei Zhang * add PRT flag and new VA op * fix flag setting for current VA op function * Why don't we set flag for current VA op function? * [RFC] implement new VA fun to support NULL bo Junwei Zhang (4): amdgpu: add new VA operations CLEAR and REPLACE amdgpu: set va flag with input parameter amdgpu: add PRT page attribute amdgpu: add a new bo va function to support NULL bo amdgpu/amdgpu.h | 7 +++++++ amdgpu/amdgpu_bo.c | 42 ++++++++++++++++++++++++++++++++++++++++-- include/drm/amdgpu_drm.h | 4 ++++ 3 files changed, 51 insertions(+), 2 deletions(-) -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>]
* [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> @ 2017-03-16 3:56 ` Junwei Zhang [not found] ` <1489636601-31486-2-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-03-16 3:56 ` [PATCH 2/4] amdgpu: set va flag with input parameter Junwei Zhang ` (3 subsequent siblings) 4 siblings, 1 reply; 15+ messages in thread From: Junwei Zhang @ 2017-03-16 3:56 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Junwei Zhang Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> --- include/drm/amdgpu_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 69a7340..34f8282 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -410,6 +410,8 @@ struct drm_amdgpu_gem_op { #define AMDGPU_VA_OP_MAP 1 #define AMDGPU_VA_OP_UNMAP 2 +#define AMDGPU_VA_OP_CLEAR 3 +#define AMDGPU_VA_OP_REPLACE 4 /* Delay the page table update till the next CS */ #define AMDGPU_VM_DELAY_UPDATE (1 << 0) -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <1489636601-31486-2-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE [not found] ` <1489636601-31486-2-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> @ 2017-03-16 14:05 ` Zhang, Jerry [not found] ` <DM5PR12MB18189A8887495F5EB83831FEFF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Zhang, Jerry @ 2017-03-16 14:05 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Koenig, Christian Hi Christian, May I get a RB for this patch? Regards, Jerry(Junwei Zhang) ________________________________________ From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Junwei Zhang <Jerry.Zhang@amd.com> Sent: Thursday, March 16, 2017 11:56 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Jerry Subject: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> --- include/drm/amdgpu_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 69a7340..34f8282 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -410,6 +410,8 @@ struct drm_amdgpu_gem_op { #define AMDGPU_VA_OP_MAP 1 #define AMDGPU_VA_OP_UNMAP 2 +#define AMDGPU_VA_OP_CLEAR 3 +#define AMDGPU_VA_OP_REPLACE 4 /* Delay the page table update till the next CS */ #define AMDGPU_VM_DELAY_UPDATE (1 << 0) -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <DM5PR12MB18189A8887495F5EB83831FEFF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE [not found] ` <DM5PR12MB18189A8887495F5EB83831FEFF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-03-16 14:20 ` Christian König [not found] ` <6c9dce66-bc31-cd9a-8ea5-c3a2439d1cc6-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Christian König @ 2017-03-16 14:20 UTC (permalink / raw) To: Zhang, Jerry, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 1670 bytes --] Hi Jerry, fell free to use this patch internally, but the upstream copy of include/drm/amdgpu_drm.h should be updated when the kernel change land. Emil usually points out how to do this correctly whenever we try to add changes manually. Christian. Am 16.03.2017 um 15:05 schrieb Zhang, Jerry: > Hi Christian, > > May I get a RB for this patch? > > Regards, > Jerry(Junwei Zhang) > > ________________________________________ > From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of > Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> > Sent: Thursday, March 16, 2017 11:56 > To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > Cc: Zhang, Jerry > Subject: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE > > Signed-off-by: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> > --- > include/drm/amdgpu_drm.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h > index 69a7340..34f8282 100644 > --- a/include/drm/amdgpu_drm.h > +++ b/include/drm/amdgpu_drm.h > @@ -410,6 +410,8 @@ struct drm_amdgpu_gem_op { > > #define AMDGPU_VA_OP_MAP 1 > #define AMDGPU_VA_OP_UNMAP 2 > +#define AMDGPU_VA_OP_CLEAR 3 > +#define AMDGPU_VA_OP_REPLACE 4 > > /* Delay the page table update till the next CS */ > #define AMDGPU_VM_DELAY_UPDATE (1 << 0) > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx [-- Attachment #1.2: Type: text/html, Size: 3839 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <6c9dce66-bc31-cd9a-8ea5-c3a2439d1cc6-5C7GfCeVMHo@public.gmane.org>]
* RE: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE [not found] ` <6c9dce66-bc31-cd9a-8ea5-c3a2439d1cc6-5C7GfCeVMHo@public.gmane.org> @ 2017-03-17 0:16 ` Zhang, Jerry [not found] ` <DM5PR12MB1818F81AB6393F9A0C9E3D0EFF390-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Zhang, Jerry @ 2017-03-17 0:16 UTC (permalink / raw) To: Koenig, Christian, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW [-- Attachment #1.1: Type: text/plain, Size: 2334 bytes --] Hi Christian, Thanks for your reminder. I always keep it in mind. Regards, Jerry (Junwei Zhang) Linux Base Graphics SRDC Software Development _____________________________________ From: Koenig, Christian Sent: Thursday, March 16, 2017 22:21 To: Zhang, Jerry; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Subject: Re: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE Hi Jerry, fell free to use this patch internally, but the upstream copy of include/drm/amdgpu_drm.h should be updated when the kernel change land. Emil usually points out how to do this correctly whenever we try to add changes manually. Christian. Am 16.03.2017 um 15:05 schrieb Zhang, Jerry: Hi Christian, May I get a RB for this patch? Regards, Jerry(Junwei Zhang) ________________________________________ From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org><mailto:amd-gfx-bounces@lists.freedesktop.org> on behalf of Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org><mailto:Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> Sent: Thursday, March 16, 2017 11:56 To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> Cc: Zhang, Jerry Subject: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE Signed-off-by: Junwei Zhang <Jerry.Zhang-5C7GfCeVMHo@public.gmane.org><mailto:Jerry.Zhang-urvtwAKJhsc@public.gmane.orgm> --- include/drm/amdgpu_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 69a7340..34f8282 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -410,6 +410,8 @@ struct drm_amdgpu_gem_op { #define AMDGPU_VA_OP_MAP 1 #define AMDGPU_VA_OP_UNMAP 2 +#define AMDGPU_VA_OP_CLEAR 3 +#define AMDGPU_VA_OP_REPLACE 4 /* Delay the page table update till the next CS */ #define AMDGPU_VM_DELAY_UPDATE (1 << 0) -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx [-- Attachment #1.2: Type: text/html, Size: 8540 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
[parent not found: <DM5PR12MB1818F81AB6393F9A0C9E3D0EFF390-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE [not found] ` <DM5PR12MB1818F81AB6393F9A0C9E3D0EFF390-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-03-17 1:27 ` Michel Dänzer 0 siblings, 0 replies; 15+ messages in thread From: Michel Dänzer @ 2017-03-17 1:27 UTC (permalink / raw) To: Zhang, Jerry, Koenig, Christian; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 17/03/17 09:16 AM, Zhang, Jerry wrote: > > Thanks for your reminder. > > I always keep it in mind. [...] > *From:*Koenig, Christian > >> fell free to use this patch internally, but the upstream copy of >> include/drm/amdgpu_drm.h should be updated when the kernel change land. >> >> Emil usually points out how to do this correctly whenever we try to add >> changes manually. See include/drm/README in the libdrm tree. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH 2/4] amdgpu: set va flag with input parameter [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-03-16 3:56 ` [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE Junwei Zhang @ 2017-03-16 3:56 ` Junwei Zhang 2017-03-16 3:56 ` [PATCH 3/4] amdgpu: add PRT page attribute Junwei Zhang ` (2 subsequent siblings) 4 siblings, 0 replies; 15+ messages in thread From: Junwei Zhang @ 2017-03-16 3:56 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Junwei Zhang Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> --- amdgpu/amdgpu_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index 6189e5a..800b77a 100644 --- a/amdgpu/amdgpu_bo.c +++ b/amdgpu/amdgpu_bo.c @@ -941,7 +941,7 @@ int amdgpu_bo_va_op(amdgpu_bo_handle bo, memset(&va, 0, sizeof(va)); va.handle = bo->handle; va.operation = ops; - va.flags = AMDGPU_VM_PAGE_READABLE | + va.flags = flags | AMDGPU_VM_PAGE_READABLE | AMDGPU_VM_PAGE_WRITEABLE | AMDGPU_VM_PAGE_EXECUTABLE; va.va_address = addr; -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 3/4] amdgpu: add PRT page attribute [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-03-16 3:56 ` [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE Junwei Zhang 2017-03-16 3:56 ` [PATCH 2/4] amdgpu: set va flag with input parameter Junwei Zhang @ 2017-03-16 3:56 ` Junwei Zhang 2017-03-16 3:56 ` [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo Junwei Zhang 2017-03-16 8:59 ` [PATCH 0/4] [libdrm] support PRT and replace interface Christian König 4 siblings, 0 replies; 15+ messages in thread From: Junwei Zhang @ 2017-03-16 3:56 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Junwei Zhang Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> --- include/drm/amdgpu_drm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 34f8282..a73b40a 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -423,6 +423,8 @@ struct drm_amdgpu_gem_op { #define AMDGPU_VM_PAGE_WRITEABLE (1 << 2) /* executable mapping, new for VI */ #define AMDGPU_VM_PAGE_EXECUTABLE (1 << 3) +/* partially resident texture */ +#define AMDGPU_VM_PAGE_PRT (1 << 4) struct drm_amdgpu_gem_va { /** GEM object handle */ -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> ` (2 preceding siblings ...) 2017-03-16 3:56 ` [PATCH 3/4] amdgpu: add PRT page attribute Junwei Zhang @ 2017-03-16 3:56 ` Junwei Zhang 2017-03-16 8:59 ` [PATCH 0/4] [libdrm] support PRT and replace interface Christian König 4 siblings, 0 replies; 15+ messages in thread From: Junwei Zhang @ 2017-03-16 3:56 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Junwei Zhang Signed-off-by: Junwei Zhang <Jerry.Zhang@amd.com> --- amdgpu/amdgpu.h | 7 +++++++ amdgpu/amdgpu_bo.c | 40 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 84ab688..a9fddd6 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -1429,6 +1429,13 @@ int amdgpu_bo_va_op(amdgpu_bo_handle bo, uint64_t flags, uint32_t ops); +int amdgpu_bo_va_op2(amdgpu_device_handle dev, + amdgpu_bo_handle bo, + uint64_t offset, + uint64_t size, + uint64_t addr, + uint64_t flags, + uint32_t ops); /** * VA mapping/unmapping for the buffer object * diff --git a/amdgpu/amdgpu_bo.c b/amdgpu/amdgpu_bo.c index 800b77a..421e440 100644 --- a/amdgpu/amdgpu_bo.c +++ b/amdgpu/amdgpu_bo.c @@ -924,13 +924,51 @@ int amdgpu_bo_list_update(amdgpu_bo_list_handle handle, return r; } -int amdgpu_bo_va_op(amdgpu_bo_handle bo, +int amdgpu_bo_va_op2(amdgpu_device_handle dev, + amdgpu_bo_handle bo, uint64_t offset, uint64_t size, uint64_t addr, uint64_t flags, uint32_t ops) { + struct drm_amdgpu_gem_va va; + int r; + + if (ops != AMDGPU_VA_OP_MAP && ops != AMDGPU_VA_OP_UNMAP && + ops != AMDGPU_VA_OP_REPLACE && + ops != AMDGPU_VA_OP_CLEAR) + return -EINVAL; + + memset(&va, 0, sizeof(va)); + if (bo) + va.handle = bo->handle; + else + va.handle = NULL; + if (flags & AMDGPU_VM_PAGE_PRT) + flags &= AMDGPU_VM_PAGE_PRT; + else + flags |= AMDGPU_VM_PAGE_READABLE | AMDGPU_VM_PAGE_WRITEABLE | + AMDGPU_VM_PAGE_EXECUTABLE; + + va.operation = ops; + va.flags = flags; + va.va_address = addr; + va.offset_in_bo = offset; + va.map_size = ALIGN(size, getpagesize()); + + r = drmCommandWriteRead(dev->fd, DRM_AMDGPU_GEM_VA, &va, sizeof(va)); + + return r; +} + +int amdgpu_bo_va_op(amdgpu_bo_handle bo, + uint64_t offset, + uint64_t size, + uint64_t addr, + uint64_t flags, + uint32_t ops) +{ amdgpu_device_handle dev = bo->dev; struct drm_amdgpu_gem_va va; int r; -- 1.9.1 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH 0/4] [libdrm] support PRT and replace interface [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> ` (3 preceding siblings ...) 2017-03-16 3:56 ` [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo Junwei Zhang @ 2017-03-16 8:59 ` Christian König [not found] ` <2a70a1b2-dbe9-a3ee-99ea-2d0af4c3baf7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 4 siblings, 1 reply; 15+ messages in thread From: Christian König @ 2017-03-16 8:59 UTC (permalink / raw) To: Junwei Zhang, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Nicolai already proposed patches for PRT support in libdrm (except the CLEAR/REPLACE addition). They look a bit cleaner and where posted first, I think we should use them instead. Christian. Am 16.03.2017 um 04:56 schrieb Junwei Zhang: > * add PRT flag and new VA op > * fix flag setting for current VA op function > * Why don't we set flag for current VA op function? > * [RFC] implement new VA fun to support NULL bo > > Junwei Zhang (4): > amdgpu: add new VA operations CLEAR and REPLACE > amdgpu: set va flag with input parameter > amdgpu: add PRT page attribute > amdgpu: add a new bo va function to support NULL bo > > amdgpu/amdgpu.h | 7 +++++++ > amdgpu/amdgpu_bo.c | 42 ++++++++++++++++++++++++++++++++++++++++-- > include/drm/amdgpu_drm.h | 4 ++++ > 3 files changed, 51 insertions(+), 2 deletions(-) > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <2a70a1b2-dbe9-a3ee-99ea-2d0af4c3baf7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>]
* RE: [PATCH 0/4] [libdrm] support PRT and replace interface [not found] ` <2a70a1b2-dbe9-a3ee-99ea-2d0af4c3baf7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> @ 2017-03-16 9:14 ` Zhang, Jerry [not found] ` <DM5PR12MB1818645A40DE984A08DD20B2FF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Zhang, Jerry @ 2017-03-16 9:14 UTC (permalink / raw) To: Christian König, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Hi Christian, Thanks for your info. Sorry to miss them... Actually this a serial of messed function patch, I should send them separately next time. If we support PRT with bo=NULL, we may need a new VA op. So please take a look at patch 4: * [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo I also have a question about current VA op func, why we didn't use the input flags? So I prepare the patch 2 to use the input flags: * [PATCH 2/4] amdgpu: set va flag with input parameter Regards, Jerry (Junwei Zhang) Linux Base Graphics SRDC Software Development _____________________________________ > -----Original Message----- > From: Christian König [mailto:deathsimple@vodafone.de] > Sent: Thursday, March 16, 2017 17:00 > To: Zhang, Jerry; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface > > Nicolai already proposed patches for PRT support in libdrm (except the > CLEAR/REPLACE addition). > > They look a bit cleaner and where posted first, I think we should use them > instead. > > Christian. > > Am 16.03.2017 um 04:56 schrieb Junwei Zhang: > > * add PRT flag and new VA op > > * fix flag setting for current VA op function > > * Why don't we set flag for current VA op function? > > * [RFC] implement new VA fun to support NULL bo > > > > Junwei Zhang (4): > > amdgpu: add new VA operations CLEAR and REPLACE > > amdgpu: set va flag with input parameter > > amdgpu: add PRT page attribute > > amdgpu: add a new bo va function to support NULL bo > > > > amdgpu/amdgpu.h | 7 +++++++ > > amdgpu/amdgpu_bo.c | 42 > ++++++++++++++++++++++++++++++++++++++++-- > > include/drm/amdgpu_drm.h | 4 ++++ > > 3 files changed, 51 insertions(+), 2 deletions(-) > > _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <DM5PR12MB1818645A40DE984A08DD20B2FF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH 0/4] [libdrm] support PRT and replace interface [not found] ` <DM5PR12MB1818645A40DE984A08DD20B2FF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2017-03-16 9:28 ` Christian König [not found] ` <84eaf027-5fb3-4fa8-c0fc-88281f7e61d7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 0 siblings, 1 reply; 15+ messages in thread From: Christian König @ 2017-03-16 9:28 UTC (permalink / raw) To: Zhang, Jerry, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Am 16.03.2017 um 10:14 schrieb Zhang, Jerry: > Hi Christian, > > Thanks for your info. > Sorry to miss them... > > Actually this a serial of messed function patch, I should send them separately next time. > > If we support PRT with bo=NULL, we may need a new VA op. > So please take a look at patch 4: > * [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo > > I also have a question about current VA op func, why we didn't use the input flags? I have no idea. > So I prepare the patch 2 to use the input flags: > * [PATCH 2/4] amdgpu: set va flag with input parameter Nicolai handled both issues by creating a new function where the BO is optional and the flags taken into account. Please take a look at his patches, they are on the mailing list. Christian. > > > Regards, > Jerry (Junwei Zhang) > > Linux Base Graphics > SRDC Software Development > _____________________________________ > > >> -----Original Message----- >> From: Christian König [mailto:deathsimple@vodafone.de] >> Sent: Thursday, March 16, 2017 17:00 >> To: Zhang, Jerry; amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface >> >> Nicolai already proposed patches for PRT support in libdrm (except the >> CLEAR/REPLACE addition). >> >> They look a bit cleaner and where posted first, I think we should use them >> instead. >> >> Christian. >> >> Am 16.03.2017 um 04:56 schrieb Junwei Zhang: >>> * add PRT flag and new VA op >>> * fix flag setting for current VA op function >>> * Why don't we set flag for current VA op function? >>> * [RFC] implement new VA fun to support NULL bo >>> >>> Junwei Zhang (4): >>> amdgpu: add new VA operations CLEAR and REPLACE >>> amdgpu: set va flag with input parameter >>> amdgpu: add PRT page attribute >>> amdgpu: add a new bo va function to support NULL bo >>> >>> amdgpu/amdgpu.h | 7 +++++++ >>> amdgpu/amdgpu_bo.c | 42 >> ++++++++++++++++++++++++++++++++++++++++-- >>> include/drm/amdgpu_drm.h | 4 ++++ >>> 3 files changed, 51 insertions(+), 2 deletions(-) >>> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <84eaf027-5fb3-4fa8-c0fc-88281f7e61d7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>]
* Re: [PATCH 0/4] [libdrm] support PRT and replace interface [not found] ` <84eaf027-5fb3-4fa8-c0fc-88281f7e61d7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> @ 2017-03-16 9:42 ` Michel Dänzer [not found] ` <f24666c5-ee24-7b72-1706-16da59260379-otUistvHUpPR7s880joybQ@public.gmane.org> 2017-03-16 13:23 ` Zhang, Jerry 1 sibling, 1 reply; 15+ messages in thread From: Michel Dänzer @ 2017-03-16 9:42 UTC (permalink / raw) To: Christian König, Zhang, Jerry Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On 16/03/17 06:28 PM, Christian König wrote: > Am 16.03.2017 um 10:14 schrieb Zhang, Jerry: >> >> So I prepare the patch 2 to use the input flags: >> * [PATCH 2/4] amdgpu: set va flag with input parameter > > Nicolai handled both issues by creating a new function where the BO is > optional and the flags taken into account. > > Please take a look at his patches, they are on the mailing list. Or on Patchwork: https://patchwork.freedesktop.org/project/amd-xorg-ddx/patches/?submitter=15673 Speaking of Patchwork, it's accumulating a lot of stale patches. Everybody submitting patches, please at least periodically go through your patches and change their state as appropriate. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
[parent not found: <f24666c5-ee24-7b72-1706-16da59260379-otUistvHUpPR7s880joybQ@public.gmane.org>]
* Re: [PATCH 0/4] [libdrm] support PRT and replace interface [not found] ` <f24666c5-ee24-7b72-1706-16da59260379-otUistvHUpPR7s880joybQ@public.gmane.org> @ 2017-03-16 13:24 ` Zhang, Jerry 0 siblings, 0 replies; 15+ messages in thread From: Zhang, Jerry @ 2017-03-16 13:24 UTC (permalink / raw) To: Michel Dänzer, Christian König Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Hi Michel, that's really help me :) thanks. Regards, Jerry(Junwei Zhang) ________________________________________ From: Michel Dänzer <michel@daenzer.net> Sent: Thursday, March 16, 2017 5:42:53 PM To: Christian König; Zhang, Jerry Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface On 16/03/17 06:28 PM, Christian König wrote: > Am 16.03.2017 um 10:14 schrieb Zhang, Jerry: >> >> So I prepare the patch 2 to use the input flags: >> * [PATCH 2/4] amdgpu: set va flag with input parameter > > Nicolai handled both issues by creating a new function where the BO is > optional and the flags taken into account. > > Please take a look at his patches, they are on the mailing list. Or on Patchwork: https://patchwork.freedesktop.org/project/amd-xorg-ddx/patches/?submitter=15673 Speaking of Patchwork, it's accumulating a lot of stale patches. Everybody submitting patches, please at least periodically go through your patches and change their state as appropriate. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH 0/4] [libdrm] support PRT and replace interface [not found] ` <84eaf027-5fb3-4fa8-c0fc-88281f7e61d7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 2017-03-16 9:42 ` Michel Dänzer @ 2017-03-16 13:23 ` Zhang, Jerry 1 sibling, 0 replies; 15+ messages in thread From: Zhang, Jerry @ 2017-03-16 13:23 UTC (permalink / raw) To: Christian König, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Hi Christian, Thanks for your info. I missed them completely :( the va op raw func looks similar as my va op2. I will re-use them in hybrid libdrm and provide for UMD development. Regards, Jerry(Junwei Zhang) ________________________________________ From: Christian König <deathsimple@vodafone.de> Sent: Thursday, March 16, 2017 5:28:21 PM To: Zhang, Jerry; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface Am 16.03.2017 um 10:14 schrieb Zhang, Jerry: > Hi Christian, > > Thanks for your info. > Sorry to miss them... > > Actually this a serial of messed function patch, I should send them separately next time. > > If we support PRT with bo=NULL, we may need a new VA op. > So please take a look at patch 4: > * [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo > > I also have a question about current VA op func, why we didn't use the input flags? I have no idea. > So I prepare the patch 2 to use the input flags: > * [PATCH 2/4] amdgpu: set va flag with input parameter Nicolai handled both issues by creating a new function where the BO is optional and the flags taken into account. Please take a look at his patches, they are on the mailing list. Christian. > > > Regards, > Jerry (Junwei Zhang) > > Linux Base Graphics > SRDC Software Development > _____________________________________ > > >> -----Original Message----- >> From: Christian König [mailto:deathsimple@vodafone.de] >> Sent: Thursday, March 16, 2017 17:00 >> To: Zhang, Jerry; amd-gfx@lists.freedesktop.org >> Subject: Re: [PATCH 0/4] [libdrm] support PRT and replace interface >> >> Nicolai already proposed patches for PRT support in libdrm (except the >> CLEAR/REPLACE addition). >> >> They look a bit cleaner and where posted first, I think we should use them >> instead. >> >> Christian. >> >> Am 16.03.2017 um 04:56 schrieb Junwei Zhang: >>> * add PRT flag and new VA op >>> * fix flag setting for current VA op function >>> * Why don't we set flag for current VA op function? >>> * [RFC] implement new VA fun to support NULL bo >>> >>> Junwei Zhang (4): >>> amdgpu: add new VA operations CLEAR and REPLACE >>> amdgpu: set va flag with input parameter >>> amdgpu: add PRT page attribute >>> amdgpu: add a new bo va function to support NULL bo >>> >>> amdgpu/amdgpu.h | 7 +++++++ >>> amdgpu/amdgpu_bo.c | 42 >> ++++++++++++++++++++++++++++++++++++++++-- >>> include/drm/amdgpu_drm.h | 4 ++++ >>> 3 files changed, 51 insertions(+), 2 deletions(-) >>> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2017-03-17 1:27 UTC | newest] Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-03-16 3:56 [PATCH 0/4] [libdrm] support PRT and replace interface Junwei Zhang [not found] ` <1489636601-31486-1-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-03-16 3:56 ` [PATCH 1/4] amdgpu: add new VA operations CLEAR and REPLACE Junwei Zhang [not found] ` <1489636601-31486-2-git-send-email-Jerry.Zhang-5C7GfCeVMHo@public.gmane.org> 2017-03-16 14:05 ` Zhang, Jerry [not found] ` <DM5PR12MB18189A8887495F5EB83831FEFF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-03-16 14:20 ` Christian König [not found] ` <6c9dce66-bc31-cd9a-8ea5-c3a2439d1cc6-5C7GfCeVMHo@public.gmane.org> 2017-03-17 0:16 ` Zhang, Jerry [not found] ` <DM5PR12MB1818F81AB6393F9A0C9E3D0EFF390-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-03-17 1:27 ` Michel Dänzer 2017-03-16 3:56 ` [PATCH 2/4] amdgpu: set va flag with input parameter Junwei Zhang 2017-03-16 3:56 ` [PATCH 3/4] amdgpu: add PRT page attribute Junwei Zhang 2017-03-16 3:56 ` [PATCH 4/4] amdgpu: add a new bo va function to support NULL bo Junwei Zhang 2017-03-16 8:59 ` [PATCH 0/4] [libdrm] support PRT and replace interface Christian König [not found] ` <2a70a1b2-dbe9-a3ee-99ea-2d0af4c3baf7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 2017-03-16 9:14 ` Zhang, Jerry [not found] ` <DM5PR12MB1818645A40DE984A08DD20B2FF260-2J9CzHegvk+QhrfEZJlvtAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2017-03-16 9:28 ` Christian König [not found] ` <84eaf027-5fb3-4fa8-c0fc-88281f7e61d7-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> 2017-03-16 9:42 ` Michel Dänzer [not found] ` <f24666c5-ee24-7b72-1706-16da59260379-otUistvHUpPR7s880joybQ@public.gmane.org> 2017-03-16 13:24 ` Zhang, Jerry 2017-03-16 13:23 ` Zhang, Jerry
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.