* [PATCH net-next 0/2] small set of sched cleanups
@ 2017-03-16 8:49 Or Gerlitz
2017-03-16 8:49 ` [PATCH net-next 1/2] net/sched: act_ife: Staticfy find_decode_metaid() Or Gerlitz
2017-03-16 8:49 ` [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable Or Gerlitz
0 siblings, 2 replies; 4+ messages in thread
From: Or Gerlitz @ 2017-03-16 8:49 UTC (permalink / raw)
To: David S. Miller; +Cc: Cong Wang, netdev, Or Gerlitz
Hi Dave,
Just two cleanups -- but for the 2nd one I think we need ack from
Cong Wang to make sure this isn't actually a bug report..
Or.
Or Gerlitz (2):
net/sched: act_ife: Staticfy find_decode_metaid()
net/sched: fq_codel: Avoid set-but-unused variable
net/sched/act_ife.c | 4 ++--
net/sched/sch_fq_codel.c | 2 --
2 files changed, 2 insertions(+), 4 deletions(-)
--
2.3.7
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH net-next 1/2] net/sched: act_ife: Staticfy find_decode_metaid()
2017-03-16 8:49 [PATCH net-next 0/2] small set of sched cleanups Or Gerlitz
@ 2017-03-16 8:49 ` Or Gerlitz
2017-03-16 8:49 ` [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable Or Gerlitz
1 sibling, 0 replies; 4+ messages in thread
From: Or Gerlitz @ 2017-03-16 8:49 UTC (permalink / raw)
To: David S. Miller; +Cc: Cong Wang, netdev, Or Gerlitz
As it's used only on that file.
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
net/sched/act_ife.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
index 71e7ff22..c75ea5c 100644
--- a/net/sched/act_ife.c
+++ b/net/sched/act_ife.c
@@ -603,8 +603,8 @@ static int tcf_ife_dump(struct sk_buff *skb, struct tc_action *a, int bind,
return -1;
}
-int find_decode_metaid(struct sk_buff *skb, struct tcf_ife_info *ife,
- u16 metaid, u16 mlen, void *mdata)
+static int find_decode_metaid(struct sk_buff *skb, struct tcf_ife_info *ife,
+ u16 metaid, u16 mlen, void *mdata)
{
struct tcf_meta_info *e;
--
2.3.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable
2017-03-16 8:49 [PATCH net-next 0/2] small set of sched cleanups Or Gerlitz
2017-03-16 8:49 ` [PATCH net-next 1/2] net/sched: act_ife: Staticfy find_decode_metaid() Or Gerlitz
@ 2017-03-16 8:49 ` Or Gerlitz
2017-03-16 10:10 ` Sergei Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Or Gerlitz @ 2017-03-16 8:49 UTC (permalink / raw)
To: David S. Miller; +Cc: Cong Wang, netdev, Or Gerlitz
The code introduced by commit 2ccccf5fb "net_sched: update hierarchical
backlog too" only sets prev_backlog in fq_codel_dequeue() but not
using that anywhere, remove that setting.
Cc: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
---
net/sched/sch_fq_codel.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
index 9f3a884..097bbe9 100644
--- a/net/sched/sch_fq_codel.c
+++ b/net/sched/sch_fq_codel.c
@@ -288,7 +288,6 @@ static struct sk_buff *fq_codel_dequeue(struct Qdisc *sch)
struct fq_codel_flow *flow;
struct list_head *head;
u32 prev_drop_count, prev_ecn_mark;
- unsigned int prev_backlog;
begin:
head = &q->new_flows;
@@ -307,7 +306,6 @@ static struct sk_buff *fq_codel_dequeue(struct Qdisc *sch)
prev_drop_count = q->cstats.drop_count;
prev_ecn_mark = q->cstats.ecn_mark;
- prev_backlog = sch->qstats.backlog;
skb = codel_dequeue(sch, &sch->qstats.backlog, &q->cparams,
&flow->cvars, &q->cstats, qdisc_pkt_len,
--
2.3.7
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable
2017-03-16 8:49 ` [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable Or Gerlitz
@ 2017-03-16 10:10 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2017-03-16 10:10 UTC (permalink / raw)
To: Or Gerlitz, David S. Miller; +Cc: Cong Wang, netdev
Hello!
On 3/16/2017 11:49 AM, Or Gerlitz wrote:
> The code introduced by commit 2ccccf5fb "net_sched: update hierarchical
> backlog too" only sets prev_backlog in fq_codel_dequeue() but not
Need 12 hex digits and () around "<summary>"; see
Documentation/process/submitting-patches.rst.
> using that anywhere, remove that setting.
>
> Cc: Cong Wang <xiyou.wangcong@gmail.com>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-16 10:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-16 8:49 [PATCH net-next 0/2] small set of sched cleanups Or Gerlitz
2017-03-16 8:49 ` [PATCH net-next 1/2] net/sched: act_ife: Staticfy find_decode_metaid() Or Gerlitz
2017-03-16 8:49 ` [PATCH net-next 2/2] net/sched: fq_codel: Avoid set-but-unused variable Or Gerlitz
2017-03-16 10:10 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.