[PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory

* [PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory
@ 2017-03-17 12:58 Thomas Petazzoni
  2017-03-24 13:52 ` Rob Herring
  2017-03-24 14:13 ` Herbert Xu
  0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2017-03-17 12:58 UTC (permalink / raw)
  To: devicetree, Rob Herring, Ian Campbell, Pawel Moll, Mark Rutland,
	Kumar Gala
  Cc: Herbert Xu, linux-crypto, romain.perier, Nadav Haklai,
	Hanna Hawa, Yehuda Yitschak, Jason Cooper, Andrew Lunn,
	Sebastian Hesselbarth, Gregory Clement, Thomas Petazzoni, stable

Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76
device variant") update the omap_rng Device Tree binding to add support
for the IP-76 variation of the IP. As part of this change, a "clocks"
property was added, but is indicated as "Required", without indicated
it's actually only required for some compatible strings.

This commit fixes that, by explicitly stating that the clocks property
is only required with the inside-secure,safexcel-eip76 compatible
string.

Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Changes since v1:
 - Instead of indicating the property as optional, indicate it as
   mandatory for the inside-secure,safexcel-eip76 compatible string, as
   suggested by Rob Herring.
---
 Documentation/devicetree/bindings/rng/omap_rng.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt
index 4714772..9cf7876 100644
--- a/Documentation/devicetree/bindings/rng/omap_rng.txt
+++ b/Documentation/devicetree/bindings/rng/omap_rng.txt
@@ -12,7 +12,8 @@ Required properties:
 - reg : Offset and length of the register set for the module
 - interrupts : the interrupt number for the RNG module.
 		Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76"
-- clocks: the trng clock source
+- clocks: the trng clock source. Only mandatory for the
+  "inside-secure,safexcel-eip76" compatible.
 
 Example:
 /* AM335x */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread