* [PATCH] can: ifi: use correct register to read rx status
@ 2017-03-17 22:14 Markus Marb
2017-03-21 14:53 ` Marc Kleine-Budde
0 siblings, 1 reply; 5+ messages in thread
From: Markus Marb @ 2017-03-17 22:14 UTC (permalink / raw)
To: wg, mkl; +Cc: linux-can, Markus Marb
The incorrect offset was used when trying to read the RXSTCMD register.
Signed-off-by: Markus Marb <markus@marb.org>
---
drivers/net/can/ifi_canfd/ifi_canfd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/ifi_canfd/ifi_canfd.c b/drivers/net/can/ifi_canfd/ifi_canfd.c
index 138f5ae..4d1fe8d 100644
--- a/drivers/net/can/ifi_canfd/ifi_canfd.c
+++ b/drivers/net/can/ifi_canfd/ifi_canfd.c
@@ -557,7 +557,7 @@ static int ifi_canfd_poll(struct napi_struct *napi, int quota)
int work_done = 0;
u32 stcmd = readl(priv->base + IFI_CANFD_STCMD);
- u32 rxstcmd = readl(priv->base + IFI_CANFD_STCMD);
+ u32 rxstcmd = readl(priv->base + IFI_CANFD_RXSTCMD);
u32 errctr = readl(priv->base + IFI_CANFD_ERROR_CTR);
/* Handle bus state changes */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ifi: use correct register to read rx status
2017-03-17 22:14 [PATCH] can: ifi: use correct register to read rx status Markus Marb
@ 2017-03-21 14:53 ` Marc Kleine-Budde
0 siblings, 0 replies; 5+ messages in thread
From: Marc Kleine-Budde @ 2017-03-21 14:53 UTC (permalink / raw)
To: Markus Marb, wg; +Cc: linux-can
[-- Attachment #1.1: Type: text/plain, Size: 481 bytes --]
On 03/17/2017 11:14 PM, Markus Marb wrote:
> The incorrect offset was used when trying to read the RXSTCMD register.
>
> Signed-off-by: Markus Marb <markus@marb.org>
Applied to can.
tnx,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ifi: use correct register to read rx status
2017-04-10 20:07 ` Markus Marb
@ 2017-04-14 12:23 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2017-04-14 12:23 UTC (permalink / raw)
To: Markus Marb; +Cc: linux-can
On 04/10/2017 10:07 PM, Markus Marb wrote:
> Hi,
Hi!
>> Which version of the core do you use ? Can you also share value of
>> register 0x54 and 0x58 ?
> I am using core version 0x020F5B14 (register 0x54).
Thanks!
> Register 0x58 is fixed i guess ? It holds 0xD073CAFD.
>
> Regards,
> Markus Marb
>
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ifi: use correct register to read rx status
2017-03-26 15:06 Marek Vasut
@ 2017-04-10 20:07 ` Markus Marb
2017-04-14 12:23 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Markus Marb @ 2017-04-10 20:07 UTC (permalink / raw)
To: Marek Vasut; +Cc: linux-can
Hi,
> Which version of the core do you use ? Can you also share value of
> register 0x54 and 0x58 ?
I am using core version 0x020F5B14 (register 0x54).
Register 0x58 is fixed i guess ? It holds 0xD073CAFD.
Regards,
Markus Marb
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] can: ifi: use correct register to read rx status
@ 2017-03-26 15:06 Marek Vasut
2017-04-10 20:07 ` Markus Marb
0 siblings, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2017-03-26 15:06 UTC (permalink / raw)
To: linux-can; +Cc: Marc Kleine-Budde, Markus Marb
Hi,
I was notified about this patch recently, unfortunately I was not on CC
on the original submission, so I was unable to review/test this patch.
Nice catch though, thanks.
Which version of the core do you use ? Can you also share value of
register 0x54 and 0x58 ?
Thanks
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-14 12:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-17 22:14 [PATCH] can: ifi: use correct register to read rx status Markus Marb
2017-03-21 14:53 ` Marc Kleine-Budde
2017-03-26 15:06 Marek Vasut
2017-04-10 20:07 ` Markus Marb
2017-04-14 12:23 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.