* [PATCH libnetfilter_cthelper] examples: fix double free in nftc-helper-add
@ 2017-03-19 14:01 Liping Zhang
2017-03-21 10:41 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Liping Zhang @ 2017-03-19 14:01 UTC (permalink / raw)
To: pablo; +Cc: netfilter-devel, Liping Zhang
From: Liping Zhang <zlpnobody@gmail.com>
After inputting the following test command, core dump happened:
# ./examples/nfct-helper-add test 1
*** Error in
`.../libnetfilter_cthelper/examples/.libs/lt-nfct-helper-add':
double free or corruption (fasttop): 0x0000000001f3c070 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x77de5)[0x7fd9ebe88de5]
/lib64/libc.so.6(+0x8022a)[0x7fd9ebe9122a]
/lib64/libc.so.6(cfree+0x4c)[0x7fd9ebe9478c]
[...]
Because "struct nfct_helper_policy *p" had been freed by nfct_helper_free,
so there's no need to invoke nfct_helper_policy_free again, otherwise
dobule free error will happen.
Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
---
examples/nfct-helper-add.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/examples/nfct-helper-add.c b/examples/nfct-helper-add.c
index 6c47626..cb7291e 100644
--- a/examples/nfct-helper-add.c
+++ b/examples/nfct-helper-add.c
@@ -32,6 +32,7 @@ int main(int argc, char *argv[])
nfct_helper_attr_set_u16(nfct_helper, NFCTH_ATTR_PROTO_L3NUM, AF_INET);
nfct_helper_attr_set_u8(nfct_helper, NFCTH_ATTR_PROTO_L4NUM, IPPROTO_TCP);
+ /* Will be freed by nfct_helper_free. */
p = nfct_helper_policy_alloc();
if (p == NULL) {
perror("OOM");
@@ -49,7 +50,6 @@ int main(int argc, char *argv[])
nfct_helper_nlmsg_build_payload(nlh, nfct_helper);
nfct_helper_free(nfct_helper);
- nfct_helper_policy_free(p);
nl = mnl_socket_open(NETLINK_NETFILTER);
if (nl == NULL) {
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH libnetfilter_cthelper] examples: fix double free in nftc-helper-add
2017-03-19 14:01 [PATCH libnetfilter_cthelper] examples: fix double free in nftc-helper-add Liping Zhang
@ 2017-03-21 10:41 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2017-03-21 10:41 UTC (permalink / raw)
To: Liping Zhang; +Cc: netfilter-devel, Liping Zhang
On Sun, Mar 19, 2017 at 10:01:10PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> After inputting the following test command, core dump happened:
> # ./examples/nfct-helper-add test 1
> *** Error in
> `.../libnetfilter_cthelper/examples/.libs/lt-nfct-helper-add':
> double free or corruption (fasttop): 0x0000000001f3c070 ***
> ======= Backtrace: =========
> /lib64/libc.so.6(+0x77de5)[0x7fd9ebe88de5]
> /lib64/libc.so.6(+0x8022a)[0x7fd9ebe9122a]
> /lib64/libc.so.6(cfree+0x4c)[0x7fd9ebe9478c]
> [...]
>
> Because "struct nfct_helper_policy *p" had been freed by nfct_helper_free,
> so there's no need to invoke nfct_helper_policy_free again, otherwise
> dobule free error will happen.
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-21 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-19 14:01 [PATCH libnetfilter_cthelper] examples: fix double free in nftc-helper-add Liping Zhang
2017-03-21 10:41 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.