From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jason Wang <jasowang@redhat.com> Subject: [PATCH net-next 6/8] tap: support receiving skb from msg_control Date: Tue, 21 Mar 2017 12:04:45 +0800 [thread overview] Message-ID: <1490069087-4783-7-git-send-email-jasowang@redhat.com> (raw) In-Reply-To: <1490069087-4783-1-git-send-email-jasowang@redhat.com> This patch makes tap_recvmsg() can receive from skb from its caller through msg_control. Vhost_net will be the first user. Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/net/tap.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index abdaf86..07d9174 100644 --- a/drivers/net/tap.c +++ b/drivers/net/tap.c @@ -824,15 +824,17 @@ static ssize_t tap_put_user(struct tap_queue *q, static ssize_t tap_do_read(struct tap_queue *q, struct iov_iter *to, - int noblock) + int noblock, struct sk_buff *skb) { DEFINE_WAIT(wait); - struct sk_buff *skb; ssize_t ret = 0; if (!iov_iter_count(to)) return 0; + if (skb) + goto done; + while (1) { if (!noblock) prepare_to_wait(sk_sleep(&q->sk), &wait, @@ -856,6 +858,7 @@ static ssize_t tap_do_read(struct tap_queue *q, if (!noblock) finish_wait(sk_sleep(&q->sk), &wait); +done: if (skb) { ret = tap_put_user(q, skb, to); if (unlikely(ret < 0)) @@ -872,7 +875,7 @@ static ssize_t tap_read_iter(struct kiocb *iocb, struct iov_iter *to) struct tap_queue *q = file->private_data; ssize_t len = iov_iter_count(to), ret; - ret = tap_do_read(q, to, file->f_flags & O_NONBLOCK); + ret = tap_do_read(q, to, file->f_flags & O_NONBLOCK, NULL); ret = min_t(ssize_t, ret, len); if (ret > 0) iocb->ki_pos = ret; @@ -1155,7 +1158,8 @@ static int tap_recvmsg(struct socket *sock, struct msghdr *m, int ret; if (flags & ~(MSG_DONTWAIT|MSG_TRUNC)) return -EINVAL; - ret = tap_do_read(q, &m->msg_iter, flags & MSG_DONTWAIT); + ret = tap_do_read(q, &m->msg_iter, flags & MSG_DONTWAIT, + m->msg_control); if (ret > total_len) { m->msg_flags |= MSG_TRUNC; ret = flags & MSG_TRUNC ? ret : total_len; -- 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: mst@redhat.com, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 6/8] tap: support receiving skb from msg_control Date: Tue, 21 Mar 2017 12:04:45 +0800 [thread overview] Message-ID: <1490069087-4783-7-git-send-email-jasowang@redhat.com> (raw) In-Reply-To: <1490069087-4783-1-git-send-email-jasowang@redhat.com> This patch makes tap_recvmsg() can receive from skb from its caller through msg_control. Vhost_net will be the first user. Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/net/tap.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index abdaf86..07d9174 100644 --- a/drivers/net/tap.c +++ b/drivers/net/tap.c @@ -824,15 +824,17 @@ static ssize_t tap_put_user(struct tap_queue *q, static ssize_t tap_do_read(struct tap_queue *q, struct iov_iter *to, - int noblock) + int noblock, struct sk_buff *skb) { DEFINE_WAIT(wait); - struct sk_buff *skb; ssize_t ret = 0; if (!iov_iter_count(to)) return 0; + if (skb) + goto done; + while (1) { if (!noblock) prepare_to_wait(sk_sleep(&q->sk), &wait, @@ -856,6 +858,7 @@ static ssize_t tap_do_read(struct tap_queue *q, if (!noblock) finish_wait(sk_sleep(&q->sk), &wait); +done: if (skb) { ret = tap_put_user(q, skb, to); if (unlikely(ret < 0)) @@ -872,7 +875,7 @@ static ssize_t tap_read_iter(struct kiocb *iocb, struct iov_iter *to) struct tap_queue *q = file->private_data; ssize_t len = iov_iter_count(to), ret; - ret = tap_do_read(q, to, file->f_flags & O_NONBLOCK); + ret = tap_do_read(q, to, file->f_flags & O_NONBLOCK, NULL); ret = min_t(ssize_t, ret, len); if (ret > 0) iocb->ki_pos = ret; @@ -1155,7 +1158,8 @@ static int tap_recvmsg(struct socket *sock, struct msghdr *m, int ret; if (flags & ~(MSG_DONTWAIT|MSG_TRUNC)) return -EINVAL; - ret = tap_do_read(q, &m->msg_iter, flags & MSG_DONTWAIT); + ret = tap_do_read(q, &m->msg_iter, flags & MSG_DONTWAIT, + m->msg_control); if (ret > total_len) { m->msg_flags |= MSG_TRUNC; ret = flags & MSG_TRUNC ? ret : total_len; -- 2.7.4
next prev parent reply other threads:[~2017-03-21 4:11 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-21 4:04 [PATCH net-next 0/8] vhost-net rx batching Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 1/8] ptr_ring: introduce batch dequeuing Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 10:25 ` Sergei Shtylyov 2017-03-22 3:16 ` Jason Wang 2017-03-22 3:16 ` Jason Wang 2017-03-22 13:43 ` Michael S. Tsirkin 2017-03-22 13:43 ` Michael S. Tsirkin 2017-03-23 5:33 ` Jason Wang 2017-03-23 5:33 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 2/8] skb_array: " Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 3/8] tun: export skb_array Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 4/8] tap: " Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` [PATCH net-next 5/8] tun: support receiving skb through msg_control Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-21 4:04 ` Jason Wang [this message] 2017-03-21 4:04 ` [PATCH net-next 6/8] tap: support receiving skb from msg_control Jason Wang 2017-03-21 4:04 ` [PATCH net-next 7/8] vhost_net: try batch dequing from skb array Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-22 14:16 ` Michael S. Tsirkin 2017-03-22 14:16 ` Michael S. Tsirkin 2017-03-23 5:34 ` Jason Wang 2017-03-23 5:34 ` Jason Wang 2017-03-29 9:58 ` Jason Wang 2017-03-29 9:58 ` Jason Wang 2017-03-29 10:46 ` Pankaj Gupta 2017-03-29 10:46 ` Pankaj Gupta 2017-03-29 10:53 ` Jason Wang 2017-03-29 10:53 ` Jason Wang 2017-03-29 21:47 ` Michael S. Tsirkin 2017-03-29 21:47 ` Michael S. Tsirkin 2017-03-21 4:04 ` [PATCH net-next 8/8] vhost_net: use lockless peeking for skb array during busy polling Jason Wang 2017-03-21 4:04 ` Jason Wang 2017-03-29 12:07 ` Michael S. Tsirkin 2017-03-29 12:07 ` Michael S. Tsirkin 2017-03-30 2:16 ` Jason Wang 2017-03-30 2:33 ` Michael S. Tsirkin 2017-03-30 2:33 ` Michael S. Tsirkin 2017-03-30 3:53 ` Jason Wang 2017-03-30 3:53 ` Jason Wang 2017-03-30 2:16 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1490069087-4783-7-git-send-email-jasowang@redhat.com \ --to=jasowang@redhat.com \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.