* [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown
@ 2017-03-24 13:19 Christian Borntraeger
2017-03-24 14:14 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Christian Borntraeger @ 2017-03-24 13:19 UTC (permalink / raw)
To: Peter Maydell
Cc: qemu-devel, Paolo Bonzini, Alexander Graf, Richard Henderson,
Cornelia Huck, Alex Bennée, Christian Borntraeger
a qemu with an empty s390 guest will exit very quickly. This races
against the testsuite reading from the console pipe leading to
intermittent test suite failures. Using -no-shutdown will keep
the guest running.
Fixes: 864111f422ba (vl: exit qemu on guest panic if -no-shutdown is not set)
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
tests/boot-serial-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
index 57edf6a..11f48b0 100644
--- a/tests/boot-serial-test.c
+++ b/tests/boot-serial-test.c
@@ -79,8 +79,8 @@ static void test_machine(const void *data)
g_assert(fd != -1);
args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
- " -serial chardev:serial0 %s", test->machine,
- tmpname, test->extra);
+ " -no-shutdown -serial chardev:serial0 %s",
+ test->machine, tmpname, test->extra);
qtest_start(args);
unlink(tmpname);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown
2017-03-24 13:19 [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown Christian Borntraeger
@ 2017-03-24 14:14 ` Peter Maydell
2017-03-24 15:53 ` Alex Bennée
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2017-03-24 14:14 UTC (permalink / raw)
To: Christian Borntraeger
Cc: qemu-devel, Paolo Bonzini, Alexander Graf, Richard Henderson,
Cornelia Huck, Alex Bennée
On 24 March 2017 at 13:19, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> a qemu with an empty s390 guest will exit very quickly. This races
> against the testsuite reading from the console pipe leading to
> intermittent test suite failures. Using -no-shutdown will keep
> the guest running.
>
> Fixes: 864111f422ba (vl: exit qemu on guest panic if -no-shutdown is not set)
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> tests/boot-serial-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
> index 57edf6a..11f48b0 100644
> --- a/tests/boot-serial-test.c
> +++ b/tests/boot-serial-test.c
> @@ -79,8 +79,8 @@ static void test_machine(const void *data)
> g_assert(fd != -1);
>
> args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
> - " -serial chardev:serial0 %s", test->machine,
> - tmpname, test->extra);
> + " -no-shutdown -serial chardev:serial0 %s",
> + test->machine, tmpname, test->extra);
>
> qtest_start(args);
> unlink(tmpname);
Applied to master, thanks. Let's see if this fixes the travis flapping...
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown
2017-03-24 14:14 ` Peter Maydell
@ 2017-03-24 15:53 ` Alex Bennée
0 siblings, 0 replies; 3+ messages in thread
From: Alex Bennée @ 2017-03-24 15:53 UTC (permalink / raw)
To: Peter Maydell
Cc: Christian Borntraeger, qemu-devel, Paolo Bonzini, Alexander Graf,
Richard Henderson, Cornelia Huck
Peter Maydell <peter.maydell@linaro.org> writes:
> On 24 March 2017 at 13:19, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>> a qemu with an empty s390 guest will exit very quickly. This races
>> against the testsuite reading from the console pipe leading to
>> intermittent test suite failures. Using -no-shutdown will keep
>> the guest running.
>>
>> Fixes: 864111f422ba (vl: exit qemu on guest panic if -no-shutdown is not set)
>> Reported-by: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> ---
>> tests/boot-serial-test.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
>> index 57edf6a..11f48b0 100644
>> --- a/tests/boot-serial-test.c
>> +++ b/tests/boot-serial-test.c
>> @@ -79,8 +79,8 @@ static void test_machine(const void *data)
>> g_assert(fd != -1);
>>
>> args = g_strdup_printf("-M %s,accel=tcg -chardev file,id=serial0,path=%s"
>> - " -serial chardev:serial0 %s", test->machine,
>> - tmpname, test->extra);
>> + " -no-shutdown -serial chardev:serial0 %s",
>> + test->machine, tmpname, test->extra);
>>
>> qtest_start(args);
>> unlink(tmpname);
>
> Applied to master, thanks. Let's see if this fixes the travis flapping...
A bit late as it is merged but I did test it on the reproduction case
and ran 50 check-qtest-s390x while loading the system with a kernel
compile. It previously failed after about 20 iterations. So:
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-24 15:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-24 13:19 [Qemu-devel] [PATCH] boot-serial-test: use -no-shutdown Christian Borntraeger
2017-03-24 14:14 ` Peter Maydell
2017-03-24 15:53 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.