All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbates@raithlin.com
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
	Damien.LeMoal@wdc.com, osandov@osandov.com, sbates@raithlin.com
Subject: [PATCH 0/2] blk-stat: Add ability to not bucket IO, add this to IO poling.
Date: Sat, 25 Mar 2017 20:18:10 -0600	[thread overview]
Message-ID: <1490494692-2416-1-git-send-email-sbates@raithlin.com> (raw)

From: Stephen Bates <sbates@raithlin.com>

Omar recently developed some patches for block layer stats that use
callbacks to determine which bucket an IO should be considered for. At
the same time there was discussion at LSF/MM that we might not want to
consider all IO when generating stats for certain algorithms (e.g. IO
completion polling).

This set does two things. It makes the bucket callback for stats
signed so we can now ignore IO that cause a negative to be returned
from the bucket function. It then uses this new functionality to
filter IO for the IO completion polling algorithms.

This patchset applies cleanly on a83b576c9c25cf (block: fix stacked
driver stats init and free) in Jens' for-next tree.

I've lightly tested this using QEMU and a real NVMe low-latency
device. I do not have performance number yet. Feedback would be
appreciated!

[BTW this is my first submission for an all new setup so apologies if
this does not come through correctly!]

Cc: Damien.LeMoal@wdc.com
Cc: osandov@osandov.com

Stephen Bates (2):
  blk-stat: convert blk-stat bucket callback to signed
  blk-stat: add a poll_size value to the request_queue struct

 block/blk-mq.c         | 17 +++++++++++++++--
 block/blk-stat.c       |  8 +++++---
 block/blk-stat.h       |  9 +++++----
 block/blk-sysfs.c      | 30 ++++++++++++++++++++++++++++++
 include/linux/blkdev.h |  1 +
 5 files changed, 56 insertions(+), 9 deletions(-)

-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: sbates@raithlin.com (sbates@raithlin.com)
Subject: [PATCH 0/2] blk-stat: Add ability to not bucket IO, add this to IO poling.
Date: Sat, 25 Mar 2017 20:18:10 -0600	[thread overview]
Message-ID: <1490494692-2416-1-git-send-email-sbates@raithlin.com> (raw)

From: Stephen Bates <sbates@raithlin.com>

Omar recently developed some patches for block layer stats that use
callbacks to determine which bucket an IO should be considered for. At
the same time there was discussion at LSF/MM that we might not want to
consider all IO when generating stats for certain algorithms (e.g. IO
completion polling).

This set does two things. It makes the bucket callback for stats
signed so we can now ignore IO that cause a negative to be returned
from the bucket function. It then uses this new functionality to
filter IO for the IO completion polling algorithms.

This patchset applies cleanly on a83b576c9c25cf (block: fix stacked
driver stats init and free) in Jens' for-next tree.

I've lightly tested this using QEMU and a real NVMe low-latency
device. I do not have performance number yet. Feedback would be
appreciated!

[BTW this is my first submission for an all new setup so apologies if
this does not come through correctly!]

Cc: Damien.LeMoal at wdc.com
Cc: osandov at osandov.com

Stephen Bates (2):
  blk-stat: convert blk-stat bucket callback to signed
  blk-stat: add a poll_size value to the request_queue struct

 block/blk-mq.c         | 17 +++++++++++++++--
 block/blk-stat.c       |  8 +++++---
 block/blk-stat.h       |  9 +++++----
 block/blk-sysfs.c      | 30 ++++++++++++++++++++++++++++++
 include/linux/blkdev.h |  1 +
 5 files changed, 56 insertions(+), 9 deletions(-)

-- 
2.7.4

             reply	other threads:[~2017-03-26  2:18 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-26  2:18 sbates [this message]
2017-03-26  2:18 ` [PATCH 0/2] blk-stat: Add ability to not bucket IO, add this to IO poling sbates
2017-03-26  2:18 ` [PATCH 1/2] blk-stat: convert blk-stat bucket callback to signed sbates
2017-03-26  2:18   ` sbates
2017-03-26  2:49   ` Omar Sandoval
2017-03-26  2:49     ` Omar Sandoval
2017-03-27 16:00     ` Stephen  Bates
2017-03-27 16:00       ` Stephen  Bates
2017-03-27 16:01       ` Omar Sandoval
2017-03-27 16:01         ` Omar Sandoval
2017-03-26  2:18 ` [PATCH 2/2] blk-stat: add a poll_size value to the request_queue struct sbates
2017-03-26  2:18   ` sbates
2017-03-28 10:50   ` Sagi Grimberg
2017-03-28 10:50     ` Sagi Grimberg
2017-03-28 19:38     ` Stephen  Bates
2017-03-28 19:38       ` Stephen  Bates
2017-03-28 19:46       ` Jens Axboe
2017-03-28 19:46         ` Jens Axboe
2017-03-28 19:58         ` Stephen  Bates
2017-03-28 19:58           ` Stephen  Bates
2017-03-28 20:38           ` Jens Axboe
2017-03-28 20:38             ` Jens Axboe
2017-03-28 21:49             ` Stephen  Bates
2017-03-28 21:52             ` Stephen  Bates
2017-03-28 21:52               ` Stephen  Bates

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490494692-2416-1-git-send-email-sbates@raithlin.com \
    --to=sbates@raithlin.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.