All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "mmc: ushc: fix NULL-deref at probe" has been added to the 4.4-stable tree
@ 2017-03-27 16:38 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2017-03-27 16:38 UTC (permalink / raw)
  To: johan, david.vrabel, gregkh, ulf.hansson; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    mmc: ushc: fix NULL-deref at probe

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mmc-ushc-fix-null-deref-at-probe.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 181302dc7239add8ab1449c23ecab193f52ee6ab Mon Sep 17 00:00:00 2001
From: Johan Hovold <johan@kernel.org>
Date: Mon, 13 Mar 2017 13:40:22 +0100
Subject: mmc: ushc: fix NULL-deref at probe

From: Johan Hovold <johan@kernel.org>

commit 181302dc7239add8ab1449c23ecab193f52ee6ab upstream.

Make sure to check the number of endpoints to avoid dereferencing a
NULL-pointer should a malicious device lack endpoints.

Fixes: 53f3a9e26ed5 ("mmc: USB SD Host Controller (USHC) driver")
Cc: David Vrabel <david.vrabel@csr.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/mmc/host/ushc.c |    3 +++
 1 file changed, 3 insertions(+)

--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -426,6 +426,9 @@ static int ushc_probe(struct usb_interfa
 	struct ushc_data *ushc;
 	int ret;
 
+	if (intf->cur_altsetting->desc.bNumEndpoints < 1)
+		return -ENODEV;
+
 	mmc = mmc_alloc_host(sizeof(struct ushc_data), &intf->dev);
 	if (mmc == NULL)
 		return -ENOMEM;


Patches currently in stable-queue which might be from johan@kernel.org are

queue-4.4/usb-serial-option-add-quectel-uc15-uc20-ec21-and-ec25-modems.patch
queue-4.4/input-ims-pcu-validate-number-of-endpoints-before-using-them.patch
queue-4.4/input-cm109-validate-number-of-endpoints-before-using-them.patch
queue-4.4/input-iforce-validate-number-of-endpoints-before-using-them.patch
queue-4.4/mmc-ushc-fix-null-deref-at-probe.patch
queue-4.4/input-kbtab-validate-number-of-endpoints-before-using-them.patch
queue-4.4/input-sur40-validate-number-of-endpoints-before-using-them.patch
queue-4.4/uwb-i1480-dfu-fix-null-deref-at-probe.patch
queue-4.4/input-hanwang-validate-number-of-endpoints-before-using-them.patch
queue-4.4/usb-idmouse-fix-null-deref-at-probe.patch
queue-4.4/uwb-hwa-rc-fix-null-deref-at-probe.patch
queue-4.4/usb-lvtest-fix-null-deref-at-probe.patch
queue-4.4/input-yealink-validate-number-of-endpoints-before-using-them.patch
queue-4.4/usb-serial-qcserial-add-dell-dw5811e.patch
queue-4.4/usb-uss720-fix-null-deref-at-probe.patch
queue-4.4/usb-wusbcore-fix-null-deref-at-probe.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-27 16:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-27 16:38 Patch "mmc: ushc: fix NULL-deref at probe" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.