From: Sean Wang <sean.wang@mediatek.com> To: Andrew Lunn <andrew@lunn.ch> Cc: <f.fainelli@gmail.com>, <vivien.didelot@savoirfairelinux.com>, <matthias.bgg@gmail.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>, <devicetree@vger.kernel.org>, <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-mediatek@lists.infradead.org>, <davem@davemloft.net>, <Landen.Chao@mediatek.com>, <keyhaede@gmail.com>, <objelf@gmail.com> Subject: Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Date: Tue, 28 Mar 2017 14:05:13 +0800 [thread overview] Message-ID: <1490681113.14184.39.camel@mtkswgap22> (raw) In-Reply-To: <20170324140215.GG28518@lunn.ch> Hi Andrew, Add comment as below inline On Fri, 2017-03-24 at 15:02 +0100, Andrew Lunn wrote: > Hi Sean > > > + regmap = devm_regmap_init(ds->dev, NULL, priv, > > + &mt7530_regmap_config); > > + if (IS_ERR(regmap)) > > + dev_warn(priv->dev, "phy regmap initialization failed"); > > + > > Shouldn't this be a fatal error? If you keep going when there is an > error, what happens when you actually try to use the regmap? > Initial thought is that it is just for debugging purpose so if it fails, it should break any functionality of switch and only have implication as a warning message. Anyway, i will remove it in the next one since it seems better being kept in private place as you suggested in the previous mail. > > + phy_mode = of_get_phy_mode(ds->ports[ds->dst->cpu_port].dn); > > + if (phy_mode < 0) { > > + dev_err(priv->dev, "Can't find phy-mode for master device\n"); > > + return phy_mode; > > + } > > + dev_info(priv->dev, "phy-mode for master device = %x\n", phy_mode); > > dev_dbg? > Sorry. i forgot turned it into dev_dbg > > + > > + id = mt7530_read(priv, MT7530_CREV); > > + id >>= CHIP_NAME_SHIFT; > > + if (id != MT7530_ID) > > + return -ENODEV; > > It might be helpful to say what ID has been found, if it is not the > supported ID. I will fix it up to make users know what was going on thanks for taking your time on those reviewing again! > Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Sean Wang <sean.wang@mediatek.com> To: Andrew Lunn <andrew@lunn.ch> Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, davem@davemloft.net, Landen.Chao@mediatek.com, keyhaede@gmail.com, objelf@gmail.com Subject: Re: [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch Date: Tue, 28 Mar 2017 14:05:13 +0800 [thread overview] Message-ID: <1490681113.14184.39.camel@mtkswgap22> (raw) In-Reply-To: <20170324140215.GG28518@lunn.ch> Hi Andrew, Add comment as below inline On Fri, 2017-03-24 at 15:02 +0100, Andrew Lunn wrote: > Hi Sean > > > + regmap = devm_regmap_init(ds->dev, NULL, priv, > > + &mt7530_regmap_config); > > + if (IS_ERR(regmap)) > > + dev_warn(priv->dev, "phy regmap initialization failed"); > > + > > Shouldn't this be a fatal error? If you keep going when there is an > error, what happens when you actually try to use the regmap? > Initial thought is that it is just for debugging purpose so if it fails, it should break any functionality of switch and only have implication as a warning message. Anyway, i will remove it in the next one since it seems better being kept in private place as you suggested in the previous mail. > > + phy_mode = of_get_phy_mode(ds->ports[ds->dst->cpu_port].dn); > > + if (phy_mode < 0) { > > + dev_err(priv->dev, "Can't find phy-mode for master device\n"); > > + return phy_mode; > > + } > > + dev_info(priv->dev, "phy-mode for master device = %x\n", phy_mode); > > dev_dbg? > Sorry. i forgot turned it into dev_dbg > > + > > + id = mt7530_read(priv, MT7530_CREV); > > + id >>= CHIP_NAME_SHIFT; > > + if (id != MT7530_ID) > > + return -ENODEV; > > It might be helpful to say what ID has been found, if it is not the > supported ID. I will fix it up to make users know what was going on thanks for taking your time on those reviewing again! > Andrew
next prev parent reply other threads:[~2017-03-28 6:05 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-21 9:35 [PATCH net-next v2 0/5] net-next: dsa: add Mediatek MT7530 support sean.wang 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` [PATCH net-next v2 1/5] dt-bindings: net: dsa: add Mediatek MT7530 binding sean.wang 2017-03-21 9:35 ` sean.wang 2017-03-24 16:16 ` Rob Herring 2017-03-24 16:16 ` Rob Herring 2017-03-21 9:35 ` [PATCH net-next v2 2/5] net-next: dsa: add Mediatek tag RX/TX handler sean.wang 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` [PATCH net-next v2 3/5] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA sean.wang 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-22 17:43 ` Andrew Lunn 2017-03-22 17:43 ` Andrew Lunn 2017-03-22 18:23 ` Florian Fainelli 2017-03-22 18:23 ` Florian Fainelli 2017-03-21 9:35 ` [PATCH net-next v2 4/5] net-next: ethernet: mediatek: add device_node of GMAC pointing into the netdev instance sean.wang 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-22 18:18 ` Andrew Lunn 2017-03-22 18:18 ` Andrew Lunn 2017-03-22 18:23 ` Florian Fainelli 2017-03-21 9:35 ` [PATCH net-next v2 5/5] net-next: dsa: add dsa support for Mediatek MT7530 switch sean.wang 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-21 9:35 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-22 18:30 ` Andrew Lunn 2017-03-22 18:30 ` Andrew Lunn 2017-03-22 18:39 ` Florian Fainelli 2017-03-22 18:39 ` Florian Fainelli 2017-03-28 5:51 ` Sean Wang 2017-03-28 5:51 ` Sean Wang 2017-03-23 7:22 ` Andrew Lunn 2017-03-23 7:22 ` Andrew Lunn 2017-03-23 8:06 ` Sean Wang 2017-03-23 8:06 ` Sean Wang 2017-03-23 14:09 ` Felix Fietkau 2017-03-23 14:09 ` Felix Fietkau 2017-03-23 14:25 ` John Crispin 2017-03-23 14:25 ` John Crispin 2017-03-23 14:30 ` Felix Fietkau 2017-03-24 7:53 ` Andrew Lunn 2017-03-24 7:53 ` Andrew Lunn 2017-03-24 14:02 ` Andrew Lunn 2017-03-28 6:05 ` Sean Wang [this message] 2017-03-28 6:05 ` Sean Wang 2017-03-24 14:19 ` Andrew Lunn 2017-03-24 14:19 ` Andrew Lunn 2017-03-28 6:50 ` Sean Wang 2017-03-28 6:50 ` Sean Wang 2017-03-28 6:50 ` Sean Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1490681113.14184.39.camel@mtkswgap22 \ --to=sean.wang@mediatek.com \ --cc=Landen.Chao@mediatek.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=keyhaede@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=objelf@gmail.com \ --cc=robh+dt@kernel.org \ --cc=vivien.didelot@savoirfairelinux.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.