[Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc

From: Tejaswini <tejaswinipoluri3@gmail.com>
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, kwolf@redhat.com, pbonzini@redhat.com,
	rth@twiddle.net, ehabkost@redhat.com,
	Tejaswini Poluri <tejaswinipoluri3@gmail.com>
Subject: [Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc
Date: Tue, 28 Mar 2017 12:49:43 +0530	[thread overview]
Message-ID: <1490685583-16987-1-git-send-email-tejaswinipoluri3@gmail.com> (raw)

From: Tejaswini Poluri <tejaswinipoluri3@gmail.com>

Start QEMU with
"qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio"
and enter "info lapic" at the monitor prompt ⇒
Segmentation fault

Signed-off-by: Tejaswini Poluri <tejaswinipoluri3@gmail.com>
---
 target/i386/helper.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/target/i386/helper.c b/target/i386/helper.c
index e2af340..f11cac6 100644
--- a/target/i386/helper.c
+++ b/target/i386/helper.c
@@ -326,6 +326,10 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, FILE *f,
 {
     X86CPU *cpu = X86_CPU(cs);
     APICCommonState *s = APIC_COMMON(cpu->apic_state);
+    if (!s) {
+        cpu_fprintf(f, "local apic state not available\n");
+        return;
+    }
     uint32_t *lvt = s->lvt;
 
     cpu_fprintf(f, "dumping local APIC state for CPU %-2u\n\n",
-- 
2.7.4
