Re: [Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc

From: Paolo Bonzini <pbonzini@redhat.com>
To: Tejaswini <tejaswinipoluri3@gmail.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com, kwolf@redhat.com, rth@twiddle.net,
	ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH] target-i386: fix "info lapic" segfault on isapc
Date: Tue, 28 Mar 2017 10:05:23 +0200	[thread overview]
Message-ID: <627c8376-285e-f457-9506-9ab7d2f11ae4@redhat.com> (raw)
In-Reply-To: <1490685583-16987-1-git-send-email-tejaswinipoluri3@gmail.com>

On 28/03/2017 09:19, Tejaswini wrote:
> From: Tejaswini Poluri <tejaswinipoluri3@gmail.com>
> 
> Start QEMU with
> "qemu-system-x86_64 -nographic -M isapc -serial none-monitor stdio"
> and enter "info lapic" at the monitor prompt ⇒
> Segmentation fault
> 
> Signed-off-by: Tejaswini Poluri <tejaswinipoluri3@gmail.com>
> ---
>  target/i386/helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target/i386/helper.c b/target/i386/helper.c
> index e2af340..f11cac6 100644
> --- a/target/i386/helper.c
> +++ b/target/i386/helper.c
> @@ -326,6 +326,10 @@ void x86_cpu_dump_local_apic_state(CPUState *cs, FILE *f,
>  {
>      X86CPU *cpu = X86_CPU(cs);
>      APICCommonState *s = APIC_COMMON(cpu->apic_state);
> +    if (!s) {
> +        cpu_fprintf(f, "local apic state not available\n");
> +        return;
> +    }
>      uint32_t *lvt = s->lvt;
>  
>      cpu_fprintf(f, "dumping local APIC state for CPU %-2u\n\n",
> 

Queued, thanks.

Paolo