All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change.
Date: Wed, 29 Mar 2017 10:42:02 +0200	[thread overview]
Message-ID: <1490776922.7948.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1490311578-18926-1-git-send-email-greearb@candelatech.com>


> +	if (data->center_freq2)
> +		if (nla_put_u32(skb, HWSIM_ATTR_CENTER_FREQ2, data-
> >center_freq2))
> +			goto nla_put_failure;
> 

That could be simplified (but isn't really interesting)

> + * @HWSIM_ATTR_CENTER_FREQ2: Configured center-freq-2.  Not reported
> if value is zero.

The value 0 really just means "unused" - so this should say "if used"
or so.

> + * @HWSIM_ATTR_CH_WIDTH: Configured channel width.

That should point to &enum nl80211_chan_width I guess.

Anyway, all of that is minor. The biggest problem I have with this
patch upon close review is that it only handles one case, and actually
ties that case to the nl80211 API.

hwsim also can deal with channel contexts already, is there much point
in making the userspace API ignorant of that?

johannes

  parent reply	other threads:[~2017-03-29  8:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 23:26 [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change greearb
2017-03-23 23:26 ` [PATCH v3 2/4] mac80211-hwsim: remove dmesg spam about get-survey greearb
2017-03-29  8:46   ` Johannes Berg
2017-03-23 23:26 ` [PATCH v3 3/4] mac80211-hwsim: add rate-limited debugging for rx-netlink greearb
2017-03-29  8:46   ` Johannes Berg
2017-03-29 15:39     ` Ben Greear
2017-03-29 16:52       ` Johannes Berg
2017-03-23 23:26 ` [PATCH v3 4/4] mac80211-hwsim: add length checks before allocating skb greearb
2017-03-29  8:47   ` Johannes Berg
2017-03-29  8:42 ` Johannes Berg [this message]
2017-03-29 15:35   ` [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change Ben Greear
2017-03-29 16:51     ` Johannes Berg
2017-03-29 17:11       ` Ben Greear
2017-03-31 11:48         ` Johannes Berg
2017-03-31 13:33           ` Ben Greear
2017-04-18  9:58             ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1490776922.7948.9.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.