All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change.
Date: Tue, 18 Apr 2017 11:58:53 +0200	[thread overview]
Message-ID: <1492509533.2472.17.camel@sipsolutions.net> (raw)
In-Reply-To: <16c10539-3ab3-f5ec-38ab-0fc7abca1a94@candelatech.com>

On Fri, 2017-03-31 at 06:33 -0700, Ben Greear wrote:
> 
> In my experience, the big problem with netlink is that if you write
> a patch that cannot make it upstream (or takes forever), then the
> netlink IDs conflict as upstream adds more stuff.

Sure, that's a common problem we all run into :)

> Other than that, it is easy to add new members, or completely new
> commands.
> 
> User-space can drop old API and simply not fully work against older
> kernels if it wants, especially for something as specialized as a
> simulated wifi radio.

Yeah, but the kernel will have to maintain both versions, and strictly
speaking shouldn't be breaking old userspace - but that would be
impossible as one moves to chanctx, perhaps even by default.

This is the problem I have with it - chanctx code already exists and is
used, so there's no technical reason not to support both now.

> So, if my patch can go in as is or with small tweaks, then I'm happy
> to keep working on it.  If it needs a complete re-write, then it will
> have to wait for someone else or some later date.

Ok, that's fair. I think I'll leave it out then though, because I
really do think that we should aim to support chanctx from the start
with this, it's well-established by now.

johannes

      reply	other threads:[~2017-04-18  9:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-23 23:26 [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change greearb
2017-03-23 23:26 ` [PATCH v3 2/4] mac80211-hwsim: remove dmesg spam about get-survey greearb
2017-03-29  8:46   ` Johannes Berg
2017-03-23 23:26 ` [PATCH v3 3/4] mac80211-hwsim: add rate-limited debugging for rx-netlink greearb
2017-03-29  8:46   ` Johannes Berg
2017-03-29 15:39     ` Ben Greear
2017-03-29 16:52       ` Johannes Berg
2017-03-23 23:26 ` [PATCH v3 4/4] mac80211-hwsim: add length checks before allocating skb greearb
2017-03-29  8:47   ` Johannes Berg
2017-03-29  8:42 ` [PATCH v3 1/4] mac80211-hwsim: notify user-space about channel change Johannes Berg
2017-03-29 15:35   ` Ben Greear
2017-03-29 16:51     ` Johannes Berg
2017-03-29 17:11       ` Ben Greear
2017-03-31 11:48         ` Johannes Berg
2017-03-31 13:33           ` Ben Greear
2017-04-18  9:58             ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492509533.2472.17.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.