All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beilei Xing <beilei.xing@intel.com>
To: jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: [PATCH v2 1/2] app/testpmd: change command line of loading profile
Date: Sat,  1 Apr 2017 15:57:07 +0800	[thread overview]
Message-ID: <1491033428-68635-2-git-send-email-beilei.xing@intel.com> (raw)
In-Reply-To: <1491033428-68635-1-git-send-email-beilei.xing@intel.com>

This patch changes CLI of loading profile from
"add ddp (port_id) (profile_path)" to "ddp add
(port_id) (profile_path)" which is more consistent
with other CLIs.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/cmdline.c | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index aac4efb..3a448b3 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -593,7 +593,7 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"E-tag set filter del e-tag-id (value) port (port_id)\n"
 			"    Delete an E-tag forwarding filter on a port\n\n"
 
-			"add ddp (port_id) (profile_path)\n"
+			"ddp add (port_id) (profile_path)\n"
 			"    Load a profile package on a port\n\n"
 
 			, list_pkt_forwarding_modes()
@@ -12746,29 +12746,29 @@ cmdline_parse_inst_t cmd_strict_link_prio = {
 };
 
 /* Load dynamic device personalization*/
-struct cmd_add_ddp_result {
-	cmdline_fixed_string_t add;
+struct cmd_ddp_add_result {
 	cmdline_fixed_string_t ddp;
+	cmdline_fixed_string_t add;
 	uint8_t port_id;
 	char filepath[];
 };
 
-cmdline_parse_token_string_t cmd_add_ddp_add =
-	TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, add, "add");
-cmdline_parse_token_string_t cmd_add_ddp_ddp =
-	TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, ddp, "ddp");
-cmdline_parse_token_num_t cmd_add_ddp_port_id =
-	TOKEN_NUM_INITIALIZER(struct cmd_add_ddp_result, port_id, UINT8);
-cmdline_parse_token_string_t cmd_add_ddp_filepath =
-	TOKEN_STRING_INITIALIZER(struct cmd_add_ddp_result, filepath, NULL);
+cmdline_parse_token_string_t cmd_ddp_add_ddp =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, ddp, "ddp");
+cmdline_parse_token_string_t cmd_ddp_add_add =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, add, "add");
+cmdline_parse_token_num_t cmd_ddp_add_port_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_ddp_add_result, port_id, UINT8);
+cmdline_parse_token_string_t cmd_ddp_add_filepath =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_add_result, filepath, NULL);
 
 static void
-cmd_add_ddp_parsed(
+cmd_ddp_add_parsed(
 	void *parsed_result,
 	__attribute__((unused)) struct cmdline *cl,
 	__attribute__((unused)) void *data)
 {
-	struct cmd_add_ddp_result *res = parsed_result;
+	struct cmd_ddp_add_result *res = parsed_result;
 	uint8_t *buff;
 	uint32_t size;
 	int ret = -ENOTSUP;
@@ -12802,15 +12802,15 @@ cmd_add_ddp_parsed(
 	close_ddp_package_file(buff);
 }
 
-cmdline_parse_inst_t cmd_add_ddp = {
-	.f = cmd_add_ddp_parsed,
+cmdline_parse_inst_t cmd_ddp_add = {
+	.f = cmd_ddp_add_parsed,
 	.data = NULL,
-	.help_str = "add/remove ddp <port_id> <profile_path>",
+	.help_str = "ddp add <port_id> <profile_path>",
 	.tokens = {
-		(void *)&cmd_add_ddp_add,
-		(void *)&cmd_add_ddp_ddp,
-		(void *)&cmd_add_ddp_port_id,
-		(void *)&cmd_add_ddp_filepath,
+		(void *)&cmd_ddp_add_ddp,
+		(void *)&cmd_ddp_add_add,
+		(void *)&cmd_ddp_add_port_id,
+		(void *)&cmd_ddp_add_filepath,
 		NULL,
 	},
 };
@@ -13081,7 +13081,7 @@ cmdline_parse_ctx_t main_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_vf_tc_min_bw,
 	(cmdline_parse_inst_t *)&cmd_vf_tc_max_bw,
 	(cmdline_parse_inst_t *)&cmd_strict_link_prio,
-	(cmdline_parse_inst_t *)&cmd_add_ddp,
+	(cmdline_parse_inst_t *)&cmd_ddp_add,
 	(cmdline_parse_inst_t *)&cmd_get_ddp_list,
 	NULL,
 };
-- 
2.5.5

  reply	other threads:[~2017-04-01  7:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  6:56 [PATCH 0/2] change command line for ddp Beilei Xing
2017-04-01  6:56 ` [PATCH 1/2] app/testpmd: change command line of loading profile Beilei Xing
2017-04-01  6:56 ` [PATCH 2/2] app/testpmd: change command line of getting profile info Beilei Xing
2017-04-01  7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing
2017-04-01  7:57   ` Beilei Xing [this message]
2017-04-01  8:23     ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Lu, Wenzhuo
2017-04-03 12:30     ` Ferruh Yigit
2017-04-01  7:57   ` [PATCH v2 2/2] app/testpmd: change command line of getting profile info Beilei Xing
2017-04-01  8:23     ` Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491033428-68635-2-git-send-email-beilei.xing@intel.com \
    --to=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.