All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beilei Xing <beilei.xing@intel.com>
To: jingjing.wu@intel.com
Cc: dev@dpdk.org
Subject: [PATCH v2 2/2] app/testpmd: change command line of getting profile info
Date: Sat,  1 Apr 2017 15:57:08 +0800	[thread overview]
Message-ID: <1491033428-68635-3-git-send-email-beilei.xing@intel.com> (raw)
In-Reply-To: <1491033428-68635-1-git-send-email-beilei.xing@intel.com>

This patch changes CLI of getting loaded profile
info list from "get ddp list (port_id)" to "ddp
get list (port_id)" which is more consistent with
other CLIs.

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
 app/test-pmd/cmdline.c | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 3a448b3..66cd09a 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -215,7 +215,7 @@ static void cmd_help_long_parsed(void *parsed_result,
 			"read txd (port_id) (queue_id) (txd_id)\n"
 			"    Display a TX descriptor of a port TX queue.\n\n"
 
-			"get ddp list (port_id)\n"
+			"ddp get list (port_id)\n"
 			"    Get ddp profile info list\n\n"
 		);
 	}
@@ -12819,29 +12819,29 @@ cmdline_parse_inst_t cmd_ddp_add = {
 #define PROFILE_INFO_SIZE 48
 #define MAX_PROFILE_NUM 16
 
-struct cmd_get_ddp_list_result {
-	cmdline_fixed_string_t get;
+struct cmd_ddp_get_list_result {
 	cmdline_fixed_string_t ddp;
+	cmdline_fixed_string_t get;
 	cmdline_fixed_string_t list;
 	uint8_t port_id;
 };
 
-cmdline_parse_token_string_t cmd_get_ddp_list_get =
-	TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, get, "get");
-cmdline_parse_token_string_t cmd_get_ddp_list_ddp =
-	TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, ddp, "ddp");
-cmdline_parse_token_string_t cmd_get_ddp_list_list =
-	TOKEN_STRING_INITIALIZER(struct cmd_get_ddp_list_result, list, "list");
-cmdline_parse_token_num_t cmd_get_ddp_list_port_id =
-	TOKEN_NUM_INITIALIZER(struct cmd_get_ddp_list_result, port_id, UINT8);
+cmdline_parse_token_string_t cmd_ddp_get_list_ddp =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, ddp, "ddp");
+cmdline_parse_token_string_t cmd_ddp_get_list_get =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, get, "get");
+cmdline_parse_token_string_t cmd_ddp_get_list_list =
+	TOKEN_STRING_INITIALIZER(struct cmd_ddp_get_list_result, list, "list");
+cmdline_parse_token_num_t cmd_ddp_get_list_port_id =
+	TOKEN_NUM_INITIALIZER(struct cmd_ddp_get_list_result, port_id, UINT8);
 
 static void
-cmd_get_ddp_list_parsed(
+cmd_ddp_get_list_parsed(
 	void *parsed_result,
 	__attribute__((unused)) struct cmdline *cl,
 	__attribute__((unused)) void *data)
 {
-	struct cmd_get_ddp_list_result *res = parsed_result;
+	struct cmd_ddp_get_list_result *res = parsed_result;
 #ifdef RTE_LIBRTE_I40E_PMD
 	struct rte_pmd_i40e_profile_list *p_list;
 	struct rte_pmd_i40e_profile_info *p_info;
@@ -12890,15 +12890,15 @@ cmd_get_ddp_list_parsed(
 		printf("Failed to get ddp list\n");
 }
 
-cmdline_parse_inst_t cmd_get_ddp_list = {
-	.f = cmd_get_ddp_list_parsed,
+cmdline_parse_inst_t cmd_ddp_get_list = {
+	.f = cmd_ddp_get_list_parsed,
 	.data = NULL,
-	.help_str = "get ddp list <port_id>",
+	.help_str = "ddp get list <port_id>",
 	.tokens = {
-		(void *)&cmd_get_ddp_list_get,
-		(void *)&cmd_get_ddp_list_ddp,
-		(void *)&cmd_get_ddp_list_list,
-		(void *)&cmd_get_ddp_list_port_id,
+		(void *)&cmd_ddp_get_list_ddp,
+		(void *)&cmd_ddp_get_list_get,
+		(void *)&cmd_ddp_get_list_list,
+		(void *)&cmd_ddp_get_list_port_id,
 		NULL,
 	},
 };
@@ -13082,7 +13082,7 @@ cmdline_parse_ctx_t main_ctx[] = {
 	(cmdline_parse_inst_t *)&cmd_vf_tc_max_bw,
 	(cmdline_parse_inst_t *)&cmd_strict_link_prio,
 	(cmdline_parse_inst_t *)&cmd_ddp_add,
-	(cmdline_parse_inst_t *)&cmd_get_ddp_list,
+	(cmdline_parse_inst_t *)&cmd_ddp_get_list,
 	NULL,
 };
 
-- 
2.5.5

  parent reply	other threads:[~2017-04-01  7:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  6:56 [PATCH 0/2] change command line for ddp Beilei Xing
2017-04-01  6:56 ` [PATCH 1/2] app/testpmd: change command line of loading profile Beilei Xing
2017-04-01  6:56 ` [PATCH 2/2] app/testpmd: change command line of getting profile info Beilei Xing
2017-04-01  7:57 ` [PATCH v2 0/2] change command line for ddp Beilei Xing
2017-04-01  7:57   ` [PATCH v2 1/2] app/testpmd: change command line of loading profile Beilei Xing
2017-04-01  8:23     ` Lu, Wenzhuo
2017-04-03 12:30     ` Ferruh Yigit
2017-04-01  7:57   ` Beilei Xing [this message]
2017-04-01  8:23     ` [PATCH v2 2/2] app/testpmd: change command line of getting profile info Lu, Wenzhuo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491033428-68635-3-git-send-email-beilei.xing@intel.com \
    --to=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.