All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch net-next] net/faraday: Add missing include of of.h
@ 2017-04-02 18:20 Andrew Lunn
  2017-04-04  1:58 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2017-04-02 18:20 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, Andrew Lunn

Breaking the include loop netdevice.h, dsa.h, devlink.h broke this
driver, it depends on includes brought in by these headers. Adding
linux/of.h fixes it.

Fixes: ed0e39e97d34 ("net: break include loop netdevice.h, dsa.h, devlink.h")
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/ethernet/faraday/ftgmac100.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 928b0df2b8e0..333265060de1 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -28,6 +28,7 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/netdevice.h>
+#include <linux/of.h>
 #include <linux/phy.h>
 #include <linux/platform_device.h>
 #include <net/ip.h>
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch net-next] net/faraday: Add missing include of of.h
  2017-04-02 18:20 [patch net-next] net/faraday: Add missing include of of.h Andrew Lunn
@ 2017-04-04  1:58 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-04-04  1:58 UTC (permalink / raw)
  To: andrew; +Cc: netdev

From: Andrew Lunn <andrew@lunn.ch>
Date: Sun,  2 Apr 2017 20:20:47 +0200

> Breaking the include loop netdevice.h, dsa.h, devlink.h broke this
> driver, it depends on includes brought in by these headers. Adding
> linux/of.h fixes it.
> 
> Fixes: ed0e39e97d34 ("net: break include loop netdevice.h, dsa.h, devlink.h")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-04  1:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-02 18:20 [patch net-next] net/faraday: Add missing include of of.h Andrew Lunn
2017-04-04  1:58 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.