* [PATCH 1/2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-01-31 19:20 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-01-31 19:20 UTC (permalink / raw)
To: linux-arm-kernel
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
All the registers from the i.MX53 AIPSTZ are present on the i.MX25 as
well. Indicate that we are compatible to fsl,imx53-aipstz. However,
don't use aipstz for our name, this seems to be specific to i.MX53.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..4c4768f 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge at 43f00000 {
+ compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
+ reg = <0x43f00000 0x60>;
+ };
+
i2c1: i2c at 43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge at 53f00000 {
+ compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
+ reg = <0x53f00000 0x60>;
+ };
+
clks: ccm at 53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 1/2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-01-31 19:20 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-01-31 19:20 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Steffen Trumtrar
Cc: devicetree, linux-kernel, linux-arm-kernel, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
All the registers from the i.MX53 AIPSTZ are present on the i.MX25 as
well. Indicate that we are compatible to fsl,imx53-aipstz. However,
don't use aipstz for our name, this seems to be specific to i.MX53.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..4c4768f 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
+ reg = <0x43f00000 0x60>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
+ reg = <0x53f00000 0x60>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 2/2] ARM: i.MX25: globally disable supervisor protect
2017-01-31 19:20 ` Martin Kaiser
@ 2017-01-31 19:20 ` Martin Kaiser
-1 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-01-31 19:20 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Steffen Trumtrar
Cc: linux-arm-kernel, devicetree, linux-kernel, Martin Kaiser
The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
for the i.MX53 platform applies to i.MX25 as well.
E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
configuration. Modifiy the AIPS configuration to allow access to the bus
by SDMA and peripherals.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/mach-imx/mach-imx25.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
index 32dcb5e..353b86e 100644
--- a/arch/arm/mach-imx/mach-imx25.c
+++ b/arch/arm/mach-imx/mach-imx25.c
@@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
mxc_set_cpu_type(MXC_CPU_MX25);
}
+static void __init imx25_dt_init(void)
+{
+ imx_aips_allow_unprivileged_access("fsl,imx25-aips");
+}
+
static void __init mx25_init_irq(void)
{
struct device_node *np;
@@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
.init_early = imx25_init_early,
+ .init_machine = imx25_dt_init,
.init_late = imx25_pm_init,
.init_irq = mx25_init_irq,
.dt_compat = imx25_dt_board_compat,
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 2/2] ARM: i.MX25: globally disable supervisor protect
@ 2017-01-31 19:20 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-01-31 19:20 UTC (permalink / raw)
To: linux-arm-kernel
The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
for the i.MX53 platform applies to i.MX25 as well.
E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
configuration. Modifiy the AIPS configuration to allow access to the bus
by SDMA and peripherals.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
arch/arm/mach-imx/mach-imx25.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
index 32dcb5e..353b86e 100644
--- a/arch/arm/mach-imx/mach-imx25.c
+++ b/arch/arm/mach-imx/mach-imx25.c
@@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
mxc_set_cpu_type(MXC_CPU_MX25);
}
+static void __init imx25_dt_init(void)
+{
+ imx_aips_allow_unprivileged_access("fsl,imx25-aips");
+}
+
static void __init mx25_init_irq(void)
{
struct device_node *np;
@@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
.init_early = imx25_init_early,
+ .init_machine = imx25_dt_init,
.init_late = imx25_pm_init,
.init_irq = mx25_init_irq,
.dt_compat = imx25_dt_board_compat,
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCH 1/2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-01 7:09 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-01 7:09 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Sascha Hauer, Steffen Trumtrar, devicetree,
linux-kernel, linux-arm-kernel
On Tue, Jan 31, 2017 at 08:20:01PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> All the registers from the i.MX53 AIPSTZ are present on the i.MX25 as
> well. Indicate that we are compatible to fsl,imx53-aipstz. However,
> don't use aipstz for our name, this seems to be specific to i.MX53.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..4c4768f 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge@43f00000 {
> + compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
> + reg = <0x43f00000 0x60>;
> + };
The additional compatible properties should indicate if there is an
older ip block this one is compatible to. Since i.MX53 is newer than
i.MX25 this goes into the wrong direction. If anything you could add the
"fsl,imx25-aips" compatible to the i.MX53 dtsi file, but I don't think
that's worth it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH 1/2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-01 7:09 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-01 7:09 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Jan 31, 2017 at 08:20:01PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> All the registers from the i.MX53 AIPSTZ are present on the i.MX25 as
> well. Indicate that we are compatible to fsl,imx53-aipstz. However,
> don't use aipstz for our name, this seems to be specific to i.MX53.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..4c4768f 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge at 43f00000 {
> + compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
> + reg = <0x43f00000 0x60>;
> + };
The additional compatible properties should indicate if there is an
older ip block this one is compatible to. Since i.MX53 is newer than
i.MX25 this goes into the wrong direction. If anything you could add the
"fsl,imx25-aips" compatible to the i.MX53 dtsi file, but I don't think
that's worth it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH 1/2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-01 7:09 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-01 7:09 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Sascha Hauer, Steffen Trumtrar,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, Jan 31, 2017 at 08:20:01PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> All the registers from the i.MX53 AIPSTZ are present on the i.MX25 as
> well. Indicate that we are compatible to fsl,imx53-aipstz. However,
> don't use aipstz for our name, this seems to be specific to i.MX53.
>
> Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
> ---
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..4c4768f 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge@43f00000 {
> + compatible = "fsl,imx25-aips", "fsl,imx53-aipstz";
> + reg = <0x43f00000 0x60>;
> + };
The additional compatible properties should indicate if there is an
older ip block this one is compatible to. Since i.MX53 is newer than
i.MX25 this goes into the wrong direction. If anything you could add the
"fsl,imx25-aips" compatible to the i.MX53 dtsi file, but I don't think
that's worth it.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-01 22:16 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-02-01 22:16 UTC (permalink / raw)
To: Sascha Hauer, Shawn Guo, Sascha Hauer, Steffen Trumtrar
Cc: devicetree, linux-kernel, linux-arm-kernel, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..1914858 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x60>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x60>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH v2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-01 22:16 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-02-01 22:16 UTC (permalink / raw)
To: linux-arm-kernel
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..1914858 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge at 43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x60>;
+ };
+
i2c1: i2c at 43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge at 53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x60>;
+ };
+
clks: ccm at 53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH v2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-01 22:16 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-02-01 22:16 UTC (permalink / raw)
To: Sascha Hauer, Shawn Guo, Sascha Hauer, Steffen Trumtrar
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
---
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..1914858 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x60>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x60>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-02 7:09 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-02 7:09 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Sascha Hauer, Steffen Trumtrar, devicetree,
linux-kernel, linux-arm-kernel
Hi Martin,
On Wed, Feb 01, 2017 at 11:16:18PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
> removed the "fsl,imx53-aipstz" property as per Sascha's request
>
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..1914858 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge@43f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x43f00000 0x60>;
> + };
One thing I haven't seen the first time: The size should be the size of
the while register space given to this device, not the position of the
last register, so 0x4000 instead of 0x60 here.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH v2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-02 7:09 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-02 7:09 UTC (permalink / raw)
To: linux-arm-kernel
Hi Martin,
On Wed, Feb 01, 2017 at 11:16:18PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
> removed the "fsl,imx53-aipstz" property as per Sascha's request
>
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..1914858 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge at 43f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x43f00000 0x60>;
> + };
One thing I haven't seen the first time: The size should be the size of
the while register space given to this device, not the position of the
last register, so 0x4000 instead of 0x60 here.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v2] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-02 7:09 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-02 7:09 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Sascha Hauer, Steffen Trumtrar,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Hi Martin,
On Wed, Feb 01, 2017 at 11:16:18PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
> ---
> v2:
> removed the "fsl,imx53-aipstz" property as per Sascha's request
>
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..1914858 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge@43f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x43f00000 0x60>;
> + };
One thing I haven't seen the first time: The size should be the size of
the while register space given to this device, not the position of the
last register, so 0x4000 instead of 0x60 here.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH v3] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-03 12:59 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-02-03 12:59 UTC (permalink / raw)
To: Sascha Hauer, Shawn Guo, Sascha Hauer, Steffen Trumtrar
Cc: linux-arm-kernel, devicetree, linux-kernel, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v3:
fixed the size of the memory regions, both are 16KBytes long
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..5ae8a14 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x4000>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x4000>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH v3] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-03 12:59 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-02-03 12:59 UTC (permalink / raw)
To: linux-arm-kernel
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v3:
fixed the size of the memory regions, both are 16KBytes long
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..5ae8a14 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge at 43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x4000>;
+ };
+
i2c1: i2c at 43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge at 53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x4000>;
+ };
+
clks: ccm at 53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH v3] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-03 12:59 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-02-03 12:59 UTC (permalink / raw)
To: Sascha Hauer, Shawn Guo, Sascha Hauer, Steffen Trumtrar
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
---
v3:
fixed the size of the memory regions, both are 16KBytes long
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index e0ba550..5ae8a14 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x4000>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x4000>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH v3] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-03 17:27 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-03 17:27 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Sascha Hauer, Steffen Trumtrar, linux-arm-kernel,
devicetree, linux-kernel
On Fri, Feb 03, 2017 at 01:59:52PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> v3:
> fixed the size of the memory regions, both are 16KBytes long
>
> v2:
> removed the "fsl,imx53-aipstz" property as per Sascha's request
>
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..5ae8a14 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge@43f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x43f00000 0x4000>;
> + };
> +
> i2c1: i2c@43f80000 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -342,6 +347,11 @@
> reg = <0x53f00000 0x100000>;
> ranges;
>
> + aips2: bridge@53f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x53f00000 0x4000>;
> + };
> +
> clks: ccm@53f80000 {
> compatible = "fsl,imx25-ccm";
> reg = <0x53f80000 0x4000>;
> --
> 2.1.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH v3] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-03 17:27 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-03 17:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 03, 2017 at 01:59:52PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Sascha
> ---
> v3:
> fixed the size of the memory regions, both are 16KBytes long
>
> v2:
> removed the "fsl,imx53-aipstz" property as per Sascha's request
>
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..5ae8a14 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge at 43f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x43f00000 0x4000>;
> + };
> +
> i2c1: i2c at 43f80000 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -342,6 +347,11 @@
> reg = <0x53f00000 0x100000>;
> ranges;
>
> + aips2: bridge at 53f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x53f00000 0x4000>;
> + };
> +
> clks: ccm at 53f80000 {
> compatible = "fsl,imx25-ccm";
> reg = <0x53f80000 0x4000>;
> --
> 2.1.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH v3] ARM: dts: i.MX25: add AIPS control registers
@ 2017-02-03 17:27 ` Sascha Hauer
0 siblings, 0 replies; 31+ messages in thread
From: Sascha Hauer @ 2017-02-03 17:27 UTC (permalink / raw)
To: Martin Kaiser
Cc: Shawn Guo, Sascha Hauer, Steffen Trumtrar,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Fri, Feb 03, 2017 at 01:59:52PM +0100, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Sascha
> ---
> v3:
> fixed the size of the memory regions, both are 16KBytes long
>
> v2:
> removed the "fsl,imx53-aipstz" property as per Sascha's request
>
> arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
> index e0ba550..5ae8a14 100644
> --- a/arch/arm/boot/dts/imx25.dtsi
> +++ b/arch/arm/boot/dts/imx25.dtsi
> @@ -93,6 +93,11 @@
> reg = <0x43f00000 0x100000>;
> ranges;
>
> + aips1: bridge@43f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x43f00000 0x4000>;
> + };
> +
> i2c1: i2c@43f80000 {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -342,6 +347,11 @@
> reg = <0x53f00000 0x100000>;
> ranges;
>
> + aips2: bridge@53f00000 {
> + compatible = "fsl,imx25-aips";
> + reg = <0x53f00000 0x4000>;
> + };
> +
> clks: ccm@53f80000 {
> compatible = "fsl,imx25-ccm";
> reg = <0x53f80000 0x4000>;
> --
> 2.1.4
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH 1/2 v4] ARM: dts: i.MX25: add AIPS control registers
@ 2017-04-03 19:47 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-04-03 19:47 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, devicetree, linux-kernel, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
---
v4:
rebased against latest linux-next
re-sending both patches, it seems they got lost along the way
v3:
fixed the size of the memory regions, both are 16KBytes long
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 89c8f8f..0cdf333 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x4000>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x4000>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 1/2 v4] ARM: dts: i.MX25: add AIPS control registers
@ 2017-04-03 19:47 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-04-03 19:47 UTC (permalink / raw)
To: linux-arm-kernel
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
---
v4:
rebased against latest linux-next
re-sending both patches, it seems they got lost along the way
v3:
fixed the size of the memory regions, both are 16KBytes long
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 89c8f8f..0cdf333 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge at 43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x4000>;
+ };
+
i2c1: i2c at 43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge at 53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x4000>;
+ };
+
clks: ccm at 53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 1/2 v4] ARM: dts: i.MX25: add AIPS control registers
@ 2017-04-03 19:47 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-04-03 19:47 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Martin Kaiser
The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
control registers. Add the memory regions for the control registers to
the Device Tree.
Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
---
v4:
rebased against latest linux-next
re-sending both patches, it seems they got lost along the way
v3:
fixed the size of the memory regions, both are 16KBytes long
v2:
removed the "fsl,imx53-aipstz" property as per Sascha's request
arch/arm/boot/dts/imx25.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
index 89c8f8f..0cdf333 100644
--- a/arch/arm/boot/dts/imx25.dtsi
+++ b/arch/arm/boot/dts/imx25.dtsi
@@ -93,6 +93,11 @@
reg = <0x43f00000 0x100000>;
ranges;
+ aips1: bridge@43f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x43f00000 0x4000>;
+ };
+
i2c1: i2c@43f80000 {
#address-cells = <1>;
#size-cells = <0>;
@@ -342,6 +347,11 @@
reg = <0x53f00000 0x100000>;
ranges;
+ aips2: bridge@53f00000 {
+ compatible = "fsl,imx25-aips";
+ reg = <0x53f00000 0x4000>;
+ };
+
clks: ccm@53f80000 {
compatible = "fsl,imx25-ccm";
reg = <0x53f80000 0x4000>;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 2/2 v2] ARM: i.MX25: globally disable supervisor protect
2017-04-03 19:47 ` Martin Kaiser
@ 2017-04-03 19:47 ` Martin Kaiser
-1 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-04-03 19:47 UTC (permalink / raw)
To: Shawn Guo
Cc: Sascha Hauer, linux-arm-kernel, devicetree, linux-kernel, Martin Kaiser
The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
for the i.MX53 platform applies to i.MX25 as well.
E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
configuration. Modifiy the AIPS configuration to allow access to the bus
by SDMA and peripherals.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
rebased against latest linux-next
re-sending both patches, it seems they got lost along the way
arch/arm/mach-imx/mach-imx25.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
index 32dcb5e..353b86e 100644
--- a/arch/arm/mach-imx/mach-imx25.c
+++ b/arch/arm/mach-imx/mach-imx25.c
@@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
mxc_set_cpu_type(MXC_CPU_MX25);
}
+static void __init imx25_dt_init(void)
+{
+ imx_aips_allow_unprivileged_access("fsl,imx25-aips");
+}
+
static void __init mx25_init_irq(void)
{
struct device_node *np;
@@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
.init_early = imx25_init_early,
+ .init_machine = imx25_dt_init,
.init_late = imx25_pm_init,
.init_irq = mx25_init_irq,
.dt_compat = imx25_dt_board_compat,
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* [PATCH 2/2 v2] ARM: i.MX25: globally disable supervisor protect
@ 2017-04-03 19:47 ` Martin Kaiser
0 siblings, 0 replies; 31+ messages in thread
From: Martin Kaiser @ 2017-04-03 19:47 UTC (permalink / raw)
To: linux-arm-kernel
The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
for the i.MX53 platform applies to i.MX25 as well.
E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
configuration. Modifiy the AIPS configuration to allow access to the bus
by SDMA and peripherals.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
rebased against latest linux-next
re-sending both patches, it seems they got lost along the way
arch/arm/mach-imx/mach-imx25.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
index 32dcb5e..353b86e 100644
--- a/arch/arm/mach-imx/mach-imx25.c
+++ b/arch/arm/mach-imx/mach-imx25.c
@@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
mxc_set_cpu_type(MXC_CPU_MX25);
}
+static void __init imx25_dt_init(void)
+{
+ imx_aips_allow_unprivileged_access("fsl,imx25-aips");
+}
+
static void __init mx25_init_irq(void)
{
struct device_node *np;
@@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
.init_early = imx25_init_early,
+ .init_machine = imx25_dt_init,
.init_late = imx25_pm_init,
.init_irq = mx25_init_irq,
.dt_compat = imx25_dt_board_compat,
--
2.1.4
^ permalink raw reply related [flat|nested] 31+ messages in thread* Re: [PATCH 2/2 v2] ARM: i.MX25: globally disable supervisor protect
@ 2017-04-04 13:14 ` Shawn Guo
0 siblings, 0 replies; 31+ messages in thread
From: Shawn Guo @ 2017-04-04 13:14 UTC (permalink / raw)
To: Martin Kaiser; +Cc: devicetree, linux-arm-kernel, Sascha Hauer, linux-kernel
On Mon, Apr 03, 2017 at 09:47:05PM +0200, Martin Kaiser wrote:
> The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
This causes the following checkpatch error.
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 6befda9a272b ("ARM: i.MX53:
globally disable supervisor protect")'
I fixed it and applied the patch.
Shawn
> for the i.MX53 platform applies to i.MX25 as well.
>
> E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
> configuration. Modifiy the AIPS configuration to allow access to the bus
> by SDMA and peripherals.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
> rebased against latest linux-next
> re-sending both patches, it seems they got lost along the way
>
> arch/arm/mach-imx/mach-imx25.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
> index 32dcb5e..353b86e 100644
> --- a/arch/arm/mach-imx/mach-imx25.c
> +++ b/arch/arm/mach-imx/mach-imx25.c
> @@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
> mxc_set_cpu_type(MXC_CPU_MX25);
> }
>
> +static void __init imx25_dt_init(void)
> +{
> + imx_aips_allow_unprivileged_access("fsl,imx25-aips");
> +}
> +
> static void __init mx25_init_irq(void)
> {
> struct device_node *np;
> @@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
>
> DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
> .init_early = imx25_init_early,
> + .init_machine = imx25_dt_init,
> .init_late = imx25_pm_init,
> .init_irq = mx25_init_irq,
> .dt_compat = imx25_dt_board_compat,
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread* [PATCH 2/2 v2] ARM: i.MX25: globally disable supervisor protect
@ 2017-04-04 13:14 ` Shawn Guo
0 siblings, 0 replies; 31+ messages in thread
From: Shawn Guo @ 2017-04-04 13:14 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 03, 2017 at 09:47:05PM +0200, Martin Kaiser wrote:
> The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
This causes the following checkpatch error.
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 6befda9a272b ("ARM: i.MX53:
globally disable supervisor protect")'
I fixed it and applied the patch.
Shawn
> for the i.MX53 platform applies to i.MX25 as well.
>
> E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
> configuration. Modifiy the AIPS configuration to allow access to the bus
> by SDMA and peripherals.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> v2:
> rebased against latest linux-next
> re-sending both patches, it seems they got lost along the way
>
> arch/arm/mach-imx/mach-imx25.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
> index 32dcb5e..353b86e 100644
> --- a/arch/arm/mach-imx/mach-imx25.c
> +++ b/arch/arm/mach-imx/mach-imx25.c
> @@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
> mxc_set_cpu_type(MXC_CPU_MX25);
> }
>
> +static void __init imx25_dt_init(void)
> +{
> + imx_aips_allow_unprivileged_access("fsl,imx25-aips");
> +}
> +
> static void __init mx25_init_irq(void)
> {
> struct device_node *np;
> @@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
>
> DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
> .init_early = imx25_init_early,
> + .init_machine = imx25_dt_init,
> .init_late = imx25_pm_init,
> .init_irq = mx25_init_irq,
> .dt_compat = imx25_dt_board_compat,
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread* Re: [PATCH 2/2 v2] ARM: i.MX25: globally disable supervisor protect
@ 2017-04-04 13:14 ` Shawn Guo
0 siblings, 0 replies; 31+ messages in thread
From: Shawn Guo @ 2017-04-04 13:14 UTC (permalink / raw)
To: Martin Kaiser
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sascha Hauer,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, Apr 03, 2017 at 09:47:05PM +0200, Martin Kaiser wrote:
> The problem described in 6befda9a272b98bfb1dc772efc3564644cbfb270
This causes the following checkpatch error.
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 6befda9a272b ("ARM: i.MX53:
globally disable supervisor protect")'
I fixed it and applied the patch.
Shawn
> for the i.MX53 platform applies to i.MX25 as well.
>
> E.g. CSPI1+SDMA and SSI1+SDMA are not working with the default AIPS
> configuration. Modifiy the AIPS configuration to allow access to the bus
> by SDMA and peripherals.
>
> Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
> ---
> v2:
> rebased against latest linux-next
> re-sending both patches, it seems they got lost along the way
>
> arch/arm/mach-imx/mach-imx25.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/mach-imx/mach-imx25.c b/arch/arm/mach-imx/mach-imx25.c
> index 32dcb5e..353b86e 100644
> --- a/arch/arm/mach-imx/mach-imx25.c
> +++ b/arch/arm/mach-imx/mach-imx25.c
> @@ -23,6 +23,11 @@ static void __init imx25_init_early(void)
> mxc_set_cpu_type(MXC_CPU_MX25);
> }
>
> +static void __init imx25_dt_init(void)
> +{
> + imx_aips_allow_unprivileged_access("fsl,imx25-aips");
> +}
> +
> static void __init mx25_init_irq(void)
> {
> struct device_node *np;
> @@ -41,6 +46,7 @@ static const char * const imx25_dt_board_compat[] __initconst = {
>
> DT_MACHINE_START(IMX25_DT, "Freescale i.MX25 (Device Tree Support)")
> .init_early = imx25_init_early,
> + .init_machine = imx25_dt_init,
> .init_late = imx25_pm_init,
> .init_irq = mx25_init_irq,
> .dt_compat = imx25_dt_board_compat,
> --
> 2.1.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 1/2 v4] ARM: dts: i.MX25: add AIPS control registers
@ 2017-04-04 13:13 ` Shawn Guo
0 siblings, 0 replies; 31+ messages in thread
From: Shawn Guo @ 2017-04-04 13:13 UTC (permalink / raw)
To: Martin Kaiser; +Cc: devicetree, linux-arm-kernel, Sascha Hauer, linux-kernel
On Mon, Apr 03, 2017 at 09:47:04PM +0200, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH 1/2 v4] ARM: dts: i.MX25: add AIPS control registers
@ 2017-04-04 13:13 ` Shawn Guo
0 siblings, 0 replies; 31+ messages in thread
From: Shawn Guo @ 2017-04-04 13:13 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 03, 2017 at 09:47:04PM +0200, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 1/2 v4] ARM: dts: i.MX25: add AIPS control registers
@ 2017-04-04 13:13 ` Shawn Guo
0 siblings, 0 replies; 31+ messages in thread
From: Shawn Guo @ 2017-04-04 13:13 UTC (permalink / raw)
To: Martin Kaiser
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Sascha Hauer,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Mon, Apr 03, 2017 at 09:47:04PM +0200, Martin Kaiser wrote:
> The i.MX25 contains two AHB to IP bridges (AIPS), each of which has a set of
> control registers. Add the memory regions for the control registers to
> the Device Tree.
>
> Signed-off-by: Martin Kaiser <martin-XxZfDwE/svGeZLLa646FqQ@public.gmane.org>
> Reviewed-by: Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 31+ messages in thread