Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Ritesh Raj Sarraf]

[-- Attachment #1: Type: text/plain, Size: 2025 bytes --]

Adding Stable, LKML and IIO MLs.

Hello Hongyan,

Do you have any feedback ? With the bisected commit reverted, I've been
successfully running the machine without any issues.

Ritesh


On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> Hello Hongyan,
> 
> Can you check the findings of Ritesh?
> 
> Thanks,
> Srinivas
> 
> On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > Hello Srinivas,
> > 
> > With the Linux 4.10.7 release, I have encountered a regression
> > introduced on my
> > Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > 
> > 
> > rrs@learner:~$ lsusb 
> > Bus 001 Device 002: ID 8087:8000 Intel Corp. 
> > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> > Bus 002 Device 006: ID 048d:8350 Integrated Technology Express, Inc. 
> > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. 
> > Bus 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd 
> > Bus 002 Device 003: ID 04f3:0303 Elan Microelectronics Corp. 
> > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129
> > Card Reader
> > Controller
> > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > 2017-04-01 / 14:04:49 ♒♒♒  ☺  
> > 
> > 
> > The ITE sensors do not feed any data on the 4.10.7 kernel. Reverting
> > back to
> > 4.10.5, everything works back.
> > 
> > 
> > After a git bisect, the culprit reported is:
> > 
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-trigger:
> > Change get
> > poll value function order to avoid sensor properties losing after
> > resume from S3
> > 1
> > 
> > Can you please review my findings to confirm that it really is a
> > regression bug
> > ?
> > 
> > 
> > Thanks,
> > Ritesh
> > 
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Srinivas Pandruvada]

[-- Attachment #1: Type: text/plain, Size: 2133 bytes --]

Hi Ritesh,

Does the attached patch helps?

Thanks,
Srinivas

On Tue, 2017-04-04 at 00:44 +0530, Ritesh Raj Sarraf wrote:
> Adding Stable, LKML and IIO MLs.
> 
> Hello Hongyan,
> 
> Do you have any feedback ? With the bisected commit reverted, I've
> been
> successfully running the machine without any issues.
> 
> Ritesh
> 
> 
> On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> > Hello Hongyan,
> > 
> > Can you check the findings of Ritesh?
> > 
> > Thanks,
> > Srinivas
> > 
> > On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > > Hello Srinivas,
> > > 
> > > With the Linux 4.10.7 release, I have encountered a regression
> > > introduced on my
> > > Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > > 
> > > 
> > > rrs@learner:~$ lsusb 
> > > Bus 001 Device 002: ID 8087:8000 Intel Corp. 
> > > Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > Bus 003 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
> > > Bus 002 Device 006: ID 048d:8350 Integrated Technology Express,
> > > Inc. 
> > > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. 
> > > Bus 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd 
> > > Bus 002 Device 003: ID 04f3:0303 Elan Microelectronics Corp. 
> > > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp.
> > > RTS5129
> > > Card Reader
> > > Controller
> > > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > 2017-04-01 / 14:04:49 ♒♒♒  ☺  
> > > 
> > > 
> > > The ITE sensors do not feed any data on the 4.10.7 kernel.
> > > Reverting
> > > back to
> > > 4.10.5, everything works back.
> > > 
> > > 
> > > After a git bisect, the culprit reported is:
> > > 
> > > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-
> > > trigger:
> > > Change get
> > > poll value function order to avoid sensor properties losing after
> > > resume from S3
> > > 1
> > > 
> > > Can you please review my findings to confirm that it really is a
> > > regression bug
> > > ?
> > > 
> > > 
> > > Thanks,
> > > Ritesh
> > > 

[-- Attachment #2: 0001-iio-hid-sensor-Store-restore-poll-and-hysteresis.patch --]
[-- Type: text/x-patch, Size: 3892 bytes --]

From 81a55bd9e6dfb4aec15da37a3a3ff8213d788f62 Mon Sep 17 00:00:00 2001
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: Tue, 4 Apr 2017 16:50:59 -0700
Subject: [PATCH] iio: hid-sensor: Store restore poll and hysteresis

Instead of relying on HW for restoring poll and hysteresis, store in driver
and restore on resume.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 .../iio/common/hid-sensors/hid-sensor-attributes.c   | 17 +++++++++++++++++
 drivers/iio/common/hid-sensors/hid-sensor-trigger.c  | 20 +++++++++++++++++---
 include/linux/hid-sensor-hub.h                       |  2 ++
 3 files changed, 36 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
index 7afdac42..aa8cacf 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-attributes.c
@@ -221,6 +221,14 @@ int hid_sensor_write_samp_freq_value(struct hid_sensor_common *st,
 	if (ret < 0 || value < 0)
 		ret = -EINVAL;
 
+	ret = sensor_hub_get_feature(st->hsdev,
+				     st->poll.report_id,
+				     st->poll.index, sizeof(value), &value);
+	if (ret < 0 || value < 0)
+		return -EINVAL;
+
+	st->poll_interval = value;
+
 	return ret;
 }
 EXPORT_SYMBOL(hid_sensor_write_samp_freq_value);
@@ -266,6 +274,15 @@ int hid_sensor_write_raw_hyst_value(struct hid_sensor_common *st,
 	if (ret < 0 || value < 0)
 		ret = -EINVAL;
 
+	ret = sensor_hub_get_feature(st->hsdev,
+				     st->sensitivity.report_id,
+				     st->sensitivity.index, sizeof(value),
+				     &value);
+	if (ret < 0 || value < 0)
+		return -EINVAL;
+
+	st->raw_hystersis = value;
+
 	return ret;
 }
 EXPORT_SYMBOL(hid_sensor_write_raw_hyst_value);
diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index ecf592d..be7011e 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -51,6 +51,8 @@ static int _hid_sensor_power_state(struct hid_sensor_common *st, bool state)
 			st->report_state.report_id,
 			st->report_state.index,
 			HID_USAGE_SENSOR_PROP_REPORTING_STATE_ALL_EVENTS_ENUM);
+
+		poll_value = hid_sensor_read_poll_value(st);
 	} else {
 		int val;
 
@@ -87,9 +89,7 @@ static int _hid_sensor_power_state(struct hid_sensor_common *st, bool state)
 	sensor_hub_get_feature(st->hsdev, st->power_state.report_id,
 			       st->power_state.index,
 			       sizeof(state_val), &state_val);
-	if (state)
-		poll_value = hid_sensor_read_poll_value(st);
-	if (poll_value > 0)
+	if (state && poll_value)
 		msleep_interruptible(poll_value * 2);
 
 	return 0;
@@ -127,6 +127,20 @@ static void hid_sensor_set_power_work(struct work_struct *work)
 	struct hid_sensor_common *attrb = container_of(work,
 						       struct hid_sensor_common,
 						       work);
+
+	if (attrb->poll_interval)
+		sensor_hub_set_feature(attrb->hsdev, attrb->poll.report_id,
+				       attrb->poll.index,
+				       sizeof(attrb->poll_interval),
+				       &attrb->poll_interval);
+
+	if (attrb->raw_hystersis)
+		sensor_hub_set_feature(attrb->hsdev,
+				       attrb->sensitivity.report_id,
+				       attrb->sensitivity.index,
+				       sizeof(attrb->raw_hystersis),
+				       &attrb->raw_hystersis);
+
 	_hid_sensor_power_state(attrb, true);
 }
 
diff --git a/include/linux/hid-sensor-hub.h b/include/linux/hid-sensor-hub.h
index 7ef111d..f32d7c3 100644
--- a/include/linux/hid-sensor-hub.h
+++ b/include/linux/hid-sensor-hub.h
@@ -231,6 +231,8 @@ struct hid_sensor_common {
 	unsigned usage_id;
 	atomic_t data_ready;
 	atomic_t user_requested_state;
+	int poll_interval;
+	int raw_hystersis;
 	struct iio_trigger *trigger;
 	int timestamp_ns_scale;
 	struct hid_sensor_hub_attribute_info poll;
-- 
2.9.3

RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

Hi All,
	Sorry for the late response, for I am on Qingming Festival for the last 3 days.
I noticed Ritesh has tried a USB sensor, I do not have that kind of sensor at hand and have not tried it yet. My patch worked well for ISH but I am not sure whether it is fine for USB sensor. Sorry for not much information can provide. I will try to see if I can find one device and try.



BR
Song Hongyan

-----Original Message-----
From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com]
Sent: Wednesday, April 5, 2017 8:45 AM
To: rrs@researchut.com; Song, Hongyan <hongyan.song@intel.com>; linux-iio <linux-iio@vger.kernel.org>
Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Hi Ritesh,

Does the attached patch helps?

Thanks,
Srinivas

On Tue, 2017-04-04 at 00:44 +0530, Ritesh Raj Sarraf wrote:
> Adding Stable, LKML and IIO MLs.
> 
> Hello Hongyan,
> 
> Do you have any feedback ? With the bisected commit reverted, I've 
> been successfully running the machine without any issues.
> 
> Ritesh
> 
> 
> On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> > Hello Hongyan,
> > 
> > Can you check the findings of Ritesh?
> > 
> > Thanks,
> > Srinivas
> > 
> > On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > > Hello Srinivas,
> > > 
> > > With the Linux 4.10.7 release, I have encountered a regression 
> > > introduced on my Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > > 
> > > 
> > > rrs@learner:~$ lsusb
> > > Bus 001 Device 002: ID 8087:8000 Intel Corp. Bus 001 Device 001: 
> > > ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 003 Device 001: ID
> > > 1d6b:0003 Linux Foundation 3.0 root hub Bus 002 Device 006: ID
> > > 048d:8350 Integrated Technology Express, Inc.
> > > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. Bus
> > > 002 Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd Bus 002 
> > > Device 003: ID 04f3:0303 Elan Microelectronics Corp.
> > > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp.
> > > RTS5129
> > > Card Reader
> > > Controller
> > > Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
> > > 2017-04-01 / 14:04:49 ♒♒♒  ☺
> > > 
> > > 
> > > The ITE sensors do not feed any data on the 4.10.7 kernel.
> > > Reverting
> > > back to
> > > 4.10.5, everything works back.
> > > 
> > > 
> > > After a git bisect, the culprit reported is:
> > > 
> > > Bisecting: 0 revisions left to test after this (roughly 0 steps) 
> > > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-
> > > trigger:
> > > Change get
> > > poll value function order to avoid sensor properties losing after 
> > > resume from S3
> > > 1
> > > 
> > > Can you please review my findings to confirm that it really is a 
> > > regression bug ?
> > > 
> > > 
> > > Thanks,
> > > Ritesh
> > > 

RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

SGkgQWxsLA0KCVNvcnJ5IGZvciB0aGUgbGF0ZSByZXNwb25zZSwgZm9yIEkgYW0gb24gUWluZ21p
bmcgRmVzdGl2YWwgZm9yIHRoZSBsYXN0IDMgZGF5cy4NCkkgbm90aWNlZCBSaXRlc2ggaGFzIHRy
aWVkIGEgVVNCIHNlbnNvciwgSSBkbyBub3QgaGF2ZSB0aGF0IGtpbmQgb2Ygc2Vuc29yIGF0IGhh
bmQgYW5kIGhhdmUgbm90IHRyaWVkIGl0IHlldC4gTXkgcGF0Y2ggd29ya2VkIHdlbGwgZm9yIElT
SCBidXQgSSBhbSBub3Qgc3VyZSB3aGV0aGVyIGl0IGlzIGZpbmUgZm9yIFVTQiBzZW5zb3IuIFNv
cnJ5IGZvciBub3QgbXVjaCBpbmZvcm1hdGlvbiBjYW4gcHJvdmlkZS4gSSB3aWxsIHRyeSB0byBz
ZWUgaWYgSSBjYW4gZmluZCBvbmUgZGV2aWNlIGFuZCB0cnkuDQoNCg0KDQpCUg0KU29uZyBIb25n
eWFuDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBTcmluaXZhcyBQYW5kcnV2
YWRhIFttYWlsdG86c3Jpbml2YXMucGFuZHJ1dmFkYUBsaW51eC5pbnRlbC5jb21dDQpTZW50OiBX
ZWRuZXNkYXksIEFwcmlsIDUsIDIwMTcgODo0NSBBTQ0KVG86IHJyc0ByZXNlYXJjaHV0LmNvbTsg
U29uZywgSG9uZ3lhbiA8aG9uZ3lhbi5zb25nQGludGVsLmNvbT47IGxpbnV4LWlpbyA8bGludXgt
aWlvQHZnZXIua2VybmVsLm9yZz4NCkNjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnOyBsaW51eC1r
ZXJuZWxAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0OiBSZTogW1NUQUJMRSBSRUdSRVNTSU9OXSBp
aW86IGhpZC1zZW5zb3ItdHJpZ2dlcjogQ2hhbmdlIGdldCBwb2xsIHZhbHVlIGZ1bmN0aW9uIG9y
ZGVyIHRvIGF2b2lkIHNlbnNvciBwcm9wZXJ0aWVzIGxvc2luZyBhZnRlciByZXN1bWUgZnJvbSBT
Mw0KDQpIaSBSaXRlc2gsDQoNCkRvZXMgdGhlIGF0dGFjaGVkIHBhdGNoIGhlbHBzPw0KDQpUaGFu
a3MsDQpTcmluaXZhcw0KDQpPbiBUdWUsIDIwMTctMDQtMDQgYXQgMDA6NDQgKzA1MzAsIFJpdGVz
aCBSYWogU2FycmFmIHdyb3RlOg0KPiBBZGRpbmcgU3RhYmxlLCBMS01MIGFuZCBJSU8gTUxzLg0K
PiANCj4gSGVsbG8gSG9uZ3lhbiwNCj4gDQo+IERvIHlvdSBoYXZlIGFueSBmZWVkYmFjayA/IFdp
dGggdGhlIGJpc2VjdGVkIGNvbW1pdCByZXZlcnRlZCwgSSd2ZSANCj4gYmVlbiBzdWNjZXNzZnVs
bHkgcnVubmluZyB0aGUgbWFjaGluZSB3aXRob3V0IGFueSBpc3N1ZXMuDQo+IA0KPiBSaXRlc2gN
Cj4gDQo+IA0KPiBPbiBTYXQsIDIwMTctMDQtMDEgYXQgMDg6MTQgLTA3MDAsIFNyaW5pdmFzIFBh
bmRydXZhZGEgd3JvdGU6DQo+ID4gSGVsbG8gSG9uZ3lhbiwNCj4gPiANCj4gPiBDYW4geW91IGNo
ZWNrIHRoZSBmaW5kaW5ncyBvZiBSaXRlc2g/DQo+ID4gDQo+ID4gVGhhbmtzLA0KPiA+IFNyaW5p
dmFzDQo+ID4gDQo+ID4gT24gU2F0LCAyMDE3LTA0LTAxIGF0IDE0OjA3ICswNTMwLCBSaXRlc2gg
UmFqIFNhcnJhZiB3cm90ZToNCj4gPiA+IEhlbGxvIFNyaW5pdmFzLA0KPiA+ID4gDQo+ID4gPiBX
aXRoIHRoZSBMaW51eCA0LjEwLjcgcmVsZWFzZSwgSSBoYXZlIGVuY291bnRlcmVkIGEgcmVncmVz
c2lvbiANCj4gPiA+IGludHJvZHVjZWQgb24gbXkgTGVub3ZvIFlvZ2EgMiAxMywgZm9yIHRoZSBJ
VEUgUm90YXRpb24gU2Vuc29yLg0KPiA+ID4gDQo+ID4gPiANCj4gPiA+IHJyc0BsZWFybmVyOn4k
IGxzdXNiDQo+ID4gPiBCdXMgMDAxIERldmljZSAwMDI6IElEIDgwODc6ODAwMCBJbnRlbCBDb3Jw
LiBCdXMgMDAxIERldmljZSAwMDE6IA0KPiA+ID4gSUQgMWQ2YjowMDAyIExpbnV4IEZvdW5kYXRp
b24gMi4wIHJvb3QgaHViIEJ1cyAwMDMgRGV2aWNlIDAwMTogSUQNCj4gPiA+IDFkNmI6MDAwMyBM
aW51eCBGb3VuZGF0aW9uIDMuMCByb290IGh1YiBCdXMgMDAyIERldmljZSAwMDY6IElEDQo+ID4g
PiAwNDhkOjgzNTAgSW50ZWdyYXRlZCBUZWNobm9sb2d5IEV4cHJlc3MsIEluYy4NCj4gPiA+IEJ1
cyAwMDIgRGV2aWNlIDAwNTogSUQgMGJkYTpiNzI4IFJlYWx0ZWsgU2VtaWNvbmR1Y3RvciBDb3Jw
LiBCdXMNCj4gPiA+IDAwMiBEZXZpY2UgMDA0OiBJRCAwNGYyOmI0MGYgQ2hpY29ueSBFbGVjdHJv
bmljcyBDby4sIEx0ZCBCdXMgMDAyIA0KPiA+ID4gRGV2aWNlIDAwMzogSUQgMDRmMzowMzAzIEVs
YW4gTWljcm9lbGVjdHJvbmljcyBDb3JwLg0KPiA+ID4gQnVzIDAwMiBEZXZpY2UgMDAyOiBJRCAw
YmRhOjAxMjkgUmVhbHRlayBTZW1pY29uZHVjdG9yIENvcnAuDQo+ID4gPiBSVFM1MTI5DQo+ID4g
PiBDYXJkIFJlYWRlcg0KPiA+ID4gQ29udHJvbGxlcg0KPiA+ID4gQnVzIDAwMiBEZXZpY2UgMDAx
OiBJRCAxZDZiOjAwMDIgTGludXggRm91bmRhdGlvbiAyLjAgcm9vdCBodWINCj4gPiA+IDIwMTct
MDQtMDEgLyAxNDowNDo0OSDimZLimZLimZLCoMKg4pi6DQo+ID4gPiANCj4gPiA+IA0KPiA+ID4g
VGhlIElURSBzZW5zb3JzIGRvIG5vdCBmZWVkIGFueSBkYXRhIG9uIHRoZSA0LjEwLjcga2VybmVs
Lg0KPiA+ID4gUmV2ZXJ0aW5nDQo+ID4gPiBiYWNrIHRvDQo+ID4gPiA0LjEwLjUsIGV2ZXJ5dGhp
bmcgd29ya3MgYmFjay4NCj4gPiA+IA0KPiA+ID4gDQo+ID4gPiBBZnRlciBhIGdpdCBiaXNlY3Qs
IHRoZSBjdWxwcml0IHJlcG9ydGVkIGlzOg0KPiA+ID4gDQo+ID4gPiBCaXNlY3Rpbmc6IDAgcmV2
aXNpb25zIGxlZnQgdG8gdGVzdCBhZnRlciB0aGlzIChyb3VnaGx5IDAgc3RlcHMpIA0KPiA+ID4g
WzZjMmFhYjA3ZDEyNDM2YWYxY2Q4ZDlhYzFkMTE3YTQ0MmNjOTFlZWNdIGlpbzogaGlkLXNlbnNv
ci0NCj4gPiA+IHRyaWdnZXI6DQo+ID4gPiBDaGFuZ2UgZ2V0DQo+ID4gPiBwb2xsIHZhbHVlIGZ1
bmN0aW9uIG9yZGVyIHRvIGF2b2lkIHNlbnNvciBwcm9wZXJ0aWVzIGxvc2luZyBhZnRlciANCj4g
PiA+IHJlc3VtZSBmcm9tIFMzDQo+ID4gPiAxDQo+ID4gPiANCj4gPiA+IENhbiB5b3UgcGxlYXNl
IHJldmlldyBteSBmaW5kaW5ncyB0byBjb25maXJtIHRoYXQgaXQgcmVhbGx5IGlzIGEgDQo+ID4g
PiByZWdyZXNzaW9uIGJ1ZyA/DQo+ID4gPiANCj4gPiA+IA0KPiA+ID4gVGhhbmtzLA0KPiA+ID4g
Uml0ZXNoDQo+ID4gPiANCg==

RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

Hi Ritesh,
	I do not have the environment so should not have a try but I think Srinivas's patch should be Ok for your platform.
Please have a try.

Thanks a lot!


BR
Song Hongyan

-----Original Message-----
From: Ritesh Raj Sarraf [mailto:rrs@researchut.com] 
Sent: Tuesday, April 4, 2017 3:14 AM
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>; Song, Hongyan <hongyan.song@intel.com>; linux-iio <linux-iio@vger.kernel.org>
Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Adding Stable, LKML and IIO MLs.

Hello Hongyan,

Do you have any feedback ? With the bisected commit reverted, I've been successfully running the machine without any issues.

Ritesh


On Sat, 2017-04-01 at 08:14 -0700, Srinivas Pandruvada wrote:
> Hello Hongyan,
> 
> Can you check the findings of Ritesh?
> 
> Thanks,
> Srinivas
> 
> On Sat, 2017-04-01 at 14:07 +0530, Ritesh Raj Sarraf wrote:
> > Hello Srinivas,
> > 
> > With the Linux 4.10.7 release, I have encountered a regression 
> > introduced on my Lenovo Yoga 2 13, for the ITE Rotation Sensor.
> > 
> > 
> > rrs@learner:~$ lsusb
> > Bus 001 Device 002: ID 8087:8000 Intel Corp. Bus 001 Device 001: ID 
> > 1d6b:0002 Linux Foundation 2.0 root hub Bus 003 Device 001: ID 
> > 1d6b:0003 Linux Foundation 3.0 root hub Bus 002 Device 006: ID 
> > 048d:8350 Integrated Technology Express, Inc.
> > Bus 002 Device 005: ID 0bda:b728 Realtek Semiconductor Corp. Bus 002 
> > Device 004: ID 04f2:b40f Chicony Electronics Co., Ltd Bus 002 Device 
> > 003: ID 04f3:0303 Elan Microelectronics Corp.
> > Bus 002 Device 002: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129 
> > Card Reader Controller Bus 002 Device 001: ID 1d6b:0002 Linux 
> > Foundation 2.0 root hub
> > 2017-04-01 / 14:04:49 ♒♒♒  ☺
> > 
> > 
> > The ITE sensors do not feed any data on the 4.10.7 kernel. Reverting
> > back to
> > 4.10.5, everything works back.
> > 
> > 
> > After a git bisect, the culprit reported is:
> > 
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > [6c2aab07d12436af1cd8d9ac1d117a442cc91eec] iio: hid-sensor-trigger:
> > Change get
> > poll value function order to avoid sensor properties losing after
> > resume from S3
> > 1
> > 
> > Can you please review my findings to confirm that it really is a
> > regression bug
> > ?
> > 
> > 
> > Thanks,
> > Ritesh
> > 
-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

SGkgUml0ZXNoLA0KCUkgZG8gbm90IGhhdmUgdGhlIGVudmlyb25tZW50IHNvIHNob3VsZCBub3Qg
aGF2ZSBhIHRyeSBidXQgSSB0aGluayBTcmluaXZhcydzIHBhdGNoIHNob3VsZCBiZSBPayBmb3Ig
eW91ciBwbGF0Zm9ybS4NClBsZWFzZSBoYXZlIGEgdHJ5Lg0KDQpUaGFua3MgYSBsb3QhDQoNCg0K
QlINClNvbmcgSG9uZ3lhbg0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogUml0
ZXNoIFJhaiBTYXJyYWYgW21haWx0bzpycnNAcmVzZWFyY2h1dC5jb21dIA0KU2VudDogVHVlc2Rh
eSwgQXByaWwgNCwgMjAxNyAzOjE0IEFNDQpUbzogU3Jpbml2YXMgUGFuZHJ1dmFkYSA8c3Jpbml2
YXMucGFuZHJ1dmFkYUBsaW51eC5pbnRlbC5jb20+OyBTb25nLCBIb25neWFuIDxob25neWFuLnNv
bmdAaW50ZWwuY29tPjsgbGludXgtaWlvIDxsaW51eC1paW9Admdlci5rZXJuZWwub3JnPg0KQ2M6
IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNClN1
YmplY3Q6IFJlOiBbU1RBQkxFIFJFR1JFU1NJT05dIGlpbzogaGlkLXNlbnNvci10cmlnZ2VyOiBD
aGFuZ2UgZ2V0IHBvbGwgdmFsdWUgZnVuY3Rpb24gb3JkZXIgdG8gYXZvaWQgc2Vuc29yIHByb3Bl
cnRpZXMgbG9zaW5nIGFmdGVyIHJlc3VtZSBmcm9tIFMzDQoNCkFkZGluZyBTdGFibGUsIExLTUwg
YW5kIElJTyBNTHMuDQoNCkhlbGxvIEhvbmd5YW4sDQoNCkRvIHlvdSBoYXZlIGFueSBmZWVkYmFj
ayA/IFdpdGggdGhlIGJpc2VjdGVkIGNvbW1pdCByZXZlcnRlZCwgSSd2ZSBiZWVuIHN1Y2Nlc3Nm
dWxseSBydW5uaW5nIHRoZSBtYWNoaW5lIHdpdGhvdXQgYW55IGlzc3Vlcy4NCg0KUml0ZXNoDQoN
Cg0KT24gU2F0LCAyMDE3LTA0LTAxIGF0IDA4OjE0IC0wNzAwLCBTcmluaXZhcyBQYW5kcnV2YWRh
IHdyb3RlOg0KPiBIZWxsbyBIb25neWFuLA0KPiANCj4gQ2FuIHlvdSBjaGVjayB0aGUgZmluZGlu
Z3Mgb2YgUml0ZXNoPw0KPiANCj4gVGhhbmtzLA0KPiBTcmluaXZhcw0KPiANCj4gT24gU2F0LCAy
MDE3LTA0LTAxIGF0IDE0OjA3ICswNTMwLCBSaXRlc2ggUmFqIFNhcnJhZiB3cm90ZToNCj4gPiBI
ZWxsbyBTcmluaXZhcywNCj4gPiANCj4gPiBXaXRoIHRoZSBMaW51eCA0LjEwLjcgcmVsZWFzZSwg
SSBoYXZlIGVuY291bnRlcmVkIGEgcmVncmVzc2lvbiANCj4gPiBpbnRyb2R1Y2VkIG9uIG15IExl
bm92byBZb2dhIDIgMTMsIGZvciB0aGUgSVRFIFJvdGF0aW9uIFNlbnNvci4NCj4gPiANCj4gPiAN
Cj4gPiBycnNAbGVhcm5lcjp+JCBsc3VzYg0KPiA+IEJ1cyAwMDEgRGV2aWNlIDAwMjogSUQgODA4
Nzo4MDAwIEludGVsIENvcnAuIEJ1cyAwMDEgRGV2aWNlIDAwMTogSUQgDQo+ID4gMWQ2YjowMDAy
IExpbnV4IEZvdW5kYXRpb24gMi4wIHJvb3QgaHViIEJ1cyAwMDMgRGV2aWNlIDAwMTogSUQgDQo+
ID4gMWQ2YjowMDAzIExpbnV4IEZvdW5kYXRpb24gMy4wIHJvb3QgaHViIEJ1cyAwMDIgRGV2aWNl
IDAwNjogSUQgDQo+ID4gMDQ4ZDo4MzUwIEludGVncmF0ZWQgVGVjaG5vbG9neSBFeHByZXNzLCBJ
bmMuDQo+ID4gQnVzIDAwMiBEZXZpY2UgMDA1OiBJRCAwYmRhOmI3MjggUmVhbHRlayBTZW1pY29u
ZHVjdG9yIENvcnAuIEJ1cyAwMDIgDQo+ID4gRGV2aWNlIDAwNDogSUQgMDRmMjpiNDBmIENoaWNv
bnkgRWxlY3Ryb25pY3MgQ28uLCBMdGQgQnVzIDAwMiBEZXZpY2UgDQo+ID4gMDAzOiBJRCAwNGYz
OjAzMDMgRWxhbiBNaWNyb2VsZWN0cm9uaWNzIENvcnAuDQo+ID4gQnVzIDAwMiBEZXZpY2UgMDAy
OiBJRCAwYmRhOjAxMjkgUmVhbHRlayBTZW1pY29uZHVjdG9yIENvcnAuIFJUUzUxMjkgDQo+ID4g
Q2FyZCBSZWFkZXIgQ29udHJvbGxlciBCdXMgMDAyIERldmljZSAwMDE6IElEIDFkNmI6MDAwMiBM
aW51eCANCj4gPiBGb3VuZGF0aW9uIDIuMCByb290IGh1Yg0KPiA+IDIwMTctMDQtMDEgLyAxNDow
NDo0OSDimZLimZLimZLCoMKg4pi6DQo+ID4gDQo+ID4gDQo+ID4gVGhlIElURSBzZW5zb3JzIGRv
IG5vdCBmZWVkIGFueSBkYXRhIG9uIHRoZSA0LjEwLjcga2VybmVsLiBSZXZlcnRpbmcNCj4gPiBi
YWNrIHRvDQo+ID4gNC4xMC41LCBldmVyeXRoaW5nIHdvcmtzIGJhY2suDQo+ID4gDQo+ID4gDQo+
ID4gQWZ0ZXIgYSBnaXQgYmlzZWN0LCB0aGUgY3VscHJpdCByZXBvcnRlZCBpczoNCj4gPiANCj4g
PiBCaXNlY3Rpbmc6IDAgcmV2aXNpb25zIGxlZnQgdG8gdGVzdCBhZnRlciB0aGlzIChyb3VnaGx5
IDAgc3RlcHMpDQo+ID4gWzZjMmFhYjA3ZDEyNDM2YWYxY2Q4ZDlhYzFkMTE3YTQ0MmNjOTFlZWNd
IGlpbzogaGlkLXNlbnNvci10cmlnZ2VyOg0KPiA+IENoYW5nZSBnZXQNCj4gPiBwb2xsIHZhbHVl
IGZ1bmN0aW9uIG9yZGVyIHRvIGF2b2lkIHNlbnNvciBwcm9wZXJ0aWVzIGxvc2luZyBhZnRlcg0K
PiA+IHJlc3VtZSBmcm9tIFMzDQo+ID4gMQ0KPiA+IA0KPiA+IENhbiB5b3UgcGxlYXNlIHJldmll
dyBteSBmaW5kaW5ncyB0byBjb25maXJtIHRoYXQgaXQgcmVhbGx5IGlzIGENCj4gPiByZWdyZXNz
aW9uIGJ1Zw0KPiA+ID8NCj4gPiANCj4gPiANCj4gPiBUaGFua3MsDQo+ID4gUml0ZXNoDQo+ID4g
DQotLSANClJpdGVzaCBSYWogU2FycmFmDQpSRVNFQVJDSFVUIC0gaHR0cDovL3d3dy5yZXNlYXJj
aHV0LmNvbQ0KIk5lY2Vzc2l0eSBpcyB0aGUgbW90aGVyIG9mIGludmVudGlvbi4iDQo=

Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Ritesh Raj Sarraf]

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> Hi Ritesh,
> 
> Does the attached patch helps?

Thank you Srinivas. I tested your patch on top of 4.10.8 and it is working
perfect.

Ritesh

-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Srinivas Pandruvada]

Hi Hongyan,

Can you check if the patch meets your requirement/needs for ISH?

Thanks,
Srinivas

On Wed, 2017-04-05 at 16:21 +0530, Ritesh Raj Sarraf wrote:
> On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> > 
> > Hi Ritesh,
> > 
> > Does the attached patch helps?
> 
> Thank you Srinivas. I tested your patch on top of 4.10.8 and it is
> working
> perfect.
> 
> Ritesh
> 

RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

Hi Srinivas,
	I have checked the patch dose not meets my requirement for ISH.
With this patch sensor properties still losing after resume from S3.

BR
Song Hongyan

-----Original Message-----
From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com] 
Sent: Wednesday, April 5, 2017 11:36 PM
To: rrs@researchut.com; Song, Hongyan <hongyan.song@intel.com>; linux-iio <linux-iio@vger.kernel.org>
Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

Hi Hongyan,

Can you check if the patch meets your requirement/needs for ISH?

Thanks,
Srinivas

On Wed, 2017-04-05 at 16:21 +0530, Ritesh Raj Sarraf wrote:
> On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> > 
> > Hi Ritesh,
> > 
> > Does the attached patch helps?
> 
> Thank you Srinivas. I tested your patch on top of 4.10.8 and it is 
> working perfect.
> 
> Ritesh
> 

RE: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Song, Hongyan]

SGkgU3Jpbml2YXMsDQoJSSBoYXZlIGNoZWNrZWQgdGhlIHBhdGNoIGRvc2Ugbm90IG1lZXRzIG15
IHJlcXVpcmVtZW50IGZvciBJU0guDQpXaXRoIHRoaXMgcGF0Y2ggc2Vuc29yIHByb3BlcnRpZXMg
c3RpbGwgbG9zaW5nIGFmdGVyIHJlc3VtZSBmcm9tIFMzLg0KDQpCUg0KU29uZyBIb25neWFuDQoN
Ci0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBTcmluaXZhcyBQYW5kcnV2YWRhIFtt
YWlsdG86c3Jpbml2YXMucGFuZHJ1dmFkYUBsaW51eC5pbnRlbC5jb21dIA0KU2VudDogV2VkbmVz
ZGF5LCBBcHJpbCA1LCAyMDE3IDExOjM2IFBNDQpUbzogcnJzQHJlc2VhcmNodXQuY29tOyBTb25n
LCBIb25neWFuIDxob25neWFuLnNvbmdAaW50ZWwuY29tPjsgbGludXgtaWlvIDxsaW51eC1paW9A
dmdlci5rZXJuZWwub3JnPg0KQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5l
bEB2Z2VyLmtlcm5lbC5vcmcNClN1YmplY3Q6IFJlOiBbU1RBQkxFIFJFR1JFU1NJT05dIGlpbzog
aGlkLXNlbnNvci10cmlnZ2VyOiBDaGFuZ2UgZ2V0IHBvbGwgdmFsdWUgZnVuY3Rpb24gb3JkZXIg
dG8gYXZvaWQgc2Vuc29yIHByb3BlcnRpZXMgbG9zaW5nIGFmdGVyIHJlc3VtZSBmcm9tIFMzDQoN
CkhpIEhvbmd5YW4sDQoNCkNhbiB5b3UgY2hlY2sgaWYgdGhlIHBhdGNoIG1lZXRzIHlvdXIgcmVx
dWlyZW1lbnQvbmVlZHMgZm9yIElTSD8NCg0KVGhhbmtzLA0KU3Jpbml2YXMNCg0KT24gV2VkLCAy
MDE3LTA0LTA1IGF0IDE2OjIxICswNTMwLCBSaXRlc2ggUmFqIFNhcnJhZiB3cm90ZToNCj4gT24g
VHVlLCAyMDE3LTA0LTA0IGF0IDE3OjQ0IC0wNzAwLCBTcmluaXZhcyBQYW5kcnV2YWRhIHdyb3Rl
Og0KPiA+IA0KPiA+IEhpIFJpdGVzaCwNCj4gPiANCj4gPiBEb2VzIHRoZSBhdHRhY2hlZCBwYXRj
aCBoZWxwcz8NCj4gDQo+IFRoYW5rIHlvdSBTcmluaXZhcy4gSSB0ZXN0ZWQgeW91ciBwYXRjaCBv
biB0b3Agb2YgNC4xMC44IGFuZCBpdCBpcyANCj4gd29ya2luZyBwZXJmZWN0Lg0KPiANCj4gUml0
ZXNoDQo+IA0K

Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get poll value function order to avoid sensor properties losing after resume from S3

[Srinivas Pandruvada]

On Thu, 2017-04-06 at 04:58 +0000, Song, Hongyan wrote:
> Hi Srinivas,
> 	I have checked the patch dose not meets my requirement for ISH.
> With this patch sensor properties still losing after resume from S3.
What is your test case? I want to try.

Thanks,
Srinivas

> 
> BR
> Song Hongyan
> 
> -----Original Message-----
> From: Srinivas Pandruvada [mailto:srinivas.pandruvada@linux.intel.com
> ] 
> Sent: Wednesday, April 5, 2017 11:36 PM
> To: rrs@researchut.com; Song, Hongyan <hongyan.song@intel.com>;
> linux-iio <linux-iio@vger.kernel.org>
> Cc: stable@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [STABLE REGRESSION] iio: hid-sensor-trigger: Change get
> poll value function order to avoid sensor properties losing after
> resume from S3
> 
> Hi Hongyan,
> 
> Can you check if the patch meets your requirement/needs for ISH?
> 
> Thanks,
> Srinivas
> 
> On Wed, 2017-04-05 at 16:21 +0530, Ritesh Raj Sarraf wrote:
> > 
> > On Tue, 2017-04-04 at 17:44 -0700, Srinivas Pandruvada wrote:
> > > 
> > > 
> > > Hi Ritesh,
> > > 
> > > Does the attached patch helps?
> > Thank you Srinivas. I tested your patch on top of 4.10.8 and it is 
> > working perfect.
> > 
> > Ritesh
> >