All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: gnomes@lxorguk.ukuu.org.uk, linux-efi@vger.kernel.org,
	matthew.garrett@nebula.com, gregkh@linuxfoundation.org,
	dhowells@redhat.com, linux-security-module@vger.kernel.org,
	keyrings@vger.kernel.org
Subject: [PATCH 04/24] Enforce module signatures if the kernel is locked down
Date: Wed, 05 Apr 2017 18:07:33 +0100	[thread overview]
Message-ID: <149141205298.30815.17897944535456597946.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <149141201983.30815.1240162780237131881.stgit@warthog.procyon.org.uk>

If the kernel is locked down, require that all modules have valid
signatures that we can verify.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 kernel/module.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index 7eba6dea4f41..3331f2eb9b93 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2756,7 +2756,7 @@ static int module_sig_check(struct load_info *info, int flags)
 	}
 
 	/* Not having a signature is only an error if we're strict. */
-	if (err == -ENOKEY && !sig_enforce)
+	if (err == -ENOKEY && !sig_enforce && !kernel_is_locked_down())
 		err = 0;
 
 	return err;

WARNING: multiple messages have this Message-ID (diff)
From: dhowells@redhat.com (David Howells)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 04/24] Enforce module signatures if the kernel is locked down
Date: Wed, 05 Apr 2017 18:07:33 +0100	[thread overview]
Message-ID: <149141205298.30815.17897944535456597946.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <149141201983.30815.1240162780237131881.stgit@warthog.procyon.org.uk>

If the kernel is locked down, require that all modules have valid
signatures that we can verify.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 kernel/module.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index 7eba6dea4f41..3331f2eb9b93 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2756,7 +2756,7 @@ static int module_sig_check(struct load_info *info, int flags)
 	}
 
 	/* Not having a signature is only an error if we're strict. */
-	if (err == -ENOKEY && !sig_enforce)
+	if (err == -ENOKEY && !sig_enforce && !kernel_is_locked_down())
 		err = 0;
 
 	return err;

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-04-05 17:08 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-05 17:07 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 17:07 ` David Howells
2017-04-05 17:07 ` [PATCH 01/24] efi: Add EFI_SECURE_BOOT bit David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:07 ` [PATCH 02/24] Add the ability to lock down access to the running kernel image David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:07 ` [PATCH 03/24] efi: Lock down the kernel if booted in secure boot mode David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:07 ` David Howells [this message]
2017-04-05 17:07   ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2017-04-05 17:07 ` [PATCH 05/24] Restrict /dev/mem and /dev/kmem when " David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:07 ` [PATCH 06/24] Add a sysrq option to exit secure boot mode David Howells
2017-04-05 17:07   ` David Howells
2017-04-05 17:08 ` [PATCH 07/24] kexec: Disable at runtime if the kernel is locked down David Howells
2017-04-05 17:08   ` David Howells
2017-04-05 17:08   ` David Howells
2017-04-05 17:08 ` [PATCH 08/24] Copy secure_boot flag in boot params across kexec reboot David Howells
2017-04-05 17:08   ` David Howells
2017-04-07 16:32 ` [PATCH 00/24] Kernel lockdown Justin Forbes
2017-04-07 16:32   ` Justin Forbes
2017-04-05 17:09 David Howells
2017-04-05 17:10 ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2017-04-05 17:10   ` David Howells
2017-04-05 17:10   ` David Howells
2017-04-05 20:14 [PATCH 00/24] Kernel lockdown David Howells
2017-04-05 20:15 ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2017-04-05 20:15   ` David Howells
2018-04-11 16:24 [PATCH 00/24] security: Add kernel lockdown David Howells
2018-04-11 16:25 ` [PATCH 04/24] Enforce module signatures if the kernel is locked down David Howells
2018-04-11 16:25   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=149141205298.30815.17897944535456597946.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.