All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
@ 2017-04-06  8:33 Kevin JOLY
  2017-04-06 20:36 ` Thomas Petazzoni
  2017-04-10 10:20 ` Arnout Vandecappelle
  0 siblings, 2 replies; 16+ messages in thread
From: Kevin JOLY @ 2017-04-06  8:33 UTC (permalink / raw)
  To: buildroot

Add support for libgphoto2 core library designed to allow access to digital camera.

Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/libgphoto2/Config.in       | 11 +++++++++++
 package/libgphoto2/libgphoto2.hash |  6 ++++++
 package/libgphoto2/libgphoto2.mk   | 29 +++++++++++++++++++++++++++++
 5 files changed, 50 insertions(+)
 create mode 100644 package/libgphoto2/Config.in
 create mode 100644 package/libgphoto2/libgphoto2.hash
 create mode 100644 package/libgphoto2/libgphoto2.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index e1713cf..09d7085 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -956,6 +956,9 @@ F:	package/cpuload/
 F:	package/bwm-ng/
 F:	package/ramsmp/
 
+N:	Kevin Joly <kevin.joly@sensefly.com>
+F:	package/libgphoto2/
+
 N:	Laurent Cans <laurent.cans@gmail.com>
 F:	package/aircrack-ng/
 
diff --git a/package/Config.in b/package/Config.in
index fe4c0ae..e17ee6f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1085,6 +1085,7 @@ menu "Hardware handling"
 	source "package/libfreefare/Config.in"
 	source "package/libftdi/Config.in"
 	source "package/libftdi1/Config.in"
+	source "package/libgphoto2/Config.in"
 	source "package/libgpiod/Config.in"
 	source "package/libgudev/Config.in"
 	source "package/libhid/Config.in"
diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
new file mode 100644
index 0000000..1626667
--- /dev/null
+++ b/package/libgphoto2/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBGPHOTO2
+	select BR2_PACKAGE_LIBTOOL
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_LIBUSB_COMPAT
+	select BR2_PACKAGE_LIBXML2
+	bool "libgphoto2"
+	help
+	  libgphoto2 is the core library designed to allow access to
+	  digital camera by external programs.
+
+	  http://gphoto.org/
diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
new file mode 100644
index 0000000..2e659ab
--- /dev/null
+++ b/package/libgphoto2/libgphoto2.hash
@@ -0,0 +1,6 @@
+# https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
+md5 a5999acc204c31515a6ec8e517d2cd91 libgphoto2-2.5.12.tar.bz2
+sha1 4ded403b87d46ad49ba88b22b9410789ed3cef10 libgphoto2-2.5.12.tar.bz2
+
+# Locally calculated hash
+sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e	libgphoto2-2.5.12.tar.bz2
diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
new file mode 100644
index 0000000..354c29a
--- /dev/null
+++ b/package/libgphoto2/libgphoto2.mk
@@ -0,0 +1,29 @@
+################################################################################
+#
+# libgphoto2
+#
+################################################################################
+
+LIBGPHOTO2_VERSION = 2.5.12
+LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.bz2
+LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
+LIBGPHOTO2_INSTALL_STAGING = YES
+
+LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
+
+ifeq ($(BR2_PACKAGE_LIBEXIF),y)
+LIBGPHOTO2_DEPENDENCIES += libexif
+endif
+
+ifeq ($(BR2_PACKAGE_LIBJPEG),y)
+LIBGPHOTO2_DEPENDENCIES += libjpeg
+endif
+
+ifeq ($(BR2_PACKAGE_GD),y)
+LIBGPHOTO2_DEPENDENCIES += gd
+endif
+
+LIBGPHOTO2_LICENSE = LGPLv2.1+
+LIBGPHOTO2_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-06  8:33 [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package Kevin JOLY
@ 2017-04-06 20:36 ` Thomas Petazzoni
  2017-04-07  5:14   ` Kevin JOLY
  2017-04-10 10:20 ` Arnout Vandecappelle
  1 sibling, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2017-04-06 20:36 UTC (permalink / raw)
  To: buildroot

Hello,

On Thu, 6 Apr 2017 10:33:12 +0200, Kevin JOLY wrote:
> Add support for libgphoto2 core library designed to allow access to digital camera.
> 
> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
> ---
>  DEVELOPERS                         |  3 +++
>  package/Config.in                  |  1 +
>  package/libgphoto2/Config.in       | 11 +++++++++++
>  package/libgphoto2/libgphoto2.hash |  6 ++++++
>  package/libgphoto2/libgphoto2.mk   | 29 +++++++++++++++++++++++++++++
>  5 files changed, 50 insertions(+)
>  create mode 100644 package/libgphoto2/Config.in
>  create mode 100644 package/libgphoto2/libgphoto2.hash
>  create mode 100644 package/libgphoto2/libgphoto2.mk

Thanks for this patch. However:

 - You already posted a patch for the same package on March, 13th, but
   you don't explain how this version is different. This patch is not
   even identified as a new iteration. What changed?

 - Romain Naour submitted on March 5 a patch adding libgphoto2, so your
   proposal seems a bit redundant with Romain's patch. Have you taken
   over Romain's patch? I'm adding Romain in Cc here.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-06 20:36 ` Thomas Petazzoni
@ 2017-04-07  5:14   ` Kevin JOLY
  2017-04-07 20:52     ` Romain Naour
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin JOLY @ 2017-04-07  5:14 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

I was talking with Romain on this mailing list and he had concern about 
license and dependencies of libgphoto2. I contacted the developpers of 
libgphoto2 to ensure that the license type was correct. I also turned 
the libexif, jpeg and gd dependencies as optional.

Anyway, if the patch is in the pipe, everything is fine. I re-submitted 
it because I didn't saw it was already on patchwork but I didn't wanted 
to be redundant with it.

Thank you

Kevin JOLY

Le 06. 04. 17 ? 22:36, Thomas Petazzoni a ?crit :
> Hello,
>
> On Thu, 6 Apr 2017 10:33:12 +0200, Kevin JOLY wrote:
>> Add support for libgphoto2 core library designed to allow access to digital camera.
>>
>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>> ---
>>   DEVELOPERS                         |  3 +++
>>   package/Config.in                  |  1 +
>>   package/libgphoto2/Config.in       | 11 +++++++++++
>>   package/libgphoto2/libgphoto2.hash |  6 ++++++
>>   package/libgphoto2/libgphoto2.mk   | 29 +++++++++++++++++++++++++++++
>>   5 files changed, 50 insertions(+)
>>   create mode 100644 package/libgphoto2/Config.in
>>   create mode 100644 package/libgphoto2/libgphoto2.hash
>>   create mode 100644 package/libgphoto2/libgphoto2.mk
> Thanks for this patch. However:
>
>   - You already posted a patch for the same package on March, 13th, but
>     you don't explain how this version is different. This patch is not
>     even identified as a new iteration. What changed?
>
>   - Romain Naour submitted on March 5 a patch adding libgphoto2, so your
>     proposal seems a bit redundant with Romain's patch. Have you taken
>     over Romain's patch? I'm adding Romain in Cc here.
>
> Thanks!
>
> Thomas

-- 

*Kevin JOLY*
Embedded systems engineer

SenseFly <http://www.sensefly.com/>
38, rte de Gen?ve
1033 Cheseaux-Lausanne, Switzerland

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170407/14948f39/attachment.html>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-07  5:14   ` Kevin JOLY
@ 2017-04-07 20:52     ` Romain Naour
  2017-04-10  9:24       ` Kevin JOLY
  0 siblings, 1 reply; 16+ messages in thread
From: Romain Naour @ 2017-04-07 20:52 UTC (permalink / raw)
  To: buildroot

Hi Kevin, Thomas,

Le 07/04/2017 ? 07:14, Kevin JOLY a ?crit :
> Hello Thomas,
> 
> I was talking with Romain on this mailing list and he had concern about license
> and dependencies of libgphoto2. I contacted the developpers of libgphoto2 to
> ensure that the license type was correct. I also turned the libexif, jpeg and gd
> dependencies as optional.
> 
> Anyway, if the patch is in the pipe, everything is fine. I re-submitted it
> because I didn't saw it was already on patchwork but I didn't wanted to be
> redundant with it.

Indeed, I've posted a patch adding libgphoto2 in Buildroot some day before your
initial submission [1], but it's ok since you're working on it.

It would be great if you add a small changlog between each iteration, see [2]
(21.5.4. Patch revision changelog). That's why Thomas asked what changed in your
last submission.

Also, can you check this new package with the new test-pkg script ? [3]
(17.20.2. How to test your package).

I'll review it later this week-end.
I'll mark my initial patch superseded in the patchwork.

Best regards,
Romain

[1] http://patchwork.ozlabs.org/patch/735448/
[2] http://nightly.buildroot.org/manual.html#submitting-patches
[3] http://nightly.buildroot.org/manual.html#_tips_and_tricks
> 
> Thank you
> 
> Kevin JOLY
> 
> Le 06. 04. 17 ? 22:36, Thomas Petazzoni a ?crit :
>> Hello,
>>
>> On Thu, 6 Apr 2017 10:33:12 +0200, Kevin JOLY wrote:
>>> Add support for libgphoto2 core library designed to allow access to digital camera.
>>>
>>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>>> ---
>>>  DEVELOPERS                         |  3 +++
>>>  package/Config.in                  |  1 +
>>>  package/libgphoto2/Config.in       | 11 +++++++++++
>>>  package/libgphoto2/libgphoto2.hash |  6 ++++++
>>>  package/libgphoto2/libgphoto2.mk   | 29 +++++++++++++++++++++++++++++
>>>  5 files changed, 50 insertions(+)
>>>  create mode 100644 package/libgphoto2/Config.in
>>>  create mode 100644 package/libgphoto2/libgphoto2.hash
>>>  create mode 100644 package/libgphoto2/libgphoto2.mk
>> Thanks for this patch. However:
>>
>>  - You already posted a patch for the same package on March, 13th, but
>>    you don't explain how this version is different. This patch is not
>>    even identified as a new iteration. What changed?
>>
>>  - Romain Naour submitted on March 5 a patch adding libgphoto2, so your
>>    proposal seems a bit redundant with Romain's patch. Have you taken
>>    over Romain's patch? I'm adding Romain in Cc here.
>>
>> Thanks!
>>
>> Thomas
> 
> -- 
> 
> *Kevin JOLY*
> Embedded systems engineer
> 
> SenseFly <http://www.sensefly.com/>
> 38, rte de Gen?ve
> 1033 Cheseaux-Lausanne, Switzerland
> 
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-07 20:52     ` Romain Naour
@ 2017-04-10  9:24       ` Kevin JOLY
  2017-04-10 11:45         ` Thomas Petazzoni
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin JOLY @ 2017-04-10  9:24 UTC (permalink / raw)
  To: buildroot

Hi Romain, Thomas,


Le 07. 04. 17 ? 22:52, Romain Naour a ?crit :
> Hi Kevin, Thomas,
>
> Le 07/04/2017 ? 07:14, Kevin JOLY a ?crit :
>> Hello Thomas,
>>
>> I was talking with Romain on this mailing list and he had concern about license
>> and dependencies of libgphoto2. I contacted the developpers of libgphoto2 to
>> ensure that the license type was correct. I also turned the libexif, jpeg and gd
>> dependencies as optional.
>>
>> Anyway, if the patch is in the pipe, everything is fine. I re-submitted it
>> because I didn't saw it was already on patchwork but I didn't wanted to be
>> redundant with it.
> Indeed, I've posted a patch adding libgphoto2 in Buildroot some day before your
> initial submission [1], but it's ok since you're working on it.
>
> It would be great if you add a small changlog between each iteration, see [2]
> (21.5.4. Patch revision changelog). That's why Thomas asked what changed in your
> last submission.
Ok, I submitted the v2 right before this email. Sorry about that, I'm 
still a newbie in patch revision!
>
> Also, can you check this new package with the new test-pkg script ? [3]
> (17.20.2. How to test your package).
I ran the test. Everything was OK except br-arm-cortex-m4-full and 
br-arm-full-nothread.
>
> I'll review it later this week-end.
> I'll mark my initial patch superseded in the patchwork.
>
> Best regards,
> Romain
>
> [1] http://patchwork.ozlabs.org/patch/735448/
> [2] http://nightly.buildroot.org/manual.html#submitting-patches
> [3] http://nightly.buildroot.org/manual.html#_tips_and_tricks
>> Thank you
>>
>> Kevin JOLY
>>
>> Le 06. 04. 17 ? 22:36, Thomas Petazzoni a ?crit :
>>> Hello,
>>>
>>> On Thu, 6 Apr 2017 10:33:12 +0200, Kevin JOLY wrote:
>>>> Add support for libgphoto2 core library designed to allow access to digital camera.
>>>>
>>>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>>>> ---
>>>>   DEVELOPERS                         |  3 +++
>>>>   package/Config.in                  |  1 +
>>>>   package/libgphoto2/Config.in       | 11 +++++++++++
>>>>   package/libgphoto2/libgphoto2.hash |  6 ++++++
>>>>   package/libgphoto2/libgphoto2.mk   | 29 +++++++++++++++++++++++++++++
>>>>   5 files changed, 50 insertions(+)
>>>>   create mode 100644 package/libgphoto2/Config.in
>>>>   create mode 100644 package/libgphoto2/libgphoto2.hash
>>>>   create mode 100644 package/libgphoto2/libgphoto2.mk
>>> Thanks for this patch. However:
>>>
>>>   - You already posted a patch for the same package on March, 13th, but
>>>     you don't explain how this version is different. This patch is not
>>>     even identified as a new iteration. What changed?
>>>
>>>   - Romain Naour submitted on March 5 a patch adding libgphoto2, so your
>>>     proposal seems a bit redundant with Romain's patch. Have you taken
>>>     over Romain's patch? I'm adding Romain in Cc here.
>>>
>>> Thanks!
>>>
>>> Thomas
>> -- 
>>
>> *Kevin JOLY*
>> Embedded systems engineer
>>
>> SenseFly <http://www.sensefly.com/>
>> 38, rte de Gen?ve
>> 1033 Cheseaux-Lausanne, Switzerland
>>
>>
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>>

Best regards,

-- 

*Kevin JOLY*
Embedded systems engineer

SenseFly <http://www.sensefly.com/>
38, rte de Gen?ve
1033 Cheseaux-Lausanne, Switzerland

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170410/c0a64a0b/attachment.html>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-06  8:33 [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package Kevin JOLY
  2017-04-06 20:36 ` Thomas Petazzoni
@ 2017-04-10 10:20 ` Arnout Vandecappelle
  2017-04-10 12:23   ` Kevin JOLY
  1 sibling, 1 reply; 16+ messages in thread
From: Arnout Vandecappelle @ 2017-04-10 10:20 UTC (permalink / raw)
  To: buildroot

 Hi Kevin,

 Some more feedback on your patch...

 A better summary line would be

libgphoto2: new package

On 06-04-17 10:33, Kevin JOLY wrote:
> Add support for libgphoto2 core library designed to allow access to digital camera.

 The commit message text should be wrapped at 72 columns.


> 
> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>

 Since Romain also worked on this package, it's nice to add

Cc: Romain Naour <romain.naour@gmail.com>

This makes sure that:
- Romain will be in Cc when you use git send-email;
- In the git history, it will be visible that Romain was involved.

[snip]
> diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
> new file mode 100644
> index 0000000..1626667
> --- /dev/null
> +++ b/package/libgphoto2/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_LIBGPHOTO2
> +	select BR2_PACKAGE_LIBTOOL
> +	select BR2_PACKAGE_LIBUSB
> +	select BR2_PACKAGE_LIBUSB_COMPAT

 Is libusb-compat really needed? It seems to be only used if libusb1 isn't
found. Also, as far as I can see in the configure script, this is optional (you
just loose most of the ports).

> +	select BR2_PACKAGE_LIBXML2

 In your reply to v1, you mentioned that br-arm-full-nothread failed. That seems
to indicate that it should depend on BR2_TOOLCHAIN_HAS_THREADS (with the
appropriate comment in case of !BR2_TOOLCHAIN_HAS_THREADS). But anyway, this
dependency is already needed for libusb. So if the package itself doesn't
require threads (just grep for "pthread", and check whether or not it's escaped
by some #ifdef), you should say:

	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb


> +	bool "libgphoto2"
> +	help
> +	  libgphoto2 is the core library designed to allow access to
> +	  digital camera by external programs.
> +
> +	  http://gphoto.org/

 For libgphoto2 itself:

http://gphoto.org/proj/libgphoto2/

> diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
> new file mode 100644
> index 0000000..2e659ab
> --- /dev/null
> +++ b/package/libgphoto2/libgphoto2.hash
> @@ -0,0 +1,6 @@
> +# https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
> +md5 a5999acc204c31515a6ec8e517d2cd91 libgphoto2-2.5.12.tar.bz2
> +sha1 4ded403b87d46ad49ba88b22b9410789ed3cef10 libgphoto2-2.5.12.tar.bz2
> +
> +# Locally calculated hash
> +sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e	libgphoto2-2.5.12.tar.bz2
> diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
> new file mode 100644
> index 0000000..354c29a
> --- /dev/null
> +++ b/package/libgphoto2/libgphoto2.mk
> @@ -0,0 +1,29 @@
> +################################################################################
> +#
> +# libgphoto2
> +#
> +################################################################################
> +
> +LIBGPHOTO2_VERSION = 2.5.12

 There's a 2.5.13 out now.

> +LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.bz2
> +LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)

 The website itself points to github, and the repository is maintained on github
(no commits in sourceforge since 2015), so I'd tend to say that you should use
the github download. However, the github download is just the autogenerated one
which doesn't contain a configure script, so indeed it's better to use
sourceforge. Still, it's better to add a comment about that:

# Project is maintained on github but github tarball doesn't have configure


> +LIBGPHOTO2_INSTALL_STAGING = YES
> +
> +LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf

 It looks like there are some configure options you may want to pass explicitly,
like --disable-rpm. The package also installs a lot of stuff in non-standard
locations, it would be good to check if the defaults are appropriate. Also take
a look at README.packaging.

> +
> +ifeq ($(BR2_PACKAGE_LIBEXIF),y)
> +LIBGPHOTO2_DEPENDENCIES += libexif

> +endif
> +
> +ifeq ($(BR2_PACKAGE_LIBJPEG),y)
> +LIBGPHOTO2_DEPENDENCIES += libjpeg

 Please add an explicit
LIBGPHOTO2_CONF_OPTS += --with-jpeg
else
LIBGPHOTO2_CONF_OPTS += --without-jpeg

 Ideally also for exif and gd, but it seems there are no options for those.

> +endif
> +
> +ifeq ($(BR2_PACKAGE_GD),y)
> +LIBGPHOTO2_DEPENDENCIES += gd
> +endif
> +
> +LIBGPHOTO2_LICENSE = LGPLv2.1+

 We switched completely to SPDX license strings, so LGPL-2.1+

> +LIBGPHOTO2_LICENSE_FILES = COPYING

 We typically put the license info near the top, just above or below the initial
DEPENDENCIES.

 It looks like some of the camlibs are actually GPL-2.0+ or LGPL-3+, and some
are LGPL-2.0 only. So the complete string should be:

LIBGPHOTO2_LICENSE = LGPLv2.1+, GPL-2.0 (adc65), GPL-2.0+ (some camlibs), \
	LGPL-2.0 (sipix), LGPL-3.0+ (pentax), BSD-3-Clause (ax203/tinyjpeg).

I couldn't find any license files for all the other licenses, so add a comment

# No license files for other licenses

 It would be good to double-check all of the above...

 Regards,
 Arnout

> +
> +$(eval $(autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-10  9:24       ` Kevin JOLY
@ 2017-04-10 11:45         ` Thomas Petazzoni
  2017-04-10 12:01           ` Arnout Vandecappelle
  0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2017-04-10 11:45 UTC (permalink / raw)
  To: buildroot

Hello,

Thanks for your new iteration of the libgphoto2 patch!

On Mon, 10 Apr 2017 11:24:32 +0200, Kevin JOLY wrote:

> > Also, can you check this new package with the new test-pkg script ? [3]
> > (17.20.2. How to test your package).  
> I ran the test. Everything was OK except br-arm-cortex-m4-full and 
> br-arm-full-nothread.

What errors did you had with those toolchains? Did you fix those issue
in your v2?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-10 11:45         ` Thomas Petazzoni
@ 2017-04-10 12:01           ` Arnout Vandecappelle
  0 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2017-04-10 12:01 UTC (permalink / raw)
  To: buildroot



On 10-04-17 13:45, Thomas Petazzoni wrote:
> Hello,
> 
> Thanks for your new iteration of the libgphoto2 patch!
> 
> On Mon, 10 Apr 2017 11:24:32 +0200, Kevin JOLY wrote:
> 
>>> Also, can you check this new package with the new test-pkg script ? [3]
>>> (17.20.2. How to test your package).  
>> I ran the test. Everything was OK except br-arm-cortex-m4-full and 
>> br-arm-full-nothread.
> 
> What errors did you had with those toolchains? Did you fix those issue
> in your v2?

 I expect br-arm-cortex-m4-full runs into the elf2flt segfault, and
br-arm-full-nothread fails because it depends on threads (as mentioned in my
review).

 Regards,
 Arnout

> 
> Thanks!
> 
> Thomas
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-10 10:20 ` Arnout Vandecappelle
@ 2017-04-10 12:23   ` Kevin JOLY
  2017-04-10 13:28     ` Arnout Vandecappelle
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin JOLY @ 2017-04-10 12:23 UTC (permalink / raw)
  To: buildroot

Hi Arnout,


Le 10. 04. 17 ? 12:20, Arnout Vandecappelle a ?crit :
>   Hi Kevin,
>
>   Some more feedback on your patch...
>
>   A better summary line would be
>
> libgphoto2: new package
>
> On 06-04-17 10:33, Kevin JOLY wrote:
>> Add support for libgphoto2 core library designed to allow access to digital camera.
>   The commit message text should be wrapped at 72 columns.
>
>
>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>   Since Romain also worked on this package, it's nice to add
>
> Cc: Romain Naour <romain.naour@gmail.com>
>
> This makes sure that:
> - Romain will be in Cc when you use git send-email;
> - In the git history, it will be visible that Romain was involved.
>
> [snip]
>> diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
>> new file mode 100644
>> index 0000000..1626667
>> --- /dev/null
>> +++ b/package/libgphoto2/Config.in
>> @@ -0,0 +1,11 @@
>> +config BR2_PACKAGE_LIBGPHOTO2
>> +	select BR2_PACKAGE_LIBTOOL
>> +	select BR2_PACKAGE_LIBUSB
>> +	select BR2_PACKAGE_LIBUSB_COMPAT
>   Is libusb-compat really needed? It seems to be only used if libusb1 isn't
> found. Also, as far as I can see in the configure script, this is optional (you
> just loose most of the ports).
You're right, this one is also optional.
>> +	select BR2_PACKAGE_LIBXML2
>   In your reply to v1, you mentioned that br-arm-full-nothread failed. That seems
> to indicate that it should depend on BR2_TOOLCHAIN_HAS_THREADS (with the
> appropriate comment in case of !BR2_TOOLCHAIN_HAS_THREADS). But anyway, this
> dependency is already needed for libusb. So if the package itself doesn't
> require threads (just grep for "pthread", and check whether or not it's escaped
> by some #ifdef), you should say:
>
> 	depends on BR2_TOOLCHAIN_HAS_THREADS # libusb
pthread was not found in the source code of libgphoto2 itself so I guess 
it is only for libusb. I added the depends on and the comment.
>
>> +	bool "libgphoto2"
>> +	help
>> +	  libgphoto2 is the core library designed to allow access to
>> +	  digital camera by external programs.
>> +
>> +	  http://gphoto.org/
>   For libgphoto2 itself:
>
> http://gphoto.org/proj/libgphoto2/
>
>> diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
>> new file mode 100644
>> index 0000000..2e659ab
>> --- /dev/null
>> +++ b/package/libgphoto2/libgphoto2.hash
>> @@ -0,0 +1,6 @@
>> +# https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
>> +md5 a5999acc204c31515a6ec8e517d2cd91 libgphoto2-2.5.12.tar.bz2
>> +sha1 4ded403b87d46ad49ba88b22b9410789ed3cef10 libgphoto2-2.5.12.tar.bz2
>> +
>> +# Locally calculated hash
>> +sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e	libgphoto2-2.5.12.tar.bz2
>> diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
>> new file mode 100644
>> index 0000000..354c29a
>> --- /dev/null
>> +++ b/package/libgphoto2/libgphoto2.mk
>> @@ -0,0 +1,29 @@
>> +################################################################################
>> +#
>> +# libgphoto2
>> +#
>> +################################################################################
>> +
>> +LIBGPHOTO2_VERSION = 2.5.12
>   There's a 2.5.13 out now.
>
>> +LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.bz2
>> +LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
>   The website itself points to github, and the repository is maintained on github
> (no commits in sourceforge since 2015), so I'd tend to say that you should use
> the github download. However, the github download is just the autogenerated one
> which doesn't contain a configure script, so indeed it's better to use
> sourceforge. Still, it's better to add a comment about that:
>
> # Project is maintained on github but github tarball doesn't have configure
>
>
>> +LIBGPHOTO2_INSTALL_STAGING = YES
>> +
>> +LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
>   It looks like there are some configure options you may want to pass explicitly,
> like --disable-rpm. The package also installs a lot of stuff in non-standard
> locations, it would be good to check if the defaults are appropriate. Also take
> a look at README.packaging.
Where did you find the --disable-rpm ? By non-standard location, do you 
mean the udevscriptdir and the utilsdir?
>
>> +
>> +ifeq ($(BR2_PACKAGE_LIBEXIF),y)
>> +LIBGPHOTO2_DEPENDENCIES += libexif
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_LIBJPEG),y)
>> +LIBGPHOTO2_DEPENDENCIES += libjpeg
>   Please add an explicit
> LIBGPHOTO2_CONF_OPTS += --with-jpeg
> else
> LIBGPHOTO2_CONF_OPTS += --without-jpeg
>
>   Ideally also for exif and gd, but it seems there are no options for those.
I found --with-gdlib=[auto|no] and --with-libexif=[auto|no]
>
>> +endif
>> +
>> +ifeq ($(BR2_PACKAGE_GD),y)
>> +LIBGPHOTO2_DEPENDENCIES += gd
>> +endif
>> +
>> +LIBGPHOTO2_LICENSE = LGPLv2.1+
>   We switched completely to SPDX license strings, so LGPL-2.1+
>
>> +LIBGPHOTO2_LICENSE_FILES = COPYING
>   We typically put the license info near the top, just above or below the initial
> DEPENDENCIES.
>
>   It looks like some of the camlibs are actually GPL-2.0+ or LGPL-3+, and some
> are LGPL-2.0 only. So the complete string should be:
>
> LIBGPHOTO2_LICENSE = LGPLv2.1+, GPL-2.0 (adc65), GPL-2.0+ (some camlibs), \
> 	LGPL-2.0 (sipix), LGPL-3.0+ (pentax), BSD-3-Clause (ax203/tinyjpeg).
>
> I couldn't find any license files for all the other licenses, so add a comment
>
> # No license files for other licenses
>
>   It would be good to double-check all of the above...
>
>   Regards,
>   Arnout
>
>> +
>> +$(eval $(autotools-package))
>>

Best regards,

-- 

*Kevin JOLY*
Embedded systems engineer

SenseFly <http://www.sensefly.com/>
38, rte de Gen?ve
1033 Cheseaux-Lausanne, Switzerland

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170410/80c69737/attachment.html>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-04-10 12:23   ` Kevin JOLY
@ 2017-04-10 13:28     ` Arnout Vandecappelle
  0 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2017-04-10 13:28 UTC (permalink / raw)
  To: buildroot



On 10-04-17 14:23, Kevin JOLY wrote:
> Hi Arnout,
> 
> 
> Le 10. 04. 17 ? 12:20, Arnout Vandecappelle a ?crit :

[snip]
>>  It looks like there are some configure options you may want to pass explicitly,
>> like --disable-rpm. The package also installs a lot of stuff in non-standard
>> locations, it would be good to check if the defaults are appropriate. Also take
>> a look at README.packaging.
> Where did you find the --disable-rpm ? 

 I misread the configure.ac (gphoto-m4/gp-packaging.m4 actually). It's in fact
--without-rpmbuild.

> By non-standard location, do you mean the
> udevscriptdir and the utilsdir?

 Yes, udevscriptdir. utilsdir is OK.


 Regards,
 Arnout

[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-03-16 23:17     ` Romain Naour
@ 2017-04-06  8:31       ` Kevin JOLY
  0 siblings, 0 replies; 16+ messages in thread
From: Kevin JOLY @ 2017-04-06  8:31 UTC (permalink / raw)
  To: buildroot

Hello Romain,


Le 17. 03. 17 ? 00:17, Romain Naour a ?crit :
> Hi Kevin,
>
> Le 09/03/2017 ? 07:52, Kevin JOLY a ?crit :
>> Hi Romain,
>>
>> Thanks a lot for your comments!
> You're welcome!
>
>>
>> Le 08. 03. 17 ? 21:10, Romain Naour a ?crit :
>>> Hi Kevin,
>>>
>>> Thanks for this contribution.
>>>
>>> I recently sent a patch adding libgphoto2 for Darktable [1].
>>> There are small differences with your patch (mostly package dependencies), can
>>> you comment on it ?
>>>
>>> Thanks!
>>>
>>> [1] http://patchwork.ozlabs.org/patch/735448/
>>>
>>> Le 08/03/2017 ? 14:38, Kevin JOLY a ?crit :
>>>> Add support for libgphoto2 core library designed to allow access to digital camera.
>>>>
>>>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>>>> ---
>>> We recommend to add yourself as package maintainer in DEVELOPERS file, see:
>>> http://nightly.buildroot.org/manual.html#DEVELOPERS
>> Ok
>>>>   package/Config.in                  |  1 +
>>>>   package/libgphoto2/Config.in       | 10 ++++++++++
>>>>   package/libgphoto2/libgphoto2.hash |  3 +++
>>>>   package/libgphoto2/libgphoto2.mk   | 14 ++++++++++++++
>>>>   4 files changed, 28 insertions(+)
>>>>   create mode 100644 package/libgphoto2/Config.in
>>>>   create mode 100644 package/libgphoto2/libgphoto2.hash
>>>>   create mode 100644 package/libgphoto2/libgphoto2.mk
>>>>
>>>> diff --git a/package/Config.in b/package/Config.in
>>>> index 9eb6a22..69430c3 100644
>>>> --- a/package/Config.in
>>>> +++ b/package/Config.in
>>>> @@ -1073,6 +1073,7 @@ menu "Hardware handling"
>>>>   	source "package/libfreefare/Config.in"
>>>>   	source "package/libftdi/Config.in"
>>>>   	source "package/libftdi1/Config.in"
>>>> +	source "package/libgphoto2/Config.in"
>>>>   	source "package/libgpiod/Config.in"
>>>>   	source "package/libgudev/Config.in"
>>>>   	source "package/libhid/Config.in"
>>>> diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
>>>> new file mode 100644
>>>> index 0000000..ba1d535
>>>> --- /dev/null
>>>> +++ b/package/libgphoto2/Config.in
>>>> @@ -0,0 +1,10 @@
>>>> +config BR2_PACKAGE_LIBGPHOTO2
>>>> +	select BR2_PACKAGE_LIBTOOL
>>>> +	select BR2_PACKAGE_LIBUSB
>>>> +	select BR2_PACKAGE_LIBUSB_COMPAT
>>>> +	select BR2_PACKAGE_LIBXML2
>>> I added gd, jpeg, libexif and lockev package as mandatory dependencies, They may
>>> be optional... can you check ?
>>>
>>> You can compare with archlinux packaging for exemple:
>>>
>>> depends=(libexif libjpeg gd libltdl libusb libxml2)
>>>
>>> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libgphoto2
>> According to the figure 5.1 of their online manual [1], libexif is optionnal. I
>> also noticed in the source code of libgphoto2 that there is several #ifdef
>> HAVE_LIBGD, #ifdef HAVE_LIBJPEG, #ifdef HAVE_LOCKDEV//so that I assumed them
>> optional. For libxml2 I was not able to compile the package without it. I got :
>> ERROR: unsafe header/library path used in cross-compilation:
>> '-I/usr/include/libxml2'
>>
>> Do you would like me to add them by default in order to keep the full feature set ?
> No, we prefer to add only the mandatory dependencies when the package is added
> and add optional dependencies in followup patches.
> So you're probably right, just make sure that optional dependencies are
> explicitly disabled in libgphoto2.
>
> It should be a user decision to enable optional dependencies.
Ok, then the required libs are libtool, libusb, libusb-compat and 
libxml2. I added the support of libexif, libjpeg and gd if selected by user.
>
>>>> +	bool "libgphoto2"
>>>> +	help
>>>> +	  libgphoto2 is the core library designed to allow access to digital camera by external programs.
>>> The help text should be wrapped within 72 characters (8 characters for one tab)
>> Ok
>>>> +
>>>> +	  http://gphoto.org/
>>>> diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
>>>> new file mode 100644
>>>> index 0000000..25de0bf
>>>> --- /dev/null
>>>> +++ b/package/libgphoto2/libgphoto2.hash
>>>> @@ -0,0 +1,3 @@
>>>> +# Hashes from: https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
>>>> +sha1	4e1208a8a66d679b8b619b05915dbb0e684c5518	libgphoto2-2.5.12.tar.gz
>>>> +md5	b3b5d36e583fc96eed0594dc414d70c9		libgphoto2-2.5.12.tar.gz
>>> I used tar.bz2 archive here since the archive is smaller and used the
>>> corresponding hashes.
>>>
>>> I added a stronger hash calculated locally
>>> sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e
>>> libgphoto2-2.5.12.tar.bz2
>>>
>> Ok
>>>> diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
>>>> new file mode 100644
>>>> index 0000000..fc5be1b
>>>> --- /dev/null
>>>> +++ b/package/libgphoto2/libgphoto2.mk
>>>> @@ -0,0 +1,14 @@
>>>> +################################################################################
>>>> +#
>>>> +# libgphoto2
>>>> +#
>>>> +################################################################################
>>>> +
>>>> +LIBGPHOTO2_VERSION = 2.5.12
>>>> +LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.gz
>>> The tar.bz2 archive should be used here.
>> Ok
>>>> +LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
>>> Missing license information:
>>>
>>> It's seems to be LGPLv2+ but...
>>>
>>>   * \par License
>>>   * This library is free software; you can redistribute it and/or
>>>   * modify it under the terms of the GNU Lesser General Public
>>>   * License as published by the Free Software Foundation; either
>>>   * version 2 of the License, or (at your option) any later version.
>>>   *
>>>   * \par
>>>   * This library is distributed in the hope that it will be useful,
>>>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>>   * Lesser General Public License for more details.
>>>   *
>>>   * \par
>>>   * You should have received a copy of the GNU Lesser General Public
>>>   * License along with this library; if not, write to the
>>>   * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>>>   * Boston, MA  02110-1301  USA
>>>
>>> ... Fedora tagged this package as GPLV2+ and GPLv2... it seems there is a
>>> licensing issue...
>>>
>>> # GPLV2+ for the main lib (due to exif.c) and most plugins, some plugins GPLv2
>>> http://pkgs.fedoraproject.org/cgit/rpms/libgphoto2.git/tree/libgphoto2.spec
>>>
>>> exif.c:
>>>    \par License
>>>    This program is free software; you can redistribute it and/or modify
>>>    it under the terms of the GNU General Public License as published by
>>>    the Free Software Foundation; either version 2 of the License, or
>>>    (at your option) any later version.
>>>
>>>    \par
>>>    This program is distributed in the hope that it will be useful,
>>>    but WITHOUT ANY WARRANTY; without even the implied warranty of
>>>    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>>    GNU General Public License for more details.
>>>
>>>    \par
>>>    You should have received a copy of the GNU General Public License
>>>    along with this program; if not, write to the
>>>    Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>>>    Boston, MA  02110-1301  USA
>> The library itself seems to be LGPL2.1. But it contains several plugins with
>> different licences (GPL-2, LGPL-2+, ...). Is LGPL2.1 suitable ?
> I'm not sure, can you contact upstream about this ?
The maintainers of gphoto2 ensured me on their mailing list that the 
licence is LGPLv2.1+ [2]
>
> Best regards,
> Romain
>
>>>> +LIBGPHOTO2_INSTALL_STAGING = YES
>>> Ok
>>>
>>>> +LIBGPHOTO2_INSTALL_TARGET = YES
>>> Not needed, this is the default behavior.
>>>
>>>> +LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
>>> Ok but maybe gd jpeg libexif and lockdev dependencies may be missing.
>>>
>>> Best regards,
>>> Romain
>>>
>>>> +
>>>> +$(eval $(autotools-package))
>>>>
>> I'll submit my patch again with your recommendation.
>>
>> Best regards,
>>
>> [1] http://gphoto.org/doc/manual/compilation.html
>> -- 
>>
>> *Kevin JOLY*
>> Embedded systems engineer
>>
>> SenseFly <http://www.sensefly.com/>
>> 38, rte de Gen?ve
>> 1033 Cheseaux-Lausanne, Switzerland
>>

I'll send a new patch with those modifications following this email.

Best regards,

[2] https://sourceforge.net/p/gphoto/mailman/message/35772390/

-- 

*Kevin JOLY*
Embedded systems engineer

SenseFly <http://www.sensefly.com/>
38, rte de Gen?ve
1033 Cheseaux-Lausanne, Switzerland

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170406/3a147239/attachment.html>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-03-09  6:52   ` Kevin JOLY
@ 2017-03-16 23:17     ` Romain Naour
  2017-04-06  8:31       ` Kevin JOLY
  0 siblings, 1 reply; 16+ messages in thread
From: Romain Naour @ 2017-03-16 23:17 UTC (permalink / raw)
  To: buildroot

Hi Kevin,

Le 09/03/2017 ? 07:52, Kevin JOLY a ?crit :
> Hi Romain,
> 
> Thanks a lot for your comments!

You're welcome!

> 
> 
> Le 08. 03. 17 ? 21:10, Romain Naour a ?crit :
>> Hi Kevin,
>>
>> Thanks for this contribution.
>>
>> I recently sent a patch adding libgphoto2 for Darktable [1].
>> There are small differences with your patch (mostly package dependencies), can
>> you comment on it ?
>>
>> Thanks!
>>
>> [1] http://patchwork.ozlabs.org/patch/735448/
>>
>> Le 08/03/2017 ? 14:38, Kevin JOLY a ?crit :
>>> Add support for libgphoto2 core library designed to allow access to digital camera.
>>>
>>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>>> ---
>> We recommend to add yourself as package maintainer in DEVELOPERS file, see:
>> http://nightly.buildroot.org/manual.html#DEVELOPERS
> Ok
>>>  package/Config.in                  |  1 +
>>>  package/libgphoto2/Config.in       | 10 ++++++++++
>>>  package/libgphoto2/libgphoto2.hash |  3 +++
>>>  package/libgphoto2/libgphoto2.mk   | 14 ++++++++++++++
>>>  4 files changed, 28 insertions(+)
>>>  create mode 100644 package/libgphoto2/Config.in
>>>  create mode 100644 package/libgphoto2/libgphoto2.hash
>>>  create mode 100644 package/libgphoto2/libgphoto2.mk
>>>
>>> diff --git a/package/Config.in b/package/Config.in
>>> index 9eb6a22..69430c3 100644
>>> --- a/package/Config.in
>>> +++ b/package/Config.in
>>> @@ -1073,6 +1073,7 @@ menu "Hardware handling"
>>>  	source "package/libfreefare/Config.in"
>>>  	source "package/libftdi/Config.in"
>>>  	source "package/libftdi1/Config.in"
>>> +	source "package/libgphoto2/Config.in"
>>>  	source "package/libgpiod/Config.in"
>>>  	source "package/libgudev/Config.in"
>>>  	source "package/libhid/Config.in"
>>> diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
>>> new file mode 100644
>>> index 0000000..ba1d535
>>> --- /dev/null
>>> +++ b/package/libgphoto2/Config.in
>>> @@ -0,0 +1,10 @@
>>> +config BR2_PACKAGE_LIBGPHOTO2
>>> +	select BR2_PACKAGE_LIBTOOL
>>> +	select BR2_PACKAGE_LIBUSB
>>> +	select BR2_PACKAGE_LIBUSB_COMPAT
>>> +	select BR2_PACKAGE_LIBXML2
>> I added gd, jpeg, libexif and lockev package as mandatory dependencies, They may
>> be optional... can you check ?
>>
>> You can compare with archlinux packaging for exemple:
>>
>> depends=(libexif libjpeg gd libltdl libusb libxml2)
>>
>> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libgphoto2
> According to the figure 5.1 of their online manual [1], libexif is optionnal. I
> also noticed in the source code of libgphoto2 that there is several #ifdef
> HAVE_LIBGD, #ifdef HAVE_LIBJPEG, #ifdef HAVE_LOCKDEV//so that I assumed them
> optional. For libxml2 I was not able to compile the package without it. I got :
> ERROR: unsafe header/library path used in cross-compilation:
> '-I/usr/include/libxml2'
> 
> Do you would like me to add them by default in order to keep the full feature set ?

No, we prefer to add only the mandatory dependencies when the package is added
and add optional dependencies in followup patches.
So you're probably right, just make sure that optional dependencies are
explicitly disabled in libgphoto2.

It should be a user decision to enable optional dependencies.

>>> +	bool "libgphoto2"
>>> +	help
>>> +	  libgphoto2 is the core library designed to allow access to digital camera by external programs.
>> The help text should be wrapped within 72 characters (8 characters for one tab)
> Ok
>>> +
>>> +	  http://gphoto.org/
>>> diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
>>> new file mode 100644
>>> index 0000000..25de0bf
>>> --- /dev/null
>>> +++ b/package/libgphoto2/libgphoto2.hash
>>> @@ -0,0 +1,3 @@
>>> +# Hashes from: https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
>>> +sha1	4e1208a8a66d679b8b619b05915dbb0e684c5518	libgphoto2-2.5.12.tar.gz
>>> +md5	b3b5d36e583fc96eed0594dc414d70c9		libgphoto2-2.5.12.tar.gz
>> I used tar.bz2 archive here since the archive is smaller and used the
>> corresponding hashes.
>>
>> I added a stronger hash calculated locally
>> sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e
>> libgphoto2-2.5.12.tar.bz2
>>
> Ok
>>> diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
>>> new file mode 100644
>>> index 0000000..fc5be1b
>>> --- /dev/null
>>> +++ b/package/libgphoto2/libgphoto2.mk
>>> @@ -0,0 +1,14 @@
>>> +################################################################################
>>> +#
>>> +# libgphoto2
>>> +#
>>> +################################################################################
>>> +
>>> +LIBGPHOTO2_VERSION = 2.5.12
>>> +LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.gz
>> The tar.bz2 archive should be used here.
> Ok
>>> +LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
>> Missing license information:
>>
>> It's seems to be LGPLv2+ but...
>>
>>  * \par License
>>  * This library is free software; you can redistribute it and/or
>>  * modify it under the terms of the GNU Lesser General Public
>>  * License as published by the Free Software Foundation; either
>>  * version 2 of the License, or (at your option) any later version.
>>  *
>>  * \par
>>  * This library is distributed in the hope that it will be useful,
>>  * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>>  * Lesser General Public License for more details.
>>  *
>>  * \par
>>  * You should have received a copy of the GNU Lesser General Public
>>  * License along with this library; if not, write to the
>>  * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>>  * Boston, MA  02110-1301  USA
>>
>> ... Fedora tagged this package as GPLV2+ and GPLv2... it seems there is a
>> licensing issue...
>>
>> # GPLV2+ for the main lib (due to exif.c) and most plugins, some plugins GPLv2
>> http://pkgs.fedoraproject.org/cgit/rpms/libgphoto2.git/tree/libgphoto2.spec
>>
>> exif.c:
>>   \par License
>>   This program is free software; you can redistribute it and/or modify
>>   it under the terms of the GNU General Public License as published by
>>   the Free Software Foundation; either version 2 of the License, or
>>   (at your option) any later version.
>>
>>   \par
>>   This program is distributed in the hope that it will be useful,
>>   but WITHOUT ANY WARRANTY; without even the implied warranty of
>>   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>   GNU General Public License for more details.
>>
>>   \par
>>   You should have received a copy of the GNU General Public License
>>   along with this program; if not, write to the
>>   Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>>   Boston, MA  02110-1301  USA

> The library itself seems to be LGPL2.1. But it contains several plugins with
> different licences (GPL-2, LGPL-2+, ...). Is LGPL2.1 suitable ?

I'm not sure, can you contact upstream about this ?

Best regards,
Romain

>>> +LIBGPHOTO2_INSTALL_STAGING = YES
>> Ok
>>
>>> +LIBGPHOTO2_INSTALL_TARGET = YES
>> Not needed, this is the default behavior.
>>
>>> +LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
>> Ok but maybe gd jpeg libexif and lockdev dependencies may be missing.
>>
>> Best regards,
>> Romain
>>
>>> +
>>> +$(eval $(autotools-package))
>>>
> I'll submit my patch again with your recommendation.
> 
> Best regards,
> 
> [1] http://gphoto.org/doc/manual/compilation.html
> -- 
> 
> *Kevin JOLY*
> Embedded systems engineer
> 
> SenseFly <http://www.sensefly.com/>
> 38, rte de Gen?ve
> 1033 Cheseaux-Lausanne, Switzerland
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
@ 2017-03-13  7:26 Kevin JOLY
  0 siblings, 0 replies; 16+ messages in thread
From: Kevin JOLY @ 2017-03-13  7:26 UTC (permalink / raw)
  To: buildroot

Add support for libgphoto2 core library designed to allow access to digital camera.

Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
---
 DEVELOPERS                         |  3 +++
 package/Config.in                  |  1 +
 package/libgphoto2/Config.in       | 11 +++++++++++
 package/libgphoto2/libgphoto2.hash |  6 ++++++
 package/libgphoto2/libgphoto2.mk   | 15 +++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/libgphoto2/Config.in
 create mode 100644 package/libgphoto2/libgphoto2.hash
 create mode 100644 package/libgphoto2/libgphoto2.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 70a5428..7ad55b6 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -935,6 +935,9 @@ F:	package/cpuload/
 F:	package/bwm-ng/
 F:	package/ramsmp/
 
+N:	Kevin Joly <kevin.joly@sensefly.com>
+F:	package/libgphoto2
+
 N:	Laurent Cans <laurent.cans@gmail.com>
 F:	package/aircrack-ng/
 
diff --git a/package/Config.in b/package/Config.in
index 85e4dee..96e03f4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1074,6 +1074,7 @@ menu "Hardware handling"
 	source "package/libfreefare/Config.in"
 	source "package/libftdi/Config.in"
 	source "package/libftdi1/Config.in"
+	source "package/libgphoto2/Config.in"
 	source "package/libgpiod/Config.in"
 	source "package/libgudev/Config.in"
 	source "package/libhid/Config.in"
diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
new file mode 100644
index 0000000..a69231d
--- /dev/null
+++ b/package/libgphoto2/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBGPHOTO2
+	select BR2_PACKAGE_LIBTOOL
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_LIBUSB_COMPAT
+	select BR2_PACKAGE_LIBXML2
+	bool "libgphoto2"
+	help
+	  libgphoto2 is the core library designed to allow access to digital
+	  camera by external programs.
+
+	  http://gphoto.org/
diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
new file mode 100644
index 0000000..2e659ab
--- /dev/null
+++ b/package/libgphoto2/libgphoto2.hash
@@ -0,0 +1,6 @@
+# https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
+md5 a5999acc204c31515a6ec8e517d2cd91 libgphoto2-2.5.12.tar.bz2
+sha1 4ded403b87d46ad49ba88b22b9410789ed3cef10 libgphoto2-2.5.12.tar.bz2
+
+# Locally calculated hash
+sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e	libgphoto2-2.5.12.tar.bz2
diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
new file mode 100644
index 0000000..72996d4
--- /dev/null
+++ b/package/libgphoto2/libgphoto2.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# libgphoto2
+#
+################################################################################
+
+LIBGPHOTO2_VERSION = 2.5.12
+LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.bz2
+LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
+LIBGPHOTO2_INSTALL_STAGING = YES
+LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
+LIBGPHOTO2_LICENSE = LGPLv2.1+
+LIBGPHOTO2_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-03-08 20:10 ` Romain Naour
@ 2017-03-09  6:52   ` Kevin JOLY
  2017-03-16 23:17     ` Romain Naour
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin JOLY @ 2017-03-09  6:52 UTC (permalink / raw)
  To: buildroot

Hi Romain,

Thanks a lot for your comments!


Le 08. 03. 17 ? 21:10, Romain Naour a ?crit :
> Hi Kevin,
>
> Thanks for this contribution.
>
> I recently sent a patch adding libgphoto2 for Darktable [1].
> There are small differences with your patch (mostly package dependencies), can
> you comment on it ?
>
> Thanks!
>
> [1] http://patchwork.ozlabs.org/patch/735448/
>
> Le 08/03/2017 ? 14:38, Kevin JOLY a ?crit :
>> Add support for libgphoto2 core library designed to allow access to digital camera.
>>
>> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
>> ---
> We recommend to add yourself as package maintainer in DEVELOPERS file, see:
> http://nightly.buildroot.org/manual.html#DEVELOPERS
Ok
>>   package/Config.in                  |  1 +
>>   package/libgphoto2/Config.in       | 10 ++++++++++
>>   package/libgphoto2/libgphoto2.hash |  3 +++
>>   package/libgphoto2/libgphoto2.mk   | 14 ++++++++++++++
>>   4 files changed, 28 insertions(+)
>>   create mode 100644 package/libgphoto2/Config.in
>>   create mode 100644 package/libgphoto2/libgphoto2.hash
>>   create mode 100644 package/libgphoto2/libgphoto2.mk
>>
>> diff --git a/package/Config.in b/package/Config.in
>> index 9eb6a22..69430c3 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -1073,6 +1073,7 @@ menu "Hardware handling"
>>   	source "package/libfreefare/Config.in"
>>   	source "package/libftdi/Config.in"
>>   	source "package/libftdi1/Config.in"
>> +	source "package/libgphoto2/Config.in"
>>   	source "package/libgpiod/Config.in"
>>   	source "package/libgudev/Config.in"
>>   	source "package/libhid/Config.in"
>> diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
>> new file mode 100644
>> index 0000000..ba1d535
>> --- /dev/null
>> +++ b/package/libgphoto2/Config.in
>> @@ -0,0 +1,10 @@
>> +config BR2_PACKAGE_LIBGPHOTO2
>> +	select BR2_PACKAGE_LIBTOOL
>> +	select BR2_PACKAGE_LIBUSB
>> +	select BR2_PACKAGE_LIBUSB_COMPAT
>> +	select BR2_PACKAGE_LIBXML2
> I added gd, jpeg, libexif and lockev package as mandatory dependencies, They may
> be optional... can you check ?
>
> You can compare with archlinux packaging for exemple:
>
> depends=(libexif libjpeg gd libltdl libusb libxml2)
>
> https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libgphoto2
According to the figure 5.1 of their online manual [1], libexif is 
optionnal. I also noticed in the source code of libgphoto2 that there is 
several #ifdef HAVE_LIBGD, #ifdef HAVE_LIBJPEG, #ifdef HAVE_LOCKDEV//so 
that I assumed them optional. For libxml2 I was not able to compile the 
package without it. I got :
ERROR: unsafe header/library path used in cross-compilation: 
'-I/usr/include/libxml2'

Do you would like me to add them by default in order to keep the full 
feature set ?
>> +	bool "libgphoto2"
>> +	help
>> +	  libgphoto2 is the core library designed to allow access to digital camera by external programs.
> The help text should be wrapped within 72 characters (8 characters for one tab)
Ok
>> +
>> +	  http://gphoto.org/
>> diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
>> new file mode 100644
>> index 0000000..25de0bf
>> --- /dev/null
>> +++ b/package/libgphoto2/libgphoto2.hash
>> @@ -0,0 +1,3 @@
>> +# Hashes from: https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
>> +sha1	4e1208a8a66d679b8b619b05915dbb0e684c5518	libgphoto2-2.5.12.tar.gz
>> +md5	b3b5d36e583fc96eed0594dc414d70c9		libgphoto2-2.5.12.tar.gz
> I used tar.bz2 archive here since the archive is smaller and used the
> corresponding hashes.
>
> I added a stronger hash calculated locally
> sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e
> libgphoto2-2.5.12.tar.bz2
>
Ok
>> diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
>> new file mode 100644
>> index 0000000..fc5be1b
>> --- /dev/null
>> +++ b/package/libgphoto2/libgphoto2.mk
>> @@ -0,0 +1,14 @@
>> +################################################################################
>> +#
>> +# libgphoto2
>> +#
>> +################################################################################
>> +
>> +LIBGPHOTO2_VERSION = 2.5.12
>> +LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.gz
> The tar.bz2 archive should be used here.
Ok
>> +LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
> Missing license information:
>
> It's seems to be LGPLv2+ but...
>
>   * \par License
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
>   * version 2 of the License, or (at your option) any later version.
>   *
>   * \par
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
>   * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>   * Lesser General Public License for more details.
>   *
>   * \par
>   * You should have received a copy of the GNU Lesser General Public
>   * License along with this library; if not, write to the
>   * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>   * Boston, MA  02110-1301  USA
>
> ... Fedora tagged this package as GPLV2+ and GPLv2... it seems there is a
> licensing issue...
>
> # GPLV2+ for the main lib (due to exif.c) and most plugins, some plugins GPLv2
> http://pkgs.fedoraproject.org/cgit/rpms/libgphoto2.git/tree/libgphoto2.spec
>
> exif.c:
>    \par License
>    This program is free software; you can redistribute it and/or modify
>    it under the terms of the GNU General Public License as published by
>    the Free Software Foundation; either version 2 of the License, or
>    (at your option) any later version.
>
>    \par
>    This program is distributed in the hope that it will be useful,
>    but WITHOUT ANY WARRANTY; without even the implied warranty of
>    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>    GNU General Public License for more details.
>
>    \par
>    You should have received a copy of the GNU General Public License
>    along with this program; if not, write to the
>    Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
>    Boston, MA  02110-1301  USA
The library itself seems to be LGPL2.1. But it contains several plugins 
with different licences (GPL-2, LGPL-2+, ...). Is LGPL2.1 suitable ?
>> +LIBGPHOTO2_INSTALL_STAGING = YES
> Ok
>
>> +LIBGPHOTO2_INSTALL_TARGET = YES
> Not needed, this is the default behavior.
>
>> +LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
> Ok but maybe gd jpeg libexif and lockdev dependencies may be missing.
>
> Best regards,
> Romain
>
>> +
>> +$(eval $(autotools-package))
>>
I'll submit my patch again with your recommendation.

Best regards,

[1] http://gphoto.org/doc/manual/compilation.html
-- 

*Kevin JOLY*
Embedded systems engineer

SenseFly <http://www.sensefly.com/>
38, rte de Gen?ve
1033 Cheseaux-Lausanne, Switzerland

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170309/e49c95b9/attachment.html>

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
  2017-03-08 13:38 Kevin JOLY
@ 2017-03-08 20:10 ` Romain Naour
  2017-03-09  6:52   ` Kevin JOLY
  0 siblings, 1 reply; 16+ messages in thread
From: Romain Naour @ 2017-03-08 20:10 UTC (permalink / raw)
  To: buildroot

Hi Kevin,

Thanks for this contribution.

I recently sent a patch adding libgphoto2 for Darktable [1].
There are small differences with your patch (mostly package dependencies), can
you comment on it ?

Thanks!

[1] http://patchwork.ozlabs.org/patch/735448/

Le 08/03/2017 ? 14:38, Kevin JOLY a ?crit :
> Add support for libgphoto2 core library designed to allow access to digital camera.
> 
> Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
> ---

We recommend to add yourself as package maintainer in DEVELOPERS file, see:
http://nightly.buildroot.org/manual.html#DEVELOPERS

>  package/Config.in                  |  1 +
>  package/libgphoto2/Config.in       | 10 ++++++++++
>  package/libgphoto2/libgphoto2.hash |  3 +++
>  package/libgphoto2/libgphoto2.mk   | 14 ++++++++++++++
>  4 files changed, 28 insertions(+)
>  create mode 100644 package/libgphoto2/Config.in
>  create mode 100644 package/libgphoto2/libgphoto2.hash
>  create mode 100644 package/libgphoto2/libgphoto2.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 9eb6a22..69430c3 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1073,6 +1073,7 @@ menu "Hardware handling"
>  	source "package/libfreefare/Config.in"
>  	source "package/libftdi/Config.in"
>  	source "package/libftdi1/Config.in"
> +	source "package/libgphoto2/Config.in"
>  	source "package/libgpiod/Config.in"
>  	source "package/libgudev/Config.in"
>  	source "package/libhid/Config.in"
> diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
> new file mode 100644
> index 0000000..ba1d535
> --- /dev/null
> +++ b/package/libgphoto2/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_LIBGPHOTO2
> +	select BR2_PACKAGE_LIBTOOL
> +	select BR2_PACKAGE_LIBUSB
> +	select BR2_PACKAGE_LIBUSB_COMPAT
> +	select BR2_PACKAGE_LIBXML2

I added gd, jpeg, libexif and lockev package as mandatory dependencies, They may
be optional... can you check ?

You can compare with archlinux packaging for exemple:

depends=(libexif libjpeg gd libltdl libusb libxml2)

https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/libgphoto2

> +	bool "libgphoto2"
> +	help
> +	  libgphoto2 is the core library designed to allow access to digital camera by external programs.

The help text should be wrapped within 72 characters (8 characters for one tab)

> +
> +	  http://gphoto.org/
> diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
> new file mode 100644
> index 0000000..25de0bf
> --- /dev/null
> +++ b/package/libgphoto2/libgphoto2.hash
> @@ -0,0 +1,3 @@
> +# Hashes from: https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
> +sha1	4e1208a8a66d679b8b619b05915dbb0e684c5518	libgphoto2-2.5.12.tar.gz
> +md5	b3b5d36e583fc96eed0594dc414d70c9		libgphoto2-2.5.12.tar.gz

I used tar.bz2 archive here since the archive is smaller and used the
corresponding hashes.

I added a stronger hash calculated locally
sha256 b9bb28990fde45ac385e4851a07dbad2e1250404b535b0a3a3b898bb431e4e2e
libgphoto2-2.5.12.tar.bz2


> diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
> new file mode 100644
> index 0000000..fc5be1b
> --- /dev/null
> +++ b/package/libgphoto2/libgphoto2.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# libgphoto2
> +#
> +################################################################################
> +
> +LIBGPHOTO2_VERSION = 2.5.12
> +LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.gz

The tar.bz2 archive should be used here.

> +LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)

Missing license information:

It's seems to be LGPLv2+ but...

 * \par License
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2 of the License, or (at your option) any later version.
 *
 * \par
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * \par
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the
 * Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
 * Boston, MA  02110-1301  USA

... Fedora tagged this package as GPLV2+ and GPLv2... it seems there is a
licensing issue...

# GPLV2+ for the main lib (due to exif.c) and most plugins, some plugins GPLv2
http://pkgs.fedoraproject.org/cgit/rpms/libgphoto2.git/tree/libgphoto2.spec

exif.c:
  \par License
  This program is free software; you can redistribute it and/or modify
  it under the terms of the GNU General Public License as published by
  the Free Software Foundation; either version 2 of the License, or
  (at your option) any later version.

  \par
  This program is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  GNU General Public License for more details.

  \par
  You should have received a copy of the GNU General Public License
  along with this program; if not, write to the
  Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  Boston, MA  02110-1301  USA

> +LIBGPHOTO2_INSTALL_STAGING = YES

Ok

> +LIBGPHOTO2_INSTALL_TARGET = YES
Not needed, this is the default behavior.

> +LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf

Ok but maybe gd jpeg libexif and lockdev dependencies may be missing.

Best regards,
Romain

> +
> +$(eval $(autotools-package))
> 

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package
@ 2017-03-08 13:38 Kevin JOLY
  2017-03-08 20:10 ` Romain Naour
  0 siblings, 1 reply; 16+ messages in thread
From: Kevin JOLY @ 2017-03-08 13:38 UTC (permalink / raw)
  To: buildroot

Add support for libgphoto2 core library designed to allow access to digital camera.

Signed-off-by: Kevin JOLY <kevin.joly@sensefly.com>
---
 package/Config.in                  |  1 +
 package/libgphoto2/Config.in       | 10 ++++++++++
 package/libgphoto2/libgphoto2.hash |  3 +++
 package/libgphoto2/libgphoto2.mk   | 14 ++++++++++++++
 4 files changed, 28 insertions(+)
 create mode 100644 package/libgphoto2/Config.in
 create mode 100644 package/libgphoto2/libgphoto2.hash
 create mode 100644 package/libgphoto2/libgphoto2.mk

diff --git a/package/Config.in b/package/Config.in
index 9eb6a22..69430c3 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1073,6 +1073,7 @@ menu "Hardware handling"
 	source "package/libfreefare/Config.in"
 	source "package/libftdi/Config.in"
 	source "package/libftdi1/Config.in"
+	source "package/libgphoto2/Config.in"
 	source "package/libgpiod/Config.in"
 	source "package/libgudev/Config.in"
 	source "package/libhid/Config.in"
diff --git a/package/libgphoto2/Config.in b/package/libgphoto2/Config.in
new file mode 100644
index 0000000..ba1d535
--- /dev/null
+++ b/package/libgphoto2/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBGPHOTO2
+	select BR2_PACKAGE_LIBTOOL
+	select BR2_PACKAGE_LIBUSB
+	select BR2_PACKAGE_LIBUSB_COMPAT
+	select BR2_PACKAGE_LIBXML2
+	bool "libgphoto2"
+	help
+	  libgphoto2 is the core library designed to allow access to digital camera by external programs.
+
+	  http://gphoto.org/
diff --git a/package/libgphoto2/libgphoto2.hash b/package/libgphoto2/libgphoto2.hash
new file mode 100644
index 0000000..25de0bf
--- /dev/null
+++ b/package/libgphoto2/libgphoto2.hash
@@ -0,0 +1,3 @@
+# Hashes from: https://sourceforge.net/projects/gphoto/files/libgphoto/2.5.12/
+sha1	4e1208a8a66d679b8b619b05915dbb0e684c5518	libgphoto2-2.5.12.tar.gz
+md5	b3b5d36e583fc96eed0594dc414d70c9		libgphoto2-2.5.12.tar.gz
diff --git a/package/libgphoto2/libgphoto2.mk b/package/libgphoto2/libgphoto2.mk
new file mode 100644
index 0000000..fc5be1b
--- /dev/null
+++ b/package/libgphoto2/libgphoto2.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libgphoto2
+#
+################################################################################
+
+LIBGPHOTO2_VERSION = 2.5.12
+LIBGPHOTO2_SOURCE = libgphoto2-$(LIBGPHOTO2_VERSION).tar.gz
+LIBGPHOTO2_SITE = https://sourceforge.net/projects/gphoto/files/libgphoto/$(LIBGPHOTO2_VERSION)
+LIBGPHOTO2_INSTALL_STAGING = YES
+LIBGPHOTO2_INSTALL_TARGET = YES
+LIBGPHOTO2_DEPENDENCIES = libxml2 libusb libusb-compat libtool host-pkgconf
+
+$(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-04-10 13:28 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-06  8:33 [Buildroot] [PATCH 1/1] libgphoto2: Add libgphoto2 package Kevin JOLY
2017-04-06 20:36 ` Thomas Petazzoni
2017-04-07  5:14   ` Kevin JOLY
2017-04-07 20:52     ` Romain Naour
2017-04-10  9:24       ` Kevin JOLY
2017-04-10 11:45         ` Thomas Petazzoni
2017-04-10 12:01           ` Arnout Vandecappelle
2017-04-10 10:20 ` Arnout Vandecappelle
2017-04-10 12:23   ` Kevin JOLY
2017-04-10 13:28     ` Arnout Vandecappelle
  -- strict thread matches above, loose matches on Subject: below --
2017-03-13  7:26 Kevin JOLY
2017-03-08 13:38 Kevin JOLY
2017-03-08 20:10 ` Romain Naour
2017-03-09  6:52   ` Kevin JOLY
2017-03-16 23:17     ` Romain Naour
2017-04-06  8:31       ` Kevin JOLY

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.