From: Mikko Koivunen <mikko.koivunen@fi.rohmeurope.com> To: jic23@kernel.org Cc: pmeerw@pmeerw.net, knaack.h@gmx.de, lars@metafoo.de, linux-iio@vger.kernel.org, Mikko Koivunen <mikko.koivunen@fi.rohmeurope.com> Subject: [PATCH v2 3/7] iio: light: rpr0521 sample_frequency read/write added Date: Fri, 7 Apr 2017 15:07:15 +0300 [thread overview] Message-ID: <1491566839-3925-3-git-send-email-mikko.koivunen@fi.rohmeurope.com> (raw) In-Reply-To: <1491566839-3925-1-git-send-email-mikko.koivunen@fi.rohmeurope.com> Added sysfs read/write sample frequency. Signed-off-by: Mikko Koivunen <mikko.koivunen@fi.rohmeurope.com> --- Tested on LeMaker HiKey with AOSP7.1 kernel 4.4. Patch v1->v2 changes: multiline comments fixed drivers/iio/light/rpr0521.c | 99 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 99 insertions(+) diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c index 30c2592..e92a8bb 100644 --- a/drivers/iio/light/rpr0521.c +++ b/drivers/iio/light/rpr0521.c @@ -132,6 +132,30 @@ static const struct rpr0521_gain_info { }, }; +struct rpr0521_samp_freq { + int als_hz; + int als_uhz; + int pxs_hz; + int pxs_uhz; +}; + +static const struct rpr0521_samp_freq rpr0521_samp_freq_i[13] = { +/* {ALS, PXS} */ + {0, 0, 0, 0}, /* 0000, 0=standby */ + {0, 0, 100, 0}, /* 0001 */ + {0, 0, 25, 0}, /* 0010 */ + {0, 0, 10, 0}, /* 0011 */ + {0, 0, 2, 500000}, /* 0100 */ + {10, 0, 20, 0}, /* 0101 */ + {10, 0, 10, 0}, /* 0110 */ + {10, 0, 2, 500000}, /* 0111 */ + {2, 500000, 20, 0}, /* 1000, measurement 100ms, sleep 300ms */ + {2, 500000, 10, 0}, /* 1001, measurement 100ms, sleep 300ms */ + {2, 500000, 0, 0}, /* 1010, high sensitivity mode */ + {2, 500000, 2, 500000}, /* 1011, high sensitivity mode */ + {20, 0, 20, 0} /* 1100, ALS_data x 0.5, see specification P.18 */ +}; + struct rpr0521_data { struct i2c_client *client; @@ -152,9 +176,15 @@ struct rpr0521_data { static IIO_CONST_ATTR(in_intensity_scale_available, RPR0521_ALS_SCALE_AVAIL); static IIO_CONST_ATTR(in_proximity_scale_available, RPR0521_PXS_SCALE_AVAIL); +/* Start with easy freq first, whole table of freq combinations is more + * complicated. + */ +static IIO_CONST_ATTR_SAMP_FREQ_AVAIL("2.5 10"); + static struct attribute *rpr0521_attributes[] = { &iio_const_attr_in_intensity_scale_available.dev_attr.attr, &iio_const_attr_in_proximity_scale_available.dev_attr.attr, + &iio_const_attr_sampling_frequency_available.dev_attr.attr, NULL, }; @@ -170,6 +200,7 @@ static const struct iio_chan_spec rpr0521_channels[] = { .channel2 = IIO_MOD_LIGHT_BOTH, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), }, { .type = IIO_INTENSITY, @@ -178,12 +209,14 @@ static const struct iio_chan_spec rpr0521_channels[] = { .channel2 = IIO_MOD_LIGHT_IR, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), }, { .type = IIO_PROXIMITY, .address = RPR0521_CHAN_PXS, .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), } }; @@ -319,6 +352,56 @@ static int rpr0521_set_gain(struct rpr0521_data *data, int chan, idx << rpr0521_gain[chan].shift); } +static int rpr0521_read_samp_freq(struct rpr0521_data *data, + enum iio_chan_type chan_type, + int *val, int *val2) +{ + int reg, ret; + + ret = regmap_read(data->regmap, RPR0521_REG_MODE_CTRL, ®); + if (ret < 0) + return ret; + reg &= RPR0521_MODE_MEAS_TIME_MASK; + if (reg >= ARRAY_SIZE(rpr0521_samp_freq_i)) + return -EINVAL; + + if (chan_type == IIO_INTENSITY) { + *val = rpr0521_samp_freq_i[reg].als_hz; + *val2 = rpr0521_samp_freq_i[reg].als_uhz; + } else if (chan_type == IIO_PROXIMITY) { + *val = rpr0521_samp_freq_i[reg].pxs_hz; + *val2 = rpr0521_samp_freq_i[reg].pxs_uhz; + } else { + return -EINVAL; + } + return 0; +} + +static int rpr0521_write_samp_freq_common(struct rpr0521_data *data, + enum iio_chan_type chan_type, + int val, int val2) +{ + int i; + + /* Ignore channel + * both pxs and als are setup only to same freq because of simplicity + */ + for (i = 0; i < ARRAY_SIZE(rpr0521_samp_freq_i); i++) + if ((val == rpr0521_samp_freq_i[i].als_hz) + && (val2 == rpr0521_samp_freq_i[i].als_uhz) + && (val == rpr0521_samp_freq_i[i].pxs_hz) + && (val2 == rpr0521_samp_freq_i[i].pxs_uhz)) { + break; + } + if (i == ARRAY_SIZE(rpr0521_samp_freq_i)) + return -EINVAL; + + return regmap_update_bits(data->regmap, + RPR0521_REG_MODE_CTRL, + RPR0521_MODE_MEAS_TIME_MASK, + i); +} + static int rpr0521_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long mask) @@ -365,8 +448,16 @@ static int rpr0521_read_raw(struct iio_dev *indio_dev, mutex_unlock(&data->lock); if (ret < 0) return ret; + return IIO_VAL_INT_PLUS_MICRO; + case IIO_CHAN_INFO_SAMP_FREQ: + mutex_lock(&data->lock); + ret = rpr0521_read_samp_freq(data, chan->type, val, val2); + mutex_unlock(&data->lock); + if (ret < 0) + return ret; return IIO_VAL_INT_PLUS_MICRO; + default: return -EINVAL; } @@ -384,8 +475,16 @@ static int rpr0521_write_raw(struct iio_dev *indio_dev, mutex_lock(&data->lock); ret = rpr0521_set_gain(data, chan->address, val, val2); mutex_unlock(&data->lock); + return ret; + case IIO_CHAN_INFO_SAMP_FREQ: + mutex_lock(&data->lock); + ret = rpr0521_write_samp_freq_common(data, + chan->type, + val, val2); + mutex_unlock(&data->lock); return ret; + default: return -EINVAL; } -- 1.7.9.5
next prev parent reply other threads:[~2017-04-07 12:07 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-07 12:07 [PATCH v2 1/7] iio: light: rpr0521 disable sensor -bugfix Mikko Koivunen 2017-04-07 12:07 ` [PATCH v2 2/7] iio: light: rpr0521 whitespace fixes Mikko Koivunen 2017-04-08 14:49 ` Jonathan Cameron 2017-04-10 13:25 ` Koivunen, Mikko 2017-04-07 12:07 ` Mikko Koivunen [this message] 2017-04-08 15:02 ` [PATCH v2 3/7] iio: light: rpr0521 sample_frequency read/write added Jonathan Cameron 2017-04-10 13:26 ` Koivunen, Mikko 2017-04-07 12:07 ` [PATCH v2 4/7] iio: light: rpr0521 proximity offset " Mikko Koivunen 2017-04-08 15:07 ` Jonathan Cameron 2017-04-10 13:36 ` Koivunen, Mikko 2017-04-07 12:07 ` [PATCH v2 5/7] iio: light: rpr0521 channel numbers reordered Mikko Koivunen 2017-04-08 15:09 ` Jonathan Cameron 2017-04-07 12:07 ` [PATCH v2 6/7] iio: light: rpr0521 triggered buffer added Mikko Koivunen 2017-04-08 15:28 ` Jonathan Cameron 2017-04-12 13:44 ` Koivunen, Mikko 2017-04-14 15:21 ` Jonathan Cameron 2017-04-25 8:37 ` Koivunen, Mikko 2017-04-07 12:07 ` [PATCH v2 7/7] iio: light: rpr0521 magic number to sizeof() on value read Mikko Koivunen 2017-04-08 15:30 ` Jonathan Cameron 2017-04-08 14:47 ` [PATCH v2 1/7] iio: light: rpr0521 disable sensor -bugfix Jonathan Cameron 2017-04-13 6:35 ` Koivunen, Mikko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1491566839-3925-3-git-send-email-mikko.koivunen@fi.rohmeurope.com \ --to=mikko.koivunen@fi.rohmeurope.com \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --subject='Re: [PATCH v2 3/7] iio: light: rpr0521 sample_frequency read/write added' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.