All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libbson: new package
       [not found] <libbson: new package>
@ 2017-04-07 11:42 ` Semyon Kolganov
  2017-04-07 12:01   ` Arnout Vandecappelle
  2017-04-07 12:18 ` [Buildroot] [PATCHv2] " Semyon Kolganov
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Semyon Kolganov @ 2017-04-07 11:42 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
 package/Config.in            |  1 +
 package/libbson/Config.in    |  5 +++++
 package/libbson/libbson.hash |  2 ++
 package/libbson/libbson.mk   | 16 ++++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 package/libbson/Config.in
 create mode 100644 package/libbson/libbson.hash
 create mode 100644 package/libbson/libbson.mk

diff --git a/package/Config.in b/package/Config.in
index 71bd44a..f312e42 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1434,6 +1434,7 @@ menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
 	source "package/icu/Config.in"
+	source "package/libbson/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
 	source "package/libenca/Config.in"
diff --git a/package/libbson/Config.in b/package/libbson/Config.in
new file mode 100644
index 0000000..5e361ea
--- /dev/null
+++ b/package/libbson/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_LIBBSON
+	bool "libbson"
+	help
+	  libbson is a library providing useful routines related to 
+	  building, parsing, and iterating BSON documents.
diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
new file mode 100644
index 0000000..a0abdb6
--- /dev/null
+++ b/package/libbson/libbson.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256	d9a1b2229a4aac2edb1564b909f0770a972af9bf94994acce2b21b2905913aed libbson-1.6.2.tar.gz
diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
new file mode 100644
index 0000000..9941a2f
--- /dev/null
+++ b/package/libbson/libbson.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# libbson
+#
+################################################################################
+
+LIBBSON_VERSION = 1.6.2
+LIBBSON_SITE = $(call github,mongodb,libbson,$(LIBBSON_VERSION))
+LIBBSON_LICENSE = GPL-2.0
+LIBBSON_LICENSE_FILES = COPYING
+LIBBSON_INSTALL_STAGING = YES
+
+LIBBSON_CONF_OPTS = \
+	-DENABLE_TESTS=OFF
+
+$(eval $(cmake-package))
\ No newline at end of file
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] libbson: new package
  2017-04-07 11:42 ` [Buildroot] [PATCH] libbson: new package Semyon Kolganov
@ 2017-04-07 12:01   ` Arnout Vandecappelle
  0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-04-07 12:01 UTC (permalink / raw)
  To: buildroot



On 07-04-17 13:42, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> ---
>  package/Config.in            |  1 +
>  package/libbson/Config.in    |  5 +++++
>  package/libbson/libbson.hash |  2 ++
>  package/libbson/libbson.mk   | 16 ++++++++++++++++
>  4 files changed, 24 insertions(+)
>  create mode 100644 package/libbson/Config.in
>  create mode 100644 package/libbson/libbson.hash
>  create mode 100644 package/libbson/libbson.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 71bd44a..f312e42 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1434,6 +1434,7 @@ menu "Text and terminal handling"
>  	source "package/augeas/Config.in"
>  	source "package/enchant/Config.in"
>  	source "package/icu/Config.in"
> +	source "package/libbson/Config.in"
>  	source "package/libcli/Config.in"
>  	source "package/libedit/Config.in"
>  	source "package/libenca/Config.in"
> diff --git a/package/libbson/Config.in b/package/libbson/Config.in
> new file mode 100644
> index 0000000..5e361ea
> --- /dev/null
> +++ b/package/libbson/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_LIBBSON
> +	bool "libbson"
> +	help
> +	  libbson is a library providing useful routines related to 
> +	  building, parsing, and iterating BSON documents.
> diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
> new file mode 100644
> index 0000000..a0abdb6
> --- /dev/null
> +++ b/package/libbson/libbson.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256	d9a1b2229a4aac2edb1564b909f0770a972af9bf94994acce2b21b2905913aed libbson-1.6.2.tar.gz
> diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
> new file mode 100644
> index 0000000..9941a2f
> --- /dev/null
> +++ b/package/libbson/libbson.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# libbson
> +#
> +################################################################################
> +
> +LIBBSON_VERSION = 1.6.2
> +LIBBSON_SITE = $(call github,mongodb,libbson,$(LIBBSON_VERSION))
> +LIBBSON_LICENSE = GPL-2.0
> +LIBBSON_LICENSE_FILES = COPYING

 jsonl is covered by MIT license, which can be found in src/jsonl/LICENSE.

 The rest seems to be Apache-2.0. Please use Debian's licensecheck to evaluate
the license. Or at least, open the COPYING file and read it!


> +LIBBSON_INSTALL_STAGING = YES
> +
> +LIBBSON_CONF_OPTS = \
> +	-DENABLE_TESTS=OFF
> +
> +$(eval $(cmake-package))
> \ No newline at end of file

 Please add a newline at the end of the file (not an empty line, just make sure
that the last line has a newline at the end).

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv2] libbson: new package
       [not found] <libbson: new package>
  2017-04-07 11:42 ` [Buildroot] [PATCH] libbson: new package Semyon Kolganov
@ 2017-04-07 12:18 ` Semyon Kolganov
  2017-04-07 17:23   ` Arnout Vandecappelle
  2017-04-10 11:16 ` [Buildroot] [PATCHv3] " Semyon Kolganov
  2017-04-10 14:29 ` [Buildroot] [PATCHv4] " Semyon Kolganov
  3 siblings, 1 reply; 9+ messages in thread
From: Semyon Kolganov @ 2017-04-07 12:18 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

Changes between v1 and v2:
 - changed license to right one
 - formatting fix
---
 package/Config.in            |  1 +
 package/libbson/Config.in    |  5 +++++
 package/libbson/libbson.hash |  2 ++
 package/libbson/libbson.mk   | 16 ++++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 package/libbson/Config.in
 create mode 100644 package/libbson/libbson.hash
 create mode 100644 package/libbson/libbson.mk

diff --git a/package/Config.in b/package/Config.in
index 71bd44a..f312e42 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1434,6 +1434,7 @@ menu "Text and terminal handling"
 	source "package/augeas/Config.in"
 	source "package/enchant/Config.in"
 	source "package/icu/Config.in"
+	source "package/libbson/Config.in"
 	source "package/libcli/Config.in"
 	source "package/libedit/Config.in"
 	source "package/libenca/Config.in"
diff --git a/package/libbson/Config.in b/package/libbson/Config.in
new file mode 100644
index 0000000..5e361ea
--- /dev/null
+++ b/package/libbson/Config.in
@@ -0,0 +1,5 @@
+config BR2_PACKAGE_LIBBSON
+	bool "libbson"
+	help
+	  libbson is a library providing useful routines related to 
+	  building, parsing, and iterating BSON documents.
diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
new file mode 100644
index 0000000..a0abdb6
--- /dev/null
+++ b/package/libbson/libbson.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256	d9a1b2229a4aac2edb1564b909f0770a972af9bf94994acce2b21b2905913aed libbson-1.6.2.tar.gz
diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
new file mode 100644
index 0000000..ce26cdc
--- /dev/null
+++ b/package/libbson/libbson.mk
@@ -0,0 +1,16 @@
+################################################################################
+#
+# libbson
+#
+################################################################################
+
+LIBBSON_VERSION = 1.6.2
+LIBBSON_SITE = $(call github,mongodb,libbson,$(LIBBSON_VERSION))
+LIBBSON_LICENSE = Apache-2.0
+LIBBSON_LICENSE_FILES = COPYING
+LIBBSON_INSTALL_STAGING = YES
+
+LIBBSON_CONF_OPTS = \
+	-DENABLE_TESTS=OFF
+
+$(eval $(cmake-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv2] libbson: new package
  2017-04-07 12:18 ` [Buildroot] [PATCHv2] " Semyon Kolganov
@ 2017-04-07 17:23   ` Arnout Vandecappelle
       [not found]     ` <1491587714.491322104@f30.my.com>
  0 siblings, 1 reply; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-04-07 17:23 UTC (permalink / raw)
  To: buildroot

 I'm sorry, license is still not OK... And I looked at it in more details and
other things are not OK either.

On 07-04-17 14:18, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> 
> Changes between v1 and v2:

 You should put a --- line before this changelog. That way, the changelog itself
will not be stored once the patch is accepted ('git am' removes the --- line and
everything below it from the commit message).

>  - changed license to right one
>  - formatting fix
> ---
>  package/Config.in            |  1 +
>  package/libbson/Config.in    |  5 +++++
>  package/libbson/libbson.hash |  2 ++
>  package/libbson/libbson.mk   | 16 ++++++++++++++++
>  4 files changed, 24 insertions(+)
>  create mode 100644 package/libbson/Config.in
>  create mode 100644 package/libbson/libbson.hash
>  create mode 100644 package/libbson/libbson.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 71bd44a..f312e42 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1434,6 +1434,7 @@ menu "Text and terminal handling"

 Since BSON is Binary JSON, it fits better in the JSON/XML menu I think.

 Also, could you base your patch on the latest master?

>  	source "package/augeas/Config.in"
>  	source "package/enchant/Config.in"
>  	source "package/icu/Config.in"
> +	source "package/libbson/Config.in"
>  	source "package/libcli/Config.in"
>  	source "package/libedit/Config.in"
>  	source "package/libenca/Config.in"
> diff --git a/package/libbson/Config.in b/package/libbson/Config.in
> new file mode 100644
> index 0000000..5e361ea
> --- /dev/null
> +++ b/package/libbson/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_LIBBSON
> +	bool "libbson"

 It looks like libbson uses pthreads (it includes pthreads.h), so you should add
	depends on BR2_TOOLCHAIN_HAS_THREADS

 It looks like it insists on building both a static and a shared library instead
of relying on the CMake configuration option, and it gives the static library a
different name so it will probably not work in practice. Probably the easiest is
to just add
	depends on !BR2_STATIC_LIBS # CMakeLists forces dynamic library

 Alternatively, the package also offers automake as a build system. I'm not sure
whether they want to keep this up long term, but it seems to be regularly
updated still. The automake system doesn't seem to have this messy library
problem. I haven't tried it, though.

 To detect these problems early, use the script support/scripts/test-pkg.

> +	help
> +	  libbson is a library providing useful routines related to 
> +	  building, parsing, and iterating BSON documents.
> diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
> new file mode 100644
> index 0000000..a0abdb6
> --- /dev/null
> +++ b/package/libbson/libbson.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256	d9a1b2229a4aac2edb1564b909f0770a972af9bf94994acce2b21b2905913aed libbson-1.6.2.tar.gz
> diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
> new file mode 100644
> index 0000000..ce26cdc
> --- /dev/null
> +++ b/package/libbson/libbson.mk
> @@ -0,0 +1,16 @@
> +################################################################################
> +#
> +# libbson
> +#
> +################################################################################
> +
> +LIBBSON_VERSION = 1.6.2
> +LIBBSON_SITE = $(call github,mongodb,libbson,$(LIBBSON_VERSION))

 There is also an uploaded tarball at
https://github.com/mongodb/libbson/releases/download/1.6.2/libbson-1.6.2.tar.gz

 We generally prefer the uploaded tarball over the autogenerated one. This
tarball has the configure script generated already, so if you convert to an
autotools package and use this tarball, you don't need to set AUTORECONF = YES.

> +LIBBSON_LICENSE = Apache-2.0
> +LIBBSON_LICENSE_FILES = COPYING

 As I said, jsonl is MIT licensed. And it turns out that there's a b64_ntop.h
which is ISC licensed, and bson-md5 which is Zlib licensed. So:

LIBBSON_LICENSE = Apache-2.0, MIT (jsonl), ISC (b64), Zlib (md5)
LIBBSON_LICENSE_FILES = COPYING THIRD_PARTY_NOTICES

> +LIBBSON_INSTALL_STAGING = YES
> +
> +LIBBSON_CONF_OPTS = \
> +	-DENABLE_TESTS=OFF

 For autoconf, you have --disable-tests and you'll also have to pass
--disable-examples. You may also need --disable-man-pages and
--disable-html-docs. There are also --en/disable-debug and
--en/disable-optimizations that may need to be set.

 Regards,
 Arnout

> +
> +$(eval $(cmake-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv3] libbson: new package
       [not found] <libbson: new package>
  2017-04-07 11:42 ` [Buildroot] [PATCH] libbson: new package Semyon Kolganov
  2017-04-07 12:18 ` [Buildroot] [PATCHv2] " Semyon Kolganov
@ 2017-04-10 11:16 ` Semyon Kolganov
  2017-04-10 13:52   ` Arnout Vandecappelle
  2017-04-10 14:29 ` [Buildroot] [PATCHv4] " Semyon Kolganov
  3 siblings, 1 reply; 9+ messages in thread
From: Semyon Kolganov @ 2017-04-10 11:16 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>

---
Changes between v2 and v3:
 - changed cmake method to autotools
 - append licenses
 - change download from github to prepared tarball on github
 - added dependency from BR2_TOOLCHAIN_HAS_THREADS
 - added force dynamic library

Changes between v1 and v2:
 - changed license to right one
 - formatting fix
---
 package/Config.in            |  1 +
 package/libbson/Config.in    |  7 +++++++
 package/libbson/libbson.hash |  2 ++
 package/libbson/libbson.mk   | 14 ++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 package/libbson/Config.in
 create mode 100644 package/libbson/libbson.hash
 create mode 100644 package/libbson/libbson.mk

diff --git a/package/Config.in b/package/Config.in
index c12e5b5..3683578 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1159,6 +1159,7 @@ menu "JSON/XML"
 	source "package/json-c/Config.in"
 	source "package/json-glib/Config.in"
 	source "package/jsoncpp/Config.in"
+	source "package/libbson/Config.in"
 	source "package/libfastjson/Config.in"
 	source "package/libjson/Config.in"
 	source "package/libroxml/Config.in"
diff --git a/package/libbson/Config.in b/package/libbson/Config.in
new file mode 100644
index 0000000..df28462
--- /dev/null
+++ b/package/libbson/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBBSON
+	bool "libbson"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on !BR2_STATIC_LIBS # CMakeLists forces dynamic library
+	help
+	  libbson is a library providing useful routines related to
+	  building, parsing, and iterating BSON documents.
diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
new file mode 100644
index 0000000..27abe90
--- /dev/null
+++ b/package/libbson/libbson.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256	aad410123e4bd8a9804c3c3d79e03344e2df104872594dc2cf19605d492944ba libbson-1.6.2.tar.gz
diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
new file mode 100644
index 0000000..b2faa4b
--- /dev/null
+++ b/package/libbson/libbson.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# libbson
+#
+################################################################################
+
+LIBBSON_VERSION = 1.6.2
+LIBBSON_SITE = https://github.com/mongodb/libbson/releases/download/$(LIBBSON_VERSION)
+LIBBSON_SOURCE = libbson-$(LIBBSON_VERSION).tar.gz
+LIBBSON_LICENSE = Apache-2.0, MIT(jsonl), ISC(b64), Zlib(md5)
+LIBBSON_LICENSE_FILES = COPYING
+LIBBSON_INSTALL_STAGING = YES
+
+$(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv2] libbson: new package
       [not found]     ` <1491587714.491322104@f30.my.com>
@ 2017-04-10 11:53       ` Arnout Vandecappelle
  0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-04-10 11:53 UTC (permalink / raw)
  To: buildroot

 Hi Semyon,

 Please keep the list in Cc. Your questions and answers may be relevant to other
people as well, and you may get faster answers from someone else.


On 07-04-17 19:55, semenak94 at mail.ru wrote:
> Thanks for such detailed answer and  your patience! I'm still a newcomer in
> buildroot community and it's my first experience in open source.

 We aim to please :-) (though sometimes we miss :-P )


> And I have some question : how correctly set all licenses of package, except
> watching license file? I'm not experienced in it... 

 It's unfortunately not so easy. Many packages reuse source code from somewhere
else, so you really have to look at every file to check the license. Fortunately
there are tools that can help:

- the 'licensecheck' script in Debian/Ubuntu;
- fossology, which has an online version at https://fossology.ist.unomaha.edu/

 However, some files in the source code are not used at all (e.g.
windows-specific sources), or don't end up in the target (e.g. the build
scripts), and these shouldn't be included in the license statement.

 For packages that have a Debian equivalent, it's also a good idea to look at
the copyright declaration in Debian, but sometimes their binary packages are
split up differently which can make it tricky to get it right.

> Does license in buildroot
> have any more value,  than formal signature?

 Not sure what you mean here. The license specification helps people to
understand which licenses they have to comply with when they use the result of
the Buildroot build. If with "formal signature" you mean the Signed-off-by, that
only says something about compliance with the license of Buildroot itself, it
has nothing to do with packages.

 Regards,
 Arnout

> 
> Thanks a lot and sorry for stupid questions.
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv3] libbson: new package
  2017-04-10 11:16 ` [Buildroot] [PATCHv3] " Semyon Kolganov
@ 2017-04-10 13:52   ` Arnout Vandecappelle
  0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-04-10 13:52 UTC (permalink / raw)
  To: buildroot

 Hi Semyon,

 We're getting there :-)

On 10-04-17 13:16, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> 
> ---

[snip]
> diff --git a/package/libbson/Config.in b/package/libbson/Config.in
> new file mode 100644
> index 0000000..df28462
> --- /dev/null
> +++ b/package/libbson/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBBSON
> +	bool "libbson"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_STATIC_LIBS # CMakeLists forces dynamic library

 Since you're no longer using cmake, this should be removed.

> +	help
> +	  libbson is a library providing useful routines related to
> +	  building, parsing, and iterating BSON documents.
> diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
> new file mode 100644
> index 0000000..27abe90
> --- /dev/null
> +++ b/package/libbson/libbson.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256	aad410123e4bd8a9804c3c3d79e03344e2df104872594dc2cf19605d492944ba libbson-1.6.2.tar.gz
> diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
> new file mode 100644
> index 0000000..b2faa4b
> --- /dev/null
> +++ b/package/libbson/libbson.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# libbson
> +#
> +################################################################################
> +
> +LIBBSON_VERSION = 1.6.2
> +LIBBSON_SITE = https://github.com/mongodb/libbson/releases/download/$(LIBBSON_VERSION)
> +LIBBSON_SOURCE = libbson-$(LIBBSON_VERSION).tar.gz
> +LIBBSON_LICENSE = Apache-2.0, MIT(jsonl), ISC(b64), Zlib(md5)

 There should be a space between the license and the object, so MIT (jsonl) etc.

> +LIBBSON_LICENSE_FILES = COPYING

LIBBSON_LICENSE_FILES = COPYING THIRD_PARTY_NOTICES

 I said this in my previous review.

 I also mentioned:

LIBBSON_CONF_OPTS = --disable-tests --disable-examples

(otherwise it will fail on NOMMU)

 Please use support/scripts/test-pkg to validate that the package builds with
all supported toolchains.


> +LIBBSON_INSTALL_STAGING = YES
> +

 For posterity, it could be useful to add:

# Also has CMake supports, but that forces shared+static libs and static
# lib has a different name.
> +$(eval $(autotools-package))


 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv4] libbson: new package
       [not found] <libbson: new package>
                   ` (2 preceding siblings ...)
  2017-04-10 11:16 ` [Buildroot] [PATCHv3] " Semyon Kolganov
@ 2017-04-10 14:29 ` Semyon Kolganov
  2017-04-10 14:59   ` Arnout Vandecappelle
  3 siblings, 1 reply; 9+ messages in thread
From: Semyon Kolganov @ 2017-04-10 14:29 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
---
Changes between v3 and v4:
 - removed force dynamic library
 - formatting fixes
 - added configure options

Changes between v2 and v3:
 - changed cmake method to autotools
 - append licenses
 - change download from github to prepared tarball on github
 - added dependency from BR2_TOOLCHAIN_HAS_THREADS
 - added force dynamic library

Changes between v1 and v2:
 - changed license to right one
 - formatting fix
---
 package/Config.in            |  1 +
 package/libbson/Config.in    |  6 ++++++
 package/libbson/libbson.hash |  2 ++
 package/libbson/libbson.mk   | 22 ++++++++++++++++++++++
 4 files changed, 31 insertions(+)
 create mode 100644 package/libbson/Config.in
 create mode 100644 package/libbson/libbson.hash
 create mode 100644 package/libbson/libbson.mk

diff --git a/package/Config.in b/package/Config.in
index c12e5b5..3683578 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1159,6 +1159,7 @@ menu "JSON/XML"
 	source "package/json-c/Config.in"
 	source "package/json-glib/Config.in"
 	source "package/jsoncpp/Config.in"
+	source "package/libbson/Config.in"
 	source "package/libfastjson/Config.in"
 	source "package/libjson/Config.in"
 	source "package/libroxml/Config.in"
diff --git a/package/libbson/Config.in b/package/libbson/Config.in
new file mode 100644
index 0000000..719271c
--- /dev/null
+++ b/package/libbson/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_LIBBSON
+	bool "libbson"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	help
+	  libbson is a library providing useful routines related to
+	  building, parsing, and iterating BSON documents.
diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
new file mode 100644
index 0000000..27abe90
--- /dev/null
+++ b/package/libbson/libbson.hash
@@ -0,0 +1,2 @@
+# Locally calculated
+sha256	aad410123e4bd8a9804c3c3d79e03344e2df104872594dc2cf19605d492944ba libbson-1.6.2.tar.gz
diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
new file mode 100644
index 0000000..24c1abd
--- /dev/null
+++ b/package/libbson/libbson.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libbson
+#
+################################################################################
+
+LIBBSON_VERSION = 1.6.2
+LIBBSON_SITE = https://github.com/mongodb/libbson/releases/download/$(LIBBSON_VERSION)
+LIBBSON_SOURCE = libbson-$(LIBBSON_VERSION).tar.gz
+LIBBSON_LICENSE = Apache-2.0, MIT (jsonl), ISC (b64), Zlib (md5)
+LIBBSON_LICENSE_FILES = COPYING THIRD_PARTY_NOTICES
+LIBBSON_CONF_OPTS = \
+	--disable-tests \
+	--disable-examples \
+	--disable-man-pages \
+	--disable-html-docs
+
+LIBBSON_INSTALL_STAGING = YES
+
+# Also has CMake supports, but that forces shared+static libs and static
+# lib has a different name.
+$(eval $(autotools-package))
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [Buildroot] [PATCHv4] libbson: new package
  2017-04-10 14:29 ` [Buildroot] [PATCHv4] " Semyon Kolganov
@ 2017-04-10 14:59   ` Arnout Vandecappelle
  0 siblings, 0 replies; 9+ messages in thread
From: Arnout Vandecappelle @ 2017-04-10 14:59 UTC (permalink / raw)
  To: buildroot

 Two minor things that I missed previous time...

On 10-04-17 16:29, Semyon Kolganov wrote:
> Signed-off-by: Semyon Kolganov <semenak94@mail.ru>
> ---
> Changes between v3 and v4:
>  - removed force dynamic library
>  - formatting fixes
>  - added configure options
> 
> Changes between v2 and v3:
>  - changed cmake method to autotools
>  - append licenses
>  - change download from github to prepared tarball on github
>  - added dependency from BR2_TOOLCHAIN_HAS_THREADS
>  - added force dynamic library
> 
> Changes between v1 and v2:
>  - changed license to right one
>  - formatting fix
> ---
>  package/Config.in            |  1 +
>  package/libbson/Config.in    |  6 ++++++
>  package/libbson/libbson.hash |  2 ++
>  package/libbson/libbson.mk   | 22 ++++++++++++++++++++++
>  4 files changed, 31 insertions(+)
>  create mode 100644 package/libbson/Config.in
>  create mode 100644 package/libbson/libbson.hash
>  create mode 100644 package/libbson/libbson.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index c12e5b5..3683578 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1159,6 +1159,7 @@ menu "JSON/XML"
>  	source "package/json-c/Config.in"
>  	source "package/json-glib/Config.in"
>  	source "package/jsoncpp/Config.in"
> +	source "package/libbson/Config.in"
>  	source "package/libfastjson/Config.in"
>  	source "package/libjson/Config.in"
>  	source "package/libroxml/Config.in"
> diff --git a/package/libbson/Config.in b/package/libbson/Config.in
> new file mode 100644
> index 0000000..719271c
> --- /dev/null
> +++ b/package/libbson/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_LIBBSON
> +	bool "libbson"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	help
> +	  libbson is a library providing useful routines related to
> +	  building, parsing, and iterating BSON documents.
> diff --git a/package/libbson/libbson.hash b/package/libbson/libbson.hash
> new file mode 100644
> index 0000000..27abe90
> --- /dev/null
> +++ b/package/libbson/libbson.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256	aad410123e4bd8a9804c3c3d79e03344e2df104872594dc2cf19605d492944ba libbson-1.6.2.tar.gz
> diff --git a/package/libbson/libbson.mk b/package/libbson/libbson.mk
> new file mode 100644
> index 0000000..24c1abd
> --- /dev/null
> +++ b/package/libbson/libbson.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# libbson
> +#
> +################################################################################
> +
> +LIBBSON_VERSION = 1.6.2
> +LIBBSON_SITE = https://github.com/mongodb/libbson/releases/download/$(LIBBSON_VERSION)
> +LIBBSON_SOURCE = libbson-$(LIBBSON_VERSION).tar.gz

 This line should be removed, it's the default.

> +LIBBSON_LICENSE = Apache-2.0, MIT (jsonl), ISC (b64), Zlib (md5)
> +LIBBSON_LICENSE_FILES = COPYING THIRD_PARTY_NOTICES
> +LIBBSON_CONF_OPTS = \
> +	--disable-tests \
> +	--disable-examples \
> +	--disable-man-pages \
> +	--disable-html-docs
> +
> +LIBBSON_INSTALL_STAGING = YES
> +
> +# Also has CMake supports, but that forces shared+static libs and static
                    ^^^^^^^^ support

 Since it's trivial and I already did it locally, I'll just resend myself. No
need to resend.

 Regards,
 Arnout

> +# lib has a different name.
> +$(eval $(autotools-package))
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-04-10 14:59 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <libbson: new package>
2017-04-07 11:42 ` [Buildroot] [PATCH] libbson: new package Semyon Kolganov
2017-04-07 12:01   ` Arnout Vandecappelle
2017-04-07 12:18 ` [Buildroot] [PATCHv2] " Semyon Kolganov
2017-04-07 17:23   ` Arnout Vandecappelle
     [not found]     ` <1491587714.491322104@f30.my.com>
2017-04-10 11:53       ` Arnout Vandecappelle
2017-04-10 11:16 ` [Buildroot] [PATCHv3] " Semyon Kolganov
2017-04-10 13:52   ` Arnout Vandecappelle
2017-04-10 14:29 ` [Buildroot] [PATCHv4] " Semyon Kolganov
2017-04-10 14:59   ` Arnout Vandecappelle

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.