* [PATCH 1/4] selftest/sstatetests: Replace glibc-initial with linux-libc-headers
@ 2017-04-07 16:41 Richard Purdie
2017-04-07 16:41 ` [PATCH 2/4] no-static-libs: Add entry for ncurses Richard Purdie
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Richard Purdie @ 2017-04-07 16:41 UTC (permalink / raw)
To: openembedded-core
The intent in these tests was to find something early in the bootstrap
process to run tests against which didn't require long build times.
This breaks with the removal of the glibc-initial do_build target.
Replacing it with linux-libc-headers seems like a good choice
and simplifies the conditionals too.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/lib/oeqa/selftest/sstatetests.py | 20 +++++---------------
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/meta/lib/oeqa/selftest/sstatetests.py b/meta/lib/oeqa/selftest/sstatetests.py
index 5814815..e35ddff 100644
--- a/meta/lib/oeqa/selftest/sstatetests.py
+++ b/meta/lib/oeqa/selftest/sstatetests.py
@@ -49,15 +49,11 @@ class SStateTests(SStateBase):
@testcase(976)
def test_sstate_creation_distro_nonspecific_pass(self):
- # glibc-initial is intended only for the glibc C library
- if self.tclibc == 'glibc':
- self.run_test_sstate_creation(['glibc-initial'], distro_specific=False, distro_nonspecific=True, temp_sstate_location=True)
+ self.run_test_sstate_creation(['linux-libc-headers'], distro_specific=False, distro_nonspecific=True, temp_sstate_location=True)
@testcase(1375)
def test_sstate_creation_distro_nonspecific_fail(self):
- # glibc-initial is intended only for the glibc C library
- if self.tclibc == 'glibc':
- self.run_test_sstate_creation(['glibc-initial'], distro_specific=True, distro_nonspecific=False, temp_sstate_location=True, should_pass=False)
+ self.run_test_sstate_creation(['linux-libc-headers'], distro_specific=True, distro_nonspecific=False, temp_sstate_location=True, should_pass=False)
# Test the sstate files deletion part of the do_cleansstate task
def run_test_cleansstate_task(self, targets, distro_specific=True, distro_nonspecific=True, temp_sstate_location=True):
@@ -79,23 +75,17 @@ class SStateTests(SStateBase):
@testcase(977)
def test_cleansstate_task_distro_specific_nonspecific(self):
targets = ['binutils-cross-'+ self.tune_arch, 'binutils-native']
- # glibc-initial is intended only for the glibc C library
- if self.tclibc == 'glibc':
- targets.append('glibc-initial')
+ targets.append('linux-libc-headers')
self.run_test_cleansstate_task(targets, distro_specific=True, distro_nonspecific=True, temp_sstate_location=True)
@testcase(1376)
def test_cleansstate_task_distro_nonspecific(self):
- # glibc-initial is intended only for the glibc C library
- if self.tclibc == 'glibc':
- self.run_test_cleansstate_task(['glibc-initial'], distro_specific=False, distro_nonspecific=True, temp_sstate_location=True)
+ self.run_test_cleansstate_task(['linux-libc-headers'], distro_specific=False, distro_nonspecific=True, temp_sstate_location=True)
@testcase(1377)
def test_cleansstate_task_distro_specific(self):
targets = ['binutils-cross-'+ self.tune_arch, 'binutils-native']
- # glibc-initial is intended only for the glibc C library
- if self.tclibc == 'glibc':
- targets.append('glibc-initial')
+ targets.append('linux-libc-headers')
self.run_test_cleansstate_task(targets, distro_specific=True, distro_nonspecific=False, temp_sstate_location=True)
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] no-static-libs: Add entry for ncurses
2017-04-07 16:41 [PATCH 1/4] selftest/sstatetests: Replace glibc-initial with linux-libc-headers Richard Purdie
@ 2017-04-07 16:41 ` Richard Purdie
2017-04-07 17:42 ` Andre McCurdy
2017-04-07 16:41 ` [PATCH 3/4] ncurses: Drop incorrect option Richard Purdie
2017-04-07 16:41 ` [PATCH 4/4] uninative-flags.inc: Build binutils-native as pie Richard Purdie
2 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2017-04-07 16:41 UTC (permalink / raw)
To: openembedded-core
Yes, the option to disable static libraries in boost really is
"--without-normal". Add this for ncurses and its variants.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/conf/distro/include/no-static-libs.inc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/meta/conf/distro/include/no-static-libs.inc b/meta/conf/distro/include/no-static-libs.inc
index 54f34a7..f8d8c09 100644
--- a/meta/conf/distro/include/no-static-libs.inc
+++ b/meta/conf/distro/include/no-static-libs.inc
@@ -33,3 +33,7 @@ DISABLE_STATIC_pn-libusb1-native = ""
EXTRA_OECONF_append = "${DISABLE_STATIC}"
EXTRA_OECMAKE_append_pn-libical = " -DSHARED_ONLY=True"
+
+EXCONFIG_ARGS_append_pn-ncurses = " --without-normal"
+EXCONFIG_ARGS_append_pn-ncurses-native = " --without-normal"
+EXCONFIG_ARGS_append_pn-nativesdk-ncurses = " --without-normal"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] ncurses: Drop incorrect option
2017-04-07 16:41 [PATCH 1/4] selftest/sstatetests: Replace glibc-initial with linux-libc-headers Richard Purdie
2017-04-07 16:41 ` [PATCH 2/4] no-static-libs: Add entry for ncurses Richard Purdie
@ 2017-04-07 16:41 ` Richard Purdie
2017-04-07 16:41 ` [PATCH 4/4] uninative-flags.inc: Build binutils-native as pie Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2017-04-07 16:41 UTC (permalink / raw)
To: openembedded-core
The --disable-static option doesn't exist in ncurses. Its equivalent is
--without-normal so remove the option which does nothing.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/recipes-core/ncurses/ncurses.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
index 3f4bf67..8990b0f 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -66,7 +66,6 @@ ncurses_configure() {
cd $1
shift
oe_runconf \
- --disable-static \
--without-debug \
--without-ada \
--without-gpm \
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] uninative-flags.inc: Build binutils-native as pie
2017-04-07 16:41 [PATCH 1/4] selftest/sstatetests: Replace glibc-initial with linux-libc-headers Richard Purdie
2017-04-07 16:41 ` [PATCH 2/4] no-static-libs: Add entry for ncurses Richard Purdie
2017-04-07 16:41 ` [PATCH 3/4] ncurses: Drop incorrect option Richard Purdie
@ 2017-04-07 16:41 ` Richard Purdie
2 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2017-04-07 16:41 UTC (permalink / raw)
To: openembedded-core
Some distros (ubuntu 16.10, debian-testing) default to gcc configured with
--enable-default-pie (see gcc -v). This breaks e.g. prelink-native on a pie
default system if binutils-native was built on a system which is not pie default
We therefore enable pie unconditionally for native recipes where static libs are
used such as libiberty from binutils, for now, until our minimum distro set is
all default pie.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
meta/conf/distro/include/uninative-flags.inc | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/meta/conf/distro/include/uninative-flags.inc b/meta/conf/distro/include/uninative-flags.inc
index e9f82c3..b6a944e 100644
--- a/meta/conf/distro/include/uninative-flags.inc
+++ b/meta/conf/distro/include/uninative-flags.inc
@@ -7,3 +7,11 @@ BUILD_CXXFLAGS_append = " -D_GLIBCXX_USE_CXX11_ABI=0"
# icu configure defaults to CXX11 if no -std= option is passed in CXXFLAGS
# therefore pass one
BUILD_CXXFLAGS_append_pn-icu-native = " -std=c++98"
+
+# Some distros (ubuntu 16.10, debian-testing) default to gcc configured with
+# --enable-default-pie (see gcc -v). This breaks e.g. prelink-native on a pie
+# default system if binutils-native was built on a system which is not pie default
+# We therefore enable pie unconditionally for native recipes where static libs are
+# used such as libiberty from binutils, for now, until our minimum distro set is
+# all default pie.
+BUILD_CFLAGS_append_pn-binutils-native = " -pie -fpie"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] no-static-libs: Add entry for ncurses
2017-04-07 16:41 ` [PATCH 2/4] no-static-libs: Add entry for ncurses Richard Purdie
@ 2017-04-07 17:42 ` Andre McCurdy
2017-04-07 21:44 ` Richard Purdie
0 siblings, 1 reply; 6+ messages in thread
From: Andre McCurdy @ 2017-04-07 17:42 UTC (permalink / raw)
To: Richard Purdie; +Cc: OE Core mailing list
On Fri, Apr 7, 2017 at 9:41 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Yes, the option to disable static libraries in boost really is
boost or ncurses?
> "--without-normal". Add this for ncurses and its variants.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/conf/distro/include/no-static-libs.inc | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/meta/conf/distro/include/no-static-libs.inc b/meta/conf/distro/include/no-static-libs.inc
> index 54f34a7..f8d8c09 100644
> --- a/meta/conf/distro/include/no-static-libs.inc
> +++ b/meta/conf/distro/include/no-static-libs.inc
> @@ -33,3 +33,7 @@ DISABLE_STATIC_pn-libusb1-native = ""
> EXTRA_OECONF_append = "${DISABLE_STATIC}"
>
> EXTRA_OECMAKE_append_pn-libical = " -DSHARED_ONLY=True"
> +
> +EXCONFIG_ARGS_append_pn-ncurses = " --without-normal"
> +EXCONFIG_ARGS_append_pn-ncurses-native = " --without-normal"
> +EXCONFIG_ARGS_append_pn-nativesdk-ncurses = " --without-normal"
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/4] no-static-libs: Add entry for ncurses
2017-04-07 17:42 ` Andre McCurdy
@ 2017-04-07 21:44 ` Richard Purdie
0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2017-04-07 21:44 UTC (permalink / raw)
To: Andre McCurdy; +Cc: OE Core mailing list
On Fri, 2017-04-07 at 10:42 -0700, Andre McCurdy wrote:
> On Fri, Apr 7, 2017 at 9:41 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> >
> > Yes, the option to disable static libraries in boost really is
> boost or ncurses?
ncurses. Its been a long day, I'll tweak the commit message, thanks.
If anyone does know how to disable static libs in boost I'd be
interested to know how!
Cheers,
Richard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-07 21:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-07 16:41 [PATCH 1/4] selftest/sstatetests: Replace glibc-initial with linux-libc-headers Richard Purdie
2017-04-07 16:41 ` [PATCH 2/4] no-static-libs: Add entry for ncurses Richard Purdie
2017-04-07 17:42 ` Andre McCurdy
2017-04-07 21:44 ` Richard Purdie
2017-04-07 16:41 ` [PATCH 3/4] ncurses: Drop incorrect option Richard Purdie
2017-04-07 16:41 ` [PATCH 4/4] uninative-flags.inc: Build binutils-native as pie Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.