All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@caviumnetworks.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Yury Norov <ynorov@caviumnetworks.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Jan Glauber <jglauber@cavium.com>
Subject: [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c
Date: Tue, 11 Apr 2017 01:35:02 +0400	[thread overview]
Message-ID: <1491860104-4103-2-git-send-email-ynorov@caviumnetworks.com> (raw)
In-Reply-To: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com>

qrwlock.c calls arch_spin_lock() and arch_spin_unlock() but doesn't
include the asm/spinlock.h, where those functions are defined. It
may produce "implicit declaration of function" errors. This patch
fixes it.

Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
 kernel/locking/qrwlock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
index cc3ed0c..6fb4292 100644
--- a/kernel/locking/qrwlock.c
+++ b/kernel/locking/qrwlock.c
@@ -20,6 +20,7 @@
 #include <linux/cpumask.h>
 #include <linux/percpu.h>
 #include <linux/hardirq.h>
+#include <asm/spinlock.h>
 #include <asm/qrwlock.h>
 
 /*
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: ynorov@caviumnetworks.com (Yury Norov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c
Date: Tue, 11 Apr 2017 01:35:02 +0400	[thread overview]
Message-ID: <1491860104-4103-2-git-send-email-ynorov@caviumnetworks.com> (raw)
In-Reply-To: <1491860104-4103-1-git-send-email-ynorov@caviumnetworks.com>

qrwlock.c calls arch_spin_lock() and arch_spin_unlock() but doesn't
include the asm/spinlock.h, where those functions are defined. It
may produce "implicit declaration of function" errors. This patch
fixes it.

Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
 kernel/locking/qrwlock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/locking/qrwlock.c b/kernel/locking/qrwlock.c
index cc3ed0c..6fb4292 100644
--- a/kernel/locking/qrwlock.c
+++ b/kernel/locking/qrwlock.c
@@ -20,6 +20,7 @@
 #include <linux/cpumask.h>
 #include <linux/percpu.h>
 #include <linux/hardirq.h>
+#include <asm/spinlock.h>
 #include <asm/qrwlock.h>
 
 /*
-- 
2.7.4

  reply	other threads:[~2017-04-10 21:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 21:35 [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks Yury Norov
2017-04-10 21:35 ` Yury Norov
2017-04-10 21:35 ` Yury Norov [this message]
2017-04-10 21:35   ` [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c Yury Norov
2017-04-10 21:35 ` [PATCH 2/3] asm-generic: don't #include <linux/atomic.h> in qspinlock_types.h Yury Norov
2017-04-10 21:35   ` Yury Norov
2017-04-10 21:35 ` [PATCH 3/3] arm64/locking: qspinlocks and qrwlocks support Yury Norov
2017-04-10 21:35   ` Yury Norov
2017-04-13 18:12   ` Peter Zijlstra
2017-04-13 18:12     ` Peter Zijlstra
2017-04-20 18:23     ` Yury Norov
2017-04-20 18:23       ` Yury Norov
2017-04-20 19:00       ` Mark Rutland
2017-04-20 19:00         ` Mark Rutland
2017-04-20 19:05       ` Peter Zijlstra
2017-04-20 19:05         ` Peter Zijlstra
2017-04-26 12:39         ` Yury Norov
2017-04-26 12:39           ` Yury Norov
2017-04-28 15:44           ` Will Deacon
2017-04-28 15:44             ` Will Deacon
2017-04-12 17:04 ` [RFC PATCH 0/3] arm64: queued spinlocks and rw-locks Adam Wallis
2017-04-12 17:04   ` Adam Wallis
2017-04-13 10:33   ` Yury Norov
2017-04-13 10:33     ` Yury Norov
2017-04-28 15:37     ` Will Deacon
2017-04-28 15:37       ` Will Deacon
2017-04-24 13:36   ` Will Deacon
2017-04-24 13:36     ` Will Deacon
2017-05-03 14:51 [PATCH " Yury Norov
2017-05-03 14:51 ` [PATCH 1/3] kernel/locking: #include <asm/spinlock.h> in qrwlock.c Yury Norov
2017-05-03 14:51   ` Yury Norov
2017-05-03 15:05   ` Geert Uytterhoeven
2017-05-03 15:05     ` Geert Uytterhoeven
2017-05-03 15:05     ` Geert Uytterhoeven
2017-05-03 15:05     ` Geert Uytterhoeven
2017-05-03 20:32     ` Yury Norov
2017-05-03 20:32       ` Yury Norov
2017-05-03 20:32       ` Yury Norov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491860104-4103-2-git-send-email-ynorov@caviumnetworks.com \
    --to=ynorov@caviumnetworks.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=jglauber@cavium.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.