[PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Zhixiong Chi]

After updating the autoconf-archive version to 2016.09.16, autoconf-archive
installs the same ax_*.m4 macros that gnome-common installs. So there will
be the conflict occurs.
The option '--with-autoconf-archive' is passed to configure, the macros
are not installed, and gnome-common will not install any M4 macros that
conflict with autoconf-archive.
At the same time, set the RDEPENDS for gnome-common.

Signed-off-by: Zhixiong Chi <zhixiong.chi@windriver.com>
---
 meta/recipes-gnome/gnome/gnome-common_3.18.0.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
index 06f3bb3..96817bb 100644
--- a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
+++ b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
@@ -14,6 +14,9 @@ SRC_URI[archive.sha256sum] = "22569e370ae755e04527b76328befc4c73b62bfd4a572499fd
 EXTRA_AUTORECONF = ""
 DEPENDS = ""
 
+EXTRA_OECONF += " --with-autoconf-archive"
+RDEPENDS_${PN} = "autoconf-archive"
+
 FILES_${PN} += "${datadir}/aclocal"
 FILES_${PN}-dev = ""
 
-- 
1.9.1

Re: [PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Alexander Kanavin]

On 04/12/2017 01:52 PM, Zhixiong Chi wrote:
> At the same time, set the RDEPENDS for gnome-common.
> --- a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
> +++ b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
> +RDEPENDS_${PN} = "autoconf-archive"

You cannot make oe-core recipes depend on recipes from other layers.

You probably need to patch autoconf-archive instead, or bring it into 
oe-core, or check why we need gnome-common in oe-core and if it can be 
moved out.

Alex

Re: [PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

On 12 April 2017 at 13:52, Zhixiong Chi <zhixiong.chi@windriver.com> wrote:

> After updating the autoconf-archive version to 2016.09.16, autoconf-archive
> installs the same ax_*.m4 macros that gnome-common installs. So there will
> be the conflict occurs.
> The option '--with-autoconf-archive' is passed to configure, the macros
> are not installed, and gnome-common will not install any M4 macros that
> conflict with autoconf-archive.
> At the same time, set the RDEPENDS for gnome-common.
>
> Signed-off-by: Zhixiong Chi <zhixiong.chi@windriver.com>
> ---
>  meta/recipes-gnome/gnome/gnome-common_3.18.0.bb | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
> b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
> index 06f3bb3..96817bb 100644
> --- a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
> +++ b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
> @@ -14,6 +14,9 @@ SRC_URI[archive.sha256sum] =
> "22569e370ae755e04527b76328befc4c73b62bfd4a572499fd
>  EXTRA_AUTORECONF = ""
>  DEPENDS = ""
>
> +EXTRA_OECONF += " --with-autoconf-archive"
> +RDEPENDS_${PN} = "autoconf-archive"
>

autoconf-archive is not in oe-core, is it?


> +
>  FILES_${PN} += "${datadir}/aclocal"
>  FILES_${PN}-dev = ""
>
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2883 bytes --]

Re: [PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Zhixiong Chi]

[-- Attachment #1: Type: text/plain, Size: 2385 bytes --]



On 2017年04月12日 19:04, Jussi Kukkonen wrote:
> On 12 April 2017 at 13:52, Zhixiong Chi <zhixiong.chi@windriver.com 
> <mailto:zhixiong.chi@windriver.com>> wrote:
>
>     After updating the autoconf-archive version to 2016.09.16,
>     autoconf-archive
>     installs the same ax_*.m4 macros that gnome-common installs. So
>     there will
>     be the conflict occurs.
>     The option '--with-autoconf-archive' is passed to configure, the
>     macros
>     are not installed, and gnome-common will not install any M4 macros
>     that
>     conflict with autoconf-archive.
>     At the same time, set the RDEPENDS for gnome-common.
>
>     Signed-off-by: Zhixiong Chi <zhixiong.chi@windriver.com
>     <mailto:zhixiong.chi@windriver.com>>
>     ---
>      meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
>     <http://gnome-common_3.18.0.bb> | 3 +++
>      1 file changed, 3 insertions(+)
>
>     diff --git a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
>     <http://gnome-common_3.18.0.bb>
>     b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
>     <http://gnome-common_3.18.0.bb>
>     index 06f3bb3..96817bb 100644
>     --- a/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
>     <http://gnome-common_3.18.0.bb>
>     +++ b/meta/recipes-gnome/gnome/gnome-common_3.18.0.bb
>     <http://gnome-common_3.18.0.bb>
>     @@ -14,6 +14,9 @@ SRC_URI[archive.sha256sum] =
>     "22569e370ae755e04527b76328befc4c73b62bfd4a572499fd
>      EXTRA_AUTORECONF = ""
>      DEPENDS = ""
>
>     +EXTRA_OECONF += " --with-autoconf-archive"
>     +RDEPENDS_${PN} = "autoconf-archive"
>
>
> autoconf-archive is not in oe-core, is it?

Yes,it is.
As Alex said, it shouldn't depend the recipe from the other layers.
I will try to move autoconf-archive into oe-core next step.

Thanks.

>     +
>      FILES_${PN} += "${datadir}/aclocal"
>      FILES_${PN}-dev = ""
>
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>

-- 
---------------------
Thanks,
Zhixiong Chi
Tel: +86-10-8477-7036


[-- Attachment #2: Type: text/html, Size: 5320 bytes --]

Re: [PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Alexander Kanavin]

On 04/13/2017 05:19 AM, Zhixiong Chi wrote:
>> autoconf-archive is not in oe-core, is it?
>>
>
> Yes,it is.
> As Alex said, it shouldn't depend the recipe from the other layers.
> I will try to move autoconf-archive into oe-core next step.

First research other ways to fix the issue please; we try to avoid 
unnecessary bloat in oe-core.

For example, how about deleting the conflicting macros from 
autoconf-archive, and making it depend on gnome-common? Or researching 
if we can get rid of gnome-common altogether in oe-core.

Alex

Re: [PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On 13 April 2017 at 08:02, Alexander Kanavin <
alexander.kanavin@linux.intel.com> wrote:

> On 04/13/2017 05:19 AM, Zhixiong Chi wrote:
>
>> autoconf-archive is not in oe-core, is it?
>>>
>>>
>> Yes,it is.
>> As Alex said, it shouldn't depend the recipe from the other layers.
>> I will try to move autoconf-archive into oe-core next step.
>>
>
> First research other ways to fix the issue please; we try to avoid
> unnecessary bloat in oe-core.
>
> For example, how about deleting the conflicting macros from
> autoconf-archive, and making it depend on gnome-common? Or researching if
> we can get rid of gnome-common altogether in oe-core.
>

I had a quick look at this. We have three recipes in oe-core that "need"
gnome-common (python3-pygobject, gnome-desktop3, matchbox-desktop). The
only meaningful usage of gnome-common in their configure.ac's is
GNOME_COMPILE_WARNINGS().

with this in mind I would not object to just the original patch with the
autoconf-archive dependency removed. However, it would be nice to build
test the meta-openembedded recipes that depend on gnome-common (and add a
dependency to autoconf-archive to the recipes that seem to need it).

Jussi

[-- Attachment #2: Type: text/html, Size: 1876 bytes --]

Re: [PATCH] gnome-common: add EXTRA_OECONF "--with-autoconf-archive"

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

On 13 April 2017 at 08:41, Jussi Kukkonen <jussi.kukkonen@intel.com> wrote:

> I had a quick look at this. We have three recipes in oe-core that "need"
> gnome-common (python3-pygobject, gnome-desktop3, matchbox-desktop). The
> only meaningful usage of gnome-common in their configure.ac's is
> GNOME_COMPILE_WARNINGS().
>

FWIW I patched matchbox-desktop in February but never submitted the srcrev
bump.  Now I wish I did...

Ross

[-- Attachment #2: Type: text/html, Size: 871 bytes --]