From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "jolsa@redhat.com" <jolsa@redhat.com>
Cc: "jolsa@kernel.org" <jolsa@kernel.org>,
"acme@redhat.com" <acme@redhat.com>,
"a.p.zijlstra@chello.nl" <a.p.zijlstra@chello.nl>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"davidcc@google.com" <davidcc@google.com>
Subject: Re: perf jvmti: unconditionally links against -lelf
Date: Wed, 12 Apr 2017 11:52:36 +0000 [thread overview]
Message-ID: <1491997955.4510.42.camel@synopsys.com> (raw)
In-Reply-To: <20170412101953.GB14409@krava>
Hi Jiri,
On Wed, 2017-04-12 at 12:19 +0200, Jiri Olsa wrote:
> On Wed, Apr 12, 2017 at 09:58:26AM +0000, Alexey Brodkin wrote:
> >
> > Hi Jiri,
> >
> > Just tried to cross-compile perf with pretty bare-minimal toolchain
> > which has no libelf installed for the target (for the record I used
> > SNPS ARC pre-built arc-2016.09 tools) like that:
> > --------------->8------------
> > make NO_LIBELF=1
> > --------------->8------------
> >
> > And got the following build failure:
> > --------------->8------------
> > LINK libperf-jvmti.so
> > .../2016.09-uclibc-archs/bin/../lib/gcc/arc-snps-linux-uclibc/6.2.1/../../../../arc-snps-linux-uclibc/bin/ld: cannot find -lelf
> > --------------->8------------
> >
> > First I was surprised because I intentionally disabled usage of libelf
> > but after some grepping figured out jvmti is linked against libelf
> > regardless any settings, see:
> > --------------->8------------
> > $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
> > $(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
> > endif
> > --------------->8------------
> >
> > This comes from commit d4dfdf00d43e ("perf jvmti: Plug compilation into perf build").
> >
> > I'm not really sure what could be the best solution to the problem I see.
> > If libelf is a real must for jvmti then probably we may force set NO_JVMTI=1
> > if NO_LIBELF=1 is passed on the command line.
> >
> > At least the following builds perf for me without issues:
> > --------------->8------------
> > make NO_LIBELF=1 NO_JVMTI=1
> > --------------->8------------
>
> hi,
> incidently, David just posted patch for this ;-)
So good to know somebody has already fixed my problem :)
Thanks for letting me know!
-Alexey
WARNING: multiple messages have this Message-ID (diff)
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: perf jvmti: unconditionally links against -lelf
Date: Wed, 12 Apr 2017 11:52:36 +0000 [thread overview]
Message-ID: <1491997955.4510.42.camel@synopsys.com> (raw)
In-Reply-To: <20170412101953.GB14409@krava>
Hi Jiri,
On Wed, 2017-04-12@12:19 +0200, Jiri Olsa wrote:
> On Wed, Apr 12, 2017@09:58:26AM +0000, Alexey Brodkin wrote:
> >
> > Hi Jiri,
> >
> > Just tried to cross-compile perf with pretty bare-minimal toolchain
> > which has no libelf installed for the target (for the record I used
> > SNPS ARC pre-built arc-2016.09 tools) like that:
> > --------------->8------------
> > make NO_LIBELF=1
> > --------------->8------------
> >
> > And got the following build failure:
> > --------------->8------------
> > ? LINK?????libperf-jvmti.so
> > .../2016.09-uclibc-archs/bin/../lib/gcc/arc-snps-linux-uclibc/6.2.1/../../../../arc-snps-linux-uclibc/bin/ld: cannot find -lelf
> > --------------->8------------
> >
> > First I was surprised because I intentionally disabled usage of libelf
> > but after some grepping figured out jvmti is linked against libelf
> > regardless any settings, see:
> > --------------->8------------
> > $(OUTPUT)$(LIBJVMTI): $(LIBJVMTI_IN)
> > ? ? ? ?$(QUIET_LINK)$(CC) -shared -Wl,-soname -Wl,$(LIBJVMTI) -o $@ $< -lelf -lrt
> > endif
> > --------------->8------------
> >
> > This comes from commit?d4dfdf00d43e ("perf jvmti: Plug compilation into perf build").
> >
> > I'm not really sure what could be the best solution to the problem I see.
> > If libelf is a real must for jvmti then probably we may force set?NO_JVMTI=1
> > if?NO_LIBELF=1 is passed on the command line.
> >
> > At least the following builds perf for me without issues:
> > --------------->8------------
> > make NO_LIBELF=1 NO_JVMTI=1
> > --------------->8------------
>
> hi,
> incidently, David just posted patch for this ;-)
So good to know somebody has already fixed my problem :)
Thanks for letting me know!
-Alexey
next prev parent reply other threads:[~2017-04-12 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 9:58 perf jvmti: unconditionally links against -lelf Alexey Brodkin
2017-04-12 9:58 ` Alexey Brodkin
2017-04-12 10:19 ` Jiri Olsa
2017-04-12 10:19 ` Jiri Olsa
2017-04-12 11:52 ` Alexey Brodkin [this message]
2017-04-12 11:52 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491997955.4510.42.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=davidcc@google.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.