* [PATCH] ethtool: disable promiscuous mode by default
@ 2017-04-12 19:58 Qi Zhang
2017-04-18 14:26 ` Remy Horton
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2017-04-12 19:58 UTC (permalink / raw)
To: remy.horton; +Cc: dev, Qi Zhang
Disable promiscuous mode by default since VLAN filter
does not work when promiscuous mode is enabled.
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
examples/ethtool/ethtool-app/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/examples/ethtool/ethtool-app/main.c b/examples/ethtool/ethtool-app/main.c
index 2c655d8..6d50d46 100644
--- a/examples/ethtool/ethtool-app/main.c
+++ b/examples/ethtool/ethtool-app/main.c
@@ -172,7 +172,6 @@ static void setup_ports(struct app_config *app_cfg, int cnt_ports)
"%s:%i: rte_eth_dev_start failed",
__FILE__, __LINE__
);
- rte_eth_promiscuous_enable(idx_port);
rte_eth_macaddr_get(idx_port, &ptr_port->mac_addr);
rte_spinlock_init(&ptr_port->lock);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ethtool: disable promiscuous mode by default
2017-04-12 19:58 [PATCH] ethtool: disable promiscuous mode by default Qi Zhang
@ 2017-04-18 14:26 ` Remy Horton
2017-04-21 0:23 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Remy Horton @ 2017-04-18 14:26 UTC (permalink / raw)
To: Qi Zhang; +Cc: dev
Probably ought to also add a new command so that promiscuous mode can be
enabled if needed.
On 12/04/2017 20:58, Qi Zhang wrote:
> Disable promiscuous mode by default since VLAN filter
> does not work when promiscuous mode is enabled.
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> examples/ethtool/ethtool-app/main.c | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Remy Horton <remy.horton@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ethtool: disable promiscuous mode by default
2017-04-18 14:26 ` Remy Horton
@ 2017-04-21 0:23 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-04-21 0:23 UTC (permalink / raw)
To: Qi Zhang; +Cc: dev, Remy Horton
18/04/2017 16:26, Remy Horton:
> Probably ought to also add a new command so that promiscuous mode can be
> enabled if needed.
>
> On 12/04/2017 20:58, Qi Zhang wrote:
> > Disable promiscuous mode by default since VLAN filter
> > does not work when promiscuous mode is enabled.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > examples/ethtool/ethtool-app/main.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Remy Horton <remy.horton@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-21 0:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-12 19:58 [PATCH] ethtool: disable promiscuous mode by default Qi Zhang
2017-04-18 14:26 ` Remy Horton
2017-04-21 0:23 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.