* [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
@ 2017-04-17 16:13 ` Alexey Brodkin
0 siblings, 0 replies; 6+ messages in thread
From: Alexey Brodkin @ 2017-04-17 16:13 UTC (permalink / raw)
To: linux-snps-arc
We used to have opencoded ehci_readl()/writel() which required no
external functions to be called.
Now with attempt to switch to generic readl()/writel() accessors
we see a missing declaration of those accessors in ehci-ppc4xx.
Something like that happens if applied
http://patchwork.ozlabs.org/patch/726714/:
---------------->8---------------
CC drivers/usb/host/ehci-ppc4xx.o
drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init':
drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration]
HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
^
---------------->8---------------
Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
Cc: Tom Rini <trini at konsulko.com>
Cc: Marek Vasut <marex at denx.de>
Cc: Stefan Roese <sr at denx.de>
---
drivers/usb/host/ehci-ppc4xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-ppc4xx.c b/drivers/usb/host/ehci-ppc4xx.c
index 9aee3ff786cb..9d235776428e 100644
--- a/drivers/usb/host/ehci-ppc4xx.c
+++ b/drivers/usb/host/ehci-ppc4xx.c
@@ -8,6 +8,7 @@
*/
#include <common.h>
#include <usb.h>
+#include <asm/io.h>
#include "ehci.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
@ 2017-04-17 16:13 ` Alexey Brodkin
0 siblings, 0 replies; 6+ messages in thread
From: Alexey Brodkin @ 2017-04-17 16:13 UTC (permalink / raw)
To: u-boot
We used to have opencoded ehci_readl()/writel() which required no
external functions to be called.
Now with attempt to switch to generic readl()/writel() accessors
we see a missing declaration of those accessors in ehci-ppc4xx.
Something like that happens if applied
http://patchwork.ozlabs.org/patch/726714/:
---------------->8---------------
CC drivers/usb/host/ehci-ppc4xx.o
drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init':
drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration]
HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
^
---------------->8---------------
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefan Roese <sr@denx.de>
---
drivers/usb/host/ehci-ppc4xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ehci-ppc4xx.c b/drivers/usb/host/ehci-ppc4xx.c
index 9aee3ff786cb..9d235776428e 100644
--- a/drivers/usb/host/ehci-ppc4xx.c
+++ b/drivers/usb/host/ehci-ppc4xx.c
@@ -8,6 +8,7 @@
*/
#include <common.h>
#include <usb.h>
+#include <asm/io.h>
#include "ehci.h"
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
2017-04-17 16:13 ` [U-Boot] " Alexey Brodkin
@ 2017-04-19 10:05 ` Stefan Roese
-1 siblings, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2017-04-19 10:05 UTC (permalink / raw)
To: linux-snps-arc
On 17.04.2017 18:13, Alexey Brodkin wrote:
> We used to have opencoded ehci_readl()/writel() which required no
> external functions to be called.
>
> Now with attempt to switch to generic readl()/writel() accessors
> we see a missing declaration of those accessors in ehci-ppc4xx.
> Something like that happens if applied
> http://patchwork.ozlabs.org/patch/726714/:
> ---------------->8---------------
> CC drivers/usb/host/ehci-ppc4xx.o
> drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init':
> drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration]
> HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
> ^
> ---------------->8---------------
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Stefan Roese <sr at denx.de>
> ---
> drivers/usb/host/ehci-ppc4xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-ppc4xx.c b/drivers/usb/host/ehci-ppc4xx.c
> index 9aee3ff786cb..9d235776428e 100644
> --- a/drivers/usb/host/ehci-ppc4xx.c
> +++ b/drivers/usb/host/ehci-ppc4xx.c
> @@ -8,6 +8,7 @@
> */
> #include <common.h>
> #include <usb.h>
> +#include <asm/io.h>
>
> #include "ehci.h"
>
>
Alexey, thanks for looking into this:
Reviewed-by: Stefan Roese <sr at denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
@ 2017-04-19 10:05 ` Stefan Roese
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Roese @ 2017-04-19 10:05 UTC (permalink / raw)
To: u-boot
On 17.04.2017 18:13, Alexey Brodkin wrote:
> We used to have opencoded ehci_readl()/writel() which required no
> external functions to be called.
>
> Now with attempt to switch to generic readl()/writel() accessors
> we see a missing declaration of those accessors in ehci-ppc4xx.
> Something like that happens if applied
> http://patchwork.ozlabs.org/patch/726714/:
> ---------------->8---------------
> CC drivers/usb/host/ehci-ppc4xx.o
> drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init':
> drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of function 'readl' [-Wimplicit-function-declaration]
> HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
> ^
> ---------------->8---------------
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefan Roese <sr@denx.de>
> ---
> drivers/usb/host/ehci-ppc4xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ehci-ppc4xx.c b/drivers/usb/host/ehci-ppc4xx.c
> index 9aee3ff786cb..9d235776428e 100644
> --- a/drivers/usb/host/ehci-ppc4xx.c
> +++ b/drivers/usb/host/ehci-ppc4xx.c
> @@ -8,6 +8,7 @@
> */
> #include <common.h>
> #include <usb.h>
> +#include <asm/io.h>
>
> #include "ehci.h"
>
>
Alexey, thanks for looking into this:
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
2017-04-19 10:05 ` [U-Boot] " Stefan Roese
@ 2017-04-19 10:17 ` Marek Vasut
-1 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2017-04-19 10:17 UTC (permalink / raw)
To: linux-snps-arc
On 04/19/2017 12:05 PM, Stefan Roese wrote:
> On 17.04.2017 18:13, Alexey Brodkin wrote:
>> We used to have opencoded ehci_readl()/writel() which required no
>> external functions to be called.
>>
>> Now with attempt to switch to generic readl()/writel() accessors
>> we see a missing declaration of those accessors in ehci-ppc4xx.
>> Something like that happens if applied
>> http://patchwork.ozlabs.org/patch/726714/:
>> ---------------->8---------------
>> CC drivers/usb/host/ehci-ppc4xx.o
>> drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init':
>> drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of
>> function 'readl' [-Wimplicit-function-declaration]
>> HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
>> ^
>> ---------------->8---------------
>>
>> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
>> Cc: Tom Rini <trini at konsulko.com>
>> Cc: Marek Vasut <marex at denx.de>
>> Cc: Stefan Roese <sr at denx.de>
>> ---
>> drivers/usb/host/ehci-ppc4xx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/ehci-ppc4xx.c
>> b/drivers/usb/host/ehci-ppc4xx.c
>> index 9aee3ff786cb..9d235776428e 100644
>> --- a/drivers/usb/host/ehci-ppc4xx.c
>> +++ b/drivers/usb/host/ehci-ppc4xx.c
>> @@ -8,6 +8,7 @@
>> */
>> #include <common.h>
>> #include <usb.h>
>> +#include <asm/io.h>
>>
>> #include "ehci.h"
>>
>>
>
> Alexey, thanks for looking into this:
>
> Reviewed-by: Stefan Roese <sr at denx.de>
Applied, thanks.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors
@ 2017-04-19 10:17 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2017-04-19 10:17 UTC (permalink / raw)
To: u-boot
On 04/19/2017 12:05 PM, Stefan Roese wrote:
> On 17.04.2017 18:13, Alexey Brodkin wrote:
>> We used to have opencoded ehci_readl()/writel() which required no
>> external functions to be called.
>>
>> Now with attempt to switch to generic readl()/writel() accessors
>> we see a missing declaration of those accessors in ehci-ppc4xx.
>> Something like that happens if applied
>> http://patchwork.ozlabs.org/patch/726714/:
>> ---------------->8---------------
>> CC drivers/usb/host/ehci-ppc4xx.o
>> drivers/usb/host/ehci-ppc4xx.c: In function 'ehci_hcd_init':
>> drivers/usb/host/ehci-ppc4xx.c:23:3: warning: implicit declaration of
>> function 'readl' [-Wimplicit-function-declaration]
>> HC_LENGTH(ehci_readl(&(*hccr)->cr_capbase)));
>> ^
>> ---------------->8---------------
>>
>> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: Marek Vasut <marex@denx.de>
>> Cc: Stefan Roese <sr@denx.de>
>> ---
>> drivers/usb/host/ehci-ppc4xx.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/host/ehci-ppc4xx.c
>> b/drivers/usb/host/ehci-ppc4xx.c
>> index 9aee3ff786cb..9d235776428e 100644
>> --- a/drivers/usb/host/ehci-ppc4xx.c
>> +++ b/drivers/usb/host/ehci-ppc4xx.c
>> @@ -8,6 +8,7 @@
>> */
>> #include <common.h>
>> #include <usb.h>
>> +#include <asm/io.h>
>>
>> #include "ehci.h"
>>
>>
>
> Alexey, thanks for looking into this:
>
> Reviewed-by: Stefan Roese <sr@denx.de>
Applied, thanks.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-19 10:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-17 16:13 [PATCH] ehci-ppc4xx: Prepare for usage of readl()/writel() accessors Alexey Brodkin
2017-04-17 16:13 ` [U-Boot] " Alexey Brodkin
2017-04-19 10:05 ` Stefan Roese
2017-04-19 10:05 ` [U-Boot] " Stefan Roese
2017-04-19 10:17 ` Marek Vasut
2017-04-19 10:17 ` [U-Boot] " Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.