* [PATCH 1/1] usb: host: xhci: print correct command ring address
@ 2017-04-18 10:30 Peter Chen
2017-04-19 15:23 ` David Laight
0 siblings, 1 reply; 2+ messages in thread
From: Peter Chen @ 2017-04-18 10:30 UTC (permalink / raw)
To: mathias.nyman; +Cc: linux-usb, Peter Chen, stable
Print correct command ring address using 'val_64'.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/usb/host/xhci-mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index de1503c..d7879f1 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2492,7 +2492,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
(xhci->cmd_ring->first_seg->dma & (u64) ~CMD_RING_RSVD_BITS) |
xhci->cmd_ring->cycle_state;
xhci_dbg_trace(xhci, trace_xhci_dbg_init,
- "// Setting command ring address to 0x%x", val);
+ "// Setting command ring address to 0x%016llx", val_64);
xhci_write_64(xhci, val_64, &xhci->op_regs->cmd_ring);
xhci_dbg_cmd_ptrs(xhci);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH 1/1] usb: host: xhci: print correct command ring address
2017-04-18 10:30 [PATCH 1/1] usb: host: xhci: print correct command ring address Peter Chen
@ 2017-04-19 15:23 ` David Laight
0 siblings, 0 replies; 2+ messages in thread
From: David Laight @ 2017-04-19 15:23 UTC (permalink / raw)
To: 'Peter Chen', mathias.nyman; +Cc: linux-usb, stable
From: Peter Chen
> Print correct command ring address using 'val_64'.
>
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/usb/host/xhci-mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
> index de1503c..d7879f1 100644
> --- a/drivers/usb/host/xhci-mem.c
> +++ b/drivers/usb/host/xhci-mem.c
> @@ -2492,7 +2492,7 @@ int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
> (xhci->cmd_ring->first_seg->dma & (u64) ~CMD_RING_RSVD_BITS) |
> xhci->cmd_ring->cycle_state;
> xhci_dbg_trace(xhci, trace_xhci_dbg_init,
> - "// Setting command ring address to 0x%x", val);
> + "// Setting command ring address to 0x%016llx", val_64);
Using "%#llx" might be better - especially if this code is used on 32bit.
David
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-19 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-18 10:30 [PATCH 1/1] usb: host: xhci: print correct command ring address Peter Chen
2017-04-19 15:23 ` David Laight
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.