All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] crypto/scheduler: fix slave init attach
@ 2017-04-19 13:42 Fan Zhang
  2017-04-19 16:04 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 2+ messages in thread
From: Fan Zhang @ 2017-04-19 13:42 UTC (permalink / raw)
  To: dev; +Cc: pablo.de.lara.guarch, stable

Fixes: 881851676940 ("crypto/scheduler: improve commandline parsing")

This patch fix the slaves attaching initially.

Originally, the scheduler will try to attach the slaves passed by the
cmdline option in the initial stage, this may break the sequence
of the slaves inside the scheduler.

Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
 drivers/crypto/scheduler/scheduler_pmd.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c
index f2a1d2a..2a92d1e 100644
--- a/drivers/crypto/scheduler/scheduler_pmd.c
+++ b/drivers/crypto/scheduler/scheduler_pmd.c
@@ -160,27 +160,6 @@ cryptodev_scheduler_create(const char *name,
 	}
 
 	for (i = 0; i < init_params->nb_slaves; i++) {
-		struct rte_cryptodev *slave_dev =
-				rte_cryptodev_pmd_get_named_dev(
-					init_params->slave_names[i]);
-
-		/* if the slave dev exists in the system, attach it */
-		if (slave_dev) {
-			int ret = rte_cryptodev_scheduler_slave_attach(
-				dev->data->dev_id,
-				slave_dev->data->dev_id);
-
-			if (ret < 0)
-				return ret;
-
-			CS_LOG_INFO("Scheduler %s attached slave %s\n",
-					dev->data->name,
-					init_params->slave_names[i]);
-
-			continue;
-		}
-
-		/* if the slave doesn't exist, store and attach later*/
 		sched_ctx->init_slave_names[sched_ctx->nb_init_slaves] =
 			rte_zmalloc_socket(
 				NULL,
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto/scheduler: fix slave init attach
  2017-04-19 13:42 [PATCH] crypto/scheduler: fix slave init attach Fan Zhang
@ 2017-04-19 16:04 ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 2+ messages in thread
From: De Lara Guarch, Pablo @ 2017-04-19 16:04 UTC (permalink / raw)
  To: Zhang, Roy Fan, dev; +Cc: stable



> -----Original Message-----
> From: Zhang, Roy Fan
> Sent: Wednesday, April 19, 2017 2:42 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; stable@dpdk.com
> Subject: [PATCH] crypto/scheduler: fix slave init attach
> 
> Fixes: 881851676940 ("crypto/scheduler: improve commandline parsing")
> 
> This patch fix the slaves attaching initially.
> 
> Originally, the scheduler will try to attach the slaves passed by the
> cmdline option in the initial stage, this may break the sequence
> of the slaves inside the scheduler.
> 
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>

Squashed into the affected commit in the subtree.

Thanks,
Pablo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-19 16:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-19 13:42 [PATCH] crypto/scheduler: fix slave init attach Fan Zhang
2017-04-19 16:04 ` De Lara Guarch, Pablo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.