All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Luck," Tony" <tony.luck@intel.com>,
	"stable@vger.kernel.org,  <stable@vger.kernel.org>
Subject: Re: [PATCH] acpi, nfit: fix the memory error check in nfit_handle_mce
Date: Thu, 20 Apr 2017 22:21:31 +0000	[thread overview]
Message-ID: <1492726809.2738.23.camel@intel.com> (raw)
In-Reply-To: <20170420221818.23522-1-vishal.l.verma@intel.com>

On Thu, 2017-04-20 at 16:18 -0600, Vishal Verma wrote:
> The check for an MCE being a memory error in the NFIT mce handler was
> bogus. Fix it to check for the correct MCA status compound error code.
> 
> Reported-by: Tony Luck <tony.luck@intel.com>
> Cc: <stable@vger.kernel.org>

Forgot to include,
Fixes: 6839a6d96f4e nfit: do an ARS scrub on hitting a latent media error

> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  drivers/acpi/nfit/mce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c
> index 3ba1c34..23e12a0 100644
> --- a/drivers/acpi/nfit/mce.c
> +++ b/drivers/acpi/nfit/mce.c
> @@ -26,7 +26,7 @@ static int nfit_handle_mce(struct notifier_block
> *nb, unsigned long val,
>  	struct nfit_spa *nfit_spa;
>  
>  	/* We only care about memory errors */
> -	if (!(mce->status & MCACOD))
> +	if (!(mce->status & 0xef80) == BIT(7))
>  		return NOTIFY_DONE;
>  
>  	/*
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "Luck, Tony" <tony.luck@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH] acpi, nfit: fix the memory error check in nfit_handle_mce
Date: Thu, 20 Apr 2017 22:21:31 +0000	[thread overview]
Message-ID: <1492726809.2738.23.camel@intel.com> (raw)
In-Reply-To: <20170420221818.23522-1-vishal.l.verma@intel.com>

On Thu, 2017-04-20 at 16:18 -0600, Vishal Verma wrote:
> The check for an MCE being a memory error in the NFIT mce handler was
> bogus. Fix it to check for the correct MCA status compound error code.
> 
> Reported-by: Tony Luck <tony.luck@intel.com>
> Cc: <stable@vger.kernel.org>

Forgot to include,
Fixes: 6839a6d96f4e nfit: do an ARS scrub on hitting a latent media error

> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
>  drivers/acpi/nfit/mce.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c
> index 3ba1c34..23e12a0 100644
> --- a/drivers/acpi/nfit/mce.c
> +++ b/drivers/acpi/nfit/mce.c
> @@ -26,7 +26,7 @@ static int nfit_handle_mce(struct notifier_block
> *nb, unsigned long val,
>  	struct nfit_spa *nfit_spa;
>  
>  	/* We only care about memory errors */
> -	if (!(mce->status & MCACOD))
> +	if (!(mce->status & 0xef80) == BIT(7))
>  		return NOTIFY_DONE;
>  
>  	/*

  reply	other threads:[~2017-04-20 22:21 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-20 22:18 [PATCH] acpi, nfit: fix the memory error check in nfit_handle_mce Vishal Verma
2017-04-20 22:18 ` Vishal Verma
2017-04-20 22:18 ` Vishal Verma
2017-04-20 22:21 ` Verma, Vishal L [this message]
2017-04-20 22:21   ` Verma, Vishal L
2017-04-21  2:21 ` kbuild test robot
2017-04-21  2:21   ` kbuild test robot
2017-04-21  2:21   ` kbuild test robot
2017-04-21 19:21 ` Dan Williams
2017-04-21 19:21   ` Dan Williams
2017-04-21 19:56   ` Verma, Vishal L
2017-04-21 19:56     ` Verma, Vishal L
2017-04-21 19:56     ` Verma, Vishal L
2017-04-21 20:16     ` Luck, Tony
2017-04-21 20:16       ` Luck, Tony
2017-04-21 20:16       ` Luck, Tony
2017-04-21 20:19       ` Dan Williams
2017-04-21 20:19         ` Dan Williams
2017-04-21 20:27         ` Luck, Tony
2017-04-21 20:27           ` Luck, Tony
2017-04-21 21:07           ` Borislav Petkov
2017-04-21 21:07             ` Borislav Petkov
2017-04-21 21:07             ` Borislav Petkov
2017-04-24 11:36             ` [PATCH 1/2] x86/MCE: Export memory_error() Borislav Petkov
2017-04-24 11:36               ` Borislav Petkov
2017-04-25 21:07               ` Vishal Verma
2017-04-25 21:07                 ` Vishal Verma
2017-05-10 19:31                 ` Verma, Vishal L
2017-05-10 19:31                   ` Verma, Vishal L
2017-05-10 19:31                   ` Verma, Vishal L
2017-05-10 20:04                   ` Borislav Petkov
2017-05-10 20:04                     ` Borislav Petkov
2017-05-10 20:06                     ` Verma, Vishal L
2017-05-10 20:06                       ` Verma, Vishal L
2017-05-10 20:08                       ` Borislav Petkov
2017-05-10 20:08                         ` Borislav Petkov
2017-05-10 21:12                         ` Verma, Vishal L
2017-05-10 21:12                           ` Verma, Vishal L
2017-05-10 21:57                           ` Borislav Petkov
2017-05-10 21:57                             ` Borislav Petkov
2017-05-10 22:03                             ` Verma, Vishal L
2017-05-10 22:03                               ` Verma, Vishal L
2017-05-10 22:16                               ` Borislav Petkov
2017-05-10 22:16                                 ` Borislav Petkov
2017-05-10 22:16                                 ` Borislav Petkov
2017-05-10 22:22                                 ` Verma, Vishal L
2017-05-10 22:22                                   ` Verma, Vishal L
2017-05-17 12:38                                   ` Borislav Petkov
2017-05-17 12:38                                     ` Borislav Petkov
2017-05-17 12:38                                     ` Borislav Petkov
2017-05-17 18:58                                     ` Verma, Vishal L
2017-05-17 18:58                                       ` Verma, Vishal L
2017-05-17 19:20                                       ` Borislav Petkov
2017-05-17 19:20                                         ` Borislav Petkov
2017-04-24 11:37             ` [PATCH 2/2] x86/ras/mce_amd_inj: Preset MCE injection struct Borislav Petkov
2017-04-24 11:37               ` Borislav Petkov
2017-04-26 19:59               ` kbuild test robot
2017-04-26 19:59                 ` kbuild test robot
2017-04-21 20:35       ` [PATCH] acpi, nfit: fix the memory error check in nfit_handle_mce Vishal Verma
2017-04-21 20:35         ` Vishal Verma
2017-04-21 20:35         ` Vishal Verma
2017-04-21 20:50         ` Luck, Tony
2017-04-21 20:50           ` Luck, Tony
2017-04-21 20:50           ` Luck, Tony
2017-04-21 20:54           ` Vishal Verma
2017-04-21 20:54             ` Vishal Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492726809.2738.23.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.