[PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG

[PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG

[Stefano Babic]

In case the defconfig was created with "make savedefconfig", it is not
enough to copy it to defconfig as it is done now. In fact, running make
${KBUILD_DEFCONFIG}, as usually when building the kernel outside poky,
does much more and the resulting .config file is different as the starting one.
The file generated by "make savedefconfig" contains in most cases a
subset of all options that are required for the kernel, and other
options are inserted automatically when make is called.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 meta/classes/kernel-yocto.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 0330270..27ff8b7 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -109,7 +109,8 @@ do_kernel_metadata() {
 					bbwarn "defconfig detected in WORKDIR. ${KBUILD_DEFCONFIG} skipped"
 				fi
 			else
-				cp -f ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG} ${WORKDIR}/defconfig
+                                oe_runmake -C ${S} O=${B} ${KBUILD_DEFCONFIG}
+                                mv ${B}/.config ${WORKDIR}/defconfig
 				sccs="${WORKDIR}/defconfig"
 			fi
 		else
-- 
2.7.4

Re: [PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]

On Wed, Apr 26, 2017 at 9:19 AM, Stefano Babic <sbabic@denx.de> wrote:

> In case the defconfig was created with "make savedefconfig", it is not
> enough to copy it to defconfig as it is done now. In fact, running make
> ${KBUILD_DEFCONFIG}, as usually when building the kernel outside poky,
> does much more and the resulting .config file is different as the starting
> one.
> The file generated by "make savedefconfig" contains in most cases a
> subset of all options that are required for the kernel, and other
> options are inserted automatically when make is called.
>
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
>  meta/classes/kernel-yocto.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass
> b/meta/classes/kernel-yocto.bbclass
> index 0330270..27ff8b7 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -109,7 +109,8 @@ do_kernel_metadata() {
>                                         bbwarn "defconfig detected in
> WORKDIR. ${KBUILD_DEFCONFIG} skipped"
>                                 fi
>                         else
> -                               cp -f ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG}
> ${WORKDIR}/defconfig
> +                                oe_runmake -C ${S} O=${B}
> ${KBUILD_DEFCONFIG}
>


This would need to be a different mode in the configuration task, not here.
This routine only gathers inputs, and doesn't process them.

I have an open bug for this, and a WIP patch that will go out early in the
2.4 release cycle.

Bruce


> +                                mv ${B}/.config ${WORKDIR}/defconfig
>                                 sccs="${WORKDIR}/defconfig"
>                         fi
>                 else
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"

[-- Attachment #2: Type: text/html, Size: 3315 bytes --]

Re: [PATCH] kernel-yocto: run make config for KBUILD_DEFCONFIG

[Stefano Babic]

On 26/04/2017 15:56, Bruce Ashfield wrote:
> 
> 
> On Wed, Apr 26, 2017 at 9:19 AM, Stefano Babic <sbabic@denx.de
> <mailto:sbabic@denx.de>> wrote:
> 
>     In case the defconfig was created with "make savedefconfig", it is not
>     enough to copy it to defconfig as it is done now. In fact, running make
>     ${KBUILD_DEFCONFIG}, as usually when building the kernel outside poky,
>     does much more and the resulting .config file is different as the
>     starting one.
>     The file generated by "make savedefconfig" contains in most cases a
>     subset of all options that are required for the kernel, and other
>     options are inserted automatically when make is called.
> 
>     Signed-off-by: Stefano Babic <sbabic@denx.de <mailto:sbabic@denx.de>>
>     ---
>      meta/classes/kernel-yocto.bbclass | 3 ++-
>      1 file changed, 2 insertions(+), 1 deletion(-)
> 
>     diff --git a/meta/classes/kernel-yocto.bbclass
>     b/meta/classes/kernel-yocto.bbclass
>     index 0330270..27ff8b7 100644
>     --- a/meta/classes/kernel-yocto.bbclass
>     +++ b/meta/classes/kernel-yocto.bbclass
>     @@ -109,7 +109,8 @@ do_kernel_metadata() {
>                                             bbwarn "defconfig detected
>     in WORKDIR. ${KBUILD_DEFCONFIG} skipped"
>                                     fi
>                             else
>     -                               cp -f
>     ${S}/arch/${ARCH}/configs/${KBUILD_DEFCONFIG} ${WORKDIR}/defconfig
>     +                                oe_runmake -C ${S} O=${B}
>     ${KBUILD_DEFCONFIG}
> 
> 
> 
> This would need to be a different mode in the configuration task, not here.
> This routine only gathers inputs, and doesn't process them.
> 

Understood.

> I have an open bug for this, and a WIP patch that will go out early in the
> 2.4 release cycle.
> 

Got it, thanks for info !

Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================