* [Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds
@ 2017-04-26 13:36 Greg Kurz
2017-04-28 15:49 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Greg Kurz @ 2017-04-26 13:36 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi
Since commit "c53eeaf75a04 configure: eliminate Python dependency for
--help", configure --help fails to produce the list of available trace
backends if invoked out-of-tree. It also spits the following error:
grep: scripts/tracetool/backend/*.py: No such file or directory
This patch simply adds the missing $source_path to fix it.
Signed-off-by: Greg Kurz <groug@kaod.org>
---
v2: - use "$source_path" instead of $source_path
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index c35acf119261..c434736c2e27 100755
--- a/configure
+++ b/configure
@@ -1271,7 +1271,7 @@ for config in $mak_wilds; do
done
# Enumerate public trace backends for --help output
-trace_backend_list=$(echo $(grep -le '^PUBLIC = True$' scripts/tracetool/backend/*.py | sed -e 's/^.*\/\(.*\)\.py$/\1/'))
+trace_backend_list=$(echo $(grep -le '^PUBLIC = True$' "$source_path"/scripts/tracetool/backend/*.py | sed -e 's/^.*\/\(.*\)\.py$/\1/'))
if test x"$show_help" = x"yes" ; then
cat << EOF
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds
2017-04-26 13:36 [Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds Greg Kurz
@ 2017-04-28 15:49 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2017-04-28 15:49 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-devel, Peter Maydell, Stefan Hajnoczi
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Wed, Apr 26, 2017 at 03:36:07PM +0200, Greg Kurz wrote:
> Since commit "c53eeaf75a04 configure: eliminate Python dependency for
> --help", configure --help fails to produce the list of available trace
> backends if invoked out-of-tree. It also spits the following error:
>
> grep: scripts/tracetool/backend/*.py: No such file or directory
>
> This patch simply adds the missing $source_path to fix it.
>
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> v2: - use "$source_path" instead of $source_path
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my staging tree:
https://github.com/stefanha/qemu/commits/staging
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-04-28 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-26 13:36 [Qemu-devel] [PATCH v2] configure: fix trace backend list for out-of-tree builds Greg Kurz
2017-04-28 15:49 ` Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.