* [Intel-wired-lan] [PATCH net-next v1 0/3] i40e/i40evf: small fixes @ 2017-04-28 23:53 Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Jesse Brandeburg 0 siblings, 1 reply; 7+ messages in thread From: Jesse Brandeburg @ 2017-04-28 23:53 UTC (permalink / raw) To: intel-wired-lan This is a quick series of fixes that were found when reviewing code. Jesse Brandeburg (3): i40evf: fix duplicate lines i40evf: fix merge error in older patch i40evf: disable unused flags drivers/net/ethernet/intel/i40evf/i40e_common.c | 3 +-- drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h | 3 +-- drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) -- 1.8.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines 2017-04-28 23:53 [Intel-wired-lan] [PATCH net-next v1 0/3] i40e/i40evf: small fixes Jesse Brandeburg @ 2017-04-28 23:53 ` Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Jesse Brandeburg 2017-05-02 19:16 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Bowers, AndrewX 0 siblings, 2 replies; 7+ messages in thread From: Jesse Brandeburg @ 2017-04-28 23:53 UTC (permalink / raw) To: intel-wired-lan This removes two duplicate lines that snuck into the code somehow. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c index deb2cb8..3cdac24 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c @@ -152,8 +152,6 @@ int i40evf_send_vf_config_msg(struct i40evf_adapter *adapter) { u32 caps; - adapter->current_op = I40E_VIRTCHNL_OP_GET_VF_RESOURCES; - adapter->aq_required &= ~I40EVF_FLAG_AQ_GET_CONFIG; caps = I40E_VIRTCHNL_VF_OFFLOAD_L2 | I40E_VIRTCHNL_VF_OFFLOAD_RSS_AQ | I40E_VIRTCHNL_VF_OFFLOAD_RSS_REG | -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Jesse Brandeburg @ 2017-04-28 23:53 ` Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused flags Jesse Brandeburg 2017-05-02 19:17 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Bowers, AndrewX 2017-05-02 19:16 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Bowers, AndrewX 1 sibling, 2 replies; 7+ messages in thread From: Jesse Brandeburg @ 2017-04-28 23:53 UTC (permalink / raw) To: intel-wired-lan This patch fixes a missing line that was missed while merging, which results in a driver feature in the VF not working to enable RSS as a negotiated feature. Fixes: 43a3d9ba34c9c ("i40evf: Allow PF driver to configure RSS") Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c index 3cdac24..91b21f2 100644 --- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c +++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c @@ -153,6 +153,7 @@ int i40evf_send_vf_config_msg(struct i40evf_adapter *adapter) u32 caps; caps = I40E_VIRTCHNL_VF_OFFLOAD_L2 | + I40E_VIRTCHNL_VF_OFFLOAD_RSS_PF | I40E_VIRTCHNL_VF_OFFLOAD_RSS_AQ | I40E_VIRTCHNL_VF_OFFLOAD_RSS_REG | I40E_VIRTCHNL_VF_OFFLOAD_VLAN | -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused flags 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Jesse Brandeburg @ 2017-04-28 23:53 ` Jesse Brandeburg 2017-05-02 19:17 ` Bowers, AndrewX 2017-05-02 19:17 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Bowers, AndrewX 1 sibling, 1 reply; 7+ messages in thread From: Jesse Brandeburg @ 2017-04-28 23:53 UTC (permalink / raw) To: intel-wired-lan The i40evf hardware doesn't have any way to ever report FCoE enabled so just force the code to always report FCoE is disabled, remove the unused defines, and mark the OP as reserved. Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- drivers/net/ethernet/intel/i40evf/i40e_common.c | 3 +-- drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40evf/i40e_common.c b/drivers/net/ethernet/intel/i40evf/i40e_common.c index 43f1076..6729624 100644 --- a/drivers/net/ethernet/intel/i40evf/i40e_common.c +++ b/drivers/net/ethernet/intel/i40evf/i40e_common.c @@ -1105,8 +1105,7 @@ void i40e_vf_parse_hw_config(struct i40e_hw *hw, hw->dev_caps.num_msix_vectors_vf = msg->max_vectors; hw->dev_caps.dcb = msg->vf_offload_flags & I40E_VIRTCHNL_VF_OFFLOAD_L2; - hw->dev_caps.fcoe = (msg->vf_offload_flags & - I40E_VIRTCHNL_VF_OFFLOAD_FCOE) ? 1 : 0; + hw->dev_caps.fcoe = 0; for (i = 0; i < msg->num_vsis; i++) { if (vsi_res->vsi_type == I40E_VSI_SRIOV) { ether_addr_copy(hw->mac.perm_addr, diff --git a/drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h b/drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h index c5ad038..b0b8de5 100644 --- a/drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h +++ b/drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h @@ -79,7 +79,7 @@ enum i40e_virtchnl_ops { I40E_VIRTCHNL_OP_DEL_VLAN = 13, I40E_VIRTCHNL_OP_CONFIG_PROMISCUOUS_MODE = 14, I40E_VIRTCHNL_OP_GET_STATS = 15, - I40E_VIRTCHNL_OP_FCOE = 16, + I40E_VIRTCHNL_OP_RSVD = 16, I40E_VIRTCHNL_OP_EVENT = 17, /* must ALWAYS be 17 */ I40E_VIRTCHNL_OP_IWARP = 20, I40E_VIRTCHNL_OP_CONFIG_IWARP_IRQ_MAP = 21, @@ -155,7 +155,6 @@ struct i40e_virtchnl_vsi_resource { /* VF offload flags */ #define I40E_VIRTCHNL_VF_OFFLOAD_L2 0x00000001 #define I40E_VIRTCHNL_VF_OFFLOAD_IWARP 0x00000002 -#define I40E_VIRTCHNL_VF_OFFLOAD_FCOE 0x00000004 #define I40E_VIRTCHNL_VF_OFFLOAD_RSS_AQ 0x00000008 #define I40E_VIRTCHNL_VF_OFFLOAD_RSS_REG 0x00000010 #define I40E_VIRTCHNL_VF_OFFLOAD_WB_ON_ITR 0x00000020 -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused flags 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused flags Jesse Brandeburg @ 2017-05-02 19:17 ` Bowers, AndrewX 0 siblings, 0 replies; 7+ messages in thread From: Bowers, AndrewX @ 2017-05-02 19:17 UTC (permalink / raw) To: intel-wired-lan > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On > Behalf Of Jesse Brandeburg > Sent: Friday, April 28, 2017 4:53 PM > To: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused > flags > > The i40evf hardware doesn't have any way to ever report FCoE enabled so > just force the code to always report FCoE is disabled, remove the unused > defines, and mark the OP as reserved. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/i40evf/i40e_common.c | 3 +-- > drivers/net/ethernet/intel/i40evf/i40e_virtchnl.h | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused flags Jesse Brandeburg @ 2017-05-02 19:17 ` Bowers, AndrewX 1 sibling, 0 replies; 7+ messages in thread From: Bowers, AndrewX @ 2017-05-02 19:17 UTC (permalink / raw) To: intel-wired-lan > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On > Behalf Of Jesse Brandeburg > Sent: Friday, April 28, 2017 4:53 PM > To: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in > older patch > > This patch fixes a missing line that was missed while merging, which results in > a driver feature in the VF not working to enable RSS as a negotiated feature. > > Fixes: 43a3d9ba34c9c ("i40evf: Allow PF driver to configure RSS") > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 1 + > 1 file changed, 1 insertion(+) Tested-by: Andrew Bowers <andrewx.bowers@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Jesse Brandeburg @ 2017-05-02 19:16 ` Bowers, AndrewX 1 sibling, 0 replies; 7+ messages in thread From: Bowers, AndrewX @ 2017-05-02 19:16 UTC (permalink / raw) To: intel-wired-lan > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On > Behalf Of Jesse Brandeburg > Sent: Friday, April 28, 2017 4:53 PM > To: intel-wired-lan at lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines > > This removes two duplicate lines that snuck into the code somehow. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> > --- > drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 2 -- > 1 file changed, 2 deletions(-) Tested-by: Andrew Bowers <andrewx.bowers@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-05-02 19:17 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-28 23:53 [Intel-wired-lan] [PATCH net-next v1 0/3] i40e/i40evf: small fixes Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Jesse Brandeburg 2017-04-28 23:53 ` [Intel-wired-lan] [PATCH net-next v1 3/3] i40evf: disable unused flags Jesse Brandeburg 2017-05-02 19:17 ` Bowers, AndrewX 2017-05-02 19:17 ` [Intel-wired-lan] [PATCH net-next v1 2/3] i40evf: fix merge error in older patch Bowers, AndrewX 2017-05-02 19:16 ` [Intel-wired-lan] [PATCH net-next v1 1/3] i40evf: fix duplicate lines Bowers, AndrewX
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.