* [PATCH 1/1] IB/mlx5: Add port_xmit_wait to counter registers read @ 2017-05-01 16:30 Tim Wright [not found] ` <20170501163008.27043-1-tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Tim Wright @ 2017-05-01 16:30 UTC (permalink / raw) To: matanb, leonro, dledford, sean.hefty, hal.rosenstock, saeedm Cc: Tim Wright, linux-rdma, netdev Add port_xmit_wait to the error counters read by mlx5_ib_process_mad to ensure sysfs port counter provides correct value for PortXmitWait. Otherwise the sysfs port_xmit_wait file always contains zero. The previous MAD_IFC implementation populated this counter, but it was removed during the migration to PPCNT for error counters (32-bit only). Signed-off-by: Tim Wright <tim@binbash.co.uk> --- drivers/infiniband/hw/mlx5/mad.c | 2 ++ include/linux/mlx5/mlx5_ifc.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/mad.c b/drivers/infiniband/hw/mlx5/mad.c index 8dacb49..f1b56de6 100644 --- a/drivers/infiniband/hw/mlx5/mad.c +++ b/drivers/infiniband/hw/mlx5/mad.c @@ -187,6 +187,8 @@ static void pma_cnt_assign(struct ib_pma_portcounters *pma_cnt, port_xmit_discards); MLX5_ASSIGN_PMA_CNTR(pma_cnt->port_xmit_constraint_errors, port_xmit_constraint_errors); + MLX5_ASSIGN_PMA_CNTR(pma_cnt->port_xmit_wait, + port_xmit_wait); MLX5_ASSIGN_PMA_CNTR(pma_cnt->port_rcv_constraint_errors, port_rcv_constraint_errors); MLX5_ASSIGN_PMA_CNTR(pma_cnt->link_overrun_errors, diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index 8382426..e641bc3 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -1452,7 +1452,9 @@ struct mlx5_ifc_ib_port_cntrs_grp_data_layout_bits { u8 vl_15_dropped[0x10]; - u8 reserved_at_a0[0xa0]; + u8 reserved_at_a0[0x80]; + + u8 port_xmit_wait[0x20]; }; struct mlx5_ifc_eth_per_traffic_grp_data_layout_bits { -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <20170501163008.27043-1-tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org>]
* Re: [PATCH 1/1] IB/mlx5: Add port_xmit_wait to counter registers read [not found] ` <20170501163008.27043-1-tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> @ 2017-05-01 20:56 ` Doug Ledford 2017-05-03 5:38 ` Leon Romanovsky 1 sibling, 0 replies; 4+ messages in thread From: Doug Ledford @ 2017-05-01 20:56 UTC (permalink / raw) To: Tim Wright, matanb-VPRAkNaXOzVWk0Htik3J/w, leonro-VPRAkNaXOzVWk0Htik3J/w, sean.hefty-ral2JQCrhuEAvxtiuMwx3w, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, saeedm-VPRAkNaXOzVWk0Htik3J/w Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA On Mon, 2017-05-01 at 17:30 +0100, Tim Wright wrote: > Add port_xmit_wait to the error counters read by mlx5_ib_process_mad > to > ensure sysfs port counter provides correct value for PortXmitWait. > Otherwise the sysfs port_xmit_wait file always contains zero. > > The previous MAD_IFC implementation populated this counter, but it > was > removed during the migration to PPCNT for error counters (32-bit > only). > > Signed-off-by: Tim Wright <tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> Thanks, applied. -- Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] IB/mlx5: Add port_xmit_wait to counter registers read [not found] ` <20170501163008.27043-1-tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> @ 2017-05-03 5:38 ` Leon Romanovsky 2017-05-03 5:38 ` Leon Romanovsky 1 sibling, 0 replies; 4+ messages in thread From: Leon Romanovsky @ 2017-05-03 5:38 UTC (permalink / raw) To: Tim Wright Cc: matanb-VPRAkNaXOzVWk0Htik3J/w, dledford-H+wXaHxf7aLQT0dZR+AlfA, sean.hefty-ral2JQCrhuEAvxtiuMwx3w, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, saeedm-VPRAkNaXOzVWk0Htik3J/w, linux-rdma-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 723 bytes --] On Mon, May 01, 2017 at 05:30:08PM +0100, Tim Wright wrote: > Add port_xmit_wait to the error counters read by mlx5_ib_process_mad to > ensure sysfs port counter provides correct value for PortXmitWait. > Otherwise the sysfs port_xmit_wait file always contains zero. > > The previous MAD_IFC implementation populated this counter, but it was > removed during the migration to PPCNT for error counters (32-bit only). > > Signed-off-by: Tim Wright <tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> > --- > drivers/infiniband/hw/mlx5/mad.c | 2 ++ > include/linux/mlx5/mlx5_ifc.h | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > Thanks, Acked-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] IB/mlx5: Add port_xmit_wait to counter registers read @ 2017-05-03 5:38 ` Leon Romanovsky 0 siblings, 0 replies; 4+ messages in thread From: Leon Romanovsky @ 2017-05-03 5:38 UTC (permalink / raw) To: Tim Wright Cc: matanb-VPRAkNaXOzVWk0Htik3J/w, dledford-H+wXaHxf7aLQT0dZR+AlfA, sean.hefty-ral2JQCrhuEAvxtiuMwx3w, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, saeedm-VPRAkNaXOzVWk0Htik3J/w, linux-rdma-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA [-- Attachment #1: Type: text/plain, Size: 723 bytes --] On Mon, May 01, 2017 at 05:30:08PM +0100, Tim Wright wrote: > Add port_xmit_wait to the error counters read by mlx5_ib_process_mad to > ensure sysfs port counter provides correct value for PortXmitWait. > Otherwise the sysfs port_xmit_wait file always contains zero. > > The previous MAD_IFC implementation populated this counter, but it was > removed during the migration to PPCNT for error counters (32-bit only). > > Signed-off-by: Tim Wright <tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> > --- > drivers/infiniband/hw/mlx5/mad.c | 2 ++ > include/linux/mlx5/mlx5_ifc.h | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > Thanks, Acked-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-03 5:38 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-01 16:30 [PATCH 1/1] IB/mlx5: Add port_xmit_wait to counter registers read Tim Wright [not found] ` <20170501163008.27043-1-tim-r/Uwd3QrhQcqdlJmJB21zg@public.gmane.org> 2017-05-01 20:56 ` Doug Ledford 2017-05-03 5:38 ` Leon Romanovsky 2017-05-03 5:38 ` Leon Romanovsky
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.