* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
@ 2017-05-02 10:30 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-05-02 10:30 UTC (permalink / raw)
To: linux-renesas-soc
Cc: linux-arm-kernel, Magnus Damm, Simon Horman, Geert Uytterhoeven,
Niklas Söderlund
The EthernetAVB should not depend on the bootloader to setup correct
drive-strength values. Values for drive-strength where found by
examining the registers after the bootloader has configured the
registers and successfully used the EthernetAVB.
Based on:
* commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength
for ravb pins")
* commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength
for ravb pins")
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
* Compile tested only due to lack of hardware access
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 7669b282bde2..a38d68c4d9a6 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -199,8 +199,22 @@
pinctrl-names = "default";
avb_pins: avb {
- groups = "avb_mdc";
- function = "avb";
+ mux {
+ groups = "avb_link", "avb_phy_int", "avb_mdc",
+ "avb_mii";
+ function = "avb";
+ };
+
+ pins_mdc {
+ groups = "avb_mdc";
+ drive-strength = <24>;
+ };
+
+ pins_mii_tx {
+ pins = "PIN_AVB_TX_CTL", "PIN_AVB_TXC", "PIN_AVB_TD0",
+ "PIN_AVB_TD1", "PIN_AVB_TD2", "PIN_AVB_TD3";
+ drive-strength = <12>;
+ };
};
i2c2_pins: i2c2 {
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
@ 2017-05-02 10:30 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-05-02 10:30 UTC (permalink / raw)
To: linux-arm-kernel
The EthernetAVB should not depend on the bootloader to setup correct
drive-strength values. Values for drive-strength where found by
examining the registers after the bootloader has configured the
registers and successfully used the EthernetAVB.
Based on:
* commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength
for ravb pins")
* commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength
for ravb pins")
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
* Compile tested only due to lack of hardware access
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 7669b282bde2..a38d68c4d9a6 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -199,8 +199,22 @@
pinctrl-names = "default";
avb_pins: avb {
- groups = "avb_mdc";
- function = "avb";
+ mux {
+ groups = "avb_link", "avb_phy_int", "avb_mdc",
+ "avb_mii";
+ function = "avb";
+ };
+
+ pins_mdc {
+ groups = "avb_mdc";
+ drive-strength = <24>;
+ };
+
+ pins_mii_tx {
+ pins = "PIN_AVB_TX_CTL", "PIN_AVB_TXC", "PIN_AVB_TD0",
+ "PIN_AVB_TD1", "PIN_AVB_TD2", "PIN_AVB_TD3";
+ drive-strength = <12>;
+ };
};
i2c2_pins: i2c2 {
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
2017-05-02 10:30 ` Simon Horman
@ 2017-05-12 14:39 ` Geert Uytterhoeven
-1 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-05-12 14:39 UTC (permalink / raw)
To: Simon Horman
Cc: Linux-Renesas, linux-arm-kernel, Magnus Damm, Geert Uytterhoeven,
Niklas Söderlund
Hi Simon,
On Tue, May 2, 2017 at 12:30 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> The EthernetAVB should not depend on the bootloader to setup correct
> drive-strength values. Values for drive-strength where found by
> examining the registers after the bootloader has configured the
> registers and successfully used the EthernetAVB.
>
> Based on:
> * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength
> for ravb pins")
> * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength
> for ravb pins")
>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> * Compile tested only due to lack of hardware access
So how did you examine the registers? ;-)
Hence I examined the registers myself:
- H3ULCB has the same register settings as Salvator-X with H3 ES1.0
- M3ULCB has the same register settings as Salvator-X with M3-W ES1.0
or H3 ES2.0.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
@ 2017-05-12 14:39 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-05-12 14:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Tue, May 2, 2017 at 12:30 PM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> The EthernetAVB should not depend on the bootloader to setup correct
> drive-strength values. Values for drive-strength where found by
> examining the registers after the bootloader has configured the
> registers and successfully used the EthernetAVB.
>
> Based on:
> * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength
> for ravb pins")
> * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength
> for ravb pins")
>
> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> * Compile tested only due to lack of hardware access
So how did you examine the registers? ;-)
Hence I examined the registers myself:
- H3ULCB has the same register settings as Salvator-X with H3 ES1.0
- M3ULCB has the same register settings as Salvator-X with M3-W ES1.0
or H3 ES2.0.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
2017-05-12 14:39 ` Geert Uytterhoeven
@ 2017-05-15 6:57 ` Simon Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-05-15 6:57 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Linux-Renesas, linux-arm-kernel, Magnus Damm, Geert Uytterhoeven,
Niklas Söderlund
On Fri, May 12, 2017 at 04:39:03PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 2, 2017 at 12:30 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > The EthernetAVB should not depend on the bootloader to setup correct
> > drive-strength values. Values for drive-strength where found by
> > examining the registers after the bootloader has configured the
> > registers and successfully used the EthernetAVB.
> >
> > Based on:
> > * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength
> > for ravb pins")
> > * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength
> > for ravb pins")
> >
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > * Compile tested only due to lack of hardware access
>
> So how did you examine the registers? ;-)
You got me there: copy-paste gone wrong.
> Hence I examined the registers myself:
> - H3ULCB has the same register settings as Salvator-X with H3 ES1.0
> - M3ULCB has the same register settings as Salvator-X with M3-W ES1.0
> or H3 ES2.0.
That was my assumption, which is what I should have written.
But as you have checked - thanks for that - I will leave the changelog
as-is and queue up the patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins
@ 2017-05-15 6:57 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2017-05-15 6:57 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, May 12, 2017 at 04:39:03PM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 2, 2017 at 12:30 PM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > The EthernetAVB should not depend on the bootloader to setup correct
> > drive-strength values. Values for drive-strength where found by
> > examining the registers after the bootloader has configured the
> > registers and successfully used the EthernetAVB.
> >
> > Based on:
> > * commit 7d73a4da2681 ("arm64: dts: r8a7795: salvator-x: Set drive-strength
> > for ravb pins")
> > * commit 4903987033be ("arm64: dts: r8a7796: salvator-x: Set drive-strength
> > for ravb pins")
> >
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > * Compile tested only due to lack of hardware access
>
> So how did you examine the registers? ;-)
You got me there: copy-paste gone wrong.
> Hence I examined the registers myself:
> - H3ULCB has the same register settings as Salvator-X with H3 ES1.0
> - M3ULCB has the same register settings as Salvator-X with M3-W ES1.0
> or H3 ES2.0.
That was my assumption, which is what I should have written.
But as you have checked - thanks for that - I will leave the changelog
as-is and queue up the patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-15 6:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 10:30 [PATCH/RFT renesas-devel] arm64: dts: ulcb: Set drive-strength for ravb pins Simon Horman
2017-05-02 10:30 ` Simon Horman
2017-05-12 14:39 ` Geert Uytterhoeven
2017-05-12 14:39 ` Geert Uytterhoeven
2017-05-15 6:57 ` Simon Horman
2017-05-15 6:57 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.