[PATCH V2] nvmf: keep track of nvmet connect error status

[PATCH V2] nvmf: keep track of nvmet connect error status

[Guan Junxiong]

To let the host know what happends to the connection establishment,
adjust the behavior of nvmf_log_connect_error to make more connect
specifig error codes human-readble.
---
 drivers/nvme/host/fabrics.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c
index 990e6fb..c5dd883 100644
--- a/drivers/nvme/host/fabrics.c
+++ b/drivers/nvme/host/fabrics.c
@@ -337,6 +337,24 @@ static void nvmf_log_connect_error(struct nvme_ctrl *ctrl,
 			}
 		}
 		break;
+
+	case NVME_SC_CONNECT_INVALID_HOST:
+		dev_err(ctrl->device,
+			"Connect for subsystem %s is not allowed, hostnqn : %s\n",
+			data->subsysnqn, data->hostnqn);
+		break;
+
+	case NVME_SC_CONNECT_CTRL_BUSY:
+		dev_err(ctrl->device,
+			"Connect command failed : controller is busy or not available\n");
+		break;
+
+	case NVME_SC_CONNECT_FORMAT:
+		dev_err(ctrl->device,
+			"Connect incompatible format : %d",
+			cmd->connect.recfmt);
+		break;
+
 	default:
 		dev_err(ctrl->device,
 			"Connect command failed, error wo/DNR bit: %d\n",
-- 
2.6.4.windows.1

Change log from V1:
1. Fix up the indentation issue by deleting one more TAB.

[PATCH V2] nvmf: keep track of nvmet connect error status

[Christoph Hellwig]

On Tue, May 02, 2017@07:37:46PM +0800, Guan Junxiong wrote:
> To let the host know what happends to the connection establishment,
> adjust the behavior of nvmf_log_connect_error to make more connect
> specifig error codes human-readble.

Hi Guan,

I was just going to apply your patches, but they all miss the
Signed-off-by: line.  Can you add it and resend, and I'll queue the
patch up?

Please also pick up the Reviewed-by: tag from Sagi while you're at it.

[PATCH V2] nvmf: keep track of nvmet connect error status

[Guan Junxiong]

On Wed, May 10 09:57:29 PDT 2017, Christoph Hellwig wrote:
> Hi Guan,

> I was just going to apply your patches, but they all miss the
> Signed-off-by: line.  Can you add it and resend, and I'll queue the
> patch up?

> Please also pick up the Reviewed-by: tag from Sagi while you're at it.

Hi Christoph,

Sorry for the late response as my mail inbox didn't catch the above response
during switch email client until I found it in the Linux-nvme Archives.

An updated patch v3 has been sent, please check your email or refer to
http://lists.infradead.org/pipermail/linux-nvme/2017-June/010960.html

Thanks.

Cheers,
Guan