All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Auger <eric.auger@redhat.com>
To: eric.auger.pro@gmail.com, eric.auger@redhat.com,
	marc.zyngier@arm.com, christoffer.dall@linaro.org,
	andre.przywara@arm.com, vijayak@caviumnetworks.com,
	Vijaya.Kumar@cavium.com, peter.maydell@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org
Cc: Prasun.Kapoor@cavium.com, drjones@redhat.com,
	pbonzini@redhat.com, dgilbert@redhat.com, quintela@redhat.com,
	bjsprakash.linux@gmail.com
Subject: [PATCH v6 04/24] arm/arm64: vgic: turn vgic_find_mmio_region into public
Date: Thu,  4 May 2017 13:44:24 +0200	[thread overview]
Message-ID: <1493898284-29504-5-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1493898284-29504-1-git-send-email-eric.auger@redhat.com>

We plan to use vgic_find_mmio_region in vgic-its.c so let's
turn it into a public function.

Also let's take the opportunity to rename the region parameter
into regions to emphasize this latter is an array of regions.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Christoffer Dall <cdall@linaro.org>

---
v5 -> v6:
- add Christoffer's A-b

v4 -> v5:
- add Marc's A-b

v3 -> v4:
- rename region parameter into regions
- add Andre's R-b
---
 virt/kvm/arm/vgic/vgic-mmio.c | 11 +++++------
 virt/kvm/arm/vgic/vgic-mmio.h |  5 +++++
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/virt/kvm/arm/vgic/vgic-mmio.c b/virt/kvm/arm/vgic/vgic-mmio.c
index 2a5db13..1c17b2a 100644
--- a/virt/kvm/arm/vgic/vgic-mmio.c
+++ b/virt/kvm/arm/vgic/vgic-mmio.c
@@ -446,13 +446,12 @@ static int match_region(const void *key, const void *elt)
 	return 0;
 }
 
-/* Find the proper register handler entry given a certain address offset. */
-static const struct vgic_register_region *
-vgic_find_mmio_region(const struct vgic_register_region *region, int nr_regions,
-		      unsigned int offset)
+const struct vgic_register_region *
+vgic_find_mmio_region(const struct vgic_register_region *regions,
+		      int nr_regions, unsigned int offset)
 {
-	return bsearch((void *)(uintptr_t)offset, region, nr_regions,
-		       sizeof(region[0]), match_region);
+	return bsearch((void *)(uintptr_t)offset, regions, nr_regions,
+		       sizeof(regions[0]), match_region);
 }
 
 void vgic_set_vmcr(struct kvm_vcpu *vcpu, struct vgic_vmcr *vmcr)
diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
index 98bb566..6eec91b 100644
--- a/virt/kvm/arm/vgic/vgic-mmio.h
+++ b/virt/kvm/arm/vgic/vgic-mmio.h
@@ -192,4 +192,9 @@ u64 vgic_sanitise_shareability(u64 reg);
 u64 vgic_sanitise_field(u64 reg, u64 field_mask, int field_shift,
 			u64 (*sanitise_fn)(u64));
 
+/* Find the proper register handler entry given a certain address offset */
+const struct vgic_register_region *
+vgic_find_mmio_region(const struct vgic_register_region *regions,
+		      int nr_regions, unsigned int offset);
+
 #endif
-- 
2.5.5

WARNING: multiple messages have this Message-ID (diff)
From: eric.auger@redhat.com (Eric Auger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 04/24] arm/arm64: vgic: turn vgic_find_mmio_region into public
Date: Thu,  4 May 2017 13:44:24 +0200	[thread overview]
Message-ID: <1493898284-29504-5-git-send-email-eric.auger@redhat.com> (raw)
In-Reply-To: <1493898284-29504-1-git-send-email-eric.auger@redhat.com>

We plan to use vgic_find_mmio_region in vgic-its.c so let's
turn it into a public function.

Also let's take the opportunity to rename the region parameter
into regions to emphasize this latter is an array of regions.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Christoffer Dall <cdall@linaro.org>

---
v5 -> v6:
- add Christoffer's A-b

v4 -> v5:
- add Marc's A-b

v3 -> v4:
- rename region parameter into regions
- add Andre's R-b
---
 virt/kvm/arm/vgic/vgic-mmio.c | 11 +++++------
 virt/kvm/arm/vgic/vgic-mmio.h |  5 +++++
 2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/virt/kvm/arm/vgic/vgic-mmio.c b/virt/kvm/arm/vgic/vgic-mmio.c
index 2a5db13..1c17b2a 100644
--- a/virt/kvm/arm/vgic/vgic-mmio.c
+++ b/virt/kvm/arm/vgic/vgic-mmio.c
@@ -446,13 +446,12 @@ static int match_region(const void *key, const void *elt)
 	return 0;
 }
 
-/* Find the proper register handler entry given a certain address offset. */
-static const struct vgic_register_region *
-vgic_find_mmio_region(const struct vgic_register_region *region, int nr_regions,
-		      unsigned int offset)
+const struct vgic_register_region *
+vgic_find_mmio_region(const struct vgic_register_region *regions,
+		      int nr_regions, unsigned int offset)
 {
-	return bsearch((void *)(uintptr_t)offset, region, nr_regions,
-		       sizeof(region[0]), match_region);
+	return bsearch((void *)(uintptr_t)offset, regions, nr_regions,
+		       sizeof(regions[0]), match_region);
 }
 
 void vgic_set_vmcr(struct kvm_vcpu *vcpu, struct vgic_vmcr *vmcr)
diff --git a/virt/kvm/arm/vgic/vgic-mmio.h b/virt/kvm/arm/vgic/vgic-mmio.h
index 98bb566..6eec91b 100644
--- a/virt/kvm/arm/vgic/vgic-mmio.h
+++ b/virt/kvm/arm/vgic/vgic-mmio.h
@@ -192,4 +192,9 @@ u64 vgic_sanitise_shareability(u64 reg);
 u64 vgic_sanitise_field(u64 reg, u64 field_mask, int field_shift,
 			u64 (*sanitise_fn)(u64));
 
+/* Find the proper register handler entry given a certain address offset */
+const struct vgic_register_region *
+vgic_find_mmio_region(const struct vgic_register_region *regions,
+		      int nr_regions, unsigned int offset);
+
 #endif
-- 
2.5.5

  parent reply	other threads:[~2017-05-04 11:45 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-04 11:44 [PATCH v6 00/24] vITS save/restore Eric Auger
2017-05-04 11:44 ` Eric Auger
2017-05-04 11:44 ` [PATCH v6 01/24] KVM: arm/arm64: Add ITS save/restore API documentation Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 13:23   ` Christoffer Dall
2017-05-04 13:23     ` Christoffer Dall
2017-05-04 14:50     ` Auger Eric
2017-05-04 14:50       ` Auger Eric
2017-05-04 16:52       ` Christoffer Dall
2017-05-04 16:52         ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 02/24] KVM: arm/arm64: Add GICV3 pending table save " Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 13:24   ` Christoffer Dall
2017-05-04 13:24     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 03/24] KVM: arm/arm64: vgic-its: rename itte into ite Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 11:44 ` Eric Auger [this message]
2017-05-04 11:44   ` [PATCH v6 04/24] arm/arm64: vgic: turn vgic_find_mmio_region into public Eric Auger
2017-05-04 11:44 ` [PATCH v6 05/24] KVM: arm64: vgic-its: KVM_DEV_ARM_VGIC_GRP_ITS_REGS group Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 11:44 ` [PATCH v6 06/24] KVM: arm/arm64: vgic: expose (un)lock_all_vcpus Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 11:44 ` [PATCH v6 07/24] KVM: arm64: vgic-its: Implement vgic_its_has_attr_regs and attr_regs_access Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 14:04   ` Marc Zyngier
2017-05-04 14:04     ` Marc Zyngier
2017-05-04 15:03     ` Auger Eric
2017-05-04 15:03       ` Auger Eric
2017-05-04 16:48   ` Christoffer Dall
2017-05-04 16:48     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 08/24] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_creadr Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 14:16   ` Marc Zyngier
2017-05-04 14:16     ` Marc Zyngier
2017-05-04 15:09     ` Auger Eric
2017-05-04 15:09       ` Auger Eric
2017-05-04 17:09   ` Christoffer Dall
2017-05-04 17:09     ` Christoffer Dall
2017-05-05  8:06     ` Auger Eric
2017-05-05  8:06       ` Auger Eric
2017-05-04 11:44 ` [PATCH v6 09/24] KVM: arm64: vgic-its: Introduce migration ABI infrastructure Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 14:45   ` Marc Zyngier
2017-05-04 14:45     ` Marc Zyngier
2017-05-04 17:13   ` Christoffer Dall
2017-05-04 17:13     ` Christoffer Dall
2017-05-05  8:16     ` Auger Eric
2017-05-05  8:16       ` Auger Eric
2017-05-05  9:43       ` Christoffer Dall
2017-05-05  9:43         ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 10/24] KVM: arm64: vgic-its: Implement vgic_mmio_uaccess_write_its_iidr Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 15:39   ` Marc Zyngier
2017-05-04 15:39     ` Marc Zyngier
2017-05-04 17:14   ` Christoffer Dall
2017-05-04 17:14     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 11/24] KVM: arm64: vgic-its: Interpret MAPD Size field and check related errors Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05  9:44   ` Marc Zyngier
2017-05-05  9:44     ` Marc Zyngier
2017-05-04 11:44 ` [PATCH v6 12/24] KVM: arm64: vgic-its: Interpret MAPD ITT_addr field Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 17:16   ` Christoffer Dall
2017-05-04 17:16     ` Christoffer Dall
2017-05-05  9:45   ` Marc Zyngier
2017-05-05  9:45     ` Marc Zyngier
2017-05-04 11:44 ` [PATCH v6 13/24] KVM: arm64: vgic-its: Check the device id matches TYPER DEVBITS range Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 17:19   ` Christoffer Dall
2017-05-04 17:19     ` Christoffer Dall
2017-05-04 17:23     ` Marc Zyngier
2017-05-04 17:23       ` Marc Zyngier
2017-05-04 11:44 ` [PATCH v6 14/24] KVM: arm64: vgic-v3: vgic_v3_lpi_sync_pending_status Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05  8:11   ` Christoffer Dall
2017-05-05  8:11     ` Christoffer Dall
2017-05-05  9:45     ` Auger Eric
2017-05-05  9:45       ` Auger Eric
2017-05-05  9:59       ` Marc Zyngier
2017-05-05  9:59         ` Marc Zyngier
2017-05-05 10:10         ` Christoffer Dall
2017-05-05 10:10           ` Christoffer Dall
2017-05-05 10:35           ` Marc Zyngier
2017-05-05 10:35             ` Marc Zyngier
2017-05-05 14:20             ` Auger Eric
2017-05-05 14:20               ` Auger Eric
2017-05-05 14:50               ` Christoffer Dall
2017-05-05 14:50                 ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 15/24] KVM: arm64: vgic-its: Read config and pending bit in add_lpi() Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05  9:57   ` Christoffer Dall
2017-05-05  9:57     ` Christoffer Dall
2017-05-05 12:50     ` Marc Zyngier
2017-05-05 12:50       ` Marc Zyngier
2017-05-05 14:50       ` Auger Eric
2017-05-05 14:50         ` Auger Eric
2017-05-05 18:07         ` Christoffer Dall
2017-05-05 18:07           ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 16/24] KVM: arm64: vgic-its: KVM_DEV_ARM_ITS_SAVE/RESTORE_TABLES Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 11:55   ` Christoffer Dall
2017-05-05 11:55     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 17/24] KVM: arm64: vgic-its: vgic_its_alloc_ite/device Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 12:04   ` Christoffer Dall
2017-05-05 12:04     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 18/24] KVM: arm64: vgic-its: Add infrastructure for table lookup Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 12:16   ` Christoffer Dall
2017-05-05 12:16     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 19/24] KVM: arm64: vgic-its: Collection table save/restore Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 12:28   ` Christoffer Dall
2017-05-05 12:28     ` Christoffer Dall
2017-05-05 14:28     ` Auger Eric
2017-05-05 14:28       ` Auger Eric
2017-05-05 14:43       ` Auger Eric
2017-05-05 14:43         ` Auger Eric
2017-05-04 11:44 ` [PATCH v6 20/24] KVM: arm64: vgic-its: vgic_its_check_id returns the entry's GPA Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-04 11:44 ` [PATCH v6 21/24] KVM: arm64: vgic-its: Device table save/restore Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 12:44   ` Christoffer Dall
2017-05-05 12:44     ` Christoffer Dall
2017-05-05 16:23     ` Auger Eric
2017-05-05 16:23       ` Auger Eric
2017-05-05 18:12       ` Christoffer Dall
2017-05-05 18:12         ` Christoffer Dall
2017-05-06 10:21         ` Auger Eric
2017-05-06 10:21           ` Auger Eric
2017-05-04 11:44 ` [PATCH v6 22/24] KVM: arm64: vgic-its: ITT save and restore Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 14:50   ` Christoffer Dall
2017-05-05 14:50     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 23/24] KVM: arm64: vgic-its: Fix pending table sync Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05 14:54   ` Christoffer Dall
2017-05-05 14:54     ` Christoffer Dall
2017-05-04 11:44 ` [PATCH v6 24/24] KVM: arm64: vgic-v3: KVM_DEV_ARM_VGIC_SAVE_PENDING_TABLES Eric Auger
2017-05-04 11:44   ` Eric Auger
2017-05-05  9:24   ` Auger Eric
2017-05-05  9:24     ` Auger Eric
2017-05-05 14:56   ` Christoffer Dall
2017-05-05 14:56     ` Christoffer Dall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493898284-29504-5-git-send-email-eric.auger@redhat.com \
    --to=eric.auger@redhat.com \
    --cc=Prasun.Kapoor@cavium.com \
    --cc=Vijaya.Kumar@cavium.com \
    --cc=andre.przywara@arm.com \
    --cc=bjsprakash.linux@gmail.com \
    --cc=christoffer.dall@linaro.org \
    --cc=dgilbert@redhat.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=quintela@redhat.com \
    --cc=vijayak@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.