From: Jin Yao <yao.jin@linux.intel.com>
To: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com
Cc: Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com, milian.wolff@kdab.com,
Jin Yao <yao.jin@linux.intel.com>
Subject: [PATCH v2 0/2] perf report: Add titles for percent/ipc/cycle in annotate browser
Date: Fri, 5 May 2017 18:27:28 +0800 [thread overview]
Message-ID: <1493980050-17210-1-git-send-email-yao.jin@linux.intel.com> (raw)
v2:
---
Thanks for the comments and ideas from Arnaldo and Milian.
1. Change "Percnt" to "Percent"
2. Add explanations for "Percent", "IPC" and "Cycle".
When user hit hotkey 'h', the help window is popup. Explanations
are added at the bottom of window.
│Report explanation: │
│ Percent: sample percentage for a block │
│ IPC: instructions per cycle for a block │
│ cycle: average number of cycles for a block │
I don't use a new window to display the report explanation,
instead, I just display the info in current help window so that
user doesn't need to press one more hotkey to get the explanation.
Changed patch:
--------------
perf report: Display titles in left frame of annotate browser
Unchanged patch:
----------------
perf report: Remove the unnecessary checking in annotate_browser_write
Initial post
------------
The patch series adds the titles "Percnt", "IPC" and "Cycle" in
annotate browser. It helps user to understand easily for what the
columns in left frame represents for.
For example:
Percnt IPC Cycle │
│25 __attribute__((noinline))
│26 int compute_flag()
│27 {
22.80 1.20 │ sub $0x8,%rsp
│25 int i;
│
│27 i = rand() % 2;
22.78 1.20 1 │ → callq rand@plt
The patch "perf report: Remove the unnecessary checking in
annotate_browser_write" removes the invalid condition checking in
current code.
Jin Yao (2):
perf report: Remove the unnecessary checking in annotate_browser_write
perf report: Display titles in left frame of annotate browser
tools/perf/ui/browsers/annotate.c | 59 +++++++++++++++++++++++++++------------
1 file changed, 41 insertions(+), 18 deletions(-)
--
2.7.4
next reply other threads:[~2017-05-05 2:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-05 10:27 Jin Yao [this message]
2017-05-05 10:27 ` [PATCH v2 1/2] perf report: Remove the unnecessary checking in annotate_browser_write Jin Yao
2017-05-05 10:27 ` [PATCH v2 2/2] perf report: Display titles in left frame of annotate browser Jin Yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493980050-17210-1-git-send-email-yao.jin@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=milian.wolff@kdab.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.