All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, borntraeger@de.ibm.com,
	heiko.carstens@de.ibm.com, davem@davemloft.net
Subject: [v3 5/9] mm: zero struct pages during initialization
Date: Fri,  5 May 2017 13:03:12 -0400	[thread overview]
Message-ID: <1494003796-748672-6-git-send-email-pasha.tatashin@oracle.com> (raw)
In-Reply-To: <1494003796-748672-1-git-send-email-pasha.tatashin@oracle.com>

When deferred struct page initialization is enabled, do not expect that
the memory that was allocated for struct pages was zeroed by the
allocator. Zero it when "struct pages" are initialized.

Also, a defined boolean VMEMMAP_ZERO is provided to tell platforms whether
they should zero memory or can deffer it.

Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 include/linux/mm.h |    9 +++++++++
 mm/page_alloc.c    |    3 +++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 4375015..1c481fc 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2419,6 +2419,15 @@ int vmemmap_populate_basepages(unsigned long start, unsigned long end,
 #ifdef CONFIG_MEMORY_HOTPLUG
 void vmemmap_free(unsigned long start, unsigned long end);
 #endif
+/*
+ * Don't zero "struct page"es during early boot, and zero only when they are
+ * initialized in parallel.
+ */
+#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
+#define VMEMMAP_ZERO	false
+#else
+#define VMEMMAP_ZERO	true
+#endif
 void register_page_bootmem_memmap(unsigned long section_nr, struct page *map,
 				  unsigned long size);
 
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2c25de4..e736c6a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1159,6 +1159,9 @@ static void free_one_page(struct zone *zone,
 static void __meminit __init_single_page(struct page *page, unsigned long pfn,
 				unsigned long zone, int nid)
 {
+#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
+	memset(page, 0, sizeof(struct page));
+#endif
 	set_page_links(page, zone, nid, pfn);
 	init_page_count(page);
 	page_mapcount_reset(page);
-- 
1.7.1

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, borntraeger@de.ibm.com,
	heiko.carstens@de.ibm.com, davem@davemloft.net
Subject: [v3 5/9] mm: zero struct pages during initialization
Date: Fri,  5 May 2017 13:03:12 -0400	[thread overview]
Message-ID: <1494003796-748672-6-git-send-email-pasha.tatashin@oracle.com> (raw)
In-Reply-To: <1494003796-748672-1-git-send-email-pasha.tatashin@oracle.com>

When deferred struct page initialization is enabled, do not expect that
the memory that was allocated for struct pages was zeroed by the
allocator. Zero it when "struct pages" are initialized.

Also, a defined boolean VMEMMAP_ZERO is provided to tell platforms whether
they should zero memory or can deffer it.

Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 include/linux/mm.h |    9 +++++++++
 mm/page_alloc.c    |    3 +++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 4375015..1c481fc 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2419,6 +2419,15 @@ int vmemmap_populate_basepages(unsigned long start, unsigned long end,
 #ifdef CONFIG_MEMORY_HOTPLUG
 void vmemmap_free(unsigned long start, unsigned long end);
 #endif
+/*
+ * Don't zero "struct page"es during early boot, and zero only when they are
+ * initialized in parallel.
+ */
+#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
+#define VMEMMAP_ZERO	false
+#else
+#define VMEMMAP_ZERO	true
+#endif
 void register_page_bootmem_memmap(unsigned long section_nr, struct page *map,
 				  unsigned long size);
 
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2c25de4..e736c6a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1159,6 +1159,9 @@ static void free_one_page(struct zone *zone,
 static void __meminit __init_single_page(struct page *page, unsigned long pfn,
 				unsigned long zone, int nid)
 {
+#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
+	memset(page, 0, sizeof(struct page));
+#endif
 	set_page_links(page, zone, nid, pfn);
 	init_page_count(page);
 	page_mapcount_reset(page);
-- 
1.7.1

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
	linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org, borntraeger@de.ibm.com,
	heiko.carstens@de.ibm.com, davem@davemloft.net
Subject: [v3 5/9] mm: zero struct pages during initialization
Date: Fri, 05 May 2017 17:03:12 +0000	[thread overview]
Message-ID: <1494003796-748672-6-git-send-email-pasha.tatashin@oracle.com> (raw)
In-Reply-To: <1494003796-748672-1-git-send-email-pasha.tatashin@oracle.com>

When deferred struct page initialization is enabled, do not expect that
the memory that was allocated for struct pages was zeroed by the
allocator. Zero it when "struct pages" are initialized.

Also, a defined boolean VMEMMAP_ZERO is provided to tell platforms whether
they should zero memory or can deffer it.

Signed-off-by: Pavel Tatashin <pasha.tatashin@oracle.com>
Reviewed-by: Shannon Nelson <shannon.nelson@oracle.com>
---
 include/linux/mm.h |    9 +++++++++
 mm/page_alloc.c    |    3 +++
 2 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 4375015..1c481fc 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2419,6 +2419,15 @@ int vmemmap_populate_basepages(unsigned long start, unsigned long end,
 #ifdef CONFIG_MEMORY_HOTPLUG
 void vmemmap_free(unsigned long start, unsigned long end);
 #endif
+/*
+ * Don't zero "struct page"es during early boot, and zero only when they are
+ * initialized in parallel.
+ */
+#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
+#define VMEMMAP_ZERO	false
+#else
+#define VMEMMAP_ZERO	true
+#endif
 void register_page_bootmem_memmap(unsigned long section_nr, struct page *map,
 				  unsigned long size);
 
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2c25de4..e736c6a 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1159,6 +1159,9 @@ static void free_one_page(struct zone *zone,
 static void __meminit __init_single_page(struct page *page, unsigned long pfn,
 				unsigned long zone, int nid)
 {
+#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT
+	memset(page, 0, sizeof(struct page));
+#endif
 	set_page_links(page, zone, nid, pfn);
 	init_page_count(page);
 	page_mapcount_reset(page);
-- 
1.7.1


  parent reply	other threads:[~2017-05-05 17:03 UTC|newest]

Thread overview: 137+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-05 17:03 [v3 0/9] parallelized "struct page" zeroing Pavel Tatashin
2017-05-05 17:03 ` Pavel Tatashin
2017-05-05 17:03 ` Pavel Tatashin
2017-05-05 17:03 ` [v3 1/9] sparc64: simplify vmemmap_populate Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` [v3 2/9] mm: defining memblock_virt_alloc_try_nid_raw Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` [v3 3/9] mm: add "zero" argument to vmemmap allocators Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-13 19:17   ` kbuild test robot
2017-05-13 19:17     ` kbuild test robot
2017-05-05 17:03 ` [v3 4/9] mm: do not zero vmemmap_buf Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` Pavel Tatashin [this message]
2017-05-05 17:03   ` [v3 5/9] mm: zero struct pages during initialization Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` [v3 6/9] sparc64: teach sparc not to zero struct pages memory Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` [v3 7/9] x86: teach x86 " Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` [v3 8/9] powerpc: teach platforms " Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03 ` [v3 9/9] s390: " Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-05 17:03   ` Pavel Tatashin
2017-05-08 11:36   ` Heiko Carstens
2017-05-08 11:36     ` Heiko Carstens
2017-05-08 11:36     ` Heiko Carstens
2017-05-15 18:24     ` Pasha Tatashin
2017-05-15 18:24       ` Pasha Tatashin
2017-05-15 18:24       ` Pasha Tatashin
2017-05-15 23:17       ` Heiko Carstens
2017-05-15 23:17         ` Heiko Carstens
2017-05-15 23:17         ` Heiko Carstens
2017-05-16  0:33         ` Pasha Tatashin
2017-05-16  0:33           ` Pasha Tatashin
2017-05-16  0:33           ` Pasha Tatashin
2017-05-09 18:12 ` [v3 0/9] parallelized "struct page" zeroing Michal Hocko
2017-05-09 18:12   ` Michal Hocko
2017-05-09 18:12   ` Michal Hocko
2017-05-09 18:54   ` Pasha Tatashin
2017-05-09 18:54     ` Pasha Tatashin
2017-05-09 18:54     ` Pasha Tatashin
2017-05-10  7:24     ` Michal Hocko
2017-05-10  7:24       ` Michal Hocko
2017-05-10  7:24       ` Michal Hocko
2017-05-10 13:42       ` Pasha Tatashin
2017-05-10 13:42         ` Pasha Tatashin
2017-05-10 13:42         ` Pasha Tatashin
2017-05-10 14:57         ` Michal Hocko
2017-05-10 14:57           ` Michal Hocko
2017-05-10 14:57           ` Michal Hocko
2017-05-10 15:01           ` Pasha Tatashin
2017-05-10 15:01             ` Pasha Tatashin
2017-05-10 15:01             ` Pasha Tatashin
2017-05-10 15:20             ` David Miller
2017-05-10 15:20               ` David Miller
2017-05-10 15:20               ` David Miller
2017-05-11 20:47             ` Pasha Tatashin
2017-05-11 20:47               ` Pasha Tatashin
2017-05-11 20:47               ` Pasha Tatashin
2017-05-11 20:59               ` Pasha Tatashin
2017-05-11 20:59                 ` Pasha Tatashin
2017-05-11 20:59                 ` Pasha Tatashin
2017-05-12 16:57                 ` David Miller
2017-05-12 16:57                   ` David Miller
2017-05-12 16:57                   ` David Miller
2017-05-12 17:24                   ` Pasha Tatashin
2017-05-12 17:24                     ` Pasha Tatashin
2017-05-12 17:24                     ` Pasha Tatashin
2017-05-12 17:37                     ` David Miller
2017-05-12 17:37                       ` David Miller
2017-05-12 17:37                       ` David Miller
2017-05-16 23:50                       ` Benjamin Herrenschmidt
2017-05-16 23:50                         ` Benjamin Herrenschmidt
2017-05-16 23:50                         ` Benjamin Herrenschmidt
2017-05-12 16:56               ` David Miller
2017-05-12 16:56                 ` David Miller
2017-05-12 16:56                 ` David Miller
2017-05-10 15:19           ` David Miller
2017-05-10 15:19             ` David Miller
2017-05-10 15:19             ` David Miller
2017-05-10 17:17             ` Matthew Wilcox
2017-05-10 17:17               ` Matthew Wilcox
2017-05-10 17:17               ` Matthew Wilcox
2017-05-10 18:00               ` David Miller
2017-05-10 18:00                 ` David Miller
2017-05-10 18:00                 ` David Miller
2017-05-10 21:11                 ` Matthew Wilcox
2017-05-10 21:11                   ` Matthew Wilcox
2017-05-10 21:11                   ` Matthew Wilcox
2017-05-11  8:05             ` Michal Hocko
2017-05-11  8:05               ` Michal Hocko
2017-05-11  8:05               ` Michal Hocko
2017-05-11 14:35               ` David Miller
2017-05-11 14:35                 ` David Miller
2017-05-11 14:35                 ` David Miller
2017-05-15 18:12   ` Pasha Tatashin
2017-05-15 18:12     ` Pasha Tatashin
2017-05-15 18:12     ` Pasha Tatashin
2017-05-15 19:38     ` Michal Hocko
2017-05-15 19:38       ` Michal Hocko
2017-05-15 19:38       ` Michal Hocko
2017-05-15 20:44       ` Pasha Tatashin
2017-05-15 20:44         ` Pasha Tatashin
2017-05-15 20:44         ` Pasha Tatashin
2017-05-16  8:36         ` Michal Hocko
2017-05-16  8:36           ` Michal Hocko
2017-05-16  8:36           ` Michal Hocko
2017-05-26 16:45           ` Pasha Tatashin
2017-05-26 16:45             ` Pasha Tatashin
2017-05-26 16:45             ` Pasha Tatashin
2017-05-29 11:53             ` Michal Hocko
2017-05-29 11:53               ` Michal Hocko
2017-05-29 11:53               ` Michal Hocko
2017-05-30 17:16               ` Pasha Tatashin
2017-05-30 17:16                 ` Pasha Tatashin
2017-05-30 17:16                 ` Pasha Tatashin
2017-05-31 16:31                 ` Michal Hocko
2017-05-31 16:31                   ` Michal Hocko
2017-05-31 16:31                   ` Michal Hocko
2017-05-31 16:51                   ` David Miller
2017-05-31 16:51                     ` David Miller
2017-05-31 16:51                     ` David Miller
2017-06-01  3:35                   ` Pasha Tatashin
2017-06-01  3:35                     ` Pasha Tatashin
2017-06-01  3:35                     ` Pasha Tatashin
2017-06-01  8:46                     ` Michal Hocko
2017-06-01  8:46                       ` Michal Hocko
2017-06-01  8:46                       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494003796-748672-6-git-send-email-pasha.tatashin@oracle.com \
    --to=pasha.tatashin@oracle.com \
    --cc=borntraeger@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.