Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures

From: Lucas Stach <l.stach@pengutronix.de>
To: Peter Senna Tschudin <peter.senna@collabora.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Richard Zhu <hongxing.zhu@nxp.com>,
	Murali Karicheri <m-karicheri2@ti.com>,
	Minghuan Lian <minghuan.Lian@freescale.com>,
	Mingkai Hu <mingkai.hu@freescale.com>,
	Roy Zang <tie-fei.zang@freescale.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Niklas Cassel <niklas.cassel@axis.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	Zhou Wang <wangzhou1@hisilicon.com>,
	Gabriele Paoloni <gabriele.paoloni@huawei.com>,
	Stanimir Varbanov <svarbanov@mm-sol.com>,
	Pratyush Anand <pratyush.anand@gmail.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: Regression: 442ec4c04d1: PCI: dwc: all: Split struct pcie_port into host-only and core structures
Date: Mon, 08 May 2017 18:34:08 +0200	[thread overview]
Message-ID: <1494261248.2322.21.camel@pengutronix.de> (raw)
In-Reply-To: <20170508150224.GA7458@collabora.com>

Am Montag, den 08.05.2017, 17:02 +0200 schrieb Peter Senna Tschudin:
> Hello Kishon,
> 
> Our iMX6 hardware (imx6q-b850v3.dts) is not booting with latest
> linux-next and I could bisect until:
> 
> commit 442ec4c04d1235f8c664a74004dae54a7a574d18
> Author: Kishon Vijay Abraham I <kishon@ti.com>
> Date:   Wed Feb 15 18:48:14 2017 +0530
> 
>     PCI: dwc: all: Split struct pcie_port into host-only and core structures
> 
> Which seem to be causing our issues. Our device (imx6q-b850v3.dts) boots
> fine with 4.10, and also boots if we disable pcie with:

Are you sure about this bisect? It seems more likely that the secondary
bus scanning goes wrong. It seems Lorenzo Pieralisi's cfg space
non-posting patches landed in next, so the root cause of this might just
be the driver hooking the wrong fault code now.

Async and synchronous aborts are different fault codes on ARM. Can you
see of removing the "16 +" in hook_fault_code() in
drivers/pci/dwc/pci-imx6.c fixes this issue?

Regards,
Lucas