All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype
@ 2017-05-09 16:47 Kieran Bingham
  2017-05-10  8:20 ` Geert Uytterhoeven
  2017-06-27 18:53 ` Geert Uytterhoeven
  0 siblings, 2 replies; 6+ messages in thread
From: Kieran Bingham @ 2017-05-09 16:47 UTC (permalink / raw)
  To: Geert Uytterhoeven, linux-renesas-soc; +Cc: Kieran Bingham

From: Kieran Bingham <kieran.bingham@ideasonboard.com>

Hi Geert,

The following changes since commit 13e0988140374123bead1dd27c287354cb95108e:

  docs: complete bumping minimal GNU Make version to 3.81 (2017-05-06 18:49:09 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git tags/submissions/vsp1/writeback/v3

for you to fetch changes up to 5debeb08338b520f52577ca6cf9be815a54c07ea:

  v4l: vsp1: Provide a writeback video device (2017-05-08 15:06:58 +0100)

----------------------------------------------------------------
v4l: vsp1: vsp1 writeback prototype

This short series extends the VSP1 on the RCar platforms to allow creating a
V4L2 video node on display pipelines where the hardware allows writing to
memory simultaneously.

In this instance, the hardware restricts the output to match the display size
(no rescaling) but does allow pixel format conversion.

A current limitation (that the DRI devs might have ideas about) is that the vb2
buffers are swapped on the atomic_flush() calls rather than on vsync events.

Ideally swapping buffers would occur on every vsync such that the output rate
of the video node would match the display rate, however the timing here proves
more difficult to synchronise the updates from a vsync and flush without adding
latency to the flush.

Is there anything I can do to synchronise the v4l2 buffers with the DRM/KMS
interfaces currently? Or does anyone have any suggestions for extending as
such?

And of course ideas on anything that could be done generically to support other
targets as well would be worth considering - though currently this
implementation is very RCar/VSP1 specific.

v3:
 - Rebased to v4.12-rc1

v2:
 - Fix checkpatch.pl warnings
 - Adapt to use a single source pad for the Writeback and LIF
 - Use WPF properties to determine when to create links instead of VSP
 - Remove incorrect vsp1_video_verify_format() changes
 - Spelling and grammar fixes

----------------------------------------------------------------
Kieran Bingham (2):
      Revert "[media] v4l: vsp1: Supply frames to the DU continuously"
      v4l: vsp1: Provide a writeback video device

 drivers/media/platform/vsp1/vsp1.h       |   1 +
 drivers/media/platform/vsp1/vsp1_drm.c   |  18 ++++
 drivers/media/platform/vsp1/vsp1_drv.c   |   5 +-
 drivers/media/platform/vsp1/vsp1_rwpf.h  |   1 +
 drivers/media/platform/vsp1/vsp1_video.c | 161 ++++++++++++++++++++++++++++---
 drivers/media/platform/vsp1/vsp1_video.h |   5 +
 drivers/media/platform/vsp1/vsp1_wpf.c   |  19 +++-
 7 files changed, 192 insertions(+), 18 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype
  2017-05-09 16:47 [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype Kieran Bingham
@ 2017-05-10  8:20 ` Geert Uytterhoeven
  2017-05-10  8:27   ` Kieran Bingham
  2017-06-27 18:53 ` Geert Uytterhoeven
  1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-05-10  8:20 UTC (permalink / raw)
  To: Kieran Bingham; +Cc: Linux-Renesas, Kieran Bingham

Hi Kieran,

On Tue, May 9, 2017 at 6:47 PM, Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> The following changes since commit 13e0988140374123bead1dd27c287354cb95108e:
>
>   docs: complete bumping minimal GNU Make version to 3.81 (2017-05-06 18:49:09 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git tags/submissions/vsp1/writeback/v3
>
> for you to fetch changes up to 5debeb08338b520f52577ca6cf9be815a54c07ea:
>
>   v4l: vsp1: Provide a writeback video device (2017-05-08 15:06:58 +0100)

Looks good, and merges cleanly into today's linux-next.

> v3:
>  - Rebased to v4.12-rc1

Interesting... Where can I find v4.12-rc1? ;-)

I see this is based on an arbitrary commit in Linus' tree instead?
While that's OK for renesas-drivers, you never want to do this for a
pull request you
sent to an upstream maintainer.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype
  2017-05-10  8:20 ` Geert Uytterhoeven
@ 2017-05-10  8:27   ` Kieran Bingham
  2017-05-10  8:29     ` Geert Uytterhoeven
  0 siblings, 1 reply; 6+ messages in thread
From: Kieran Bingham @ 2017-05-10  8:27 UTC (permalink / raw)
  To: Geert Uytterhoeven, Kieran Bingham; +Cc: Linux-Renesas, Kieran Bingham



On 10/05/17 09:20, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Tue, May 9, 2017 at 6:47 PM, Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
>> The following changes since commit 13e0988140374123bead1dd27c287354cb95108e:
>>
>>   docs: complete bumping minimal GNU Make version to 3.81 (2017-05-06 18:49:09 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git tags/submissions/vsp1/writeback/v3
>>
>> for you to fetch changes up to 5debeb08338b520f52577ca6cf9be815a54c07ea:
>>
>>   v4l: vsp1: Provide a writeback video device (2017-05-08 15:06:58 +0100)
> 
> Looks good, and merges cleanly into today's linux-next.
> 
>> v3:
>>  - Rebased to v4.12-rc1
> 
> Interesting... Where can I find v4.12-rc1? ;-)
> 
> I see this is based on an arbitrary commit in Linus' tree instead?
> While that's OK for renesas-drivers, you never want to do this for a
> pull request you
> sent to an upstream maintainer.

Sorry - that was meant to say rebased in preparation for v4.12-rc1 ...

As are the others of course.
This was the point at which both DRM and V4L had been merged, and I was able to
rebase my work on top of those as a constant representative base.

If it's better I can resend pull requests after v4.12-rc1 is out ... but the
window between then, and your integration is only one day! so I've just been
sending these out as I've refreshed and tested them.

--
Kieran


> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype
  2017-05-10  8:27   ` Kieran Bingham
@ 2017-05-10  8:29     ` Geert Uytterhoeven
  0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-05-10  8:29 UTC (permalink / raw)
  To: Kieran Bingham; +Cc: Kieran Bingham, Linux-Renesas

Hi Kieran,

On Wed, May 10, 2017 at 10:27 AM, Kieran Bingham
<kieran.bingham@ideasonboard.com> wrote:
>>> v3:
>>>  - Rebased to v4.12-rc1
>>
>> Interesting... Where can I find v4.12-rc1? ;-)
>>
>> I see this is based on an arbitrary commit in Linus' tree instead?
>> While that's OK for renesas-drivers, you never want to do this for a
>> pull request you
>> sent to an upstream maintainer.
>
> Sorry - that was meant to say rebased in preparation for v4.12-rc1 ...

OK.

> As are the others of course.
> This was the point at which both DRM and V4L had been merged, and I was able to
> rebase my work on top of those as a constant representative base.
>
> If it's better I can resend pull requests after v4.12-rc1 is out ... but the
> window between then, and your integration is only one day! so I've just been
> sending these out as I've refreshed and tested them.

No need to refresh, until something Really Bad happens w.r.t. merge conflicts.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype
  2017-05-09 16:47 [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype Kieran Bingham
  2017-05-10  8:20 ` Geert Uytterhoeven
@ 2017-06-27 18:53 ` Geert Uytterhoeven
  2017-06-28  8:07   ` Kieran Bingham
  1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2017-06-27 18:53 UTC (permalink / raw)
  To: Kieran Bingham; +Cc: Linux-Renesas, Kieran Bingham

Hi Kieran,

On Tue, May 9, 2017 at 6:47 PM, Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> The following changes since commit 13e0988140374123bead1dd27c287354cb95108e:
>
>   docs: complete bumping minimal GNU Make version to 3.81 (2017-05-06 18:49:09 -0700)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git tags/submissions/vsp1/writeback/v3
>
> for you to fetch changes up to 5debeb08338b520f52577ca6cf9be815a54c07ea:
>
>   v4l: vsp1: Provide a writeback video device (2017-05-08 15:06:58 +0100)

Dropped, too many conflicts.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype
  2017-06-27 18:53 ` Geert Uytterhoeven
@ 2017-06-28  8:07   ` Kieran Bingham
  0 siblings, 0 replies; 6+ messages in thread
From: Kieran Bingham @ 2017-06-28  8:07 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux-Renesas, Kieran Bingham



On 27/06/17 19:53, Geert Uytterhoeven wrote:
> Hi Kieran,
> 
> On Tue, May 9, 2017 at 6:47 PM, Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com> wrote:
>> The following changes since commit 13e0988140374123bead1dd27c287354cb95108e:
>>
>>   docs: complete bumping minimal GNU Make version to 3.81 (2017-05-06 18:49:09 -0700)
>>
>> are available in the git repository at:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git tags/submissions/vsp1/writeback/v3
>>
>> for you to fetch changes up to 5debeb08338b520f52577ca6cf9be815a54c07ea:
>>
>>   v4l: vsp1: Provide a writeback video device (2017-05-08 15:06:58 +0100)
> 
> Dropped, too many conflicts.
> 


Thanks for the notification.

I'll rebase and push again for integration on linux-media.
--
Kieran

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-06-28  8:07 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-09 16:47 [GIT PULL FOR renesas-drivers] v4l: vsp1: writeback prototype Kieran Bingham
2017-05-10  8:20 ` Geert Uytterhoeven
2017-05-10  8:27   ` Kieran Bingham
2017-05-10  8:29     ` Geert Uytterhoeven
2017-06-27 18:53 ` Geert Uytterhoeven
2017-06-28  8:07   ` Kieran Bingham

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.