From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: <x86@kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <tglx@linutronix.de>, <mingo@kernel.org>, <hpa@zytor.com>,
<ebiederm@xmission.com>, <bhe@redhat.com>,
<izumi.taku@jp.fujitsu.com>,
Dou Liyang <douly.fnst@cn.fujitsu.com>
Subject: [RFC PATCH v3 04/12] x86/time: Initialize interrupt mode behind timer init
Date: Wed, 10 May 2017 21:44:41 +0800 [thread overview]
Message-ID: <1494423889-25799-5-git-send-email-douly.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <1494423889-25799-1-git-send-email-douly.fnst@cn.fujitsu.com>
In start_kernel(), firstly, it works on the default interrupy mode, then
switch to the final mode. Normally, Booting with BIOS reset is OK.
But, At dump-capture kernel, it boot up without BIOS reset, default mode
may not be compatible with the actual registers, that causes the delivery
interrupt to fail.
Try to set up the final mode as soon as possible. according to the parts
which split from that initialization:
1) Set up the APIC/IOAPIC (including testing whether the timer
interrupt works)
2) Calibrate TSC
3) Set up the local APIC timer
-- From Thomas Gleixner
Initializing the mode should be earlier than calibrating TSC as soon as
possible and needs testing whether the timer interrupt works at the same
time.
Add apic_interrupt_mode_init() just behind timers init, which meet the
above conditions.
Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
---
arch/x86/kernel/time.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index d39c091..23b074e 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -21,6 +21,7 @@
#include <asm/timer.h>
#include <asm/hpet.h>
#include <asm/time.h>
+#include <asm/apic.h>
#ifdef CONFIG_X86_64
__visible volatile unsigned long jiffies __cacheline_aligned = INITIAL_JIFFIES;
@@ -84,6 +85,13 @@ void __init hpet_time_init(void)
static __init void x86_late_time_init(void)
{
x86_init.timers.timer_init();
+
+ /*
+ * After PIT/HPET timers init, select and setup
+ * the final interrupt mode for delivering IRQs.
+ */
+ apic_interrupt_mode_init();
+
tsc_init();
}
--
2.5.5
next prev parent reply other threads:[~2017-05-10 13:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 13:44 [RFC PATCH v3 00/12] Unify interrupt mode and setup it as soon as possible Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 01/12] x86/apic: Replace init_bsp_APIC() with apic_virtual_wire_mode_setup() Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 02/12] x86/apic: Construct a selector for the interrupt delivery mode Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 03/12] x86/apic: Prepare for unifying the interrupt delivery modes setup Dou Liyang
2017-05-10 13:44 ` Dou Liyang [this message]
2017-06-06 6:00 ` [RFC PATCH v4 04/12] x86/time: Initialize interrupt mode behind timer init Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 05/12] x86/ioapic: Refactor the delay logic in timer_irq_works() Dou Liyang
2017-05-26 8:10 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 06/12] x86/apic: Split local APIC timer setup from the APIC setup Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 07/12] x86/apic: Move the logical APIC ID setup from apic_bsp_setup() Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 08/12] x86/apic: Make interrupt mode setup earlier for SMP-capable system Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 09/12] x86/apic: Setup interrupt mode earlier in case of no SMP motherboard Dou Liyang
2017-05-12 9:55 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 10/12] x86/apic: Make the interrupt mode setup earlier for UP system Dou Liyang
2017-05-11 10:57 ` [RFC PATCH v4 " Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 11/12] x86/apic: Mark the apic_interrupt_mode extern for disable_smp() Dou Liyang
2017-05-10 13:44 ` [RFC PATCH v3 12/12] x86/apic: Remove the apic_virtual_wire_mode_setup() Dou Liyang
2017-05-22 20:23 ` [RFC PATCH v3 00/12] Unify interrupt mode and setup it as soon as possible Thomas Gleixner
2017-05-23 1:29 ` Dou Liyang
2017-06-06 6:50 ` Dou Liyang
2017-06-26 10:08 ` Dou Liyang
2017-06-26 11:50 ` Thomas Gleixner
2017-06-27 1:50 ` Dou Liyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1494423889-25799-5-git-send-email-douly.fnst@cn.fujitsu.com \
--to=douly.fnst@cn.fujitsu.com \
--cc=bhe@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.